From 74e85f40d29a6a6ffff2b71fd11918cd56d2434e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20Storsj=C3=B6?= Date: Fri, 1 Feb 2013 11:42:19 +0200 Subject: [PATCH] omxil: Skip a kinda-broken samsung mp3 decoder MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Martin Storsjö --- modules/codec/omxil/omxil.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/modules/codec/omxil/omxil.c b/modules/codec/omxil/omxil.c index a69b41fc5b..ba73f04e99 100644 --- a/modules/codec/omxil/omxil.c +++ b/modules/codec/omxil/omxil.c @@ -1019,6 +1019,14 @@ loaded: /* Use VC1 decoder for WMV3 for now */ if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.WMV.Decoder")) continue; + /* This decoder does work, but has an insane latency (leading to errors + * about "main audio output playback way too late" and dropped frames). + * At least Samsung Galaxy S III (where this decoder is present) has + * got another one, OMX.SEC.mp3.dec, that works well and has a + * sensible latency. (Also, even if that one isn't found, in general, + * using SW codecs is usually more than fast enough for MP3.) */ + if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.MP3.Decoder")) + continue; #endif omx_error = InitialiseComponent(p_dec, p_sys->ppsz_components[i], &p_sys->omx_handle); -- 2.39.2