From 9d1d95de40c79dadbb8b21c8bdd5660ccf5a6c8e Mon Sep 17 00:00:00 2001
From: =?utf8?q?R=C3=A9mi=20Denis-Courmont?= <rem@videolan.org>
Date: Sun, 26 Feb 2006 14:48:02 +0000
Subject: [PATCH] Get rid of --enable-shared-libvlc on non-Microsoft platforms
 as it did never worked properly, if at all with these (you should use libtool
 to build a shared libvlc instead)

---
 bootstrap       |  8 --------
 configure.ac    |  2 +-
 src/Makefile.am | 25 ++++++-------------------
 3 files changed, 7 insertions(+), 28 deletions(-)

diff --git a/bootstrap b/bootstrap
index 01702d8261..d6672f1ec0 100755
--- a/bootstrap
+++ b/bootstrap
@@ -226,16 +226,8 @@ LTLIBVLC = \$(top_builddir)/src/libvlc.la
 
 if BUILD_SHARED
 LIBVLC = \$(top_builddir)/src/libvlc\$(LIBEXT)
-if HAVE_WIN32
 LIBADD = \$(LIBVLC)
 endif
-if HAVE_WINCE
-LIBADD = \$(LIBVLC)
-endif
-if HAVE_DARWIN
-LIBADD = \$(LIBVLC)
-endif
-endif
 
 all: all-modules
 
diff --git a/configure.ac b/configure.ac
index 05bff92582..3d7c08a1c3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1388,7 +1388,7 @@ dnl  Is the shared libvlc forced ?
 dnl
 build_pic=no
 AC_ARG_ENABLE(shared-libvlc,
-  [  --enable-shared-libvlc  shared libvlc (default disabled EXPERIMENTAL)])
+  [  --enable-shared-libvlc  Win32 libvlc.dll build (default disabled)])
 AS_IF([test "${enable_libtool}" != "no" && test "${enable_shared_libvlc}"], [
   AC_MSG_ERROR([--enable-shared-libvlc and --enable-libtool are mutually exclusive])
 ])
diff --git a/src/Makefile.am b/src/Makefile.am
index 726f014ff1..c632b36f69 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -187,30 +187,15 @@ endif
 if USE_LIBTOOL
 lib_LTLIBRARIES = libvlc.la
 else
-LIBRARIES_nopic = libvlc.a
-LIBRARIES_pic = libvlc_pic.a
-if HAVE_WIN32
-lib_LIBRARIES = $(LIBRARIES_nopic)
-else
-if BUILD_SHARED
-lib_LIBRARIES = $(LIBRARIES_pic)
-else
-lib_LIBRARIES = $(LIBRARIES_nopic)
+lib_LIBRARIES = libvlc.a
 if BUILD_PIC
-lib_LIBRARIES += $(LIBRARIES_pic)
-endif
-endif
+lib_LIBRARIES += libvlc_pic.a
 endif
 endif
 
+if HAVE_WIN32
 if BUILD_SHARED
 DATA_noinst_libvlc = libvlc$(LIBEXT)
-if HAVE_WIN32
-OBJECTS_libvlc_so = $(libvlc_a_OBJECTS)
-LDFLAGS_libvlc_so = -Wl,--out-implib,$(top_builddir)/src/libvlc.dll.a
-else
-OBJECTS_libvlc_so = $(libvlc_pic_a_OBJECTS)
-endif
 endif
 
 libvlc$(LIBEXT): $(OBJECTS_libvlc_so) stamp-builtins
@@ -221,11 +206,13 @@ libvlc$(LIBEXT): $(OBJECTS_libvlc_so) stamp-builtins
 	  c|*)  ld="$(LINK)" ;; \
 	esac ; \
 	echo $$ld $(OBJECTS_libvlc_so) $(LDFLAGS_libvlc_so) $$ldfl; \
-	$$ld $(OBJECTS_libvlc_so) $(LDFLAGS_libvlc_so) $$ldfl
+	$$ld $(libvlc_a_OBJECTS) \
+		-Wl,--out-implib,$(top_builddir)/src/libvlc.dll.a $$ldfl
 # It sucks big time, but we have to do that to link vlc properly
 # on non-PIC OSes, otherwise ld will favor builtins-less libvlc.a over
 # libvlc$(LIBEXT)
 	rm -f libvlc.a
+endif
 
 EXTRA_DIST += \
 	$(SOURCES_libvlc_beos) \
-- 
2.39.2