From b0a4877958841d924ded607f19f9afa1509cdb98 Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Sat, 28 Jul 2018 16:01:18 +0200 Subject: [PATCH] Remove a TODO. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Making the penalizer smaller (as one should if adjusting it towards a smaller range, as there's effectively I² numerator and I denominator) does not seem to have much effect; actually, increasing it to 0.01 seems to give better results on alley-2, but that's the “wrong way”. --- equations.frag | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/equations.frag b/equations.frag index d4328de..51e1394 100644 --- a/equations.frag +++ b/equations.frag @@ -69,8 +69,6 @@ void main() // E_I term. Note that we don't square β_0, in line with DeepFlow; // it's probably an error (see variational_refinement.txt), // but squaring it seems to give worse results. - // - // FIXME: Should the penalizer be adjusted for 0..1 intensity range instead of 0..255? float beta_0 = texture(beta_0_tex, tc).x; float k1 = delta * beta_0 * inversesqrt(beta_0 * (I_x * du + I_y * dv + I_t) * (I_x * du + I_y * dv + I_t) + 1e-6); float A11 = k1 * I_x * I_x; @@ -106,8 +104,7 @@ void main() float I_xt = I_tx_ty.x; float I_yt = I_tx_ty.y; - // E_G term. Same TODOs as E_I. Same normalization as beta_0 - // (see derivatives.frag). + // E_G term. Same normalization as beta_0 (see derivatives.frag). float beta_x = 1.0 / (I_xx * I_xx + I_xy * I_xy + 1e-7); float beta_y = 1.0 / (I_xy * I_xy + I_yy * I_yy + 1e-7); float k2 = gamma * inversesqrt( -- 2.39.2