From c235fa52c1ecc0b085dced0879a8c5a10bbfc97f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jean-Philippe=20Andr=C3=A9?= Date: Thu, 4 Feb 2010 03:29:37 +0100 Subject: [PATCH] Extensions: fix leak: free commands --- modules/misc/lua/extension_thread.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/misc/lua/extension_thread.c b/modules/misc/lua/extension_thread.c index 638b9669ee..cadfc3acc1 100644 --- a/modules/misc/lua/extension_thread.c +++ b/modules/misc/lua/extension_thread.c @@ -285,6 +285,7 @@ static void* Run( void *data ) if( cmd ) { p_ext->p_sys->command = cmd->next; + cmd->next = NULL; // This prevents FreeCommands from freeing next } vlc_mutex_unlock( &p_ext->p_sys->command_lock ); @@ -346,7 +347,6 @@ static void* Run( void *data ) msg_Dbg( p_mgr, "Trigger menu %d of '%s'", *pi_id, p_ext->psz_name ); lua_ExtensionTriggerMenu( p_mgr, p_ext, *pi_id ); - free( pi_id ); break; } @@ -373,6 +373,8 @@ static void* Run( void *data ) } } + FreeCommands( cmd ); + vlc_mutex_lock( &p_ext->p_sys->command_lock ); if( !p_ext->p_sys->b_exiting && !p_ext->p_sys->command ) { -- 2.39.2