From d5bbdb443ab800dcc02dd4f9b486f4cec3af5e60 Mon Sep 17 00:00:00 2001 From: Mikko Rapeli Date: Fri, 10 Aug 2012 14:17:02 +0200 Subject: [PATCH] histogramgenerator.cpp: check for division by zero Fixes Coverity CID 709284: Division or modulo by zero (DIVIDE_BY_ZERO) Division by expression "byteCount >> 7" which may be zero has undefined behavior 87 const float scaling = (float)partH/(byteCount >> 7); --- src/colorcorrection/histogramgenerator.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/colorcorrection/histogramgenerator.cpp b/src/colorcorrection/histogramgenerator.cpp index 456aad6b..2681c504 100644 --- a/src/colorcorrection/histogramgenerator.cpp +++ b/src/colorcorrection/histogramgenerator.cpp @@ -84,7 +84,10 @@ QImage HistogramGenerator::calculateHistogram(const QSize ¶deSize, const QIm const int d = 20; // Distance for text const int partH = (wh-nParts*d)/nParts; - const float scaling = (float)partH/(byteCount >> 7); + float scaling = 0; + int div = byteCount >> 7; + if ( div > 0 ) + scaling = (float)partH/(byteCount >> 7); const int dist = 40; int wy = 0; // Drawing position -- 2.39.5