From e6511e80462f959ad201d7fb8800eabefde9e798 Mon Sep 17 00:00:00 2001 From: =?utf8?q?R=C3=A9mi=20Denis-Courmont?= Date: Thu, 4 Mar 2010 19:42:47 +0200 Subject: [PATCH] Linux: fix set_libvlc_path and enable it --- src/misc/linux_specific.c | 50 +++++++++++++++++++++++---------------- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/src/misc/linux_specific.c b/src/misc/linux_specific.c index 57b0805b77..5d2924656b 100644 --- a/src/misc/linux_specific.c +++ b/src/misc/linux_specific.c @@ -28,23 +28,14 @@ #include #include "../libvlc.h" -#if 0 -#include -#include -#include +static const char default_path[] = PKGLIBDIR; static void set_libvlc_path (void) { - static char libvlc_path[PATH_MAX]; - - assert (strlen (LIBDIR) < sizeof (libvlc_path)); - strcpy (libvlc_path, LIBDIR); /* fail safe */ - psz_vlcpath = libvlc_path; - /* Find the path to libvlc (i.e. ourselves) */ FILE *maps = fopen ("/proc/self/maps", "rt"); if (maps == NULL) - return; + goto error; char *line = NULL; size_t linelen = 0; @@ -68,15 +59,29 @@ static void set_libvlc_path (void) if (end == NULL) continue; *file = '\0'; - printf ("libvlc at %s\n", dir); - if (strlen (dir) < sizeof (libvlc_path)) - strcpy (libvlc_path, dir); + if (asprintf (&psz_vlcpath, "%s/"PACKAGE, dir) == -1) + goto error; break; } free (line); fclose (maps); + return; + +error: + psz_vlcpath = (char *)default_path; /* default, cannot fail */ +} + +static void unset_libvlc_path (void) +{ + if (psz_vlcpath != default_path) + free (psz_vlcpath); } -#endif + +static struct +{ + vlc_mutex_t lock; + unsigned refs; +} once = { VLC_STATIC_MUTEX, 0 }; #ifdef __GLIBC__ # include @@ -102,10 +107,11 @@ void system_Init (libvlc_int_t *libvlc, int *argc, const char *argv[]) } #endif -#if 0 - static pthread_once_t once = PTHREAD_ONCE_INIT; - pthread_once (&once, set_libvlc_path); -#endif + vlc_mutex_lock (&once.lock); + if (once.refs++ == 0) + set_libvlc_path (); + vlc_mutex_unlock (&once.lock); + (void)libvlc; (void)argc; (void)argv; } @@ -116,6 +122,10 @@ void system_Configure (libvlc_int_t *libvlc, int *argc, const char *argv[]) void system_End (libvlc_int_t *libvlc) { + vlc_mutex_lock (&once.lock); + if (--once.refs == 0) + unset_libvlc_path (); + vlc_mutex_unlock (&once.lock); + (void)libvlc; } - -- 2.39.5