From f0867739c9a788a250a37174e0952e0e96e318b3 Mon Sep 17 00:00:00 2001 From: Montel Laurent Date: Sun, 12 May 2013 17:18:31 +0200 Subject: [PATCH] const ref --- src/projectitem.cpp | 8 ++++---- src/projectitem.h | 8 ++++---- src/projectlist.cpp | 4 ++-- src/projectlist.h | 6 +++--- src/projectsettings.cpp | 2 +- src/projectsettings.h | 2 +- src/renderwidget.cpp | 2 +- src/renderwidget.h | 2 +- src/smallruler.cpp | 2 +- src/smallruler.h | 2 +- src/subprojectitem.cpp | 2 +- src/subprojectitem.h | 2 +- src/trackview.cpp | 2 +- src/trackview.h | 2 +- src/transition.cpp | 2 +- src/transition.h | 2 +- src/transitionsettings.cpp | 2 +- src/transitionsettings.h | 2 +- 18 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/projectitem.cpp b/src/projectitem.cpp index aeb4a870..46ec6989 100644 --- a/src/projectitem.cpp +++ b/src/projectitem.cpp @@ -35,7 +35,7 @@ const int JobTypeRole = Qt::UserRole + 6; const int JobStatusMessage = Qt::UserRole + 7; const int itemHeight = 38; -ProjectItem::ProjectItem(QTreeWidget * parent, DocClipBase *clip, QSize pixmapSize) : +ProjectItem::ProjectItem(QTreeWidget * parent, DocClipBase *clip, const QSize &pixmapSize) : QTreeWidgetItem(parent, PROJECTCLIPTYPE), m_clip(clip), m_clipId(clip->getId()), @@ -44,7 +44,7 @@ ProjectItem::ProjectItem(QTreeWidget * parent, DocClipBase *clip, QSize pixmapSi buildItem(pixmapSize); } -ProjectItem::ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, QSize pixmapSize) : +ProjectItem::ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, const QSize &pixmapSize) : QTreeWidgetItem(parent, PROJECTCLIPTYPE), m_clip(clip), m_clipId(clip->getId()), @@ -101,7 +101,7 @@ bool ProjectItem::hasPixmap() const return m_pixmapSet; } -void ProjectItem::setPixmap(const QPixmap p) +void ProjectItem::setPixmap(const QPixmap& p) { m_pixmapSet = true; setData(0, Qt::DecorationRole, p); @@ -295,7 +295,7 @@ bool ProjectItem::isProxyRunning() const return false; } -bool ProjectItem::playlistHasProxies(const QString path) +bool ProjectItem::playlistHasProxies(const QString& path) { kDebug()<<"// CHECKING FOR PROXIES"; QFile file(path); diff --git a/src/projectitem.h b/src/projectitem.h index 6d07b1b8..c33de17a 100644 --- a/src/projectitem.h +++ b/src/projectitem.h @@ -41,8 +41,8 @@ class DocClipBase; class ProjectItem : public QTreeWidgetItem { public: - ProjectItem(QTreeWidget * parent, DocClipBase *clip, QSize pixmapSize); - ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, QSize pixmapSize); + ProjectItem(QTreeWidget * parent, DocClipBase *clip, const QSize &pixmapSize); + ProjectItem(QTreeWidgetItem * parent, DocClipBase *clip, const QSize &pixmapSize); virtual ~ProjectItem(); QDomElement toXml() const; int numReferences() const; @@ -79,7 +79,7 @@ public: /** \brief Returns true if the thumbnail for this clip has been loaded. */ bool hasPixmap() const; /** \brief Sets the thumbnail for this clip. */ - void setPixmap(const QPixmap p); + void setPixmap(const QPixmap& p); virtual bool operator<(const QTreeWidgetItem &other)const { int column = treeWidget()->sortColumn(); @@ -96,7 +96,7 @@ private: /** @brief Setup basic properties */ void buildItem(QSize pixmapSize); /** @brief Check if an xml project file has proxies */ - bool playlistHasProxies(const QString path); + bool playlistHasProxies(const QString& path); }; #endif diff --git a/src/projectlist.cpp b/src/projectlist.cpp index 4744ff1e..9c74ef09 100644 --- a/src/projectlist.cpp +++ b/src/projectlist.cpp @@ -1496,7 +1496,7 @@ void ProjectList::getCachedThumbnail(ProjectItem *item) } } -QPixmap ProjectList::roundedPixmap(QImage img) +QPixmap ProjectList::roundedPixmap(const QImage &img) { QPixmap pix(img.width(), img.height()); pix.fill(Qt::transparent); @@ -1510,7 +1510,7 @@ QPixmap ProjectList::roundedPixmap(QImage img) return pix; } -QPixmap ProjectList::roundedPixmap(QPixmap source) +QPixmap ProjectList::roundedPixmap(const QPixmap &source) { QPixmap pix(source.width(), source.height()); pix.fill(Qt::transparent); diff --git a/src/projectlist.h b/src/projectlist.h index 25a222d9..04a55f6c 100644 --- a/src/projectlist.h +++ b/src/projectlist.h @@ -87,7 +87,7 @@ signals: namespace Mlt { class Producer; -}; +} class ProjectItem; class ProjectListView; @@ -426,8 +426,8 @@ private: /** @brief Start an MLT process job. */ void processClipJob(QStringList ids, const QString&destination, bool autoAdd, QStringList jobParams, const QString &description, stringMap extraParams = stringMap()); /** @brief Create rounded shape pixmap for project tree thumb. */ - QPixmap roundedPixmap(QImage img); - QPixmap roundedPixmap(QPixmap source); + QPixmap roundedPixmap(const QImage &img); + QPixmap roundedPixmap(const QPixmap &source); /** @brief Extract a clip's metadata with the exiftool program. */ void extractMetadata(DocClipBase *clip); /** @brief Add a special FFmpeg tag if clip matches some properties (for example set full_luma for Sony NEX camcorders. */ diff --git a/src/projectsettings.cpp b/src/projectsettings.cpp index 6e32cb02..e963b288 100644 --- a/src/projectsettings.cpp +++ b/src/projectsettings.cpp @@ -35,7 +35,7 @@ #include #include -ProjectSettings::ProjectSettings(ProjectList *projectlist, QMap metadata, QStringList lumas, int videotracks, int audiotracks, const QString projectPath, bool readOnlyTracks, bool savedProject, QWidget * parent) : +ProjectSettings::ProjectSettings(ProjectList *projectlist, QMap metadata, QStringList lumas, int videotracks, int audiotracks, const QString &projectPath, bool readOnlyTracks, bool savedProject, QWidget * parent) : QDialog(parent), m_savedProject(savedProject), m_projectList(projectlist), m_lumas(lumas) { setupUi(this); diff --git a/src/projectsettings.h b/src/projectsettings.h index eb8de24d..7ff27296 100644 --- a/src/projectsettings.h +++ b/src/projectsettings.h @@ -32,7 +32,7 @@ class ProjectSettings : public QDialog, public Ui::ProjectSettings_UI Q_OBJECT public: - ProjectSettings(ProjectList *projectlist, QMap metadata, QStringList lumas, int videotracks, int audiotracks, const QString projectPath, bool readOnlyTracks, bool unsavedProject, QWidget * parent = 0); + ProjectSettings(ProjectList *projectlist, QMap metadata, QStringList lumas, int videotracks, int audiotracks, const QString& projectPath, bool readOnlyTracks, bool unsavedProject, QWidget * parent = 0); QString selectedProfile() const; KUrl selectedFolder() const; QPoint tracks(); diff --git a/src/renderwidget.cpp b/src/renderwidget.cpp index d2104d61..fbc9c11b 100644 --- a/src/renderwidget.cpp +++ b/src/renderwidget.cpp @@ -1391,7 +1391,7 @@ void RenderWidget::refreshView(const QString &profile) } } -KUrl RenderWidget::filenameWithExtension(KUrl url, QString extension) +KUrl RenderWidget::filenameWithExtension(KUrl url, const QString &extension) { if (url.isEmpty()) url = KUrl(m_projectFolder); QString directory = url.directory(KUrl::AppendTrailingSlash | KUrl::ObeyTrailingSlash); diff --git a/src/renderwidget.h b/src/renderwidget.h index f742a1da..2c0002eb 100644 --- a/src/renderwidget.h +++ b/src/renderwidget.h @@ -198,7 +198,7 @@ private: void parseProfiles(const QString &meta = QString(), const QString &group = QString(), const QString &profile = QString()); void parseFile(const QString &exportFile, bool editable); void updateButtons(); - KUrl filenameWithExtension(KUrl url, QString extension); + KUrl filenameWithExtension(KUrl url, const QString &extension); /** @brief Check if a job needs to be started. */ void checkRenderStatus(); void startRendering(RenderJobItem *item); diff --git a/src/smallruler.cpp b/src/smallruler.cpp index df28a8d9..cc5d2680 100644 --- a/src/smallruler.cpp +++ b/src/smallruler.cpp @@ -108,7 +108,7 @@ void SmallRuler::setZone(int start, int end) updatePixmap(); } -void SmallRuler::setMarkers(QList < CommentedTime > list) +void SmallRuler::setMarkers(const QList &list) { m_markers = list; updatePixmap(); diff --git a/src/smallruler.h b/src/smallruler.h index 0453a8c5..53ffbcf6 100644 --- a/src/smallruler.h +++ b/src/smallruler.h @@ -41,7 +41,7 @@ public: void setZoneStart(); void setZoneEnd(); QPoint zone(); - void setMarkers(QList < CommentedTime > list); + void setMarkers(const QList < CommentedTime >& list); void updatePalette(); void refreshRuler(); diff --git a/src/subprojectitem.cpp b/src/subprojectitem.cpp index eba677b1..0e76b352 100644 --- a/src/subprojectitem.cpp +++ b/src/subprojectitem.cpp @@ -77,7 +77,7 @@ QPoint SubProjectItem::zone() const return z; } -void SubProjectItem::setZone(QPoint p) +void SubProjectItem::setZone(const QPoint& p) { m_in = p.x(); m_out = p.y(); diff --git a/src/subprojectitem.h b/src/subprojectitem.h index d3efd85a..5b1d7912 100644 --- a/src/subprojectitem.h +++ b/src/subprojectitem.h @@ -44,7 +44,7 @@ public: int numReferences() const; DocClipBase *referencedClip(); QPoint zone() const; - void setZone(QPoint p); + void setZone(const QPoint &p); QString description() const; void setDescription(QString desc); static int itemDefaultHeight(); diff --git a/src/trackview.cpp b/src/trackview.cpp index e88bfb79..4aceb76f 100644 --- a/src/trackview.cpp +++ b/src/trackview.cpp @@ -39,7 +39,7 @@ #include #include -TrackView::TrackView(KdenliveDoc *doc, QList actions, bool *ok, QWidget *parent) : +TrackView::TrackView(KdenliveDoc *doc, const QList &actions, bool *ok, QWidget *parent) : QWidget(parent), m_scale(1.0), m_projectTracks(0), diff --git a/src/trackview.h b/src/trackview.h index 3a936aa3..a629c819 100644 --- a/src/trackview.h +++ b/src/trackview.h @@ -50,7 +50,7 @@ class TrackView : public QWidget, public Ui::TimeLine_UI Q_OBJECT public: - explicit TrackView(KdenliveDoc *doc, QList actions, bool *ok, QWidget *parent = 0); + explicit TrackView(KdenliveDoc *doc, const QList & actions, bool *ok, QWidget *parent = 0); virtual ~ TrackView(); void setEditMode(const QString & editMode); const QString & editMode() const; diff --git a/src/transition.cpp b/src/transition.cpp index ecdd7086..e8bfbd41 100644 --- a/src/transition.cpp +++ b/src/transition.cpp @@ -33,7 +33,7 @@ #include #endif -Transition::Transition(const ItemInfo &info, int transitiontrack, double fps, QDomElement params, bool automaticTransition) : +Transition::Transition(const ItemInfo &info, int transitiontrack, double fps, const QDomElement ¶ms, bool automaticTransition) : AbstractClipItem(info, QRectF(), fps), m_forceTransitionTrack(false), m_automaticTransition(automaticTransition), diff --git a/src/transition.h b/src/transition.h index e7796655..aa9a9cae 100644 --- a/src/transition.h +++ b/src/transition.h @@ -41,7 +41,7 @@ class Transition : public AbstractClipItem Q_OBJECT public: - Transition(const ItemInfo &info, int transitiontrack, double fps, QDomElement params = QDomElement(), bool automaticTransition = false); + Transition(const ItemInfo &info, int transitiontrack, double fps, const QDomElement ¶ms = QDomElement(), bool automaticTransition = false); virtual ~Transition(); virtual void paint(QPainter *painter, const QStyleOptionGraphicsItem *option, diff --git a/src/transitionsettings.cpp b/src/transitionsettings.cpp index fcd3d495..55655f31 100644 --- a/src/transitionsettings.cpp +++ b/src/transitionsettings.cpp @@ -69,7 +69,7 @@ TransitionSettings::TransitionSettings(Monitor *monitor, QWidget* parent) : connect(m_effectEdit, SIGNAL(parameterChanged(QDomElement,QDomElement,int)), this , SLOT(slotUpdateEffectParams(QDomElement,QDomElement))); } -void TransitionSettings::updateProjectFormat(MltVideoProfile profile, Timecode t, const QList info) +void TransitionSettings::updateProjectFormat(MltVideoProfile profile, Timecode t, const QList &info) { m_effectEdit->updateProjectFormat(profile, t); m_tracks = info; diff --git a/src/transitionsettings.h b/src/transitionsettings.h index f236f849..769e94ba 100644 --- a/src/transitionsettings.h +++ b/src/transitionsettings.h @@ -34,7 +34,7 @@ class TransitionSettings : public QWidget, public Ui::TransitionSettings_UI public: explicit TransitionSettings(Monitor *monitor, QWidget* parent = 0); void raiseWindow(QWidget*); - void updateProjectFormat(MltVideoProfile profile, Timecode t, const QList info); + void updateProjectFormat(MltVideoProfile profile, Timecode t, const QList & info); void updateTimecodeFormat(); void setKeyframes(const QString &data, int maximum); -- 2.39.2