From fc1415ba45654f57bc25264fcd9e16221523f626 Mon Sep 17 00:00:00 2001 From: Montel Laurent Date: Sun, 12 May 2013 17:37:48 +0200 Subject: [PATCH 1/1] add explicit keyword when necessary. Add const ref when necessary --- src/cliptranscode.cpp | 2 +- src/cliptranscode.h | 2 +- src/complexparameter.cpp | 4 ++-- src/complexparameter.h | 6 +++--- src/definitions.h | 2 +- src/documentchecker.cpp | 2 +- src/effectslistview.h | 2 +- src/kdenlivedoc.cpp | 2 +- src/kdenlivedoc.h | 2 +- src/kthumb.h | 2 +- src/monitormanager.h | 2 +- src/parameterplotter.h | 4 ++-- 12 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/cliptranscode.cpp b/src/cliptranscode.cpp index 23f0f277..9caf4e4a 100644 --- a/src/cliptranscode.cpp +++ b/src/cliptranscode.cpp @@ -27,7 +27,7 @@ #include -ClipTranscode::ClipTranscode(KUrl::List urls, const QString ¶ms, const QStringList &postParams, const QString &description, bool automaticMode, QWidget * parent) : +ClipTranscode::ClipTranscode(const KUrl::List &urls, const QString ¶ms, const QStringList &postParams, const QString &description, bool automaticMode, QWidget * parent) : QDialog(parent), m_urls(urls), m_duration(0), m_automaticMode(automaticMode), m_postParams(postParams) { setFont(KGlobalSettings::toolBarFont()); diff --git a/src/cliptranscode.h b/src/cliptranscode.h index 3b707ed7..a5addaa6 100644 --- a/src/cliptranscode.h +++ b/src/cliptranscode.h @@ -37,7 +37,7 @@ class ClipTranscode : public QDialog, public Ui::ClipTranscode_UI Q_OBJECT public: - ClipTranscode(KUrl::List urls, const QString ¶ms, const QStringList &postParams, const QString &description, bool automaticMode = false, QWidget * parent = 0); + ClipTranscode(const KUrl::List &urls, const QString ¶ms, const QStringList &postParams, const QString &description, bool automaticMode = false, QWidget * parent = 0); ~ClipTranscode(); public slots: diff --git a/src/complexparameter.cpp b/src/complexparameter.cpp index da364e54..7b4d5ff2 100644 --- a/src/complexparameter.cpp +++ b/src/complexparameter.cpp @@ -131,12 +131,12 @@ void ComplexParameter::slotUpdateEffectParams(QDomElement e) emit parameterChanged(); } -QDomElement ComplexParameter::getParamDesc() +QDomElement ComplexParameter::getParamDesc() const { return m_param; } -void ComplexParameter::slotUpdateParameterList(QStringList l) +void ComplexParameter::slotUpdateParameterList(const QStringList &l) { kDebug() << l ; m_ui.parameterList->clear(); diff --git a/src/complexparameter.h b/src/complexparameter.h index 8d3dc9fa..89906054 100644 --- a/src/complexparameter.h +++ b/src/complexparameter.h @@ -29,8 +29,8 @@ class ComplexParameter : public QWidget Q_OBJECT public: - ComplexParameter(QWidget *parent = 0); - QDomElement getParamDesc(); + explicit ComplexParameter(QWidget *parent = 0); + QDomElement getParamDesc() const; private: Ui::KeyframeWidget_UI m_ui; QDomElement m_param; @@ -47,7 +47,7 @@ public slots: void itemSelectionChanged(); void setupParam(const QDomElement, const QString& paramName, int, int); void slotUpdateEffectParams(QDomElement e); - void slotUpdateParameterList(QStringList); + void slotUpdateParameterList(const QStringList &); signals: void removeEffect(ClipItem*, QDomElement); void updateClipEffect(ClipItem*, QDomElement); diff --git a/src/definitions.h b/src/definitions.h index dd22fbb4..cb61e83c 100644 --- a/src/definitions.h +++ b/src/definitions.h @@ -265,7 +265,7 @@ class CommentedTime { public: CommentedTime(): t(GenTime(0)), type(0) {} - CommentedTime(const GenTime &time, QString comment, int markerType = 0) + CommentedTime(const GenTime &time, const QString& comment, int markerType = 0) : t(time), c(comment), type(markerType) { } QString comment() const { diff --git a/src/documentchecker.cpp b/src/documentchecker.cpp index 96f63c8d..7504af20 100644 --- a/src/documentchecker.cpp +++ b/src/documentchecker.cpp @@ -432,7 +432,7 @@ bool DocumentChecker::hasErrorInClips() DocumentChecker::~DocumentChecker() { - if (m_dialog) delete m_dialog; + delete m_dialog; } diff --git a/src/effectslistview.h b/src/effectslistview.h index bba95eae..c744d080 100644 --- a/src/effectslistview.h +++ b/src/effectslistview.h @@ -45,7 +45,7 @@ class EffectsListView : public QWidget, public Ui::EffectList_UI Q_OBJECT public: - EffectsListView(QWidget *parent = 0); + explicit EffectsListView(QWidget *parent = 0); /** @brief Re-initializes the list of effects. */ void reloadEffectList(QMenu *effectsMenu, KActionCategory *effectActions); diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp index 12380e12..4ecf1c4a 100644 --- a/src/kdenlivedoc.cpp +++ b/src/kdenlivedoc.cpp @@ -1850,7 +1850,7 @@ const QMap KdenliveDoc::metadata() const return m_documentMetadata; } -void KdenliveDoc::setMetadata(const QMap meta) +void KdenliveDoc::setMetadata(const QMap &meta) { setModified(true); m_documentMetadata = meta; diff --git a/src/kdenlivedoc.h b/src/kdenlivedoc.h index 97df1eac..286f8045 100644 --- a/src/kdenlivedoc.h +++ b/src/kdenlivedoc.h @@ -167,7 +167,7 @@ Q_OBJECT public: /** @brief Returns the document metadata (author, copyright, ...) */ const QMap metadata() const; /** @brief Set the document metadata (author, copyright, ...) */ - void setMetadata(const QMap meta); + void setMetadata(const QMap & meta); private: KUrl m_url; diff --git a/src/kthumb.h b/src/kthumb.h index b3a2f529..f7446ac3 100644 --- a/src/kthumb.h +++ b/src/kthumb.h @@ -53,7 +53,7 @@ class KThumb: public QObject Q_OBJECT public: - KThumb(ClipManager *clipManager, const KUrl &url, const QString &id, const QString &hash, QObject * parent = 0); + explicit KThumb(ClipManager *clipManager, const KUrl &url, const QString &id, const QString &hash, QObject * parent = 0); ~KThumb(); void setProducer(Mlt::Producer *producer); bool hasProducer() const; diff --git a/src/monitormanager.h b/src/monitormanager.h index ca2b5736..70eb597f 100644 --- a/src/monitormanager.h +++ b/src/monitormanager.h @@ -32,7 +32,7 @@ class MonitorManager : public QObject Q_OBJECT public: - MonitorManager(QWidget *parent = 0); + explicit MonitorManager(QWidget *parent = 0); void initMonitors(Monitor *clipMonitor, Monitor *projectMonitor, RecMonitor *recMonitor); void appendMonitor(AbstractMonitor *monitor); void removeMonitor(AbstractMonitor *monitor); diff --git a/src/parameterplotter.h b/src/parameterplotter.h index 52286903..2961dcab 100644 --- a/src/parameterplotter.h +++ b/src/parameterplotter.h @@ -26,7 +26,7 @@ class ParameterPlotter : public KPlotWidget { Q_OBJECT public: - ParameterPlotter(QWidget *parent = 0); + explicit ParameterPlotter(QWidget *parent = 0); virtual ~ParameterPlotter() {} void setMoveX(bool); void setMoveY(bool); @@ -36,7 +36,7 @@ public: bool isMoveY(); bool isMoveTimeline(); bool isNewPoints(); - void replot(const QString& name = ""); + void replot(const QString& name = QString()); private: KPlotPoint* m_movepoint; int m_activeIndexPlot; -- 2.39.5