X-Git-Url: https://git.sesse.net/?p=movit;a=blobdiff_plain;f=resample_effect.cpp;fp=resample_effect.cpp;h=5ab0468d41122c8d367e8d4907c5cdd2d5bc4a41;hp=e1e6199ec5b5b857add0df623d6fd05a25d4b1e0;hb=cc9e1cb1ba6a09b38b5e59ccab817a97dd49ca98;hpb=ff9e68a3f5abb179bd7bf9fb84df48327f148583

diff --git a/resample_effect.cpp b/resample_effect.cpp
index e1e6199..5ab0468 100644
--- a/resample_effect.cpp
+++ b/resample_effect.cpp
@@ -74,9 +74,12 @@ unsigned combine_samples(float *src, float *dst, unsigned num_src_samples, unsig
 		float offset, total_weight, sum_sq_error;
 		combine_two_samples(w1, w2, &offset, &total_weight, &sum_sq_error);
 
-		// If the interpolation error is larger than that of one level
-		// at 8-bit precision, don't combine.
-		if (sum_sq_error > 1.0f / (256.0f * 256.0f)) {
+		// If the interpolation error is larger than that of about sqrt(2) of
+		// a level at 8-bit precision, don't combine. (You'd think 1.0 was enough,
+		// but since the artifacts are not really random, they can get quite
+		// visible. On the other hand, going to 0.25f, I can see no change at
+		// all with 8-bit output, so it would not seem to be worth it.)
+		if (sum_sq_error > 0.5f / (256.0f * 256.0f)) {
 			continue;
 		}