From f78cdecc6646f28638dfd86a3a8ef27d11238aea Mon Sep 17 00:00:00 2001
From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
Date: Wed, 27 Dec 2023 08:47:47 +0100
Subject: [PATCH] Remove redundant parameters to add_pv().

---
 www/js/remoteglot.js | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/www/js/remoteglot.js b/www/js/remoteglot.js
index c0cba6a..d6659f8 100644
--- a/www/js/remoteglot.js
+++ b/www/js/remoteglot.js
@@ -689,19 +689,17 @@ function thousands(x) {
 /**
  * @param {!string} start_fen
  * @param {Array.<string>} pv
- * @param {number} move_num
- * @param {!string} toplay
  * @param {Array<{ first_move: integer, score: Object }>} scores
  * @param {number} start_display_move_num
  * @param {number=} opt_limit
  * @param {boolean=} opt_showlast
  */
-function add_pv(start_fen, pv, move_num, toplay, scores, start_display_move_num, opt_limit, opt_showlast) {
+function add_pv(start_fen, pv, scores, start_display_move_num, opt_limit, opt_showlast) {
 	display_lines.push({
 		start_fen: start_fen,
 		pv: pv,
-		move_num: parseInt(move_num),
-		toplay: toplay,
+		move_num: find_move_num(start_fen),
+		toplay: find_toplay(start_fen),
 		scores: scores,
 		start_display_move_num: start_display_move_num
 	});
@@ -886,9 +884,7 @@ function update_refutation_lines() {
 		moves.push(move);
 	}
 
-	let move_num = find_move_num(base_fen);
-	let toplay = find_toplay(base_fen);
-	let invert = (toplay === 'B');
+	let invert = (find_toplay(base_fen) === 'B');
 	if (current_display_line && current_display_move % 2 == 0 && !current_display_line_is_history) {
 		invert = !invert;
 	}
@@ -925,7 +921,7 @@ function update_refutation_lines() {
 			let pv_td = document.createElement("td");
 			tr.appendChild(pv_td);
 			pv_td.classList.add("pv");
-			pv_td.append(add_pv(base_fen, base_line.concat([ line['move'] ]), move_num, toplay, scores, start_display_move_num));
+			pv_td.append(add_pv(base_fen, base_line.concat([ line['move'] ]), scores, start_display_move_num));
 
 			tbl.append(tr);
 			continue;
@@ -954,7 +950,7 @@ function update_refutation_lines() {
 		let pv_td = document.createElement("td");
 		tr.appendChild(pv_td);
 		pv_td.classList.add("pv");
-		pv_td.append(add_pv(base_fen, base_line.concat(line['pv']), move_num, toplay, scores, start_display_move_num, 10));
+		pv_td.append(add_pv(base_fen, base_line.concat(line['pv']), scores, start_display_move_num, 10));
 
 		tbl.append(tr);
 	}
@@ -1106,8 +1102,8 @@ function update_board() {
 	// unconditionally taken from current_data (we're not interested in
 	// historic history).
 	if (current_data['position']['history']) {
-		let start = (current_data['position'] && current_data['position']['start_fen']) ? current_data['position']['start_fen'] : 'start';
-		add_pv(start, current_data['position']['history'], 1, 'W', null, 0, 8, true);
+		let start = (current_data['position'] && current_data['position']['start_fen']) ? current_data['position']['start_fen'] : 'rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1';
+		add_pv(start, current_data['position']['history'], null, 0, 8, true);
 	} else {
 		display_lines.push(null);
 	}
-- 
2.39.2