#include <vlc_picture.h>
#include <vlc_charset.h>
#include <vlc_fs.h>
+#include <vlc_atomic.h>
#include <arpa/inet.h>
#define CARD_INDEX_TEXT N_("Input card to use")
#define CARD_INDEX_LONGTEXT N_( \
- "SDI capture card to use, if multiple exist. " \
+ "DeckLink capture card to use, if multiple exist. " \
"The cards are numbered from 0." )
#define MODE_TEXT N_("Desired input video mode")
#define MODE_LONGTEXT N_( \
- "Desired input video mode for SDI captures. " \
+ "Desired input video mode for DeckLink captures. " \
"This value should be a FOURCC code in textual " \
"form, e.g. \"ntsc\"." )
#define CACHING_TEXT N_("Caching value in ms")
#define CACHING_LONGTEXT N_( \
- "Caching value for SDI captures. This " \
+ "Caching value for DeckLink captures. This " \
"value should be set in milliseconds." )
#define AUDIO_CONNECTION_TEXT N_("Audio connection")
#define AUDIO_CONNECTION_LONGTEXT N_( \
- "Audio connection to use for SDI captures. " \
+ "Audio connection to use for DeckLink captures. " \
"Valid choices: embedded, aesebu, analog. " \
"Leave blank for card default." )
#define RATE_TEXT N_("Audio sampling rate in Hz")
#define RATE_LONGTEXT N_( \
- "Audio sampling rate (in hertz) for SDI captures. " \
+ "Audio sampling rate (in hertz) for DeckLink captures. " \
"0 disables audio input." )
#define CHANNELS_TEXT N_("Number of audio channels")
#define CHANNELS_LONGTEXT N_( \
- "Number of input audio channels for SDI captures. " \
+ "Number of input audio channels for DeckLink captures. " \
"Must be 2, 8 or 16. 0 disables audio input." )
#define VIDEO_CONNECTION_TEXT N_("Video connection")
#define VIDEO_CONNECTION_LONGTEXT N_( \
- "Video connection to use for SDI captures. " \
+ "Video connection to use for DeckLink captures. " \
"Valid choices: sdi, hdmi, opticalsdi, component, " \
"composite, svideo. " \
"Leave blank for card default." )
"Aspect ratio (4:3, 16:9). Default assumes square pixels." )
vlc_module_begin ()
- set_shortname( N_("SDI") )
- set_description( N_("Blackmagic SDI input") )
+ set_shortname( N_("DeckLink") )
+ set_description( N_("Blackmagic DeckLink SDI input") )
set_category( CAT_INPUT )
set_subcategory( SUBCAT_INPUT_ACCESS )
- add_integer( "sdi-card-index", 0, NULL,
+ add_integer( "decklink-card-index", 0, NULL,
CARD_INDEX_TEXT, CARD_INDEX_LONGTEXT, true )
- add_string( "sdi-mode", "pal ", NULL,
+ add_string( "decklink-mode", "pal ", NULL,
MODE_TEXT, MODE_LONGTEXT, true )
- add_integer( "sdi-caching", DEFAULT_PTS_DELAY / 1000, NULL,
+ add_integer( "decklink-caching", DEFAULT_PTS_DELAY / 1000, NULL,
CACHING_TEXT, CACHING_LONGTEXT, true )
- add_string( "sdi-audio-connection", 0, NULL,
+ add_string( "decklink-audio-connection", 0, NULL,
AUDIO_CONNECTION_TEXT, AUDIO_CONNECTION_LONGTEXT, true )
- add_integer( "sdi-audio-rate", 48000, NULL,
+ add_integer( "decklink-audio-rate", 48000, NULL,
RATE_TEXT, RATE_LONGTEXT, true )
- add_integer( "sdi-audio-channels", 2, NULL,
+ add_integer( "decklink-audio-channels", 2, NULL,
CHANNELS_TEXT, CHANNELS_LONGTEXT, true )
- add_string( "sdi-video-connection", 0, NULL,
+ add_string( "decklink-video-connection", 0, NULL,
VIDEO_CONNECTION_TEXT, VIDEO_CONNECTION_LONGTEXT, true )
- add_string( "sdi-aspect-ratio", NULL, NULL,
+ add_string( "decklink-aspect-ratio", NULL, NULL,
ASPECT_RATIO_TEXT, ASPECT_RATIO_LONGTEXT, true )
- add_shortcut( "sdi" )
+ add_shortcut( "decklink" )
set_capability( "access_demux", 10 )
set_callbacks( Open, Close )
vlc_module_end ()
class DeckLinkCaptureDelegate : public IDeckLinkInputCallback
{
public:
- DeckLinkCaptureDelegate( demux_t *p_demux ) : m_ref_(1), p_demux_(p_demux) {}
+ DeckLinkCaptureDelegate( demux_t *p_demux ) : p_demux_(p_demux)
+ {
+ vlc_atomic_set( &m_ref_, 1 );
+ }
virtual HRESULT STDMETHODCALLTYPE QueryInterface(REFIID iid, LPVOID *ppv) { return E_NOINTERFACE; }
- /* Note: AddRef() and Release() here are not thread safe. */
-
virtual ULONG STDMETHODCALLTYPE AddRef(void)
{
- return ++m_ref_;
+ return vlc_atomic_inc( &m_ref_ );
}
virtual ULONG STDMETHODCALLTYPE Release(void)
{
- if ( --m_ref_ == 0 )
- {
+ uintptr_t new_ref = vlc_atomic_dec( &m_ref_ );
+ if ( new_ref == 0 )
delete this;
- return 0;
- }
- return m_ref_;
+ return new_ref;
}
virtual HRESULT STDMETHODCALLTYPE VideoInputFormatChanged(BMDVideoInputFormatChangedEvents, IDeckLinkDisplayMode*, BMDDetectedVideoInputFormatFlags);
virtual HRESULT STDMETHODCALLTYPE VideoInputFrameArrived(IDeckLinkVideoInputFrame*, IDeckLinkAudioInputPacket*);
private:
- int m_ref_;
+ vlc_atomic_t m_ref_;
demux_t *p_demux_;
};
{
demux_t *p_demux = (demux_t*)p_this;
demux_sys_t *p_sys;
+ int ret = VLC_SUCCESS;
+ char *psz_aspect;
+ char *psz_display_mode = NULL;
+ char *psz_video_connection = NULL;
+ char *psz_audio_connection = NULL;
+ bool b_found_mode;
+ int i_card_index;
/* Only when selected */
if( *p_demux->psz_access == '\0' )
if( !decklink_iterator )
{
msg_Err( p_demux, "DeckLink drivers not found." );
- decklink_iterator->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
HRESULT result;
- int i_card_index = var_CreateGetInteger( p_demux, "sdi-card-index" );
+ i_card_index = var_InheritInteger( p_demux, "decklink-card-index" );
for( int i = 0; i <= i_card_index; ++i )
{
if( p_sys->p_card )
break;
}
- decklink_iterator->Release();
-
if( result != S_OK )
{
msg_Err( p_demux, "DeckLink PCI card %d not found", i_card_index );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
const char *psz_model_name;
if( result != S_OK )
{
msg_Err( p_demux, "Could not get model name" );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
msg_Dbg( p_demux, "Opened DeckLink PCI card %d (%s)", i_card_index, psz_model_name );
if( p_sys->p_card->QueryInterface( IID_IDeckLinkInput, (void**)&p_sys->p_input) != S_OK )
{
msg_Err( p_demux, "Card has no inputs" );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
/* Set up the video and audio sources. */
if( p_sys->p_card->QueryInterface( IID_IDeckLinkConfiguration, (void**)&p_config) != S_OK )
{
msg_Err( p_demux, "Failed to get configuration interface" );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
- char *psz_tmp = var_CreateGetNonEmptyString( p_demux, "sdi-video-connection" );
- if( psz_tmp )
+ psz_video_connection = var_CreateGetNonEmptyString( p_demux, "decklink-video-connection" );
+ if( psz_video_connection )
{
BMDVideoConnection conn;
- if ( !strcmp( psz_tmp, "sdi" ) )
+ if ( !strcmp( psz_video_connection, "sdi" ) )
conn = bmdVideoConnectionSDI;
- else if ( !strcmp( psz_tmp, "hdmi" ) )
+ else if ( !strcmp( psz_video_connection, "hdmi" ) )
conn = bmdVideoConnectionHDMI;
- else if ( !strcmp( psz_tmp, "opticalsdi" ) )
+ else if ( !strcmp( psz_video_connection, "opticalsdi" ) )
conn = bmdVideoConnectionOpticalSDI;
- else if ( !strcmp( psz_tmp, "component" ) )
+ else if ( !strcmp( psz_video_connection, "component" ) )
conn = bmdVideoConnectionComponent;
- else if ( !strcmp( psz_tmp, "composite" ) )
+ else if ( !strcmp( psz_video_connection, "composite" ) )
conn = bmdVideoConnectionComposite;
- else if ( !strcmp( psz_tmp, "svideo" ) )
+ else if ( !strcmp( psz_video_connection, "svideo" ) )
conn = bmdVideoConnectionSVideo;
else
{
- msg_Err( p_demux, "Invalid --sdi-video-connection specified; choose one of " \
+ msg_Err( p_demux, "Invalid --decklink-video-connection specified; choose one of " \
"sdi, hdmi, opticalsdi, component, composite, or svideo." );
- p_config->Release();
- free( psz_tmp );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
- free( psz_tmp );
msg_Dbg( p_demux, "Setting video input format to 0x%x", conn);
result = p_config->SetVideoInputFormat( conn );
if( result != S_OK )
{
msg_Err( p_demux, "Failed to set video input connection" );
- p_config->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
}
- psz_tmp = var_CreateGetNonEmptyString( p_demux, "sdi-audio-connection" );
- if( psz_tmp )
+ psz_audio_connection = var_CreateGetNonEmptyString( p_demux, "decklink-audio-connection" );
+ if( psz_audio_connection )
{
BMDAudioConnection conn;
- if ( !strcmp( psz_tmp, "embedded" ) )
+ if ( !strcmp( psz_audio_connection, "embedded" ) )
conn = bmdAudioConnectionEmbedded;
- else if ( !strcmp( psz_tmp, "aesebu" ) )
+ else if ( !strcmp( psz_audio_connection, "aesebu" ) )
conn = bmdAudioConnectionAESEBU;
- else if ( !strcmp( psz_tmp, "analog" ) )
+ else if ( !strcmp( psz_audio_connection, "analog" ) )
conn = bmdAudioConnectionAnalog;
else
{
- msg_Err( p_demux, "Invalid --sdi-audio-connection specified; choose one of " \
+ msg_Err( p_demux, "Invalid --decklink-audio-connection specified; choose one of " \
"embedded, aesebu, or analog." );
- free( psz_tmp );
- p_config->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
- free( psz_tmp );
msg_Dbg( p_demux, "Setting audio input format to 0x%x", conn);
result = p_config->SetAudioInputFormat( conn );
if( result != S_OK )
{
msg_Err( p_demux, "Failed to set audio input connection" );
- p_config->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
}
- p_config->Release();
-
/* Get the list of display modes. */
IDeckLinkDisplayModeIterator *p_display_iterator;
result = p_sys->p_input->GetDisplayModeIterator( &p_display_iterator );
if( result != S_OK )
{
msg_Err( p_demux, "Failed to enumerate display modes" );
- p_display_iterator->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
- char *psz_display_mode = var_CreateGetString( p_demux, "sdi-mode" );
+ psz_display_mode = var_InheritString( p_demux, "decklink-mode" );
if( !psz_display_mode || strlen( psz_display_mode ) == 0 || strlen( psz_display_mode ) > 4 ) {
- msg_Err( p_demux, "Missing or invalid --sdi-mode string" );
- free( psz_display_mode );
- p_display_iterator->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ msg_Err( p_demux, "Missing or invalid --decklink-mode string" );
+ ret = VLC_EGENERIC;
+ goto finish;
}
/*
- * Pad the --sdi-mode string to four characters, so the user can specify e.g. "pal"
+ * Pad the --decklink-mode string to four characters, so the user can specify e.g. "pal"
* without having to add the trailing space.
*/
char sz_display_mode_padded[5];
for( int i = 0; i < strlen( psz_display_mode ); ++i )
sz_display_mode_padded[i] = psz_display_mode[i];
- free( psz_display_mode );
-
BMDDisplayMode wanted_mode_id;
memcpy( &wanted_mode_id, &sz_display_mode_padded, sizeof(wanted_mode_id) );
- bool b_found_mode = false;
+ b_found_mode = false;
for (;;)
{
{
msg_Err( p_demux, "Failed to get display mode name" );
p_display_mode->Release();
- p_display_iterator->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
BMDTimeValue frame_duration, time_scale;
{
msg_Err( p_demux, "Failed to get frame rate" );
p_display_mode->Release();
- p_display_iterator->Release();
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
const char *psz_field_dominance;
p_display_mode->Release();
}
- p_display_iterator->Release();
-
if( !b_found_mode )
{
- msg_Err( p_demux, "Unknown SDI mode specified. " \
- "Run VLC with -v --verbose-objects=-all,+sdi " \
+ msg_Err( p_demux, "Unknown video mode specified. " \
+ "Run VLC with -v --verbose-objects=-all,+decklink " \
"to get a list of supported modes." );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
result = p_sys->p_input->EnableVideoInput( htonl( wanted_mode_id ), bmdFormat8BitYUV, 0 );
if( result != S_OK )
{
msg_Err( p_demux, "Failed to enable video input" );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
/* Set up audio. */
- p_sys->i_rate = var_CreateGetInteger( p_demux, "sdi-audio-rate" );
- p_sys->i_channels = var_CreateGetInteger( p_demux, "sdi-audio-channels" );
+ p_sys->i_rate = var_InheritInteger( p_demux, "decklink-audio-rate" );
+ p_sys->i_channels = var_InheritInteger( p_demux, "decklink-audio-channels" );
if( p_sys->i_rate > 0 && p_sys->i_channels > 0 )
{
result = p_sys->p_input->EnableAudioInput( p_sys->i_rate, bmdAudioSampleType16bitInteger, p_sys->i_channels );
if( result != S_OK )
{
msg_Err( p_demux, "Failed to enable audio input" );
- Close( p_this );
- return VLC_EGENERIC;
+ ret = VLC_EGENERIC;
+ goto finish;
}
}
result = p_sys->p_input->StartStreams();
if( result != S_OK )
{
- msg_Err( p_demux, "Failed to start streams" );
- Close( p_this );
- return VLC_EGENERIC;
+ msg_Err( p_demux, "Could not start streaming from SDI card. This could be caused "
+ "by invalid video mode or flags, access denied, or card already in use." );
+ ret = VLC_EGENERIC;
+ goto finish;
}
/* Declare elementary streams */
video_fmt.video.i_frame_rate_base = p_sys->i_fps_den;
video_fmt.i_bitrate = video_fmt.video.i_width * video_fmt.video.i_height * video_fmt.video.i_frame_rate * 2 * 8;
- psz_tmp = var_CreateGetNonEmptyString( p_demux, "sdi-aspect-ratio" );
- if( psz_tmp )
+ psz_aspect = var_CreateGetNonEmptyString( p_demux, "decklink-aspect-ratio" );
+ if( psz_aspect )
{
- char *psz_denominator = strchr( psz_tmp, ':' );
+ char *psz_denominator = strchr( psz_aspect, ':' );
if( psz_denominator )
{
*psz_denominator++ = '\0';
- video_fmt.video.i_sar_num = atoi( psz_tmp ) * video_fmt.video.i_height;
+ video_fmt.video.i_sar_num = atoi( psz_aspect ) * video_fmt.video.i_height;
video_fmt.video.i_sar_den = atoi( psz_denominator ) * video_fmt.video.i_width;
}
- free( psz_tmp );
+ free( psz_aspect );
}
msg_Dbg( p_demux, "added new video es %4.4s %dx%d",
p_sys->p_audio_es = es_out_Add( p_demux->out, &audio_fmt );
/* Update default_pts to a suitable value for access */
- var_Create( p_demux, "sdi-caching", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
+ var_Create( p_demux, "decklink-caching", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
+
+finish:
+ if( decklink_iterator )
+ decklink_iterator->Release();
+
+ if( p_config )
+ p_config->Release();
+
+ free( psz_video_connection );
+ free( psz_audio_connection );
+ free( psz_display_mode );
+
+ if( p_display_iterator )
+ p_display_iterator->Release();
+
+ if( ret != VLC_SUCCESS )
+ Close( p_this );
- return VLC_SUCCESS;
+ return ret;
}
static void Close( vlc_object_t *p_this )
case DEMUX_GET_PTS_DELAY:
pi64 = (int64_t*)va_arg( args, int64_t * );
- *pi64 = var_GetInteger( p_demux, "sdi-caching" ) * 1000;
+ *pi64 = var_GetInteger( p_demux, "decklink-caching" ) * 1000;
return VLC_SUCCESS;
case DEMUX_GET_TIME:
projects / vlc / commitdiff