git.sesse.net Git - vlc/blob - modules/codec/omxil/omxil.c

   1 /*****************************************************************************
   2  * omxil.c: Video decoder module making use of OpenMAX IL components.
   3  *****************************************************************************
   4  * Copyright (C) 2010 VLC authors and VideoLAN
   5  * $Id$
   6  *
   7  * Authors: Gildas Bazin <gbazin@videolan.org>
   8  *
   9  * This program is free software; you can redistribute it and/or modify it
  10  * under the terms of the GNU Lesser General Public License as published by
  11  * the Free Software Foundation; either version 2.1 of the License, or
  12  * (at your option) any later version.
  13  *
  14  * This program is distributed in the hope that it will be useful,
  15  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  16  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  17  * GNU Lesser General Public License for more details.
  18  *
  19  * You should have received a copy of the GNU Lesser General Public License
  20  * along with this program; if not, write to the Free Software Foundation,
  21  * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  22  *****************************************************************************/
  23
  24 /*****************************************************************************
  25  * Preamble
  26  *****************************************************************************/
  27 #ifdef HAVE_CONFIG_H
  28 # include "config.h"
  29 #endif
  30
  31 #include <limits.h>
  32
  33 #include <vlc_common.h>
  34 #include <vlc_plugin.h>
  35 #include <vlc_codec.h>
  36 #include <vlc_block_helper.h>
  37 #include <vlc_cpu.h>
  38 #include "../h264_nal.h"
  39
  40 #include "omxil.h"
  41 #include "omxil_core.h"
  42
  43 #ifndef NDEBUG
  44 # define OMXIL_EXTRA_DEBUG
  45 #endif
  46
  47 #define SENTINEL_FLAG 0x10000
  48
  49 /*****************************************************************************
  50  * Local prototypes
  51  *****************************************************************************/
  52 static int  OpenDecoder( vlc_object_t * );
  53 static int  OpenEncoder( vlc_object_t * );
  54 static int  OpenGeneric( vlc_object_t *, bool b_encode );
  55 static void CloseGeneric( vlc_object_t * );
  56
  57 static picture_t *DecodeVideo( decoder_t *, block_t ** );
  58 static block_t *DecodeAudio ( decoder_t *, block_t ** );
  59 static block_t *EncodeVideo( encoder_t *, picture_t * );
  60
  61 static OMX_ERRORTYPE OmxEventHandler( OMX_HANDLETYPE, OMX_PTR, OMX_EVENTTYPE,
  62                                       OMX_U32, OMX_U32, OMX_PTR );
  63 static OMX_ERRORTYPE OmxEmptyBufferDone( OMX_HANDLETYPE, OMX_PTR,
  64                                          OMX_BUFFERHEADERTYPE * );
  65 static OMX_ERRORTYPE OmxFillBufferDone( OMX_HANDLETYPE, OMX_PTR,
  66                                         OMX_BUFFERHEADERTYPE * );
  67
  68 /*****************************************************************************
  69  * Module descriptor
  70  *****************************************************************************/
  71 vlc_module_begin ()
  72     set_description( N_("Audio/Video decoder (using OpenMAX IL)") )
  73     set_category( CAT_INPUT )
  74     set_subcategory( SUBCAT_INPUT_VCODEC )
  75     set_section( N_("Decoding") , NULL )
  76 #if defined(USE_IOMX)
  77     /* For IOMX, don't enable it automatically via priorities,
  78      * enable it only via the --codec iomx command line parameter when
  79      * wanted. */
  80     set_capability( "decoder", 0 )
  81 #else
  82     set_capability( "decoder", 80 )
  83 #endif
  84     set_callbacks( OpenDecoder, CloseGeneric )
  85
  86     add_submodule ()
  87     set_section( N_("Encoding") , NULL )
  88     set_description( N_("Video encoder (using OpenMAX IL)") )
  89     set_capability( "encoder", 0 )
  90     set_callbacks( OpenEncoder, CloseGeneric )
  91 vlc_module_end ()
  92
  93 /*****************************************************************************
  94  * ImplementationSpecificWorkarounds: place-holder for implementation
  95  * specific workarounds
  96  *****************************************************************************/
  97 static OMX_ERRORTYPE ImplementationSpecificWorkarounds(decoder_t *p_dec,
  98     OmxPort *p_port, es_format_t *p_fmt)
  99 {
 100     decoder_sys_t *p_sys = p_dec->p_sys;
 101     OMX_PARAM_PORTDEFINITIONTYPE *def = &p_port->definition;
 102     int i_profile = 0xFFFF, i_level = 0xFFFF;
 103
 104     /* Try to find out the profile of the video */
 105     while(p_fmt->i_cat == VIDEO_ES && def->eDir == OMX_DirInput &&
 106           p_fmt->i_codec == VLC_CODEC_H264)
 107     {
 108         uint8_t *p = (uint8_t*)p_dec->fmt_in.p_extra;
 109         if(!p || !p_dec->fmt_in.p_extra) break;
 110
 111         /* Check the profile / level */
 112         if(p_dec->fmt_in.i_original_fourcc == VLC_FOURCC('a','v','c','1') &&
 113            p[0] == 1)
 114         {
 115             if(p_dec->fmt_in.i_extra < 12) break;
 116             p_sys->i_nal_size_length = 1 + (p[4]&0x03);
 117             if( !(p[5]&0x1f) ) break;
 118             p += 8;
 119         }
 120         else
 121         {
 122             if(p_dec->fmt_in.i_extra < 8) break;
 123             if(!p[0] && !p[1] && !p[2] && p[3] == 1) p += 4;
 124             else if(!p[0] && !p[1] && p[2] == 1) p += 3;
 125             else break;
 126         }
 127
 128         if( ((*p++)&0x1f) != 7) break;
 129
 130         /* Get profile/level out of first SPS */
 131         i_profile = p[0];
 132         i_level = p[2];
 133         break;
 134     }
 135
 136     if(!strcmp(p_sys->psz_component, "OMX.TI.Video.Decoder"))
 137     {
 138         if(p_fmt->i_cat == VIDEO_ES && def->eDir == OMX_DirInput &&
 139            p_fmt->i_codec == VLC_CODEC_H264 &&
 140            (i_profile != 66 || i_level > 30))
 141         {
 142             msg_Dbg(p_dec, "h264 profile/level not supported (0x%x, 0x%x)",
 143                     i_profile, i_level);
 144             return OMX_ErrorNotImplemented;
 145         }
 146
 147         if(p_fmt->i_cat == VIDEO_ES && def->eDir == OMX_DirOutput &&
 148            p_fmt->i_codec == VLC_CODEC_I420)
 149         {
 150             /* I420 xvideo is slow on OMAP */
 151             def->format.video.eColorFormat = OMX_COLOR_FormatCbYCrY;
 152             GetVlcChromaFormat( def->format.video.eColorFormat,
 153                                 &p_fmt->i_codec, 0 );
 154             GetVlcChromaSizes( p_fmt->i_codec,
 155                                def->format.video.nFrameWidth,
 156                                def->format.video.nFrameHeight,
 157                                &p_port->i_frame_size, &p_port->i_frame_stride,
 158                                &p_port->i_frame_stride_chroma_div );
 159             def->format.video.nStride = p_port->i_frame_stride;
 160             def->nBufferSize = p_port->i_frame_size;
 161         }
 162     }
 163     else if(!strcmp(p_sys->psz_component, "OMX.st.video_encoder"))
 164     {
 165         if(p_fmt->i_cat == VIDEO_ES)
 166         {
 167             /* Bellagio's encoder doesn't encode the framerate in Q16 */
 168             def->format.video.xFramerate >>= 16;
 169         }
 170     }
 171 #if 0 /* FIXME: doesn't apply for HP Touchpad */
 172     else if (!strncmp(p_sys->psz_component, "OMX.qcom.video.decoder.",
 173                       strlen("OMX.qcom.video.decoder")))
 174     {
 175         /* qdsp6 refuses buffer size larger than 450K on input port */
 176         if (def->nBufferSize > 450 * 1024)
 177         {
 178             def->nBufferSize = 450 * 1024;
 179             p_port->i_frame_size = def->nBufferSize;
 180         }
 181     }
 182 #endif
 183
 184     return OMX_ErrorNone;
 185 }
 186
 187 /*****************************************************************************
 188  * SetPortDefinition: set definition of the omx port based on the vlc format
 189  *****************************************************************************/
 190 static OMX_ERRORTYPE SetPortDefinition(decoder_t *p_dec, OmxPort *p_port,
 191                                        es_format_t *p_fmt)
 192 {
 193     OMX_PARAM_PORTDEFINITIONTYPE *def = &p_port->definition;
 194     OMX_ERRORTYPE omx_error;
 195
 196     omx_error = OMX_GetParameter(p_port->omx_handle,
 197                                  OMX_IndexParamPortDefinition, def);
 198     CHECK_ERROR(omx_error, "OMX_GetParameter failed (%x : %s)",
 199                 omx_error, ErrorToString(omx_error));
 200
 201     switch(p_fmt->i_cat)
 202     {
 203     case VIDEO_ES:
 204         def->format.video.nFrameWidth = p_fmt->video.i_width;
 205         def->format.video.nFrameHeight = p_fmt->video.i_height;
 206         if(def->format.video.eCompressionFormat == OMX_VIDEO_CodingUnused)
 207             def->format.video.nStride = def->format.video.nFrameWidth;
 208         if( p_fmt->video.i_frame_rate > 0 &&
 209             p_fmt->video.i_frame_rate_base > 0 )
 210             def->format.video.xFramerate = (p_fmt->video.i_frame_rate << 16) /
 211                 p_fmt->video.i_frame_rate_base;
 212
 213         if(def->eDir == OMX_DirInput || p_dec->p_sys->b_enc)
 214         {
 215             if (def->eDir == OMX_DirInput && p_dec->p_sys->b_enc)
 216                 def->nBufferSize = def->format.video.nFrameWidth *
 217                   def->format.video.nFrameHeight * 2;
 218             p_port->i_frame_size = def->nBufferSize;
 219
 220             if(!GetOmxVideoFormat(p_fmt->i_codec,
 221                                   &def->format.video.eCompressionFormat, 0) )
 222             {
 223                 if(!GetOmxChromaFormat(p_fmt->i_codec,
 224                                        &def->format.video.eColorFormat, 0) )
 225                 {
 226                     omx_error = OMX_ErrorNotImplemented;
 227                     CHECK_ERROR(omx_error, "codec %4.4s doesn't match any OMX format",
 228                                 (char *)&p_fmt->i_codec );
 229                 }
 230                 GetVlcChromaSizes( p_fmt->i_codec,
 231                                    def->format.video.nFrameWidth,
 232                                    def->format.video.nFrameHeight,
 233                                    &p_port->i_frame_size, &p_port->i_frame_stride,
 234                                    &p_port->i_frame_stride_chroma_div );
 235                 def->format.video.nStride = p_port->i_frame_stride;
 236                 def->nBufferSize = p_port->i_frame_size;
 237             }
 238         }
 239         else
 240         {
 241             if( !GetVlcChromaFormat( def->format.video.eColorFormat,
 242                                      &p_fmt->i_codec, 0 ) )
 243             {
 244                 omx_error = OMX_ErrorNotImplemented;
 245                 CHECK_ERROR(omx_error, "OMX color format %i not supported",
 246                             (int)def->format.video.eColorFormat );
 247             }
 248             GetVlcChromaSizes( p_fmt->i_codec,
 249                                def->format.video.nFrameWidth,
 250                                def->format.video.nFrameHeight,
 251                                &p_port->i_frame_size, &p_port->i_frame_stride,
 252                                &p_port->i_frame_stride_chroma_div );
 253             def->format.video.nStride = p_port->i_frame_stride;
 254             if (p_port->i_frame_size > def->nBufferSize)
 255                 def->nBufferSize = p_port->i_frame_size;
 256         }
 257         break;
 258
 259     case AUDIO_ES:
 260         p_port->i_frame_size = def->nBufferSize;
 261         if(def->eDir == OMX_DirInput)
 262         {
 263             if(!GetOmxAudioFormat(p_fmt->i_codec,
 264                                   &def->format.audio.eEncoding, 0) )
 265             {
 266                 omx_error = OMX_ErrorNotImplemented;
 267                 CHECK_ERROR(omx_error, "codec %4.4s doesn't match any OMX format",
 268                             (char *)&p_fmt->i_codec );
 269             }
 270         }
 271         else
 272         {
 273             if( !OmxToVlcAudioFormat(def->format.audio.eEncoding,
 274                                    &p_fmt->i_codec, 0 ) )
 275             {
 276                 omx_error = OMX_ErrorNotImplemented;
 277                 CHECK_ERROR(omx_error, "OMX audio encoding %i not supported",
 278                             (int)def->format.audio.eEncoding );
 279             }
 280         }
 281         break;
 282
 283     default: return OMX_ErrorNotImplemented;
 284     }
 285
 286     omx_error = ImplementationSpecificWorkarounds(p_dec, p_port, p_fmt);
 287     CHECK_ERROR(omx_error, "ImplementationSpecificWorkarounds failed (%x : %s)",
 288                 omx_error, ErrorToString(omx_error));
 289
 290     omx_error = OMX_SetParameter(p_port->omx_handle,
 291                                  OMX_IndexParamPortDefinition, def);
 292     CHECK_ERROR(omx_error, "OMX_SetParameter failed (%x : %s)",
 293                 omx_error, ErrorToString(omx_error));
 294
 295     omx_error = OMX_GetParameter(p_port->omx_handle,
 296                                  OMX_IndexParamPortDefinition, def);
 297     CHECK_ERROR(omx_error, "OMX_GetParameter failed (%x : %s)",
 298                 omx_error, ErrorToString(omx_error));
 299
 300     if(p_port->i_frame_size > def->nBufferSize)
 301         def->nBufferSize = p_port->i_frame_size;
 302     p_port->i_frame_size = def->nBufferSize;
 303
 304     /* Deal with audio params */
 305     if(p_fmt->i_cat == AUDIO_ES)
 306     {
 307         omx_error = SetAudioParameters(p_port->omx_handle,
 308                                        &p_port->format_param, def->nPortIndex,
 309                                        def->format.audio.eEncoding,
 310                                        p_fmt->i_codec,
 311                                        p_fmt->audio.i_channels,
 312                                        p_fmt->audio.i_rate,
 313                                        p_fmt->i_bitrate,
 314                                        p_fmt->audio.i_bitspersample,
 315                                        p_fmt->audio.i_blockalign);
 316         if (def->eDir == OMX_DirInput) {
 317             CHECK_ERROR(omx_error, "SetAudioParameters failed (%x : %s)",
 318                         omx_error, ErrorToString(omx_error));
 319         } else if (omx_error != OMX_ErrorNone) {
 320             msg_Warn(p_dec, "SetAudioParameters failed (%x : %s) on output port",
 321                      omx_error, ErrorToString(omx_error));
 322             omx_error = OMX_ErrorNone;
 323         }
 324     }
 325     if (!strcmp(p_dec->p_sys->psz_component, "OMX.TI.DUCATI1.VIDEO.DECODER") &&
 326                 def->eDir == OMX_DirOutput)
 327     {
 328         /* When setting the output buffer size above, the decoder actually
 329          * sets the buffer size to a lower value than what was chosen. If
 330          * we try to allocate buffers of this size, it fails. Thus, forcibly
 331          * use a larger buffer size. */
 332         def->nBufferSize *= 2;
 333     }
 334
 335  error:
 336     return omx_error;
 337 }
 338
 339 /*****************************************************************************
 340  * GetPortDefinition: set vlc format based on the definition of the omx port
 341  *****************************************************************************/
 342 static OMX_ERRORTYPE GetPortDefinition(decoder_t *p_dec, OmxPort *p_port,
 343                                        es_format_t *p_fmt)
 344 {
 345     decoder_sys_t *p_sys = p_dec->p_sys;
 346     OMX_PARAM_PORTDEFINITIONTYPE *def = &p_port->definition;
 347     OMX_ERRORTYPE omx_error;
 348     OMX_CONFIG_RECTTYPE crop_rect;
 349
 350     omx_error = OMX_GetParameter(p_port->omx_handle,
 351                                  OMX_IndexParamPortDefinition, def);
 352     CHECK_ERROR(omx_error, "OMX_GetParameter failed (%x : %s)",
 353                 omx_error, ErrorToString(omx_error));
 354
 355     switch(p_fmt->i_cat)
 356     {
 357     case VIDEO_ES:
 358         p_fmt->video.i_width = def->format.video.nFrameWidth;
 359         p_fmt->video.i_visible_width = def->format.video.nFrameWidth;
 360         p_fmt->video.i_height = def->format.video.nFrameHeight;
 361         p_fmt->video.i_visible_height = def->format.video.nFrameHeight;
 362         p_fmt->video.i_frame_rate = p_dec->fmt_in.video.i_frame_rate;
 363         p_fmt->video.i_frame_rate_base = p_dec->fmt_in.video.i_frame_rate_base;
 364
 365         OMX_INIT_STRUCTURE(crop_rect);
 366         crop_rect.nPortIndex = def->nPortIndex;
 367         omx_error = OMX_GetConfig(p_port->omx_handle, OMX_IndexConfigCommonOutputCrop, &crop_rect);
 368         if (omx_error == OMX_ErrorNone)
 369         {
 370             if (!def->format.video.nSliceHeight)
 371                 def->format.video.nSliceHeight = def->format.video.nFrameHeight;
 372             if (!def->format.video.nStride)
 373                 def->format.video.nStride = def->format.video.nFrameWidth;
 374             p_fmt->video.i_width = crop_rect.nWidth;
 375             p_fmt->video.i_visible_width = crop_rect.nWidth;
 376             p_fmt->video.i_height = crop_rect.nHeight;
 377             p_fmt->video.i_visible_height = crop_rect.nHeight;
 378             if (def->format.video.eColorFormat == OMX_TI_COLOR_FormatYUV420PackedSemiPlanar)
 379                 def->format.video.nSliceHeight -= crop_rect.nTop/2;
 380         }
 381         else
 382         {
 383             /* Don't pass the error back to the caller, this isn't mandatory */
 384             omx_error = OMX_ErrorNone;
 385         }
 386
 387         /* Hack: Nexus One (stock firmware with binary OMX driver blob)
 388          * claims to output 420Planar even though it in in practice is
 389          * NV21. */
 390         if(def->format.video.eColorFormat == OMX_COLOR_FormatYUV420Planar &&
 391            !strncmp(p_sys->psz_component, "OMX.qcom.video.decoder",
 392                     strlen("OMX.qcom.video.decoder")))
 393             def->format.video.eColorFormat = OMX_QCOM_COLOR_FormatYVU420SemiPlanar;
 394
 395         if (IgnoreOmxDecoderPadding(p_sys->psz_component)) {
 396             def->format.video.nSliceHeight = 0;
 397             def->format.video.nStride = p_fmt->video.i_width;
 398         }
 399
 400         if(!GetVlcVideoFormat( def->format.video.eCompressionFormat,
 401                                &p_fmt->i_codec, 0 ) )
 402         {
 403             if( !GetVlcChromaFormat( def->format.video.eColorFormat,
 404                                      &p_fmt->i_codec, 0 ) )
 405             {
 406                 omx_error = OMX_ErrorNotImplemented;
 407                 CHECK_ERROR(omx_error, "OMX color format %i not supported",
 408                             (int)def->format.video.eColorFormat );
 409             }
 410             GetVlcChromaSizes( p_fmt->i_codec,
 411                                def->format.video.nFrameWidth,
 412                                def->format.video.nFrameHeight,
 413                                &p_port->i_frame_size, &p_port->i_frame_stride,
 414                                &p_port->i_frame_stride_chroma_div );
 415         }
 416         if(p_port->i_frame_size > def->nBufferSize)
 417             def->nBufferSize = p_port->i_frame_size;
 418         p_port->i_frame_size = def->nBufferSize;
 419 #if 0
 420         if((int)p_port->i_frame_stride > def->format.video.nStride)
 421             def->format.video.nStride = p_port->i_frame_stride;
 422 #endif
 423         p_port->i_frame_stride = def->format.video.nStride;
 424         break;
 425
 426     case AUDIO_ES:
 427         if( !OmxToVlcAudioFormat( def->format.audio.eEncoding,
 428                                 &p_fmt->i_codec, 0 ) )
 429         {
 430             omx_error = OMX_ErrorNotImplemented;
 431             CHECK_ERROR(omx_error, "OMX audio format %i not supported",
 432                         (int)def->format.audio.eEncoding );
 433         }
 434
 435         omx_error = GetAudioParameters(p_port->omx_handle,
 436                                        &p_port->format_param, def->nPortIndex,
 437                                        def->format.audio.eEncoding,
 438                                        &p_fmt->audio.i_channels,
 439                                        &p_fmt->audio.i_rate,
 440                                        &p_fmt->i_bitrate,
 441                                        &p_fmt->audio.i_bitspersample,
 442                                        &p_fmt->audio.i_blockalign);
 443         CHECK_ERROR(omx_error, "GetAudioParameters failed (%x : %s)",
 444                     omx_error, ErrorToString(omx_error));
 445
 446         if(p_fmt->audio.i_channels < 9)
 447         {
 448             static const int pi_channels_maps[9] =
 449             {
 450                 0, AOUT_CHAN_CENTER, AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT,
 451                 AOUT_CHAN_CENTER | AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT,
 452                 AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_REARLEFT
 453                 | AOUT_CHAN_REARRIGHT,
 454                 AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
 455                 | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT,
 456                 AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
 457                 | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_LFE,
 458                 AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
 459                 | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_MIDDLELEFT
 460                 | AOUT_CHAN_MIDDLERIGHT,
 461                 AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER | AOUT_CHAN_REARLEFT
 462                 | AOUT_CHAN_REARRIGHT | AOUT_CHAN_MIDDLELEFT | AOUT_CHAN_MIDDLERIGHT
 463                 | AOUT_CHAN_LFE
 464             };
 465             p_fmt->audio.i_physical_channels =
 466                 p_fmt->audio.i_original_channels =
 467                     pi_channels_maps[p_fmt->audio.i_channels];
 468         }
 469
 470         date_Init( &p_dec->p_sys->end_date, p_fmt->audio.i_rate, 1 );
 471
 472         break;
 473
 474     default: return OMX_ErrorNotImplemented;
 475     }
 476
 477  error:
 478     return omx_error;
 479 }
 480
 481 /*****************************************************************************
 482  * DeinitialiseComponent: Deinitialise and unload an OMX component
 483  *****************************************************************************/
 484 static OMX_ERRORTYPE DeinitialiseComponent(decoder_t *p_dec,
 485                                            OMX_HANDLETYPE omx_handle)
 486 {
 487     decoder_sys_t *p_sys = p_dec->p_sys;
 488     OMX_ERRORTYPE omx_error;
 489     OMX_STATETYPE state;
 490     unsigned int i, j;
 491
 492     if(!omx_handle) return OMX_ErrorNone;
 493
 494     omx_error = OMX_GetState(omx_handle, &state);
 495     CHECK_ERROR(omx_error, "OMX_GetState failed (%x)", omx_error );
 496
 497     if(state == OMX_StateExecuting)
 498     {
 499         omx_error = OMX_SendCommand( omx_handle, OMX_CommandStateSet,
 500                                      OMX_StateIdle, 0 );
 501         CHECK_ERROR(omx_error, "OMX_CommandStateSet Idle failed (%x)", omx_error );
 502         while (1) {
 503             OMX_U32 cmd, state;
 504             omx_error = WaitForSpecificOmxEvent(&p_sys->event_queue, OMX_EventCmdComplete, &cmd, &state, 0);
 505             CHECK_ERROR(omx_error, "Wait for Idle failed (%x)", omx_error );
 506             // The event queue can contain other OMX_EventCmdComplete items,
 507             // such as for OMX_CommandFlush
 508             if (cmd == OMX_CommandStateSet && state == OMX_StateIdle)
 509                 break;
 510         }
 511     }
 512
 513     omx_error = OMX_GetState(omx_handle, &state);
 514     CHECK_ERROR(omx_error, "OMX_GetState failed (%x)", omx_error );
 515
 516     if(state == OMX_StateIdle)
 517     {
 518         omx_error = OMX_SendCommand( omx_handle, OMX_CommandStateSet,
 519                                      OMX_StateLoaded, 0 );
 520         CHECK_ERROR(omx_error, "OMX_CommandStateSet Loaded failed (%x)", omx_error );
 521
 522         for(i = 0; i < p_sys->ports; i++)
 523         {
 524             OmxPort *p_port = &p_sys->p_ports[i];
 525             OMX_BUFFERHEADERTYPE *p_buffer;
 526
 527             for(j = 0; j < p_port->i_buffers; j++)
 528             {
 529                 OMX_FIFO_GET(&p_port->fifo, p_buffer);
 530                 if (p_buffer->nFlags & SENTINEL_FLAG) {
 531                     free(p_buffer);
 532                     j--;
 533                     continue;
 534                 }
 535                 omx_error = OMX_FreeBuffer( omx_handle,
 536                                             p_port->i_port_index, p_buffer );
 537
 538                 if(omx_error != OMX_ErrorNone) break;
 539             }
 540             CHECK_ERROR(omx_error, "OMX_FreeBuffer failed (%x, %i, %i)",
 541                         omx_error, (int)p_port->i_port_index, j );
 542             while (1) {
 543                 OMX_FIFO_PEEK(&p_port->fifo, p_buffer);
 544                 if (!p_buffer) break;
 545
 546                 OMX_FIFO_GET(&p_port->fifo, p_buffer);
 547                 if (p_buffer->nFlags & SENTINEL_FLAG) {
 548                     free(p_buffer);
 549                     continue;
 550                 }
 551                 msg_Warn( p_dec, "Stray buffer left in fifo, %p", p_buffer );
 552             }
 553         }
 554
 555         omx_error = WaitForSpecificOmxEvent(&p_sys->event_queue, OMX_EventCmdComplete, 0, 0, 0);
 556         CHECK_ERROR(omx_error, "Wait for Loaded failed (%x)", omx_error );
 557     }
 558
 559  error:
 560     for(i = 0; i < p_sys->ports; i++)
 561     {
 562         OmxPort *p_port = &p_sys->p_ports[i];
 563         free(p_port->pp_buffers);
 564         p_port->pp_buffers = 0;
 565     }
 566     omx_error = pf_free_handle( omx_handle );
 567     return omx_error;
 568 }
 569
 570 /*****************************************************************************
 571  * InitialiseComponent: Load and initialise an OMX component
 572  *****************************************************************************/
 573 static OMX_ERRORTYPE InitialiseComponent(decoder_t *p_dec,
 574     OMX_STRING psz_component, OMX_HANDLETYPE *p_handle)
 575 {
 576     static OMX_CALLBACKTYPE callbacks =
 577         { OmxEventHandler, OmxEmptyBufferDone, OmxFillBufferDone };
 578     decoder_sys_t *p_sys = p_dec->p_sys;
 579     OMX_HANDLETYPE omx_handle;
 580     OMX_ERRORTYPE omx_error;
 581     unsigned int i;
 582     OMX_U8 psz_role[OMX_MAX_STRINGNAME_SIZE];
 583     OMX_PARAM_COMPONENTROLETYPE role;
 584     OMX_PARAM_PORTDEFINITIONTYPE definition;
 585     OMX_PORT_PARAM_TYPE param;
 586
 587     /* Load component */
 588     omx_error = pf_get_handle( &omx_handle, psz_component, p_dec, &callbacks );
 589     if(omx_error != OMX_ErrorNone)
 590     {
 591         msg_Warn( p_dec, "OMX_GetHandle(%s) failed (%x: %s)", psz_component,
 592                   omx_error, ErrorToString(omx_error) );
 593         return omx_error;
 594     }
 595     strncpy(p_sys->psz_component, psz_component, OMX_MAX_STRINGNAME_SIZE-1);
 596
 597     omx_error = OMX_ComponentRoleEnum(omx_handle, psz_role, 0);
 598     if(omx_error == OMX_ErrorNone)
 599         msg_Dbg(p_dec, "loaded component %s of role %s", psz_component, psz_role);
 600     else
 601         msg_Dbg(p_dec, "loaded component %s", psz_component);
 602     PrintOmx(p_dec, omx_handle, OMX_ALL);
 603
 604     /* Set component role */
 605     OMX_INIT_STRUCTURE(role);
 606     strcpy((char*)role.cRole,
 607            GetOmxRole(p_sys->b_enc ? p_dec->fmt_out.i_codec : p_dec->fmt_in.i_codec,
 608                       p_dec->fmt_in.i_cat, p_sys->b_enc));
 609
 610     omx_error = OMX_SetParameter(omx_handle, OMX_IndexParamStandardComponentRole,
 611                                  &role);
 612     omx_error = OMX_GetParameter(omx_handle, OMX_IndexParamStandardComponentRole,
 613                                  &role);
 614     if(omx_error == OMX_ErrorNone)
 615         msg_Dbg(p_dec, "component standard role set to %s", role.cRole);
 616
 617     /* Find the input / output ports */
 618     OMX_INIT_STRUCTURE(param);
 619     OMX_INIT_STRUCTURE(definition);
 620     omx_error = OMX_GetParameter(omx_handle, p_dec->fmt_in.i_cat == VIDEO_ES ?
 621                                  OMX_IndexParamVideoInit : OMX_IndexParamAudioInit, &param);
 622     if(omx_error != OMX_ErrorNone) {
 623 #ifdef __ANDROID__
 624         param.nPorts = 2;
 625         param.nStartPortNumber = 0;
 626 #else
 627         param.nPorts = 0;
 628 #endif
 629     }
 630
 631     for(i = 0; i < param.nPorts; i++)
 632     {
 633         OmxPort *p_port;
 634
 635         /* Get port definition */
 636         definition.nPortIndex = param.nStartPortNumber + i;
 637         omx_error = OMX_GetParameter(omx_handle, OMX_IndexParamPortDefinition,
 638                                      &definition);
 639         if(omx_error != OMX_ErrorNone) continue;
 640
 641         if(definition.eDir == OMX_DirInput) p_port = &p_sys->in;
 642         else  p_port = &p_sys->out;
 643
 644         p_port->b_valid = true;
 645         p_port->i_port_index = definition.nPortIndex;
 646         p_port->definition = definition;
 647         p_port->omx_handle = omx_handle;
 648     }
 649
 650     if(!p_sys->in.b_valid || !p_sys->out.b_valid)
 651     {
 652         omx_error = OMX_ErrorInvalidComponent;
 653         CHECK_ERROR(omx_error, "couldn't find an input and output port");
 654     }
 655
 656     if(!strncmp(p_sys->psz_component, "OMX.SEC.", 8) &&
 657        p_dec->fmt_in.i_cat == VIDEO_ES)
 658     {
 659         OMX_INDEXTYPE index;
 660         omx_error = OMX_GetExtensionIndex(omx_handle, (OMX_STRING) "OMX.SEC.index.ThumbnailMode", &index);
 661         if(omx_error == OMX_ErrorNone)
 662         {
 663             OMX_BOOL enable = OMX_TRUE;
 664             omx_error = OMX_SetConfig(omx_handle, index, &enable);
 665             CHECK_ERROR(omx_error, "Unable to set ThumbnailMode");
 666         } else {
 667             OMX_BOOL enable = OMX_TRUE;
 668             /* Needed on Samsung Galaxy S II */
 669             omx_error = OMX_SetConfig(omx_handle, OMX_IndexVendorSetYUV420pMode, &enable);
 670             if (omx_error == OMX_ErrorNone)
 671                 msg_Dbg(p_dec, "Set OMX_IndexVendorSetYUV420pMode successfully");
 672             else
 673                 msg_Dbg(p_dec, "Unable to set OMX_IndexVendorSetYUV420pMode: %x", omx_error);
 674         }
 675     }
 676
 677     /* Set port definitions */
 678     for(i = 0; i < p_sys->ports; i++)
 679     {
 680         omx_error = SetPortDefinition(p_dec, &p_sys->p_ports[i],
 681                                       p_sys->p_ports[i].p_fmt);
 682         if(omx_error != OMX_ErrorNone) goto error;
 683     }
 684
 685     /* Allocate our array for the omx buffers and enable ports */
 686     for(i = 0; i < p_sys->ports; i++)
 687     {
 688         OmxPort *p_port = &p_sys->p_ports[i];
 689
 690         p_port->pp_buffers =
 691             malloc(p_port->definition.nBufferCountActual *
 692                    sizeof(OMX_BUFFERHEADERTYPE*));
 693         if(!p_port->pp_buffers)
 694         {
 695           omx_error = OMX_ErrorInsufficientResources;
 696           CHECK_ERROR(omx_error, "memory allocation failed");
 697         }
 698         p_port->i_buffers = p_port->definition.nBufferCountActual;
 699
 700         /* Enable port */
 701         if(!p_port->definition.bEnabled)
 702         {
 703             omx_error = OMX_SendCommand( omx_handle, OMX_CommandPortEnable,
 704                                          p_port->i_port_index, NULL);
 705             CHECK_ERROR(omx_error, "OMX_CommandPortEnable on %i failed (%x)",
 706                         (int)p_port->i_port_index, omx_error );
 707             omx_error = WaitForSpecificOmxEvent(&p_sys->event_queue, OMX_EventCmdComplete, 0, 0, 0);
 708             CHECK_ERROR(omx_error, "Wait for PortEnable on %i failed (%x)",
 709                         (int)p_port->i_port_index, omx_error );
 710         }
 711     }
 712
 713     *p_handle = omx_handle;
 714     return OMX_ErrorNone;
 715
 716  error:
 717     DeinitialiseComponent(p_dec, omx_handle);
 718     *p_handle = 0;
 719     return omx_error;
 720 }
 721
 722 /*****************************************************************************
 723  * OpenDecoder: Create the decoder instance
 724  *****************************************************************************/
 725 static int OpenDecoder( vlc_object_t *p_this )
 726 {
 727     decoder_t *p_dec = (decoder_t*)p_this;
 728     int status;
 729
 730     if( 0 || !GetOmxRole(p_dec->fmt_in.i_codec, p_dec->fmt_in.i_cat, false) )
 731         return VLC_EGENERIC;
 732
 733     status = OpenGeneric( p_this, false );
 734     if(status != VLC_SUCCESS) return status;
 735
 736     p_dec->pf_decode_video = DecodeVideo;
 737     p_dec->pf_decode_audio = DecodeAudio;
 738
 739     return VLC_SUCCESS;
 740 }
 741
 742 /*****************************************************************************
 743  * OpenEncoder: Create the encoder instance
 744  *****************************************************************************/
 745 static int OpenEncoder( vlc_object_t *p_this )
 746 {
 747     encoder_t *p_enc = (encoder_t*)p_this;
 748     int status;
 749
 750     if( !GetOmxRole(p_enc->fmt_out.i_codec, p_enc->fmt_in.i_cat, true) )
 751         return VLC_EGENERIC;
 752
 753     status = OpenGeneric( p_this, true );
 754     if(status != VLC_SUCCESS) return status;
 755
 756     p_enc->pf_encode_video = EncodeVideo;
 757
 758     return VLC_SUCCESS;
 759 }
 760
 761 /*****************************************************************************
 762  * OpenGeneric: Create the generic decoder/encoder instance
 763  *****************************************************************************/
 764 static int OpenGeneric( vlc_object_t *p_this, bool b_encode )
 765 {
 766     decoder_t *p_dec = (decoder_t*)p_this;
 767     decoder_sys_t *p_sys;
 768     OMX_ERRORTYPE omx_error;
 769     OMX_BUFFERHEADERTYPE *p_header;
 770     unsigned int i, j;
 771
 772     if (InitOmxCore(p_this) != VLC_SUCCESS) {
 773         return VLC_EGENERIC;
 774     }
 775
 776     /* Allocate the memory needed to store the decoder's structure */
 777     if( ( p_dec->p_sys = p_sys = calloc( 1, sizeof(*p_sys)) ) == NULL )
 778     {
 779         DeinitOmxCore();
 780         return VLC_ENOMEM;
 781     }
 782
 783     /* Initialise the thread properties */
 784     if(!b_encode)
 785     {
 786         p_dec->fmt_out.i_cat = p_dec->fmt_in.i_cat;
 787         p_dec->fmt_out.video = p_dec->fmt_in.video;
 788         p_dec->fmt_out.audio = p_dec->fmt_in.audio;
 789         p_dec->fmt_out.i_codec = 0;
 790     }
 791     p_sys->b_enc = b_encode;
 792     InitOmxEventQueue(&p_sys->event_queue);
 793     vlc_mutex_init (&p_sys->in.fifo.lock);
 794     vlc_cond_init (&p_sys->in.fifo.wait);
 795     p_sys->in.fifo.offset = offsetof(OMX_BUFFERHEADERTYPE, pOutputPortPrivate) / sizeof(void *);
 796     p_sys->in.fifo.pp_last = &p_sys->in.fifo.p_first;
 797     p_sys->in.b_direct = false;
 798     p_sys->in.b_flushed = true;
 799     p_sys->in.p_fmt = &p_dec->fmt_in;
 800     vlc_mutex_init (&p_sys->out.fifo.lock);
 801     vlc_cond_init (&p_sys->out.fifo.wait);
 802     p_sys->out.fifo.offset = offsetof(OMX_BUFFERHEADERTYPE, pInputPortPrivate) / sizeof(void *);
 803     p_sys->out.fifo.pp_last = &p_sys->out.fifo.p_first;
 804     p_sys->out.b_direct = false;
 805     p_sys->out.b_flushed = true;
 806     p_sys->out.p_fmt = &p_dec->fmt_out;
 807     p_sys->ports = 2;
 808     p_sys->p_ports = &p_sys->in;
 809     p_sys->b_use_pts = 0;
 810
 811     msg_Dbg(p_dec, "fmt in:%4.4s, out: %4.4s", (char *)&p_dec->fmt_in.i_codec,
 812             (char *)&p_dec->fmt_out.i_codec);
 813
 814     /* Enumerate components and build a list of the one we want to try */
 815     p_sys->components =
 816         CreateComponentsList(p_this,
 817              GetOmxRole(p_sys->b_enc ? p_dec->fmt_out.i_codec :
 818                         p_dec->fmt_in.i_codec, p_dec->fmt_in.i_cat,
 819                         p_sys->b_enc), p_sys->ppsz_components);
 820     if( !p_sys->components )
 821     {
 822         msg_Warn( p_this, "couldn't find an omx component for codec %4.4s",
 823                   (char *)&p_dec->fmt_in.i_codec );
 824         CloseGeneric(p_this);
 825         return VLC_EGENERIC;
 826     }
 827
 828     /* Try to load and initialise a component */
 829     omx_error = OMX_ErrorUndefined;
 830     for(i = 0; i < p_sys->components; i++)
 831     {
 832 #ifdef __ANDROID__
 833         /* ignore OpenCore software codecs */
 834         if (!strncmp(p_sys->ppsz_components[i], "OMX.PV.", 7))
 835             continue;
 836         /* The same sw codecs, renamed in ICS (perhaps also in honeycomb) */
 837         if (!strncmp(p_sys->ppsz_components[i], "OMX.google.", 11))
 838             continue;
 839         /* This one has been seen on HTC One V - it behaves like it works,
 840          * but FillBufferDone returns buffers filled with 0 bytes. The One V
 841          * has got a working OMX.qcom.video.decoder.avc instead though. */
 842         if (!strncmp(p_sys->ppsz_components[i], "OMX.ARICENT.", 12))
 843             continue;
 844         /* Codecs with DRM, that don't output plain YUV data but only
 845          * support direct rendering where the output can't be intercepted. */
 846         if (strstr(p_sys->ppsz_components[i], ".secure"))
 847             continue;
 848         /* Use VC1 decoder for WMV3 for now */
 849         if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.WMV.Decoder"))
 850             continue;
 851         /* This decoder does work, but has an insane latency (leading to errors
 852          * about "main audio output playback way too late" and dropped frames).
 853          * At least Samsung Galaxy S III (where this decoder is present) has
 854          * got another one, OMX.SEC.mp3.dec, that works well and has a
 855          * sensible latency. (Also, even if that one isn't found, in general,
 856          * using SW codecs is usually more than fast enough for MP3.) */
 857         if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.MP3.Decoder"))
 858             continue;
 859         /* This codec should be able to handle both VC1 and WMV3, but
 860          * for VC1 it doesn't output any buffers at all (in the way we use
 861          * it) and for WMV3 it outputs plain black buffers. Thus ignore
 862          * it until we can make it work properly. */
 863         if (!strcmp(p_sys->ppsz_components[i], "OMX.Nvidia.vc1.decode"))
 864             continue;
 865 #endif
 866         omx_error = InitialiseComponent(p_dec, p_sys->ppsz_components[i],
 867                                         &p_sys->omx_handle);
 868         if(omx_error == OMX_ErrorNone) break;
 869     }
 870     CHECK_ERROR(omx_error, "no component could be initialised" );
 871
 872     /* Move component to Idle then Executing state */
 873     OMX_SendCommand( p_sys->omx_handle, OMX_CommandStateSet, OMX_StateIdle, 0 );
 874     CHECK_ERROR(omx_error, "OMX_CommandStateSet Idle failed (%x)", omx_error );
 875
 876     /* Allocate omx buffers */
 877     for(i = 0; i < p_sys->ports; i++)
 878     {
 879         OmxPort *p_port = &p_sys->p_ports[i];
 880
 881         for(j = 0; j < p_port->i_buffers; j++)
 882         {
 883 #if 0
 884 #define ALIGN(x,BLOCKLIGN) (((x) + BLOCKLIGN - 1) & ~(BLOCKLIGN - 1))
 885             char *p_buf = malloc(p_port->definition.nBufferSize +
 886                                  p_port->definition.nBufferAlignment);
 887             p_port->pp_buffers[i] = (void *)ALIGN((uintptr_t)p_buf, p_port->definition.nBufferAlignment);
 888 #endif
 889
 890             if(p_port->b_direct)
 891                 omx_error =
 892                     OMX_UseBuffer( p_sys->omx_handle, &p_port->pp_buffers[j],
 893                                    p_port->i_port_index, 0,
 894                                    p_port->definition.nBufferSize, (void*)1);
 895             else
 896                 omx_error =
 897                     OMX_AllocateBuffer( p_sys->omx_handle, &p_port->pp_buffers[j],
 898                                         p_port->i_port_index, 0,
 899                                         p_port->definition.nBufferSize);
 900
 901             if(omx_error != OMX_ErrorNone) break;
 902             OMX_FIFO_PUT(&p_port->fifo, p_port->pp_buffers[j]);
 903         }
 904         p_port->i_buffers = j;
 905         CHECK_ERROR(omx_error, "OMX_UseBuffer failed (%x, %i, %i)",
 906                     omx_error, (int)p_port->i_port_index, j );
 907     }
 908
 909     omx_error = WaitForSpecificOmxEvent(&p_sys->event_queue, OMX_EventCmdComplete, 0, 0, 0);
 910     CHECK_ERROR(omx_error, "Wait for Idle failed (%x)", omx_error );
 911
 912     omx_error = OMX_SendCommand( p_sys->omx_handle, OMX_CommandStateSet,
 913                                  OMX_StateExecuting, 0);
 914     CHECK_ERROR(omx_error, "OMX_CommandStateSet Executing failed (%x)", omx_error );
 915     omx_error = WaitForSpecificOmxEvent(&p_sys->event_queue, OMX_EventCmdComplete, 0, 0, 0);
 916     CHECK_ERROR(omx_error, "Wait for Executing failed (%x)", omx_error );
 917
 918     /* Send codec configuration data */
 919     if( p_dec->fmt_in.i_extra )
 920     {
 921         OMX_FIFO_GET(&p_sys->in.fifo, p_header);
 922         p_header->nFilledLen = p_dec->fmt_in.i_extra;
 923
 924         /* Convert H.264 NAL format to annex b */
 925         if( p_sys->i_nal_size_length && !p_sys->in.b_direct )
 926         {
 927             p_header->nFilledLen = 0;
 928             convert_sps_pps( p_dec, p_dec->fmt_in.p_extra, p_dec->fmt_in.i_extra,
 929                              p_header->pBuffer, p_header->nAllocLen,
 930                              (uint32_t*) &p_header->nFilledLen, NULL );
 931         }
 932         else if(p_sys->in.b_direct)
 933         {
 934             p_header->pOutputPortPrivate = p_header->pBuffer;
 935             p_header->pBuffer = p_dec->fmt_in.p_extra;
 936         }
 937         else if (p_dec->fmt_in.i_codec == VLC_CODEC_WMV3 &&
 938                  p_dec->fmt_in.i_extra >= 4 &&
 939                  p_header->nAllocLen >= 36)
 940         {
 941             int profile;
 942             // According to OMX IL 1.2.0 spec (4.3.33.2), the codec config
 943             // data for VC-1 Main/Simple (aka WMV3) is according to table 265
 944             // in the VC-1 spec. Most of the fields are just set with placeholders
 945             // (like framerate, hrd_buffer/rate).
 946             static const uint8_t wmv3seq[] = {
 947                 0xff, 0xff, 0xff, 0xc5, // numframes=ffffff, marker byte
 948                 0x04, 0x00, 0x00, 0x00, // marker byte
 949                 0x00, 0x00, 0x00, 0x00, // struct C, almost equal to p_extra
 950                 0x00, 0x00, 0x00, 0x00, // struct A, vert size
 951                 0x00, 0x00, 0x00, 0x00, // struct A, horiz size
 952                 0x0c, 0x00, 0x00, 0x00, // marker byte
 953                 0xff, 0xff, 0x00, 0x80, // struct B, level=4, cbr=0, hrd_buffer=ffff
 954                 0xff, 0xff, 0x00, 0x00, // struct B, hrd_rate=ffff
 955                 0xff, 0xff, 0xff, 0xff, // struct B, framerate=ffffffff
 956             };
 957             p_header->nFilledLen = sizeof(wmv3seq);
 958             memcpy(p_header->pBuffer, wmv3seq, p_header->nFilledLen);
 959             // Struct C - almost equal to the extradata
 960             memcpy(&p_header->pBuffer[8], p_dec->fmt_in.p_extra, 4);
 961             // Expand profile from the highest 2 bits to the highest 4 bits
 962             profile = p_header->pBuffer[8] >> 6;
 963             p_header->pBuffer[8] = (p_header->pBuffer[8] & 0x0f) | (profile << 4);
 964             // Fill in the height/width for struct A
 965             SetDWLE(&p_header->pBuffer[12], p_dec->fmt_in.video.i_height);
 966             SetDWLE(&p_header->pBuffer[16], p_dec->fmt_in.video.i_width);
 967         }
 968         else
 969         {
 970             if(p_header->nFilledLen > p_header->nAllocLen)
 971             {
 972                 msg_Dbg(p_dec, "buffer too small (%i,%i)", (int)p_header->nFilledLen,
 973                         (int)p_header->nAllocLen);
 974                 p_header->nFilledLen = p_header->nAllocLen;
 975             }
 976             memcpy(p_header->pBuffer, p_dec->fmt_in.p_extra, p_header->nFilledLen);
 977         }
 978
 979         p_header->nOffset = 0;
 980         p_header->nFlags = OMX_BUFFERFLAG_CODECCONFIG | OMX_BUFFERFLAG_ENDOFFRAME;
 981         msg_Dbg(p_dec, "sending codec config data %p, %p, %i", p_header,
 982                 p_header->pBuffer, (int)p_header->nFilledLen);
 983         OMX_EmptyThisBuffer(p_sys->omx_handle, p_header);
 984     }
 985
 986     /* Get back output port definition */
 987     omx_error = GetPortDefinition(p_dec, &p_sys->out, p_sys->out.p_fmt);
 988     if(omx_error != OMX_ErrorNone) goto error;
 989
 990     PrintOmx(p_dec, p_sys->omx_handle, p_dec->p_sys->in.i_port_index);
 991     PrintOmx(p_dec, p_sys->omx_handle, p_dec->p_sys->out.i_port_index);
 992
 993     if(p_sys->b_error) goto error;
 994
 995     p_dec->b_need_packetized = true;
 996     if (!strcmp(p_sys->psz_component, "OMX.TI.DUCATI1.VIDEO.DECODER"))
 997         p_sys->b_use_pts = 1;
 998
 999     if (!strcmp(p_sys->psz_component, "OMX.STM.Video.Decoder"))
1000         p_sys->b_use_pts = 1;
1001
1002     if (p_sys->b_use_pts)
1003         msg_Dbg( p_dec, "using pts timestamp mode for %s", p_sys->psz_component);
1004
1005     return VLC_SUCCESS;
1006
1007  error:
1008     CloseGeneric(p_this);
1009     return VLC_EGENERIC;
1010 }
1011
1012 /*****************************************************************************
1013  * PortReconfigure
1014  *****************************************************************************/
1015 static OMX_ERRORTYPE PortReconfigure(decoder_t *p_dec, OmxPort *p_port)
1016 {
1017     decoder_sys_t *p_sys = p_dec->p_sys;
1018     OMX_PARAM_PORTDEFINITIONTYPE definition;
1019     OMX_BUFFERHEADERTYPE *p_buffer;
1020     OMX_ERRORTYPE omx_error;
1021     unsigned int i;
1022
1023     /* Sanity checking */
1024     OMX_INIT_STRUCTURE(definition);
1025     definition.nPortIndex = p_port->i_port_index;
1026     omx_error = OMX_GetParameter(p_dec->p_sys->omx_handle, OMX_IndexParamPortDefinition,
1027                                  &definition);
1028     if(omx_error != OMX_ErrorNone || (p_dec->fmt_in.i_cat == VIDEO_ES &&
1029        (!definition.format.video.nFrameWidth ||
1030        !definition.format.video.nFrameHeight)) )
1031         return OMX_ErrorUndefined;
1032
1033     omx_error = OMX_SendCommand( p_sys->omx_handle, OMX_CommandPortDisable,
1034                                  p_port->i_port_index, NULL);
1035     CHECK_ERROR(omx_error, "OMX_CommandPortDisable on %i failed (%x)",
1036                 (int)p_port->i_port_index, omx_error );
1037
1038     for(i = 0; i < p_port->i_buffers; i++)
1039     {
1040         OMX_FIFO_GET(&p_port->fifo, p_buffer);
1041         if (p_buffer->nFlags & SENTINEL_FLAG) {
1042             free(p_buffer);
1043             i--;
1044             continue;
1045         }
1046         omx_error = OMX_FreeBuffer( p_sys->omx_handle,
1047                                     p_port->i_port_index, p_buffer );
1048
1049         if(omx_error != OMX_ErrorNone) break;
1050     }
1051     CHECK_ERROR(omx_error, "OMX_FreeBuffer failed (%x, %i, %i)",
1052                 omx_error, (int)p_port->i_port_index, i );
1053
1054     omx_error = WaitForSpecificOmxEvent(&p_sys->event_queue, OMX_EventCmdComplete, 0, 0, 0);
1055     CHECK_ERROR(omx_error, "Wait for PortDisable failed (%x)", omx_error );
1056
1057     /* Get the new port definition */
1058     omx_error = GetPortDefinition(p_dec, &p_sys->out, p_sys->out.p_fmt);
1059     if(omx_error != OMX_ErrorNone) goto error;
1060
1061     if( p_dec->fmt_in.i_cat != AUDIO_ES )
1062     {
1063         /* Don't explicitly set the new parameters that we got with
1064          * OMX_GetParameter above when using audio codecs.
1065          * That struct hasn't been changed since, so there should be
1066          * no need to set it here, unless some codec expects the
1067          * SetParameter call as a trigger event for some part of
1068          * the reconfiguration.
1069          * This fixes using audio decoders on Samsung Galaxy S II,
1070          *
1071          * Only skipping this for audio codecs, to minimize the
1072          * change for current working configurations for video.
1073          */
1074         omx_error = OMX_SetParameter(p_dec->p_sys->omx_handle, OMX_IndexParamPortDefinition,
1075                                      &definition);
1076         CHECK_ERROR(omx_error, "OMX_SetParameter failed (%x : %s)",
1077                     omx_error, ErrorToString(omx_error));
1078     }
1079
1080     omx_error = OMX_SendCommand( p_sys->omx_handle, OMX_CommandPortEnable,
1081                                  p_port->i_port_index, NULL);
1082     CHECK_ERROR(omx_error, "OMX_CommandPortEnable on %i failed (%x)",
1083                 (int)p_port->i_port_index, omx_error );
1084
1085     if (p_port->definition.nBufferCountActual > p_port->i_buffers) {
1086         free(p_port->pp_buffers);
1087         p_port->pp_buffers = malloc(p_port->definition.nBufferCountActual * sizeof(OMX_BUFFERHEADERTYPE*));
1088         if(!p_port->pp_buffers)
1089         {
1090             omx_error = OMX_ErrorInsufficientResources;
1091             CHECK_ERROR(omx_error, "memory allocation failed");
1092         }
1093     }
1094     p_port->i_buffers = p_port->definition.nBufferCountActual;
1095     for(i = 0; i < p_port->i_buffers; i++)
1096     {
1097         if(p_port->b_direct)
1098             omx_error =
1099                 OMX_UseBuffer( p_sys->omx_handle, &p_port->pp_buffers[i],
1100                                p_port->i_port_index, 0,
1101                                p_port->definition.nBufferSize, (void*)1);
1102         else
1103             omx_error =
1104                 OMX_AllocateBuffer( p_sys->omx_handle, &p_port->pp_buffers[i],
1105                                     p_port->i_port_index, 0,
1106                                     p_port->definition.nBufferSize);
1107
1108         if(omx_error != OMX_ErrorNone) break;
1109         OMX_FIFO_PUT(&p_port->fifo, p_port->pp_buffers[i]);
1110     }
1111     p_port->i_buffers = i;
1112     CHECK_ERROR(omx_error, "OMX_UseBuffer failed (%x, %i, %i)",
1113                 omx_error, (int)p_port->i_port_index, i );
1114
1115     omx_error = WaitForSpecificOmxEvent(&p_sys->event_queue, OMX_EventCmdComplete, 0, 0, 0);
1116     CHECK_ERROR(omx_error, "Wait for PortEnable failed (%x)", omx_error );
1117
1118     PrintOmx(p_dec, p_sys->omx_handle, p_dec->p_sys->in.i_port_index);
1119     PrintOmx(p_dec, p_sys->omx_handle, p_dec->p_sys->out.i_port_index);
1120
1121  error:
1122     return omx_error;
1123 }
1124
1125 /*****************************************************************************
1126  * DecodeVideo: Called to decode one frame
1127  *****************************************************************************/
1128 static picture_t *DecodeVideo( decoder_t *p_dec, block_t **pp_block )
1129 {
1130     decoder_sys_t *p_sys = p_dec->p_sys;
1131     picture_t *p_pic = NULL, *p_next_pic;
1132     OMX_ERRORTYPE omx_error;
1133     unsigned int i;
1134
1135     OMX_BUFFERHEADERTYPE *p_header;
1136     block_t *p_block;
1137
1138     if( !pp_block || !*pp_block )
1139         return NULL;
1140
1141     p_block = *pp_block;
1142
1143     /* Check for errors from codec */
1144     if(p_sys->b_error)
1145     {
1146         msg_Dbg(p_dec, "error during decoding");
1147         block_Release( p_block );
1148         return 0;
1149     }
1150
1151     if( p_block->i_flags & (BLOCK_FLAG_DISCONTINUITY|BLOCK_FLAG_CORRUPTED) )
1152     {
1153         block_Release( p_block );
1154         if(!p_sys->in.b_flushed)
1155         {
1156             msg_Dbg(p_dec, "flushing");
1157             OMX_SendCommand( p_sys->omx_handle, OMX_CommandFlush,
1158                              p_sys->in.definition.nPortIndex, 0 );
1159         }
1160         p_sys->in.b_flushed = true;
1161         return NULL;
1162     }
1163
1164     /* Take care of decoded frames first */
1165     while(!p_pic)
1166     {
1167         OMX_FIFO_PEEK(&p_sys->out.fifo, p_header);
1168         if(!p_header) break; /* No frame available */
1169
1170         if(p_sys->out.b_update_def)
1171         {
1172             omx_error = GetPortDefinition(p_dec, &p_sys->out, p_sys->out.p_fmt);
1173             p_sys->out.b_update_def = 0;
1174         }
1175
1176         if(p_header->nFilledLen)
1177         {
1178             p_pic = p_header->pAppPrivate;
1179             if(!p_pic)
1180             {
1181                 /* We're not in direct rendering mode.
1182                  * Get a new picture and copy the content */
1183                 p_pic = decoder_NewPicture( p_dec );
1184
1185                 if (p_pic)
1186                     CopyOmxPicture(p_sys->out.definition.format.video.eColorFormat,
1187                                    p_pic, p_sys->out.definition.format.video.nSliceHeight,
1188                                    p_sys->out.i_frame_stride,
1189                                    p_header->pBuffer + p_header->nOffset,
1190                                    p_sys->out.i_frame_stride_chroma_div);
1191             }
1192
1193             if (p_pic)
1194                 p_pic->date = FromOmxTicks(p_header->nTimeStamp);
1195             p_header->nFilledLen = 0;
1196             p_header->pAppPrivate = 0;
1197         }
1198
1199         /* Get a new picture */
1200         if(p_sys->out.b_direct && !p_header->pAppPrivate)
1201         {
1202             p_next_pic = decoder_NewPicture( p_dec );
1203             if(!p_next_pic) break;
1204
1205             OMX_FIFO_GET(&p_sys->out.fifo, p_header);
1206             p_header->pAppPrivate = p_next_pic;
1207             p_header->pInputPortPrivate = p_header->pBuffer;
1208             p_header->pBuffer = p_next_pic->p[0].p_pixels;
1209         }
1210         else
1211         {
1212             OMX_FIFO_GET(&p_sys->out.fifo, p_header);
1213         }
1214
1215 #ifdef OMXIL_EXTRA_DEBUG
1216         msg_Dbg( p_dec, "FillThisBuffer %p, %p", p_header, p_header->pBuffer );
1217 #endif
1218         OMX_FillThisBuffer(p_sys->omx_handle, p_header);
1219     }
1220
1221     /* Send the input buffer to the component */
1222     OMX_FIFO_GET_TIMEOUT(&p_sys->in.fifo, p_header, 200000);
1223
1224     if (p_header && p_header->nFlags & SENTINEL_FLAG) {
1225         free(p_header);
1226         goto reconfig;
1227     }
1228
1229     if(p_header)
1230     {
1231         p_header->nFilledLen = p_block->i_buffer;
1232         p_header->nOffset = 0;
1233         p_header->nFlags = OMX_BUFFERFLAG_ENDOFFRAME;
1234         if (p_sys->b_use_pts && p_block->i_pts)
1235             p_header->nTimeStamp = ToOmxTicks(p_block->i_pts);
1236         else
1237             p_header->nTimeStamp = ToOmxTicks(p_block->i_dts);
1238
1239         /* In direct mode we pass the input pointer as is.
1240          * Otherwise we memcopy the data */
1241         if(p_sys->in.b_direct)
1242         {
1243             p_header->pOutputPortPrivate = p_header->pBuffer;
1244             p_header->pBuffer = p_block->p_buffer;
1245             p_header->pAppPrivate = p_block;
1246         }
1247         else
1248         {
1249             if(p_header->nFilledLen > p_header->nAllocLen)
1250             {
1251                 msg_Dbg(p_dec, "buffer too small (%i,%i)",
1252                         (int)p_header->nFilledLen, (int)p_header->nAllocLen);
1253                 p_header->nFilledLen = p_header->nAllocLen;
1254             }
1255             memcpy(p_header->pBuffer, p_block->p_buffer, p_header->nFilledLen );
1256             block_Release(p_block);
1257         }
1258
1259         /* Convert H.264 NAL format to annex b. Doesn't do anything if
1260          * i_nal_size_length == 0, which is the case for codecs other
1261          * than H.264 */
1262         convert_h264_to_annexb( p_header->pBuffer, p_header->nFilledLen,
1263                                 p_sys->i_nal_size_length );
1264 #ifdef OMXIL_EXTRA_DEBUG
1265         msg_Dbg( p_dec, "EmptyThisBuffer %p, %p, %i", p_header, p_header->pBuffer,
1266                  (int)p_header->nFilledLen );
1267 #endif
1268         OMX_EmptyThisBuffer(p_sys->omx_handle, p_header);
1269         p_sys->in.b_flushed = false;
1270         *pp_block = NULL; /* Avoid being fed the same packet again */
1271     }
1272
1273 reconfig:
1274     /* Handle the PortSettingsChanged events */
1275     for(i = 0; i < p_sys->ports; i++)
1276     {
1277         OmxPort *p_port = &p_sys->p_ports[i];
1278         if(p_port->b_reconfigure)
1279         {
1280             omx_error = PortReconfigure(p_dec, p_port);
1281             p_port->b_reconfigure = 0;
1282         }
1283         if(p_port->b_update_def)
1284         {
1285             omx_error = GetPortDefinition(p_dec, p_port, p_port->p_fmt);
1286             p_port->b_update_def = 0;
1287         }
1288     }
1289
1290     return p_pic;
1291 }
1292
1293 /*****************************************************************************
1294  * DecodeAudio: Called to decode one frame
1295  *****************************************************************************/
1296 block_t *DecodeAudio ( decoder_t *p_dec, block_t **pp_block )
1297 {
1298     decoder_sys_t *p_sys = p_dec->p_sys;
1299     block_t *p_buffer = NULL;
1300     OMX_BUFFERHEADERTYPE *p_header;
1301     OMX_ERRORTYPE omx_error;
1302     block_t *p_block;
1303     unsigned int i;
1304
1305     if( !pp_block || !*pp_block ) return NULL;
1306
1307     p_block = *pp_block;
1308
1309     /* Check for errors from codec */
1310     if(p_sys->b_error)
1311     {
1312         msg_Dbg(p_dec, "error during decoding");
1313         block_Release( p_block );
1314         return 0;
1315     }
1316
1317     if( p_block->i_flags & (BLOCK_FLAG_DISCONTINUITY|BLOCK_FLAG_CORRUPTED) )
1318     {
1319         block_Release( p_block );
1320         date_Set( &p_sys->end_date, 0 );
1321         if(!p_sys->in.b_flushed)
1322         {
1323             msg_Dbg(p_dec, "flushing");
1324             OMX_SendCommand( p_sys->omx_handle, OMX_CommandFlush,
1325                              p_sys->in.definition.nPortIndex, 0 );
1326         }
1327         p_sys->in.b_flushed = true;
1328         return NULL;
1329     }
1330
1331     if( !date_Get( &p_sys->end_date ) )
1332     {
1333         if( !p_block->i_pts )
1334         {
1335             /* We've just started the stream, wait for the first PTS. */
1336             block_Release( p_block );
1337             return NULL;
1338         }
1339         date_Set( &p_sys->end_date, p_block->i_pts );
1340     }
1341
1342     /* Take care of decoded frames first */
1343     while(!p_buffer)
1344     {
1345         unsigned int i_samples = 0;
1346
1347         OMX_FIFO_PEEK(&p_sys->out.fifo, p_header);
1348         if(!p_header) break; /* No frame available */
1349
1350         if (p_sys->out.p_fmt->audio.i_channels)
1351             i_samples = p_header->nFilledLen / p_sys->out.p_fmt->audio.i_channels / 2;
1352         if(i_samples)
1353         {
1354             p_buffer = decoder_NewAudioBuffer( p_dec, i_samples );
1355             if( !p_buffer ) break; /* No audio buffer available */
1356
1357             memcpy( p_buffer->p_buffer, p_header->pBuffer, p_buffer->i_buffer );
1358             p_header->nFilledLen = 0;
1359
1360             int64_t timestamp = FromOmxTicks(p_header->nTimeStamp);
1361             if( timestamp != 0 &&
1362                 timestamp != date_Get( &p_sys->end_date ) )
1363                 date_Set( &p_sys->end_date, timestamp );
1364
1365             p_buffer->i_pts = date_Get( &p_sys->end_date );
1366             p_buffer->i_length = date_Increment( &p_sys->end_date, i_samples ) -
1367                 p_buffer->i_pts;
1368         }
1369
1370 #ifdef OMXIL_EXTRA_DEBUG
1371         msg_Dbg( p_dec, "FillThisBuffer %p, %p", p_header, p_header->pBuffer );
1372 #endif
1373         OMX_FIFO_GET(&p_sys->out.fifo, p_header);
1374         OMX_FillThisBuffer(p_sys->omx_handle, p_header);
1375     }
1376
1377
1378     /* Send the input buffer to the component */
1379     OMX_FIFO_GET_TIMEOUT(&p_sys->in.fifo, p_header, 200000);
1380
1381     if (p_header && p_header->nFlags & SENTINEL_FLAG) {
1382         free(p_header);
1383         goto reconfig;
1384     }
1385
1386     if(p_header)
1387     {
1388         p_header->nFilledLen = p_block->i_buffer;
1389         p_header->nOffset = 0;
1390         p_header->nFlags = OMX_BUFFERFLAG_ENDOFFRAME;
1391         p_header->nTimeStamp = ToOmxTicks(p_block->i_dts);
1392
1393         /* In direct mode we pass the input pointer as is.
1394          * Otherwise we memcopy the data */
1395         if(p_sys->in.b_direct)
1396         {
1397             p_header->pOutputPortPrivate = p_header->pBuffer;
1398             p_header->pBuffer = p_block->p_buffer;
1399             p_header->pAppPrivate = p_block;
1400         }
1401         else
1402         {
1403             if(p_header->nFilledLen > p_header->nAllocLen)
1404             {
1405                 msg_Dbg(p_dec, "buffer too small (%i,%i)",
1406                         (int)p_header->nFilledLen, (int)p_header->nAllocLen);
1407                 p_header->nFilledLen = p_header->nAllocLen;
1408             }
1409             memcpy(p_header->pBuffer, p_block->p_buffer, p_header->nFilledLen );
1410             block_Release(p_block);
1411         }
1412
1413 #ifdef OMXIL_EXTRA_DEBUG
1414         msg_Dbg( p_dec, "EmptyThisBuffer %p, %p, %i", p_header, p_header->pBuffer,
1415                  (int)p_header->nFilledLen );
1416 #endif
1417         OMX_EmptyThisBuffer(p_sys->omx_handle, p_header);
1418         p_sys->in.b_flushed = false;
1419         *pp_block = NULL; /* Avoid being fed the same packet again */
1420     }
1421
1422 reconfig:
1423     /* Handle the PortSettingsChanged events */
1424     for(i = 0; i < p_sys->ports; i++)
1425     {
1426         OmxPort *p_port = &p_sys->p_ports[i];
1427         if(!p_port->b_reconfigure) continue;
1428         p_port->b_reconfigure = 0;
1429         omx_error = PortReconfigure(p_dec, p_port);
1430     }
1431
1432     return p_buffer;
1433 }
1434
1435 /*****************************************************************************
1436  * EncodeVideo: Called to encode one frame
1437  *****************************************************************************/
1438 static block_t *EncodeVideo( encoder_t *p_enc, picture_t *p_pic )
1439 {
1440     decoder_t *p_dec = ( decoder_t *)p_enc;
1441     decoder_sys_t *p_sys = p_dec->p_sys;
1442     OMX_ERRORTYPE omx_error;
1443     unsigned int i;
1444
1445     OMX_BUFFERHEADERTYPE *p_header;
1446     block_t *p_block = 0;
1447
1448     if( !p_pic ) return NULL;
1449
1450     /* Check for errors from codec */
1451     if(p_sys->b_error)
1452     {
1453         msg_Dbg(p_dec, "error during encoding");
1454         return NULL;
1455     }
1456
1457     /* Send the input buffer to the component */
1458     OMX_FIFO_GET(&p_sys->in.fifo, p_header);
1459     if(p_header)
1460     {
1461         /* In direct mode we pass the input pointer as is.
1462          * Otherwise we memcopy the data */
1463         if(p_sys->in.b_direct)
1464         {
1465             p_header->pOutputPortPrivate = p_header->pBuffer;
1466             p_header->pBuffer = p_pic->p[0].p_pixels;
1467         }
1468         else
1469         {
1470             CopyVlcPicture(p_dec, p_header, p_pic);
1471         }
1472
1473         p_header->nFilledLen = p_sys->in.i_frame_size;
1474         p_header->nOffset = 0;
1475         p_header->nFlags = OMX_BUFFERFLAG_ENDOFFRAME;
1476         p_header->nTimeStamp = ToOmxTicks(p_pic->date);
1477 #ifdef OMXIL_EXTRA_DEBUG
1478         msg_Dbg( p_dec, "EmptyThisBuffer %p, %p, %i", p_header, p_header->pBuffer,
1479                  (int)p_header->nFilledLen );
1480 #endif
1481         OMX_EmptyThisBuffer(p_sys->omx_handle, p_header);
1482         p_sys->in.b_flushed = false;
1483     }
1484
1485     /* Handle the PortSettingsChanged events */
1486     for(i = 0; i < p_sys->ports; i++)
1487     {
1488         OmxPort *p_port = &p_sys->p_ports[i];
1489         if(!p_port->b_reconfigure) continue;
1490         p_port->b_reconfigure = 0;
1491         omx_error = PortReconfigure(p_dec, p_port);
1492     }
1493
1494     /* Wait for the decoded frame */
1495     while(!p_block)
1496     {
1497         OMX_FIFO_GET(&p_sys->out.fifo, p_header);
1498
1499         if(p_header->nFilledLen)
1500         {
1501             if(p_header->nFlags & OMX_BUFFERFLAG_CODECCONFIG)
1502             {
1503                 /* TODO: need to store codec config */
1504                 msg_Dbg(p_dec, "received codec config %i", (int)p_header->nFilledLen);
1505             }
1506
1507             p_block = p_header->pAppPrivate;
1508             if(!p_block)
1509             {
1510                 /* We're not in direct rendering mode.
1511                  * Get a new block and copy the content */
1512                 p_block = block_Alloc( p_header->nFilledLen );
1513                 memcpy(p_block->p_buffer, p_header->pBuffer, p_header->nFilledLen );
1514             }
1515
1516             p_block->i_buffer = p_header->nFilledLen;
1517             p_block->i_pts = p_block->i_dts = FromOmxTicks(p_header->nTimeStamp);
1518             p_header->nFilledLen = 0;
1519             p_header->pAppPrivate = 0;
1520         }
1521
1522 #ifdef OMXIL_EXTRA_DEBUG
1523         msg_Dbg( p_dec, "FillThisBuffer %p, %p", p_header, p_header->pBuffer );
1524 #endif
1525         OMX_FillThisBuffer(p_sys->omx_handle, p_header);
1526     }
1527
1528     msg_Dbg(p_dec, "done");
1529     return p_block;
1530 }
1531
1532 /*****************************************************************************
1533  * CloseGeneric: omxil decoder destruction
1534  *****************************************************************************/
1535 static void CloseGeneric( vlc_object_t *p_this )
1536 {
1537     decoder_t *p_dec = (decoder_t *)p_this;
1538     decoder_sys_t *p_sys = p_dec->p_sys;
1539
1540     if(p_sys->omx_handle) DeinitialiseComponent(p_dec, p_sys->omx_handle);
1541
1542     DeinitOmxCore();
1543
1544     DeinitOmxEventQueue(&p_sys->event_queue);
1545     vlc_mutex_destroy (&p_sys->in.fifo.lock);
1546     vlc_cond_destroy (&p_sys->in.fifo.wait);
1547     vlc_mutex_destroy (&p_sys->out.fifo.lock);
1548     vlc_cond_destroy (&p_sys->out.fifo.wait);
1549
1550     free( p_sys );
1551 }
1552
1553 /*****************************************************************************
1554  * OmxEventHandler:
1555  *****************************************************************************/
1556 static OMX_ERRORTYPE OmxEventHandler( OMX_HANDLETYPE omx_handle,
1557     OMX_PTR app_data, OMX_EVENTTYPE event, OMX_U32 data_1,
1558     OMX_U32 data_2, OMX_PTR event_data )
1559 {
1560     decoder_t *p_dec = (decoder_t *)app_data;
1561     decoder_sys_t *p_sys = p_dec->p_sys;
1562     unsigned int i;
1563     (void)omx_handle;
1564
1565     PrintOmxEvent((vlc_object_t *) p_dec, event, data_1, data_2, event_data);
1566     switch (event)
1567     {
1568     case OMX_EventError:
1569         //p_sys->b_error = true;
1570         break;
1571
1572     case OMX_EventPortSettingsChanged:
1573         if( data_2 == 0 || data_2 == OMX_IndexParamPortDefinition )
1574         {
1575             OMX_BUFFERHEADERTYPE *sentinel;
1576             for(i = 0; i < p_sys->ports; i++)
1577                 if(p_sys->p_ports[i].definition.eDir == OMX_DirOutput)
1578                     p_sys->p_ports[i].b_reconfigure = true;
1579             sentinel = calloc(1, sizeof(*sentinel));
1580             if (sentinel) {
1581                 sentinel->nFlags = SENTINEL_FLAG;
1582                 OMX_FIFO_PUT(&p_sys->in.fifo, sentinel);
1583             }
1584         }
1585         else if( data_2 == OMX_IndexConfigCommonOutputCrop )
1586         {
1587             for(i = 0; i < p_sys->ports; i++)
1588                 if(p_sys->p_ports[i].definition.nPortIndex == data_1)
1589                     p_sys->p_ports[i].b_update_def = true;
1590         }
1591         else
1592         {
1593             msg_Dbg( p_dec, "Unhandled setting change %x", (unsigned int)data_2 );
1594         }
1595         break;
1596
1597     default:
1598         break;
1599     }
1600
1601     PostOmxEvent(&p_sys->event_queue, event, data_1, data_2, event_data);
1602     return OMX_ErrorNone;
1603 }
1604
1605 static OMX_ERRORTYPE OmxEmptyBufferDone( OMX_HANDLETYPE omx_handle,
1606     OMX_PTR app_data, OMX_BUFFERHEADERTYPE *omx_header )
1607 {
1608     decoder_t *p_dec = (decoder_t *)app_data;
1609     decoder_sys_t *p_sys = p_dec->p_sys;
1610     (void)omx_handle;
1611
1612 #ifdef OMXIL_EXTRA_DEBUG
1613     msg_Dbg( p_dec, "OmxEmptyBufferDone %p, %p", omx_header, omx_header->pBuffer );
1614 #endif
1615
1616     if(omx_header->pAppPrivate || omx_header->pOutputPortPrivate)
1617     {
1618         block_t *p_block = (block_t *)omx_header->pAppPrivate;
1619         omx_header->pBuffer = omx_header->pOutputPortPrivate;
1620         if(p_block) block_Release(p_block);
1621         omx_header->pAppPrivate = 0;
1622     }
1623     OMX_FIFO_PUT(&p_sys->in.fifo, omx_header);
1624
1625     return OMX_ErrorNone;
1626 }
1627
1628 static OMX_ERRORTYPE OmxFillBufferDone( OMX_HANDLETYPE omx_handle,
1629     OMX_PTR app_data, OMX_BUFFERHEADERTYPE *omx_header )
1630 {
1631     decoder_t *p_dec = (decoder_t *)app_data;
1632     decoder_sys_t *p_sys = p_dec->p_sys;
1633     (void)omx_handle;
1634
1635 #ifdef OMXIL_EXTRA_DEBUG
1636     msg_Dbg( p_dec, "OmxFillBufferDone %p, %p, %i", omx_header, omx_header->pBuffer,
1637              (int)omx_header->nFilledLen );
1638 #endif
1639
1640     if(omx_header->pInputPortPrivate)
1641     {
1642         omx_header->pBuffer = omx_header->pInputPortPrivate;
1643     }
1644     OMX_FIFO_PUT(&p_sys->out.fifo, omx_header);
1645
1646     return OMX_ErrorNone;
1647 }