]> git.sesse.net Git - vlc/blob - src/playlist/engine.c
Fix media library's input items reference counting
[vlc] / src / playlist / engine.c
1 /*****************************************************************************
2  * engine.c : Run the playlist and handle its control
3  *****************************************************************************
4  * Copyright (C) 1999-2007 the VideoLAN team
5  * $Id$
6  *
7  * Authors: Samuel Hocevar <sam@zoy.org>
8  *          ClĂ©ment Stenac <zorglub@videolan.org>
9  *
10  * This program is free software; you can redistribute it and/or modify
11  * it under the terms of the GNU General Public License as published by
12  * the Free Software Foundation; either version 2 of the License, or
13  * (at your option) any later version.
14  *
15  * This program is distributed in the hope that it will be useful,
16  * but WITHOUT ANY WARRANTY; without even the implied warranty of
17  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
18  * GNU General Public License for more details.
19  *
20  * You should have received a copy of the GNU General Public License
21  * along with this program; if not, write to the Free Software
22  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
23  *****************************************************************************/
24
25 #ifdef HAVE_CONFIG_H
26 # include "config.h"
27 #endif
28
29 #include <vlc/vlc.h>
30 #include <vlc_vout.h>
31 #include <vlc_sout.h>
32 #include <vlc_playlist.h>
33 #include <vlc_interface.h>
34 #include "playlist_internal.h"
35 #include "stream_output/stream_output.h" /* sout_DeleteInstance */
36
37 /*****************************************************************************
38  * Local prototypes
39  *****************************************************************************/
40 static void VariablesInit( playlist_t *p_playlist );
41 static void playlist_Destructor( vlc_object_t * p_this );
42
43 static int RandomCallback( vlc_object_t *p_this, char const *psz_cmd,
44                            vlc_value_t oldval, vlc_value_t newval, void *a )
45 {
46     (void)psz_cmd; (void)oldval; (void)newval; (void)a;
47
48     ((playlist_t*)p_this)->b_reset_currently_playing = VLC_TRUE;
49     playlist_Signal( ((playlist_t*)p_this) );
50     return VLC_SUCCESS;
51 }
52
53 /**
54  * Create playlist
55  *
56  * Create a playlist structure.
57  * \param p_parent the vlc object that is to be the parent of this playlist
58  * \return a pointer to the created playlist, or NULL on error
59  */
60 playlist_t * playlist_Create( vlc_object_t *p_parent )
61 {
62     static const char playlist_name[] = "playlist";
63     playlist_t *p_playlist;
64     vlc_bool_t b_save;
65     int i_tree;
66
67     /* Allocate structure */
68     p_playlist = vlc_custom_create( p_parent, sizeof( *p_playlist ),
69                                     VLC_OBJECT_PLAYLIST, playlist_name );
70     if( !p_playlist )
71     {
72         msg_Err( p_parent, "out of memory" );
73         return NULL;
74     }
75
76     TAB_INIT( p_playlist->i_sds, p_playlist->pp_sds );
77
78     p_parent->p_libvlc->p_playlist = p_playlist;
79
80     VariablesInit( p_playlist );
81
82     /* Initialise data structures */
83     vlc_mutex_init( p_playlist, &p_playlist->gc_lock );
84     p_playlist->i_last_playlist_id = 0;
85     p_playlist->p_input = NULL;
86
87     p_playlist->gc_date = 0;
88     p_playlist->b_cant_sleep = VLC_FALSE;
89
90     ARRAY_INIT( p_playlist->items );
91     ARRAY_INIT( p_playlist->all_items );
92     ARRAY_INIT( p_playlist->current );
93
94     p_playlist->i_current_index = 0;
95     p_playlist->b_reset_currently_playing = VLC_TRUE;
96     p_playlist->last_rebuild_date = 0;
97
98     i_tree = var_CreateGetBool( p_playlist, "playlist-tree" );
99     p_playlist->b_always_tree = (i_tree == 1);
100     p_playlist->b_never_tree = (i_tree == 2);
101
102     p_playlist->b_doing_ml = VLC_FALSE;
103
104     p_playlist->b_auto_preparse =
105                         var_CreateGetBool( p_playlist, "auto-preparse" ) ;
106
107     p_playlist->p_root_category = playlist_NodeCreate( p_playlist, NULL, NULL,
108                                     0, NULL );
109     p_playlist->p_root_onelevel = playlist_NodeCreate( p_playlist, NULL, NULL,
110                                     0, p_playlist->p_root_category->p_input );
111
112     if( !p_playlist->p_root_category || !p_playlist->p_root_onelevel )
113         return NULL;
114
115     /* Create playlist and media library */
116     playlist_NodesPairCreate( p_playlist, _( "Playlist" ),
117                             &p_playlist->p_local_category,
118                             &p_playlist->p_local_onelevel, VLC_FALSE );
119
120     p_playlist->p_local_category->i_flags |= PLAYLIST_RO_FLAG;
121     p_playlist->p_local_onelevel->i_flags |= PLAYLIST_RO_FLAG;
122
123     if( !p_playlist->p_local_category || !p_playlist->p_local_onelevel ||
124         !p_playlist->p_local_category->p_input ||
125         !p_playlist->p_local_onelevel->p_input )
126         return NULL;
127
128     if( config_GetInt( p_playlist, "media-library") )
129     {
130         playlist_NodesPairCreate( p_playlist, _( "Media Library" ),
131                             &p_playlist->p_ml_category,
132                             &p_playlist->p_ml_onelevel, VLC_FALSE );
133
134         if(!p_playlist->p_ml_category || !p_playlist->p_ml_onelevel)
135             return NULL;
136
137         p_playlist->p_ml_category->i_flags |= PLAYLIST_RO_FLAG;
138         p_playlist->p_ml_onelevel->i_flags |= PLAYLIST_RO_FLAG;
139     }
140     else
141     {
142         p_playlist->p_ml_category = p_playlist->p_ml_onelevel = NULL;
143     }
144
145     /* Initial status */
146     p_playlist->status.p_item = NULL;
147     p_playlist->status.p_node = p_playlist->p_local_onelevel;
148     p_playlist->request.b_request = VLC_FALSE;
149     p_playlist->status.i_status = PLAYLIST_STOPPED;
150
151     p_playlist->i_sort = SORT_ID;
152     p_playlist->i_order = ORDER_NORMAL;
153
154
155     b_save = p_playlist->b_auto_preparse;
156     p_playlist->b_auto_preparse = VLC_FALSE;
157     playlist_MLLoad( p_playlist );
158     p_playlist->b_auto_preparse = VLC_TRUE;
159
160     vlc_object_set_destructor( p_playlist, playlist_Destructor );
161
162     return p_playlist;
163 }
164
165 /**
166  * Destroy playlist
167  *
168  * Destroy a playlist structure.
169  * \param p_playlist the playlist object
170  * \return nothing
171  */
172 void playlist_Destroy( playlist_t *p_playlist )
173 {
174     /* XXX: should go in the playlist destructor */
175     var_Destroy( p_playlist, "intf-change" );
176     var_Destroy( p_playlist, "item-change" );
177     var_Destroy( p_playlist, "playlist-current" );
178     var_Destroy( p_playlist, "intf-popupmenu" );
179     var_Destroy( p_playlist, "intf-show" );
180     var_Destroy( p_playlist, "play-and-stop" );
181     var_Destroy( p_playlist, "play-and-exit" );
182     var_Destroy( p_playlist, "random" );
183     var_Destroy( p_playlist, "repeat" );
184     var_Destroy( p_playlist, "loop" );
185     var_Destroy( p_playlist, "activity" );
186
187     vlc_object_release( p_playlist );
188 }
189
190 static void playlist_Destructor( vlc_object_t * p_this )
191 {
192     playlist_t * p_playlist = (playlist_t *)p_this;
193
194     // Kill preparser
195     if( p_playlist->p_preparse )
196     {
197         vlc_object_release( p_playlist->p_preparse );
198     }
199
200     // Kill meta fetcher
201     if( p_playlist->p_fetcher )
202     {
203         vlc_object_release( p_playlist->p_fetcher );
204     }
205 }
206
207 /* Destroy remaining objects */
208 static void ObjectGarbageCollector( playlist_t *p_playlist, vlc_bool_t b_force )
209 {
210     vlc_object_t *p_obj;
211
212     if( !b_force )
213     {
214         if( mdate() - p_playlist->gc_date < 1000000 )
215         {
216             p_playlist->b_cant_sleep = VLC_TRUE;
217             return;
218         }
219         else if( p_playlist->gc_date == 0 )
220             return;
221     }
222
223     vlc_mutex_lock( &p_playlist->gc_lock );
224     while( ( p_obj = vlc_object_find( p_playlist->p_libvlc, VLC_OBJECT_VOUT,
225                                                   FIND_CHILD ) ) )
226     {
227         if( p_obj->p_parent != VLC_OBJECT(p_playlist->p_libvlc) )
228         {
229             vlc_object_release( p_obj );
230             break;
231         }
232         msg_Dbg( p_playlist, "garbage collector destroying 1 vout" );
233         vlc_object_detach( p_obj );
234         vlc_object_release( p_obj );
235         vout_Destroy( (vout_thread_t *)p_obj );
236     }
237     while( ( p_obj = vlc_object_find( p_playlist, VLC_OBJECT_SOUT,
238                                                   FIND_CHILD ) ) )
239     {
240         if( p_obj->p_parent != VLC_OBJECT(p_playlist) )
241         {
242             vlc_object_release( p_obj );
243             break;
244         }
245         msg_Dbg( p_playlist, "garbage collector destroying 1 sout" );
246         vlc_object_detach( p_obj );
247         vlc_object_release( p_obj );
248         sout_DeleteInstance( (sout_instance_t*)p_obj );
249     }
250     p_playlist->b_cant_sleep = VLC_FALSE;
251     vlc_mutex_unlock( &p_playlist->gc_lock );
252 }
253
254 /**
255  * Main loop
256  *
257  * Main loop for the playlist
258  * \param p_playlist the playlist object
259  * \return nothing
260  */
261 void playlist_MainLoop( playlist_t *p_playlist )
262 {
263     playlist_item_t *p_item = NULL;
264     vlc_bool_t b_playexit = var_GetBool( p_playlist, "play-and-exit" );
265     PL_LOCK;
266
267     if( p_playlist->b_reset_currently_playing &&
268         mdate() - p_playlist->last_rebuild_date > 30000 ) // 30 ms
269     {
270         ResetCurrentlyPlaying( p_playlist, var_GetBool( p_playlist, "random" ),
271                              p_playlist->status.p_item );
272         p_playlist->last_rebuild_date = mdate();
273     }
274
275 check_input:
276     /* If there is an input, check that it doesn't need to die. */
277     if( p_playlist->p_input )
278     {
279         if( p_playlist->request.b_request && !p_playlist->p_input->b_die )
280         {
281             PL_DEBUG( "incoming request - stopping current input" );
282             input_StopThread( p_playlist->p_input );
283         }
284
285         /* This input is dead. Remove it ! */
286         if( p_playlist->p_input->b_dead )
287         {
288             int i_activity;
289             input_thread_t *p_input;
290             PL_DEBUG( "dead input" );
291
292             p_input = p_playlist->p_input;
293             p_playlist->p_input = NULL;
294
295             /* Release the playlist lock, because we may get stuck
296              * in vlc_object_release() for some time. */
297             PL_UNLOCK;
298
299             /* Destroy input */
300             vlc_object_release( p_input );
301
302             PL_LOCK;
303
304             p_playlist->gc_date = mdate();
305             p_playlist->b_cant_sleep = VLC_TRUE;
306
307             if( p_playlist->status.p_item->i_flags
308                 & PLAYLIST_REMOVE_FLAG )
309             {
310                  PL_DEBUG( "%s was marked for deletion, deleting",
311                                  PLI_NAME( p_playlist->status.p_item  ) );
312                  playlist_ItemDelete( p_playlist->status.p_item );
313                  if( p_playlist->request.p_item == p_playlist->status.p_item )
314                      p_playlist->request.p_item = NULL;
315                  p_playlist->status.p_item = NULL;
316             }
317
318             i_activity= var_GetInteger( p_playlist, "activity" );
319             var_SetInteger( p_playlist, "activity", i_activity -
320                             DEFAULT_INPUT_ACTIVITY );
321             goto check_input;
322         }
323         /* This input is dying, let it do */
324         else if( p_playlist->p_input->b_die )
325         {
326             PL_DEBUG( "dying input" );
327             PL_UNLOCK;
328             msleep( INTF_IDLE_SLEEP );
329             PL_LOCK;
330             goto check_input;
331         }
332         /* This input has finished, ask it to die ! */
333         else if( p_playlist->p_input->b_error
334                   || p_playlist->p_input->b_eof )
335         {
336             PL_DEBUG( "finished input" );
337             input_StopThread( p_playlist->p_input );
338             /* No need to wait here, we'll wait in the p_input->b_die case */
339             goto check_input;
340         }
341         else if( p_playlist->p_input->i_state != INIT_S )
342         {
343             PL_UNLOCK;
344             ObjectGarbageCollector( p_playlist, VLC_FALSE );
345             PL_LOCK;
346         }
347     }
348     else
349     {
350         /* No input. Several cases
351          *  - No request, running status -> start new item
352          *  - No request, stopped status -> collect garbage
353          *  - Request, running requested -> start new item
354          *  - Request, stopped requested -> collect garbage
355         */
356         if( p_playlist->request.i_status != PLAYLIST_STOPPED )
357         {
358             msg_Dbg( p_playlist, "starting new item" );
359             p_item = playlist_NextItem( p_playlist );
360
361             if( p_item == NULL )
362             {
363                 msg_Dbg( p_playlist, "nothing to play" );
364                 p_playlist->status.i_status = PLAYLIST_STOPPED;
365                 PL_UNLOCK;
366
367                 if( b_playexit == VLC_TRUE )
368                 {
369                     msg_Info( p_playlist, "end of playlist, exiting" );
370                     vlc_object_kill( p_playlist->p_libvlc );
371                 }
372                 ObjectGarbageCollector( p_playlist, VLC_TRUE );
373                 return;
374              }
375              playlist_PlayItem( p_playlist, p_item );
376          }
377          else
378          {
379             const vlc_bool_t b_gc_forced = p_playlist->status.i_status != PLAYLIST_STOPPED;
380
381             p_playlist->status.i_status = PLAYLIST_STOPPED;
382             if( p_playlist->status.p_item &&
383                 p_playlist->status.p_item->i_flags & PLAYLIST_REMOVE_FLAG )
384             {
385                 PL_DEBUG( "deleting item marked for deletion" );
386                 playlist_ItemDelete( p_playlist->status.p_item );
387                 p_playlist->status.p_item = NULL;
388             }
389
390             /* Collect garbage */
391             PL_UNLOCK;
392             ObjectGarbageCollector( p_playlist, b_gc_forced );
393             PL_LOCK;
394         }
395     }
396     PL_UNLOCK;
397 }
398
399 static void ML_Decref( playlist_item_t *p_node )
400 {
401     vlc_gc_decref( p_node->p_input );
402
403     int i;
404     if( p_node->i_children > 0 )
405         for( i = 0 ; i < p_node->i_children ; i++ )
406             ML_Decref( p_node->pp_children[i] );
407 }
408
409 /**
410  * Last loop
411  *
412  * The playlist is dying so do the last loop
413  * \param p_playlist the playlist object
414  * \return nothing
415 */
416 void playlist_LastLoop( playlist_t *p_playlist )
417 {
418     vlc_object_t *p_obj;
419
420     /* If there is an input, kill it */
421     while( 1 )
422     {
423         PL_LOCK;
424         if( p_playlist->p_input == NULL )
425         {
426             PL_UNLOCK;
427             break;
428         }
429
430         if( p_playlist->p_input->b_dead )
431         {
432             input_thread_t *p_input;
433
434             /* Unlink current input */
435             p_input = p_playlist->p_input;
436             p_playlist->p_input = NULL;
437             PL_UNLOCK;
438
439             /* Destroy input */
440             vlc_object_release( p_input );
441             continue;
442         }
443         else if( p_playlist->p_input->b_die )
444         {
445             /* This input is dying, leave it alone */
446             ;
447         }
448         else if( p_playlist->p_input->b_error || p_playlist->p_input->b_eof )
449         {
450             input_StopThread( p_playlist->p_input );
451             PL_UNLOCK;
452             continue;
453         }
454         else
455         {
456             p_playlist->p_input->b_eof = 1;
457         }
458         PL_UNLOCK;
459
460         msleep( INTF_IDLE_SLEEP );
461     }
462
463     /* close all remaining sout */
464     while( ( p_obj = vlc_object_find( p_playlist,
465                                       VLC_OBJECT_SOUT, FIND_CHILD ) ) )
466     {
467         vlc_object_detach( p_obj );
468         vlc_object_release( p_obj );
469         sout_DeleteInstance( (sout_instance_t*)p_obj );
470     }
471
472     /* close all remaining vout */
473     while( ( p_obj = vlc_object_find( p_playlist,
474                                       VLC_OBJECT_VOUT, FIND_CHILD ) ) )
475     {
476         vlc_object_detach( p_obj );
477         vlc_object_release( p_obj );
478         vout_Destroy( (vout_thread_t *)p_obj );
479     }
480
481     while( p_playlist->i_sds )
482     {
483         playlist_ServicesDiscoveryRemove( p_playlist,
484                                           p_playlist->pp_sds[0]->p_sd->psz_module );
485     }
486
487     playlist_MLDump( p_playlist );
488     /* We don't need the media library anymore */
489     ML_Decref( p_playlist->p_ml_category );
490
491     PL_LOCK;
492     FOREACH_ARRAY( playlist_item_t *p_del, p_playlist->all_items )
493         free( p_del->pp_children );
494         vlc_gc_decref( p_del->p_input );
495         free( p_del );
496     FOREACH_END();
497     ARRAY_RESET( p_playlist->all_items );
498
499     ARRAY_RESET( p_playlist->items );
500     ARRAY_RESET( p_playlist->current );
501
502     PL_UNLOCK;
503 }
504
505 /**
506  * Preparse loop
507  *
508  * Main loop for preparser queue
509  * \param p_obj items to preparse
510  * \return nothing
511  */
512 void playlist_PreparseLoop( playlist_preparse_t *p_obj )
513 {
514     playlist_t *p_playlist = (playlist_t *)p_obj->p_parent;
515     input_item_t *p_current;
516     int i_activity;
517     uint32_t i_m, i_o;
518
519     while( !p_playlist->b_die )
520     {
521         vlc_object_lock( p_obj );
522         while( p_obj->i_waiting == 0 )
523         {
524             if( vlc_object_wait( p_obj ) || p_playlist->b_die )
525             {
526                 vlc_object_unlock( p_obj );
527                 return;
528             }
529         }
530
531         p_current = p_obj->pp_waiting[0];
532         REMOVE_ELEM( p_obj->pp_waiting, p_obj->i_waiting, 0 );
533         vlc_object_unlock( p_obj );
534
535         PL_LOCK;
536         if( p_current )
537         {
538             if( p_current->i_type == ITEM_TYPE_FILE )
539             {
540                 stats_TimerStart( p_playlist, "Preparse run",
541                                   STATS_TIMER_PREPARSE );
542                 /* Do not preparse if it is already done (like by playing it) */
543                 if( !input_item_IsPreparsed( p_current ) )
544                 {
545                     PL_UNLOCK;
546                     input_Preparse( p_playlist, p_current );
547                     PL_LOCK;
548                 }
549                 stats_TimerStop( p_playlist, STATS_TIMER_PREPARSE );
550                 PL_UNLOCK;
551                 input_item_SetPreparsed( p_current, VLC_TRUE );
552                 var_SetInteger( p_playlist, "item-change", p_current->i_id );
553                 PL_LOCK;
554             }
555             /* If we haven't retrieved enough meta, add to secondary queue
556              * which will run the "meta fetchers".
557              * This only checks for meta, not for art
558              * \todo don't do this for things we won't get meta for, like vids
559              */
560             char *psz_arturl = input_item_GetArtURL( p_current );
561             char *psz_name = input_item_GetName( p_current );
562             if( !input_MetaSatisfied( p_playlist, p_current, &i_m, &i_o ) )
563             {
564                 preparse_item_t p;
565                 PL_DEBUG( "need to fetch meta for %s", p_current->psz_name );
566                 p.p_item = p_current;
567                 p.b_fetch_art = VLC_FALSE;
568                 vlc_object_lock( p_playlist->p_fetcher );
569                 INSERT_ELEM( p_playlist->p_fetcher->p_waiting,
570                              p_playlist->p_fetcher->i_waiting,
571                              p_playlist->p_fetcher->i_waiting, p);
572                 vlc_object_signal_unlocked( p_playlist->p_fetcher );
573                 vlc_object_unlock( p_playlist->p_fetcher );
574             }
575             /* We already have all needed meta, but we need art right now */
576             else if( p_playlist->p_fetcher->i_art_policy == ALBUM_ART_ALL &&
577                         ( !psz_arturl || strncmp( psz_arturl, "file://", 7 ) ) )
578             {
579                 preparse_item_t p;
580                 PL_DEBUG("meta ok for %s, need to fetch art", psz_name );
581                 p.p_item = p_current;
582                 p.b_fetch_art = VLC_TRUE;
583                 vlc_object_lock( p_playlist->p_fetcher );
584                 INSERT_ELEM( p_playlist->p_fetcher->p_waiting,
585                              p_playlist->p_fetcher->i_waiting,
586                              p_playlist->p_fetcher->i_waiting, p);
587                 vlc_object_signal_unlocked( p_playlist->p_fetcher );
588                 vlc_object_unlock( p_playlist->p_fetcher );
589             }
590             else
591             {
592                 PL_DEBUG( "no fetch required for %s (art currently %s)",
593                           psz_name, psz_arturl );
594                 vlc_gc_decref( p_current );
595             }
596             free( psz_name );
597             free( psz_arturl );
598             PL_UNLOCK;
599         }
600         else
601             PL_UNLOCK;
602
603         vlc_object_lock( p_obj );
604         i_activity = var_GetInteger( p_playlist, "activity" );
605         if( i_activity < 0 ) i_activity = 0;
606         vlc_object_unlock( p_obj );
607         /* Sleep at least 1ms */
608         msleep( (i_activity+1) * 1000 );
609     }
610 }
611
612 /**
613  * Fetcher loop
614  *
615  * Main loop for secondary preparser queue
616  * \param p_obj items to preparse
617  * \return nothing
618  */
619 void playlist_FetcherLoop( playlist_fetcher_t *p_obj )
620 {
621     playlist_t *p_playlist = (playlist_t *)p_obj->p_parent;
622     vlc_bool_t b_fetch_art;
623     input_item_t *p_item;
624     int i_activity;
625
626     while( !p_playlist->b_die )
627     {
628         vlc_mutex_lock( &p_obj->object_lock );
629         while( p_obj->i_waiting == 0 )
630         {
631             vlc_cond_wait( &p_obj->object_wait, &p_obj->object_lock );
632             if( p_playlist->b_die )
633             {
634                 vlc_mutex_unlock( &p_obj->object_lock );
635                 return;
636             }
637         }
638
639         b_fetch_art = p_obj->p_waiting->b_fetch_art;
640         p_item = p_obj->p_waiting->p_item;
641         REMOVE_ELEM( p_obj->p_waiting, p_obj->i_waiting, 0 );
642         vlc_mutex_unlock( &p_obj->object_lock );
643         if( p_item )
644         {
645             if( !b_fetch_art )
646             {
647                 /* If the user doesn't want us to fetch meta automatically
648                  * abort here. */
649                 if( p_playlist->p_fetcher->b_fetch_meta )
650                 {
651                     input_MetaFetch( p_playlist, p_item );
652                     var_SetInteger( p_playlist, "item-change", p_item->i_id );
653                 }
654
655                 /*  Fetch right now */
656                 if( p_playlist->p_fetcher->i_art_policy == ALBUM_ART_ALL )
657                 {
658                     vlc_mutex_lock( &p_obj->object_lock );
659                     preparse_item_t p;
660                     p.p_item = p_item;
661                     p.b_fetch_art = VLC_TRUE;
662                     INSERT_ELEM( p_playlist->p_fetcher->p_waiting,
663                                  p_playlist->p_fetcher->i_waiting,
664                                  0, p );
665                     PL_DEBUG( "meta fetched for %s, get art", p_item->psz_name );
666                     vlc_mutex_unlock( &p_obj->object_lock );
667                     continue;
668                 }
669                 else
670                     vlc_gc_decref( p_item );
671             }
672             else
673             {
674                 int i_ret;
675
676                 /* Check if it is not yet preparsed and if so wait for it (at most 0.5s)
677                  * (This can happen if we fetch art on play)
678                  * FIXME this doesn't work if we need to fetch meta before art ... */
679                 for( i_ret = 0; i_ret < 10 && !input_item_IsPreparsed( p_item ); i_ret++ )
680                 {
681                     vlc_bool_t b_break;
682                     PL_LOCK;
683                     b_break = ( !p_playlist->p_input || input_GetItem(p_playlist->p_input) != p_item  ||
684                                 p_playlist->p_input->b_die || p_playlist->p_input->b_eof || p_playlist->p_input->b_error );
685                     PL_UNLOCK;
686                     if( b_break )
687                         break;
688                     msleep( 50000 );
689                 }
690
691                 i_ret = input_ArtFind( p_playlist, p_item );
692                 if( i_ret == 1 )
693                 {
694                     PL_DEBUG( "downloading art for %s", p_item->psz_name );
695                     if( input_DownloadAndCacheArt( p_playlist, p_item ) )
696                         input_item_SetArtNotFound( p_item, VLC_TRUE );
697                     else {
698                         input_item_SetArtFetched( p_item, VLC_TRUE );
699                         var_SetInteger( p_playlist, "item-change",
700                                         p_item->i_id );
701                     }
702                 }
703                 else if( i_ret == 0 ) /* Was in cache */
704                 {
705                     PL_DEBUG( "found art for %s in cache", p_item->psz_name );
706                     input_item_SetArtFetched( p_item, VLC_TRUE );
707                     var_SetInteger( p_playlist, "item-change", p_item->i_id );
708                 }
709                 else
710                 {
711                     PL_DEBUG( "art not found for %s", p_item->psz_name );
712                     input_item_SetArtNotFound( p_item, VLC_TRUE );
713                 }
714                 vlc_gc_decref( p_item );
715            }
716         }
717         vlc_object_lock( p_obj );
718         i_activity = var_GetInteger( p_playlist, "activity" );
719         if( i_activity < 0 ) i_activity = 0;
720         vlc_object_unlock( p_obj );
721         /* Sleep at least 1ms */
722         msleep( (i_activity+1) * 1000 );
723     }
724 }
725
726 static void VariablesInit( playlist_t *p_playlist )
727 {
728     vlc_value_t val;
729     /* These variables control updates */
730     var_Create( p_playlist, "intf-change", VLC_VAR_BOOL );
731     val.b_bool = VLC_TRUE;
732     var_Set( p_playlist, "intf-change", val );
733
734     var_Create( p_playlist, "item-change", VLC_VAR_INTEGER );
735     val.i_int = -1;
736     var_Set( p_playlist, "item-change", val );
737
738     var_Create( p_playlist, "item-deleted", VLC_VAR_INTEGER );
739     val.i_int = -1;
740     var_Set( p_playlist, "item-deleted", val );
741
742     var_Create( p_playlist, "item-append", VLC_VAR_ADDRESS );
743
744     var_Create( p_playlist, "playlist-current", VLC_VAR_INTEGER );
745     val.i_int = -1;
746     var_Set( p_playlist, "playlist-current", val );
747
748     var_Create( p_playlist, "intf-popupmenu", VLC_VAR_BOOL );
749
750     var_Create( p_playlist, "intf-show", VLC_VAR_BOOL );
751     val.b_bool = VLC_TRUE;
752     var_Set( p_playlist, "intf-show", val );
753
754     var_Create( p_playlist, "activity", VLC_VAR_INTEGER );
755     var_SetInteger( p_playlist, "activity", 0 );
756
757     /* Variables to control playback */
758     var_CreateGetBool( p_playlist, "play-and-stop" );
759     var_CreateGetBool( p_playlist, "play-and-exit" );
760     var_CreateGetBool( p_playlist, "random" );
761     var_CreateGetBool( p_playlist, "repeat" );
762     var_CreateGetBool( p_playlist, "loop" );
763
764     var_AddCallback( p_playlist, "random", RandomCallback, NULL );
765 }