]> git.sesse.net Git - vlc/blob - src/video_output/video_output.c
* src/*: bunch of portability fixes.
[vlc] / src / video_output / video_output.c
1 /*****************************************************************************
2  * video_output.c : video output thread
3  * This module describes the programming interface for video output threads.
4  * It includes functions allowing to open a new thread, send pictures to a
5  * thread, and destroy a previously oppened video output thread.
6  *****************************************************************************
7  * Copyright (C) 2000-2004 VideoLAN
8  * $Id$
9  *
10  * Authors: Vincent Seguin <seguin@via.ecp.fr>
11  *
12  * This program is free software; you can redistribute it and/or modify
13  * it under the terms of the GNU General Public License as published by
14  * the Free Software Foundation; either version 2 of the License, or
15  * (at your option) any later version.
16  *
17  * This program is distributed in the hope that it will be useful,
18  * but WITHOUT ANY WARRANTY; without even the implied warranty of
19  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
20  * GNU General Public License for more details.
21  *
22  * You should have received a copy of the GNU General Public License
23  * along with this program; if not, write to the Free Software
24  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
25  *****************************************************************************/
26
27 /*****************************************************************************
28  * Preamble
29  *****************************************************************************/
30 #include <stdlib.h>                                                /* free() */
31
32 #include <vlc/vlc.h>
33
34 #ifdef HAVE_SYS_TIMES_H
35 #   include <sys/times.h>
36 #endif
37
38 #include "vlc_video.h"
39 #include "video_output.h"
40 #include "vlc_spu.h"
41 #include <vlc/input.h>                 /* for input_thread_t and i_pts_delay */
42
43 #if defined( SYS_DARWIN )
44 #include "darwin_specific.h"
45 #endif
46
47 /*****************************************************************************
48  * Local prototypes
49  *****************************************************************************/
50 static int      InitThread        ( vout_thread_t * );
51 static void     RunThread         ( vout_thread_t * );
52 static void     ErrorThread       ( vout_thread_t * );
53 static void     EndThread         ( vout_thread_t * );
54 static void     DestroyThread     ( vout_thread_t * );
55
56 static void     AspectRatio       ( int, int *, int * );
57 static int      BinaryLog         ( uint32_t );
58 static void     MaskToShift       ( int *, int *, uint32_t );
59 static void     InitWindowSize    ( vout_thread_t *, int *, int * );
60
61 /* Object variables callbacks */
62 static int DeinterlaceCallback( vlc_object_t *, char const *,
63                                 vlc_value_t, vlc_value_t, void * );
64 static int FilterCallback( vlc_object_t *, char const *,
65                            vlc_value_t, vlc_value_t, void * );
66
67 /*****************************************************************************
68  * vout_Request: find a video output thread, create one, or destroy one.
69  *****************************************************************************
70  * This function looks for a video output thread matching the current
71  * properties. If not found, it spawns a new one.
72  *****************************************************************************/
73 vout_thread_t * __vout_Request ( vlc_object_t *p_this, vout_thread_t *p_vout,
74                                  unsigned int i_width, unsigned int i_height,
75                                  vlc_fourcc_t i_chroma, unsigned int i_aspect )
76 {
77     if( !i_width || !i_height || !i_chroma )
78     {
79         /* Reattach video output to input before bailing out */
80         if( p_vout )
81         {
82             vlc_object_t *p_playlist;
83
84             p_playlist = vlc_object_find( p_this, VLC_OBJECT_PLAYLIST,
85                                           FIND_ANYWHERE );
86
87             if( p_playlist )
88             {
89                 spu_Attach( p_vout->p_spu, p_this, VLC_FALSE );
90                 vlc_object_detach( p_vout );
91                 vlc_object_attach( p_vout, p_playlist );
92
93                 vlc_object_release( p_playlist );
94             }
95             else
96             {
97                 msg_Dbg( p_this, "cannot find playlist, destroying vout" );
98                 vlc_object_detach( p_vout );
99                 vout_Destroy( p_vout );
100             }
101         }
102         return NULL;
103     }
104
105     /* If a video output was provided, lock it, otherwise look for one. */
106     if( p_vout )
107     {
108         vlc_object_yield( p_vout );
109     }
110     else
111     {
112         p_vout = vlc_object_find( p_this, VLC_OBJECT_VOUT, FIND_CHILD );
113
114         if( !p_vout )
115         {
116             vlc_object_t *p_playlist;
117
118             p_playlist = vlc_object_find( p_this,
119                                           VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
120             if( p_playlist )
121             {
122                 p_vout = vlc_object_find( p_playlist,
123                                           VLC_OBJECT_VOUT, FIND_CHILD );
124                 /* only first children of p_input for unused vout */
125                 if( p_vout && p_vout->p_parent != p_playlist )
126                 {
127                     vlc_object_release( p_vout );
128                     p_vout = NULL;
129                 }
130                 vlc_object_release( p_playlist );
131             }
132         }
133     }
134
135     /* If we now have a video output, check it has the right properties */
136     if( p_vout )
137     {
138         char *psz_filter_chain;
139
140         /* We don't directly check for the "filter" variable for obvious
141          * performance reasons. */
142         if( p_vout->b_filter_change )
143         {
144             psz_filter_chain = config_GetPsz( p_this, "filter" );
145
146             if( psz_filter_chain && !*psz_filter_chain )
147             {
148                 free( psz_filter_chain );
149                 psz_filter_chain = NULL;
150             }
151             if( p_vout->psz_filter_chain && !*p_vout->psz_filter_chain )
152             {
153                 free( p_vout->psz_filter_chain );
154                 p_vout->psz_filter_chain = NULL;
155             }
156
157             if( ( !psz_filter_chain && !p_vout->psz_filter_chain ) ||
158                 ( psz_filter_chain && p_vout->psz_filter_chain &&
159                   !strcmp( psz_filter_chain, p_vout->psz_filter_chain ) ) )
160             {
161                 p_vout->b_filter_change = VLC_FALSE;
162             }
163
164             if( psz_filter_chain ) free( psz_filter_chain );
165         }
166
167         if( ( p_vout->render.i_width != i_width ) ||
168             ( p_vout->render.i_height != i_height ) ||
169             ( p_vout->render.i_chroma != i_chroma ) ||
170             ( p_vout->render.i_aspect != i_aspect
171                     && !p_vout->b_override_aspect ) ||
172             p_vout->b_filter_change )
173         {
174             /* We are not interested in this format, close this vout */
175             vlc_object_detach( p_vout );
176             vlc_object_release( p_vout );
177             vout_Destroy( p_vout );
178             p_vout = NULL;
179         }
180         else
181         {
182             /* This video output is cool! Hijack it. */
183             vlc_object_detach( p_vout );
184             spu_Attach( p_vout->p_spu, p_this, VLC_TRUE );
185             vlc_object_attach( p_vout, p_this );
186             vlc_object_release( p_vout );
187         }
188     }
189
190     if( !p_vout )
191     {
192         msg_Dbg( p_this, "no usable vout present, spawning one" );
193
194         p_vout = vout_Create( p_this, i_width, i_height, i_chroma, i_aspect );
195     }
196
197     return p_vout;
198 }
199
200 /*****************************************************************************
201  * vout_Create: creates a new video output thread
202  *****************************************************************************
203  * This function creates a new video output thread, and returns a pointer
204  * to its description. On error, it returns NULL.
205  *****************************************************************************/
206 vout_thread_t * __vout_Create( vlc_object_t *p_parent,
207                                unsigned int i_width, unsigned int i_height,
208                                vlc_fourcc_t i_chroma, unsigned int i_aspect )
209 {
210     vout_thread_t  * p_vout;                            /* thread descriptor */
211     input_thread_t * p_input_thread;
212     int              i_index;                               /* loop variable */
213     char           * psz_plugin;
214     vlc_value_t      val, text;
215
216     /* Allocate descriptor */
217     p_vout = vlc_object_create( p_parent, VLC_OBJECT_VOUT );
218     if( p_vout == NULL )
219     {
220         msg_Err( p_parent, "out of memory" );
221         return NULL;
222     }
223
224     /* Initialize pictures - translation tables and functions
225      * will be initialized later in InitThread */
226     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++)
227     {
228         p_vout->p_picture[i_index].pf_lock = NULL;
229         p_vout->p_picture[i_index].pf_unlock = NULL;
230         p_vout->p_picture[i_index].i_status = FREE_PICTURE;
231         p_vout->p_picture[i_index].i_type   = EMPTY_PICTURE;
232         p_vout->p_picture[i_index].b_slow   = 0;
233     }
234
235     /* No images in the heap */
236     p_vout->i_heap_size = 0;
237
238     /* Initialize the rendering heap */
239     I_RENDERPICTURES = 0;
240     p_vout->render.i_width    = i_width;
241     p_vout->render.i_height   = i_height;
242     p_vout->render.i_chroma   = i_chroma;
243     p_vout->render.i_aspect   = i_aspect;
244
245     p_vout->render.i_rmask    = 0;
246     p_vout->render.i_gmask    = 0;
247     p_vout->render.i_bmask    = 0;
248
249     p_vout->render.i_last_used_pic = -1;
250     p_vout->render.b_allow_modify_pics = 1;
251
252     /* Zero the output heap */
253     I_OUTPUTPICTURES = 0;
254     p_vout->output.i_width    = 0;
255     p_vout->output.i_height   = 0;
256     p_vout->output.i_chroma   = 0;
257     p_vout->output.i_aspect   = 0;
258
259     p_vout->output.i_rmask    = 0;
260     p_vout->output.i_gmask    = 0;
261     p_vout->output.i_bmask    = 0;
262
263     /* Initialize misc stuff */
264     p_vout->i_changes    = 0;
265     p_vout->f_gamma      = 0;
266     p_vout->b_grayscale  = 0;
267     p_vout->b_info       = 0;
268     p_vout->b_interface  = 0;
269     p_vout->b_scale      = 1;
270     p_vout->b_fullscreen = 0;
271     p_vout->i_alignment  = 0;
272     p_vout->render_time  = 10;
273     p_vout->c_fps_samples = 0;
274     p_vout->b_filter_change = 0;
275     p_vout->pf_control = 0;
276     p_vout->p_parent_intf = 0;
277
278     /* Initialize locks */
279     vlc_mutex_init( p_vout, &p_vout->picture_lock );
280     vlc_mutex_init( p_vout, &p_vout->change_lock );
281
282     /* Mouse coordinates */
283     var_Create( p_vout, "mouse-x", VLC_VAR_INTEGER );
284     var_Create( p_vout, "mouse-y", VLC_VAR_INTEGER );
285     var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
286     var_Create( p_vout, "mouse-moved", VLC_VAR_BOOL );
287     var_Create( p_vout, "mouse-clicked", VLC_VAR_INTEGER );
288
289     /* Initialize subpicture unit */
290     p_vout->p_spu = spu_Create( p_vout );
291     spu_Attach( p_vout->p_spu, p_parent, VLC_TRUE );
292
293     /* Attach the new object now so we can use var inheritance below */
294     vlc_object_attach( p_vout, p_parent );
295
296     spu_Init( p_vout->p_spu );
297
298     /* Take care of some "interface/control" related initialisations */
299     vout_IntfInit( p_vout );
300
301     p_vout->b_override_aspect = VLC_FALSE;
302
303     /* If the parent is not a VOUT object, that means we are at the start of
304      * the video output pipe */
305     if( p_parent->i_object_type != VLC_OBJECT_VOUT )
306     {
307         var_Get( p_vout, "aspect-ratio", &val );
308
309         /* Check whether the user tried to override aspect ratio */
310         if( val.psz_string )
311         {
312             unsigned int i_new_aspect = i_aspect;
313             char *psz_parser = strchr( val.psz_string, ':' );
314
315             if( psz_parser )
316             {
317                 *psz_parser++ = '\0';
318                 i_new_aspect = atoi( val.psz_string ) * VOUT_ASPECT_FACTOR
319                                                       / atoi( psz_parser );
320             }
321             else
322             {
323                 i_new_aspect = i_width * VOUT_ASPECT_FACTOR
324                                        * atof( val.psz_string )
325                                        / i_height;
326             }
327
328             free( val.psz_string );
329
330             if( i_new_aspect && i_new_aspect != i_aspect )
331             {
332                 int i_aspect_x, i_aspect_y;
333
334                 AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
335
336                 msg_Dbg( p_vout, "overriding source aspect ratio to %i:%i",
337                          i_aspect_x, i_aspect_y );
338
339                 p_vout->render.i_aspect = i_new_aspect;
340
341                 p_vout->b_override_aspect = VLC_TRUE;
342             }
343         }
344
345         /* Look for the default filter configuration */
346         var_Create( p_vout, "filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
347         var_Get( p_vout, "filter", &val );
348         p_vout->psz_filter_chain = val.psz_string;
349     }
350     else
351     {
352         /* continue the parent's filter chain */
353         char *psz_end;
354
355         psz_end = strchr( ((vout_thread_t *)p_parent)->psz_filter_chain, ':' );
356         if( psz_end && *(psz_end+1) )
357             p_vout->psz_filter_chain = strdup( psz_end+1 );
358         else p_vout->psz_filter_chain = NULL;
359     }
360
361     /* Choose the video output module */
362     if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
363     {
364         var_Create( p_vout, "vout", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
365         var_Get( p_vout, "vout", &val );
366         psz_plugin = val.psz_string;
367     }
368     else
369     {
370         /* the filter chain is a string list of filters separated by double
371          * colons */
372         char *psz_end;
373
374         psz_end = strchr( p_vout->psz_filter_chain, ':' );
375         if( psz_end )
376             psz_plugin = strndup( p_vout->psz_filter_chain,
377                                   psz_end - p_vout->psz_filter_chain );
378         else psz_plugin = strdup( p_vout->psz_filter_chain );
379     }
380
381     /* Initialize the dimensions of the video window */
382     InitWindowSize( p_vout, &p_vout->i_window_width,
383                     &p_vout->i_window_height );
384
385     /* Create the vout thread */
386     p_vout->p_module = module_Need( p_vout,
387         ( p_vout->psz_filter_chain && *p_vout->psz_filter_chain ) ?
388         "video filter" : "video output", psz_plugin, 0 );
389
390     if( psz_plugin ) free( psz_plugin );
391     if( p_vout->p_module == NULL )
392     {
393         msg_Err( p_vout, "no suitable vout module" );
394         vlc_object_detach( p_vout );
395         vlc_object_destroy( p_vout );
396         return NULL;
397     }
398
399     /* Create a few object variables for interface interaction */
400     var_Create( p_vout, "deinterlace", VLC_VAR_STRING | VLC_VAR_HASCHOICE );
401     text.psz_string = _("Deinterlace");
402     var_Change( p_vout, "deinterlace", VLC_VAR_SETTEXT, &text, NULL );
403     val.psz_string = ""; text.psz_string = _("Disable");
404     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
405     val.psz_string = "discard"; text.psz_string = _("Discard");
406     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
407     val.psz_string = "blend"; text.psz_string = _("Blend");
408     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
409     val.psz_string = "mean"; text.psz_string = _("Mean");
410     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
411     val.psz_string = "bob"; text.psz_string = _("Bob");
412     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
413     val.psz_string = "linear"; text.psz_string = _("Linear");
414     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
415     if( var_Get( p_vout, "deinterlace-mode", &val ) == VLC_SUCCESS )
416     {
417         var_Set( p_vout, "deinterlace", val );
418         if( val.psz_string ) free( val.psz_string );
419     }
420     var_AddCallback( p_vout, "deinterlace", DeinterlaceCallback, NULL );
421
422
423     var_Create( p_vout, "filter", VLC_VAR_STRING );
424     text.psz_string = _("Filters");
425     var_Change( p_vout, "filter", VLC_VAR_SETTEXT, &text, NULL );
426     var_Change( p_vout, "filter", VLC_VAR_INHERITVALUE, &val, NULL );
427     if( val.psz_string )
428     {
429         var_Set( p_vout, "filter", val );
430         free( val.psz_string );
431     }
432     var_AddCallback( p_vout, "filter", FilterCallback, NULL );
433
434     /* Calculate delay created by internal caching */
435     p_input_thread = (input_thread_t *)vlc_object_find( p_vout,
436                                            VLC_OBJECT_INPUT, FIND_ANYWHERE );
437     if( p_input_thread )
438     {
439         p_vout->i_pts_delay = p_input_thread->i_pts_delay;
440         vlc_object_release( p_input_thread );
441     }
442     else
443     {
444         p_vout->i_pts_delay = DEFAULT_PTS_DELAY;
445     }
446
447     if( vlc_thread_create( p_vout, "video output", RunThread,
448                            VLC_THREAD_PRIORITY_OUTPUT, VLC_TRUE ) )
449     {
450         msg_Err( p_vout, "out of memory" );
451         module_Unneed( p_vout, p_vout->p_module );
452         vlc_object_detach( p_vout );
453         vlc_object_destroy( p_vout );
454         return NULL;
455     }
456
457     if( p_vout->b_error )
458     {
459         msg_Err( p_vout, "video output creation failed" );
460
461         /* Make sure the thread is destroyed */
462         p_vout->b_die = VLC_TRUE;
463
464         vlc_thread_join( p_vout );
465
466         vlc_object_detach( p_vout );
467         vlc_object_destroy( p_vout );
468         return NULL;
469     }
470
471     return p_vout;
472 }
473
474 /*****************************************************************************
475  * vout_Destroy: destroys a previously created video output
476  *****************************************************************************
477  * Destroy a terminated thread.
478  * The function will request a destruction of the specified thread. If pi_error
479  * is NULL, it will return once the thread is destroyed. Else, it will be
480  * update using one of the THREAD_* constants.
481  *****************************************************************************/
482 void vout_Destroy( vout_thread_t *p_vout )
483 {
484     vlc_object_t *p_playlist;
485
486     /* Request thread destruction */
487     p_vout->b_die = VLC_TRUE;
488     vlc_thread_join( p_vout );
489
490     var_Destroy( p_vout, "intf-change" );
491
492     p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST,
493                                   FIND_ANYWHERE );
494
495     if( p_vout->psz_filter_chain ) free( p_vout->psz_filter_chain );
496
497     /* Free structure */
498     vlc_object_destroy( p_vout );
499
500     /* If it was the last vout, tell the interface to show up */
501     if( p_playlist != NULL )
502     {
503         vout_thread_t *p_another_vout = vlc_object_find( p_playlist,
504                                             VLC_OBJECT_VOUT, FIND_ANYWHERE );
505         if( p_another_vout == NULL )
506         {
507             vlc_value_t val;
508             val.b_bool = VLC_TRUE;
509             var_Set( p_playlist, "intf-show", val );
510         }
511         else
512         {
513             vlc_object_release( p_another_vout );
514         }
515         vlc_object_release( p_playlist );
516     }
517 }
518
519 /*****************************************************************************
520  * InitThread: initialize video output thread
521  *****************************************************************************
522  * This function is called from RunThread and performs the second step of the
523  * initialization. It returns 0 on success. Note that the thread's flag are not
524  * modified inside this function.
525  *****************************************************************************/
526 static int InitThread( vout_thread_t *p_vout )
527 {
528     int i, i_aspect_x, i_aspect_y;
529
530     vlc_mutex_lock( &p_vout->change_lock );
531
532 #ifdef STATS
533     p_vout->c_loops = 0;
534 #endif
535
536     /* Initialize output method, it allocates direct buffers for us */
537     if( p_vout->pf_init( p_vout ) )
538     {
539         vlc_mutex_unlock( &p_vout->change_lock );
540         return VLC_EGENERIC;
541     }
542
543     if( !I_OUTPUTPICTURES )
544     {
545         msg_Err( p_vout, "plugin was unable to allocate at least "
546                          "one direct buffer" );
547         p_vout->pf_end( p_vout );
548         vlc_mutex_unlock( &p_vout->change_lock );
549         return VLC_EGENERIC;
550     }
551
552     if( I_OUTPUTPICTURES > VOUT_MAX_PICTURES )
553     {
554         msg_Err( p_vout, "plugin allocated too many direct buffers, "
555                          "our internal buffers must have overflown." );
556         p_vout->pf_end( p_vout );
557         vlc_mutex_unlock( &p_vout->change_lock );
558         return VLC_EGENERIC;
559     }
560
561     msg_Dbg( p_vout, "got %i direct buffer(s)", I_OUTPUTPICTURES );
562
563 #if 0
564     if( !p_vout->psz_filter_chain )
565     {
566         char *psz_aspect = config_GetPsz( p_vout, "pixel-ratio" );
567
568         if( psz_aspect )
569         {
570             int i_new_aspect = p_vout->output.i_width * VOUT_ASPECT_FACTOR
571                                                       * atof( psz_aspect )
572                                                       / p_vout->output.i_height;
573             free( psz_aspect );
574
575             if( i_new_aspect && i_new_aspect != p_vout->output.i_aspect )
576             {
577                 AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
578
579                 msg_Dbg( p_vout, "output ratio forced to %i:%i\n",
580                          i_aspect_x, i_aspect_y );
581                 p_vout->output.i_aspect = i_new_aspect;
582             }
583         }
584     }
585 #endif
586
587     AspectRatio( p_vout->render.i_aspect, &i_aspect_x, &i_aspect_y );
588     msg_Dbg( p_vout,
589              "picture in %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
590              p_vout->render.i_width, p_vout->render.i_height,
591              p_vout->render.i_chroma, (char*)&p_vout->render.i_chroma,
592              i_aspect_x, i_aspect_y );
593
594     AspectRatio( p_vout->output.i_aspect, &i_aspect_x, &i_aspect_y );
595     msg_Dbg( p_vout,
596              "picture out %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
597              p_vout->output.i_width, p_vout->output.i_height,
598              p_vout->output.i_chroma, (char*)&p_vout->output.i_chroma,
599              i_aspect_x, i_aspect_y );
600
601     /* Calculate shifts from system-updated masks */
602     MaskToShift( &p_vout->output.i_lrshift, &p_vout->output.i_rrshift,
603                  p_vout->output.i_rmask );
604     MaskToShift( &p_vout->output.i_lgshift, &p_vout->output.i_rgshift,
605                  p_vout->output.i_gmask );
606     MaskToShift( &p_vout->output.i_lbshift, &p_vout->output.i_rbshift,
607                  p_vout->output.i_bmask );
608
609     /* Check whether we managed to create direct buffers similar to
610      * the render buffers, ie same size and chroma */
611     if( ( p_vout->output.i_width == p_vout->render.i_width )
612      && ( p_vout->output.i_height == p_vout->render.i_height )
613      && ( vout_ChromaCmp( p_vout->output.i_chroma, p_vout->render.i_chroma ) ) )
614     {
615         /* Cool ! We have direct buffers, we can ask the decoder to
616          * directly decode into them ! Map the first render buffers to
617          * the first direct buffers, but keep the first direct buffer
618          * for memcpy operations */
619         p_vout->b_direct = 1;
620
621         for( i = 1; i < VOUT_MAX_PICTURES; i++ )
622         {
623             if( p_vout->p_picture[ i ].i_type != DIRECT_PICTURE &&
624                 I_RENDERPICTURES >= VOUT_MIN_DIRECT_PICTURES - 1 &&
625                 p_vout->p_picture[ i - 1 ].i_type == DIRECT_PICTURE )
626             {
627                 /* We have enough direct buffers so there's no need to
628                  * try to use system memory buffers. */
629                 break;
630             }
631             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
632             I_RENDERPICTURES++;
633         }
634
635         msg_Dbg( p_vout, "direct render, mapping "
636                  "render pictures 0-%i to system pictures 1-%i",
637                  VOUT_MAX_PICTURES - 2, VOUT_MAX_PICTURES - 1 );
638     }
639     else
640     {
641         /* Rats... Something is wrong here, we could not find an output
642          * plugin able to directly render what we decode. See if we can
643          * find a chroma plugin to do the conversion */
644         p_vout->b_direct = 0;
645
646         /* Choose the best module */
647         p_vout->chroma.p_module = module_Need( p_vout, "chroma", NULL, 0 );
648
649         if( p_vout->chroma.p_module == NULL )
650         {
651             msg_Err( p_vout, "no chroma module for %4.4s to %4.4s",
652                      (char*)&p_vout->render.i_chroma,
653                      (char*)&p_vout->output.i_chroma );
654             p_vout->pf_end( p_vout );
655             vlc_mutex_unlock( &p_vout->change_lock );
656             return VLC_EGENERIC;
657         }
658
659         msg_Dbg( p_vout, "indirect render, mapping "
660                  "render pictures 0-%i to system pictures %i-%i",
661                  VOUT_MAX_PICTURES - 1, I_OUTPUTPICTURES,
662                  I_OUTPUTPICTURES + VOUT_MAX_PICTURES - 1 );
663
664         /* Append render buffers after the direct buffers */
665         for( i = I_OUTPUTPICTURES; i < 2 * VOUT_MAX_PICTURES; i++ )
666         {
667             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
668             I_RENDERPICTURES++;
669
670             /* Check if we have enough render pictures */
671             if( I_RENDERPICTURES == VOUT_MAX_PICTURES )
672                 break;
673         }
674     }
675
676     /* Link pictures back to their heap */
677     for( i = 0 ; i < I_RENDERPICTURES ; i++ )
678     {
679         PP_RENDERPICTURE[ i ]->p_heap = &p_vout->render;
680     }
681
682     for( i = 0 ; i < I_OUTPUTPICTURES ; i++ )
683     {
684         PP_OUTPUTPICTURE[ i ]->p_heap = &p_vout->output;
685     }
686
687 /* XXX XXX mark thread ready */
688     return VLC_SUCCESS;
689 }
690
691 /*****************************************************************************
692  * RunThread: video output thread
693  *****************************************************************************
694  * Video output thread. This function does only returns when the thread is
695  * terminated. It handles the pictures arriving in the video heap and the
696  * display device events.
697  *****************************************************************************/
698 static void RunThread( vout_thread_t *p_vout)
699 {
700     int             i_index;                                /* index in heap */
701     int             i_idle_loops = 0;  /* loops without displaying a picture */
702     mtime_t         current_date;                            /* current date */
703     mtime_t         display_date;                            /* display date */
704
705     picture_t *     p_picture;                            /* picture pointer */
706     picture_t *     p_last_picture = NULL;                   /* last picture */
707     picture_t *     p_directbuffer;              /* direct buffer to display */
708
709     subpicture_t *  p_subpic;                          /* subpicture pointer */
710
711     /*
712      * Initialize thread
713      */
714     p_vout->b_error = InitThread( p_vout );
715
716     /* signal the creation of the vout */
717     vlc_thread_ready( p_vout );
718
719     if( p_vout->b_error )
720     {
721         /* Destroy thread structures allocated by Create and InitThread */
722         DestroyThread( p_vout );
723         return;
724     }
725
726     /*
727      * Main loop - it is not executed if an error occurred during
728      * initialization
729      */
730     while( (!p_vout->b_die) && (!p_vout->b_error) )
731     {
732         /* Initialize loop variables */
733         p_picture = NULL;
734         display_date = 0;
735         current_date = mdate();
736
737 #if 0
738         p_vout->c_loops++;
739         if( !(p_vout->c_loops % VOUT_STATS_NB_LOOPS) )
740         {
741             msg_Dbg( p_vout, "picture heap: %d/%d",
742                      I_RENDERPICTURES, p_vout->i_heap_size );
743         }
744 #endif
745
746         /*
747          * Find the picture to display (the one with the earliest date).
748          * This operation does not need lock, since only READY_PICTUREs
749          * are handled. */
750         for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
751         {
752             if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
753                 && ( (p_picture == NULL) ||
754                      (PP_RENDERPICTURE[i_index]->date < display_date) ) )
755             {
756                 p_picture = PP_RENDERPICTURE[i_index];
757                 display_date = p_picture->date;
758             }
759         }
760
761         if( p_picture )
762         {
763             /* If we met the last picture, parse again to see whether there is
764              * a more appropriate one. */
765             if( p_picture == p_last_picture )
766             {
767                 for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
768                 {
769                     if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
770                         && (PP_RENDERPICTURE[i_index] != p_last_picture)
771                         && ((p_picture == p_last_picture) ||
772                             (PP_RENDERPICTURE[i_index]->date < display_date)) )
773                     {
774                         p_picture = PP_RENDERPICTURE[i_index];
775                         display_date = p_picture->date;
776                     }
777                 }
778             }
779
780             /* If we found better than the last picture, destroy it */
781             if( p_last_picture && p_picture != p_last_picture )
782             {
783                 vlc_mutex_lock( &p_vout->picture_lock );
784                 if( p_last_picture->i_refcount )
785                 {
786                     p_last_picture->i_status = DISPLAYED_PICTURE;
787                 }
788                 else
789                 {
790                     p_last_picture->i_status = DESTROYED_PICTURE;
791                     p_vout->i_heap_size--;
792                 }
793                 vlc_mutex_unlock( &p_vout->picture_lock );
794                 p_last_picture = NULL;
795             }
796
797             /* Compute FPS rate */
798             p_vout->p_fps_sample[ p_vout->c_fps_samples++ % VOUT_FPS_SAMPLES ]
799                 = display_date;
800
801             if( !p_picture->b_force &&
802                 p_picture != p_last_picture &&
803                 display_date < current_date + p_vout->render_time )
804             {
805                 /* Picture is late: it will be destroyed and the thread
806                  * will directly choose the next picture */
807                 vlc_mutex_lock( &p_vout->picture_lock );
808                 if( p_picture->i_refcount )
809                 {
810                     /* Pretend we displayed the picture, but don't destroy
811                      * it since the decoder might still need it. */
812                     p_picture->i_status = DISPLAYED_PICTURE;
813                 }
814                 else
815                 {
816                     /* Destroy the picture without displaying it */
817                     p_picture->i_status = DESTROYED_PICTURE;
818                     p_vout->i_heap_size--;
819                 }
820                 msg_Warn( p_vout, "late picture skipped ("I64Fd")",
821                                   current_date - display_date );
822                 vlc_mutex_unlock( &p_vout->picture_lock );
823
824                 continue;
825             }
826
827             if( display_date >
828                 current_date + p_vout->i_pts_delay + VOUT_BOGUS_DELAY )
829             {
830                 /* Picture is waaay too early: it will be destroyed */
831                 vlc_mutex_lock( &p_vout->picture_lock );
832                 if( p_picture->i_refcount )
833                 {
834                     /* Pretend we displayed the picture, but don't destroy
835                      * it since the decoder might still need it. */
836                     p_picture->i_status = DISPLAYED_PICTURE;
837                 }
838                 else
839                 {
840                     /* Destroy the picture without displaying it */
841                     p_picture->i_status = DESTROYED_PICTURE;
842                     p_vout->i_heap_size--;
843                 }
844                 msg_Warn( p_vout, "vout warning: early picture skipped "
845                           "("I64Fd")", display_date - current_date
846                           - p_vout->i_pts_delay );
847                 vlc_mutex_unlock( &p_vout->picture_lock );
848
849                 continue;
850             }
851
852             if( display_date > current_date + VOUT_DISPLAY_DELAY )
853             {
854                 /* A picture is ready to be rendered, but its rendering date
855                  * is far from the current one so the thread will perform an
856                  * empty loop as if no picture were found. The picture state
857                  * is unchanged */
858                 p_picture    = NULL;
859                 display_date = 0;
860             }
861             else if( p_picture == p_last_picture )
862             {
863                 /* We are asked to repeat the previous picture, but we first
864                  * wait for a couple of idle loops */
865                 if( i_idle_loops < 4 )
866                 {
867                     p_picture    = NULL;
868                     display_date = 0;
869                 }
870                 else
871                 {
872                     /* We set the display date to something high, otherwise
873                      * we'll have lots of problems with late pictures */
874                     display_date = current_date + p_vout->render_time;
875                 }
876             }
877         }
878
879         if( p_picture == NULL )
880         {
881             i_idle_loops++;
882         }
883
884         /*
885          * Check for subpictures to display
886          */
887         p_subpic = spu_SortSubpictures( p_vout->p_spu, display_date );
888
889         /*
890          * Perform rendering
891          */
892         p_directbuffer = vout_RenderPicture( p_vout, p_picture, p_subpic );
893
894         /*
895          * Call the plugin-specific rendering method if there is one
896          */
897         if( p_picture != NULL && p_directbuffer != NULL && p_vout->pf_render )
898         {
899             /* Render the direct buffer returned by vout_RenderPicture */
900             p_vout->pf_render( p_vout, p_directbuffer );
901         }
902
903         /*
904          * Sleep, wake up
905          */
906         if( display_date != 0 && p_directbuffer != NULL )
907         {
908             mtime_t current_render_time = mdate() - current_date;
909             /* if render time is very large we don't include it in the mean */
910             if( current_render_time < p_vout->render_time +
911                 VOUT_DISPLAY_DELAY )
912             {
913                 /* Store render time using a sliding mean weighting to
914                  * current value in a 3 to 1 ratio*/
915                 p_vout->render_time *= 3;
916                 p_vout->render_time += current_render_time;
917                 p_vout->render_time >>= 2;
918             }
919         }
920
921         /* Give back change lock */
922         vlc_mutex_unlock( &p_vout->change_lock );
923
924         /* Sleep a while or until a given date */
925         if( display_date != 0 )
926         {
927             /* If there are filters in the chain, better give them the picture
928              * in advance */
929             if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
930             {
931                 mwait( display_date - VOUT_MWAIT_TOLERANCE );
932             }
933         }
934         else
935         {
936             msleep( VOUT_IDLE_SLEEP );
937         }
938
939         /* On awakening, take back lock and send immediately picture
940          * to display. */
941         vlc_mutex_lock( &p_vout->change_lock );
942
943         /*
944          * Display the previously rendered picture
945          */
946         if( p_picture != NULL && p_directbuffer != NULL )
947         {
948             /* Display the direct buffer returned by vout_RenderPicture */
949             if( p_vout->pf_display )
950             {
951                 p_vout->pf_display( p_vout, p_directbuffer );
952             }
953
954             /* Tell the vout this was the last picture and that it does not
955              * need to be forced anymore. */
956             p_last_picture = p_picture;
957             p_last_picture->b_force = 0;
958         }
959
960         if( p_picture != NULL )
961         {
962             /* Reinitialize idle loop count */
963             i_idle_loops = 0;
964         }
965
966         /*
967          * Check events and manage thread
968          */
969         if( p_vout->pf_manage && p_vout->pf_manage( p_vout ) )
970         {
971             /* A fatal error occurred, and the thread must terminate
972              * immediately, without displaying anything - setting b_error to 1
973              * causes the immediate end of the main while() loop. */
974             p_vout->b_error = 1;
975         }
976
977         if( p_vout->i_changes & VOUT_SIZE_CHANGE )
978         {
979             /* this must only happen when the vout plugin is incapable of
980              * rescaling the picture itself. In this case we need to destroy
981              * the current picture buffers and recreate new ones with the right
982              * dimensions */
983             int i;
984
985             p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
986
987             p_vout->pf_end( p_vout );
988             for( i = 0; i < I_OUTPUTPICTURES; i++ )
989                  p_vout->p_picture[ i ].i_status = FREE_PICTURE;
990
991             I_OUTPUTPICTURES = 0;
992             if( p_vout->pf_init( p_vout ) )
993             {
994                 msg_Err( p_vout, "cannot resize display" );
995                 /* FIXME: pf_end will be called again in EndThread() */
996                 p_vout->b_error = 1;
997             }
998
999             /* Need to reinitialise the chroma plugin */
1000             if( p_vout->chroma.p_module )
1001             {
1002                 if( p_vout->chroma.p_module->pf_deactivate )
1003                     p_vout->chroma.p_module->pf_deactivate( VLC_OBJECT(p_vout) );
1004                 p_vout->chroma.p_module->pf_activate( VLC_OBJECT(p_vout) );
1005             }
1006         }
1007
1008         if( p_vout->i_changes & VOUT_PICTURE_BUFFERS_CHANGE )
1009         {
1010             /* This happens when the picture buffers need to be recreated.
1011              * This is useful on multimonitor displays for instance.
1012              *
1013              * Warning: This only works when the vout creates only 1 picture
1014              * buffer!! */
1015             p_vout->i_changes &= ~VOUT_PICTURE_BUFFERS_CHANGE;
1016
1017             if( !p_vout->b_direct )
1018             {
1019                 module_Unneed( p_vout, p_vout->chroma.p_module );
1020             }
1021
1022             vlc_mutex_lock( &p_vout->picture_lock );
1023
1024             p_vout->pf_end( p_vout );
1025
1026             I_OUTPUTPICTURES = I_RENDERPICTURES = 0;
1027
1028             p_vout->b_error = InitThread( p_vout );
1029
1030             vlc_mutex_unlock( &p_vout->picture_lock );
1031         }
1032     }
1033
1034     /*
1035      * Error loop - wait until the thread destruction is requested
1036      */
1037     if( p_vout->b_error )
1038     {
1039         ErrorThread( p_vout );
1040     }
1041
1042     /* End of thread */
1043     EndThread( p_vout );
1044
1045     /* Destroy thread structures allocated by CreateThread */
1046     DestroyThread( p_vout );
1047 }
1048
1049 /*****************************************************************************
1050  * ErrorThread: RunThread() error loop
1051  *****************************************************************************
1052  * This function is called when an error occurred during thread main's loop.
1053  * The thread can still receive feed, but must be ready to terminate as soon
1054  * as possible.
1055  *****************************************************************************/
1056 static void ErrorThread( vout_thread_t *p_vout )
1057 {
1058     /* Wait until a `die' order */
1059     while( !p_vout->b_die )
1060     {
1061         /* Sleep a while */
1062         msleep( VOUT_IDLE_SLEEP );
1063     }
1064 }
1065
1066 /*****************************************************************************
1067  * EndThread: thread destruction
1068  *****************************************************************************
1069  * This function is called when the thread ends after a sucessful
1070  * initialization. It frees all resources allocated by InitThread.
1071  *****************************************************************************/
1072 static void EndThread( vout_thread_t *p_vout )
1073 {
1074     int     i_index;                                        /* index in heap */
1075
1076 #ifdef STATS
1077     {
1078         struct tms cpu_usage;
1079         times( &cpu_usage );
1080
1081         msg_Dbg( p_vout, "cpu usage (user: %d, system: %d)",
1082                  cpu_usage.tms_utime, cpu_usage.tms_stime );
1083     }
1084 #endif
1085
1086     if( !p_vout->b_direct )
1087     {
1088         module_Unneed( p_vout, p_vout->chroma.p_module );
1089     }
1090
1091     /* Destroy all remaining pictures */
1092     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++ )
1093     {
1094         if ( p_vout->p_picture[i_index].i_type == MEMORY_PICTURE )
1095         {
1096             free( p_vout->p_picture[i_index].p_data_orig );
1097         }
1098     }
1099
1100     /* Destroy subpicture unit */
1101     spu_Attach( p_vout->p_spu, VLC_OBJECT(p_vout), VLC_FALSE );
1102     spu_Destroy( p_vout->p_spu );
1103
1104     /* Destroy translation tables */
1105     p_vout->pf_end( p_vout );
1106
1107     /* Release the change lock */
1108     vlc_mutex_unlock( &p_vout->change_lock );
1109 }
1110
1111 /*****************************************************************************
1112  * DestroyThread: thread destruction
1113  *****************************************************************************
1114  * This function is called when the thread ends. It frees all ressources
1115  * allocated by CreateThread. Status is available at this stage.
1116  *****************************************************************************/
1117 static void DestroyThread( vout_thread_t *p_vout )
1118 {
1119     /* Destroy the locks */
1120     vlc_mutex_destroy( &p_vout->picture_lock );
1121     vlc_mutex_destroy( &p_vout->change_lock );
1122
1123     /* Release the module */
1124     if( p_vout && p_vout->p_module )
1125     {
1126         module_Unneed( p_vout, p_vout->p_module );
1127     }
1128 }
1129
1130 /* following functions are local */
1131
1132 static int ReduceHeight( int i_ratio )
1133 {
1134     int i_dummy = VOUT_ASPECT_FACTOR;
1135     int i_pgcd  = 1;
1136
1137     if( !i_ratio )
1138     {
1139         return i_pgcd;
1140     }
1141
1142     /* VOUT_ASPECT_FACTOR is (2^7 * 3^3 * 5^3), we just check for 2, 3 and 5 */
1143     while( !(i_ratio & 1) && !(i_dummy & 1) )
1144     {
1145         i_ratio >>= 1;
1146         i_dummy >>= 1;
1147         i_pgcd  <<= 1;
1148     }
1149
1150     while( !(i_ratio % 3) && !(i_dummy % 3) )
1151     {
1152         i_ratio /= 3;
1153         i_dummy /= 3;
1154         i_pgcd  *= 3;
1155     }
1156
1157     while( !(i_ratio % 5) && !(i_dummy % 5) )
1158     {
1159         i_ratio /= 5;
1160         i_dummy /= 5;
1161         i_pgcd  *= 5;
1162     }
1163
1164     return i_pgcd;
1165 }
1166
1167 static void AspectRatio( int i_aspect, int *i_aspect_x, int *i_aspect_y )
1168 {
1169     unsigned int i_pgcd = ReduceHeight( i_aspect );
1170     *i_aspect_x = i_aspect / i_pgcd;
1171     *i_aspect_y = VOUT_ASPECT_FACTOR / i_pgcd;
1172 }
1173
1174 /*****************************************************************************
1175  * BinaryLog: computes the base 2 log of a binary value
1176  *****************************************************************************
1177  * This functions is used by MaskToShift, to get a bit index from a binary
1178  * value.
1179  *****************************************************************************/
1180 static int BinaryLog( uint32_t i )
1181 {
1182     int i_log = 0;
1183
1184     if( i == 0 ) return -31337;
1185
1186     if( i & 0xffff0000 ) i_log += 16;
1187     if( i & 0xff00ff00 ) i_log += 8;
1188     if( i & 0xf0f0f0f0 ) i_log += 4;
1189     if( i & 0xcccccccc ) i_log += 2;
1190     if( i & 0xaaaaaaaa ) i_log += 1;
1191
1192     return i_log;
1193 }
1194
1195 /*****************************************************************************
1196  * MaskToShift: transform a color mask into right and left shifts
1197  *****************************************************************************
1198  * This function is used for obtaining color shifts from masks.
1199  *****************************************************************************/
1200 static void MaskToShift( int *pi_left, int *pi_right, uint32_t i_mask )
1201 {
1202     uint32_t i_low, i_high;            /* lower hand higher bits of the mask */
1203
1204     if( !i_mask )
1205     {
1206         *pi_left = *pi_right = 0;
1207         return;
1208     }
1209
1210     /* Get bits */
1211     i_low =  i_mask & (- (int32_t)i_mask);          /* lower bit of the mask */
1212     i_high = i_mask + i_low;                       /* higher bit of the mask */
1213
1214     /* Transform bits into an index */
1215     i_low =  BinaryLog (i_low);
1216     i_high = BinaryLog (i_high);
1217
1218     /* Update pointers and return */
1219     *pi_left =   i_low;
1220     *pi_right = (8 - i_high + i_low);
1221 }
1222
1223 /*****************************************************************************
1224  * InitWindowSize: find the initial dimensions the video window should have.
1225  *****************************************************************************
1226  * This function will check the "width", "height" and "zoom" config options and
1227  * will calculate the size that the video window should have.
1228  *****************************************************************************/
1229 static void InitWindowSize( vout_thread_t *p_vout, int *pi_width,
1230                             int *pi_height )
1231 {
1232     vlc_value_t val;
1233     int i_width, i_height;
1234     uint64_t ll_zoom;
1235
1236 #define FP_FACTOR 1000                             /* our fixed point factor */
1237
1238     var_Get( p_vout, "align", &val );
1239     p_vout->i_alignment = val.i_int;
1240
1241     var_Get( p_vout, "width", &val );
1242     i_width = val.i_int;
1243     var_Get( p_vout, "height", &val );
1244     i_height = val.i_int;
1245     var_Get( p_vout, "zoom", &val );
1246     ll_zoom = (uint64_t)( FP_FACTOR * val.f_float );
1247
1248     if( i_width > 0 && i_height > 0)
1249     {
1250         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1251         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1252         return;
1253     }
1254     else if( i_width > 0 )
1255     {
1256         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1257         *pi_height = (int)( i_width * ll_zoom * VOUT_ASPECT_FACTOR /
1258                             p_vout->render.i_aspect / FP_FACTOR );
1259         return;
1260     }
1261     else if( i_height > 0 )
1262     {
1263         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1264         *pi_width = (int)( i_height * ll_zoom * p_vout->render.i_aspect /
1265                            VOUT_ASPECT_FACTOR / FP_FACTOR );
1266         return;
1267     }
1268
1269     if( p_vout->render.i_height * p_vout->render.i_aspect
1270         >= p_vout->render.i_width * VOUT_ASPECT_FACTOR )
1271     {
1272         *pi_width = (int)( p_vout->render.i_height * ll_zoom
1273           * p_vout->render.i_aspect / VOUT_ASPECT_FACTOR / FP_FACTOR );
1274         *pi_height = (int)( p_vout->render.i_height * ll_zoom / FP_FACTOR );
1275     }
1276     else
1277     {
1278         *pi_width = (int)( p_vout->render.i_width * ll_zoom / FP_FACTOR );
1279         *pi_height = (int)( p_vout->render.i_width * ll_zoom
1280           * VOUT_ASPECT_FACTOR / p_vout->render.i_aspect / FP_FACTOR );
1281     }
1282
1283 #undef FP_FACTOR
1284 }
1285
1286 /*****************************************************************************
1287  * vout_VarCallback: generic callback for intf variables
1288  *****************************************************************************/
1289 int vout_VarCallback( vlc_object_t * p_this, const char * psz_variable,
1290                       vlc_value_t old_value, vlc_value_t new_value,
1291                       void * unused )
1292 {
1293     vout_thread_t * p_vout = (vout_thread_t *)p_this;
1294     vlc_value_t val;
1295     val.b_bool = VLC_TRUE;
1296     var_Set( p_vout, "intf-change", val );
1297     return VLC_SUCCESS;
1298 }
1299
1300 /*****************************************************************************
1301  * object variables callbacks: a bunch of object variables are used by the
1302  * interfaces to interact with the vout.
1303  *****************************************************************************/
1304 static int DeinterlaceCallback( vlc_object_t *p_this, char const *psz_cmd,
1305                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1306 {
1307     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1308     input_thread_t *p_input;
1309     vlc_value_t val;
1310
1311     char *psz_mode = newval.psz_string;
1312     char *psz_filter;
1313
1314     psz_filter = config_GetPsz( p_vout, "filter" );
1315
1316     if( !psz_mode || !*psz_mode )
1317     {
1318         config_PutPsz( p_vout, "filter", "" );
1319     }
1320     else
1321     {
1322         if( !psz_filter || !*psz_filter )
1323         {
1324             config_PutPsz( p_vout, "filter", "deinterlace" );
1325         }
1326         else
1327         {
1328             if( strstr( psz_filter, "deinterlace" ) == NULL )
1329             {
1330                 psz_filter = realloc( psz_filter, strlen( psz_filter ) + 20 );
1331                 strcat( psz_filter, ",deinterlace" );
1332             }
1333             config_PutPsz( p_vout, "filter", psz_filter );
1334         }
1335     }
1336
1337     if( psz_filter ) free( psz_filter );
1338
1339
1340     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1341                                                  FIND_PARENT );
1342     if( !p_input ) return VLC_EGENERIC;
1343
1344     if( psz_mode && *psz_mode )
1345     {
1346         val.psz_string = psz_mode;
1347         var_Set( p_vout, "deinterlace-mode", val );
1348         /* Modify input as well because the vout might have to be restarted */
1349         var_Create( p_input, "deinterlace-mode", VLC_VAR_STRING );
1350         var_Set( p_input, "deinterlace-mode", val );
1351     }
1352
1353     /* Now restart current video stream */
1354     var_Get( p_input, "video-es", &val );
1355     if( val.i_int >= 0 )
1356     {
1357         vlc_value_t val_es;
1358         val_es.i_int = -VIDEO_ES;
1359         p_vout->b_filter_change = VLC_TRUE;
1360         var_Set( p_input, "video-es", val_es );
1361         var_Set( p_input, "video-es", val );
1362     }
1363
1364     vlc_object_release( p_input );
1365
1366     val.b_bool = VLC_TRUE;
1367     var_Set( p_vout, "intf-change", val );
1368     return VLC_SUCCESS;
1369 }
1370
1371 static int FilterCallback( vlc_object_t *p_this, char const *psz_cmd,
1372                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1373 {
1374     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1375     input_thread_t *p_input;
1376     vlc_value_t val;
1377
1378     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1379                                                  FIND_PARENT );
1380
1381     if (!p_input)
1382     {
1383         msg_Err( p_vout, "Input not found" );
1384         return( VLC_EGENERIC );
1385     }
1386
1387     /* Now restart current video stream */
1388     var_Get( p_input, "video-es", &val );
1389     if( val.i_int >= 0 )
1390     {
1391         vlc_value_t val_es;
1392         val_es.i_int = -VIDEO_ES;
1393         p_vout->b_filter_change = VLC_TRUE;
1394         var_Set( p_input, "video-es", val_es );
1395         var_Set( p_input, "video-es", val );
1396     }
1397
1398     vlc_object_release( p_input );
1399
1400     val.b_bool = VLC_TRUE;
1401     var_Set( p_vout, "intf-change", val );
1402     return VLC_SUCCESS;
1403 }