]> git.sesse.net Git - vlc/blob - src/video_output/video_output.c
* src/video_output/vout_subpictures.c, video_output.c: fixed a crash with dvd menus.
[vlc] / src / video_output / video_output.c
1 /*****************************************************************************
2  * video_output.c : video output thread
3  * This module describes the programming interface for video output threads.
4  * It includes functions allowing to open a new thread, send pictures to a
5  * thread, and destroy a previously oppened video output thread.
6  *****************************************************************************
7  * Copyright (C) 2000-2004 VideoLAN
8  * $Id$
9  *
10  * Authors: Vincent Seguin <seguin@via.ecp.fr>
11  *
12  * This program is free software; you can redistribute it and/or modify
13  * it under the terms of the GNU General Public License as published by
14  * the Free Software Foundation; either version 2 of the License, or
15  * (at your option) any later version.
16  *
17  * This program is distributed in the hope that it will be useful,
18  * but WITHOUT ANY WARRANTY; without even the implied warranty of
19  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
20  * GNU General Public License for more details.
21  *
22  * You should have received a copy of the GNU General Public License
23  * along with this program; if not, write to the Free Software
24  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
25  *****************************************************************************/
26
27 /*****************************************************************************
28  * Preamble
29  *****************************************************************************/
30 #include <stdlib.h>                                                /* free() */
31
32 #include <vlc/vlc.h>
33
34 #ifdef HAVE_SYS_TIMES_H
35 #   include <sys/times.h>
36 #endif
37
38 #include "vlc_video.h"
39 #include "video_output.h"
40 #include <vlc/input.h>                 /* for input_thread_t and i_pts_delay */
41
42 #if defined( SYS_DARWIN )
43 #include "darwin_specific.h"
44 #endif
45
46 /*****************************************************************************
47  * Local prototypes
48  *****************************************************************************/
49 static int      InitThread        ( vout_thread_t * );
50 static void     RunThread         ( vout_thread_t * );
51 static void     ErrorThread       ( vout_thread_t * );
52 static void     EndThread         ( vout_thread_t * );
53 static void     DestroyThread     ( vout_thread_t * );
54
55 static int      ReduceHeight      ( int );
56 static int      BinaryLog         ( uint32_t );
57 static void     MaskToShift       ( int *, int *, uint32_t );
58 static void     InitWindowSize    ( vout_thread_t *, int *, int * );
59
60 /* Object variables callbacks */
61 static int DeinterlaceCallback( vlc_object_t *, char const *,
62                                 vlc_value_t, vlc_value_t, void * );
63 static int FilterCallback( vlc_object_t *, char const *,
64                            vlc_value_t, vlc_value_t, void * );
65
66 /**
67  * vout_AspectRatio
68  *
69  * Set the i_aspect_x and i_aspect_y from i_aspect.
70  */
71 void vout_AspectRatio( unsigned int i_aspect,
72                        /*out*/ unsigned int *i_aspect_x,
73                        /*out*/ unsigned int *i_aspect_y )
74 {
75   unsigned int i_pgcd = ReduceHeight( i_aspect );
76   *i_aspect_x = i_aspect / i_pgcd;
77   *i_aspect_y = VOUT_ASPECT_FACTOR / i_pgcd;
78 }
79
80 /*****************************************************************************
81  * vout_Request: find a video output thread, create one, or destroy one.
82  *****************************************************************************
83  * This function looks for a video output thread matching the current
84  * properties. If not found, it spawns a new one.
85  *****************************************************************************/
86 vout_thread_t * __vout_Request ( vlc_object_t *p_this, vout_thread_t *p_vout,
87                                  unsigned int i_width, unsigned int i_height,
88                                  vlc_fourcc_t i_chroma, unsigned int i_aspect )
89 {
90     if( !i_width || !i_height || !i_chroma )
91     {
92         /* Reattach video output to input before bailing out */
93         if( p_vout )
94         {
95             vlc_object_t *p_playlist;
96
97             p_playlist = vlc_object_find( p_this, VLC_OBJECT_PLAYLIST,
98                                           FIND_ANYWHERE );
99
100             if( p_playlist )
101             {
102                 vout_AttachSPU( p_vout, VLC_FALSE );
103                 vlc_object_detach( p_vout );
104                 vlc_object_attach( p_vout, p_playlist );
105
106                 vlc_object_release( p_playlist );
107             }
108             else
109             {
110                 msg_Dbg( p_this, "cannot find playlist, destroying vout" );
111                 vlc_object_detach( p_vout );
112                 vout_Destroy( p_vout );
113             }
114         }
115         return NULL;
116     }
117
118     /* If a video output was provided, lock it, otherwise look for one. */
119     if( p_vout )
120     {
121         vlc_object_yield( p_vout );
122     }
123     else
124     {
125         p_vout = vlc_object_find( p_this, VLC_OBJECT_VOUT, FIND_CHILD );
126
127         if( !p_vout )
128         {
129             vlc_object_t *p_playlist;
130
131             p_playlist = vlc_object_find( p_this,
132                                           VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
133             if( p_playlist )
134             {
135                 p_vout = vlc_object_find( p_playlist,
136                                           VLC_OBJECT_VOUT, FIND_CHILD );
137                 /* only first children of p_input for unused vout */
138                 if( p_vout && p_vout->p_parent != p_playlist )
139                 {
140                     vlc_object_release( p_vout );
141                     p_vout = NULL;
142                 }
143                 vlc_object_release( p_playlist );
144             }
145         }
146     }
147
148     /* If we now have a video output, check it has the right properties */
149     if( p_vout )
150     {
151         char *psz_filter_chain;
152
153         /* We don't directly check for the "filter" variable for obvious
154          * performance reasons. */
155         if( p_vout->b_filter_change )
156         {
157             psz_filter_chain = config_GetPsz( p_this, "filter" );
158
159             if( psz_filter_chain && !*psz_filter_chain )
160             {
161                 free( psz_filter_chain );
162                 psz_filter_chain = NULL;
163             }
164             if( p_vout->psz_filter_chain && !*p_vout->psz_filter_chain )
165             {
166                 free( p_vout->psz_filter_chain );
167                 p_vout->psz_filter_chain = NULL;
168             }
169
170             if( ( !psz_filter_chain && !p_vout->psz_filter_chain ) ||
171                 ( psz_filter_chain && p_vout->psz_filter_chain &&
172                   !strcmp( psz_filter_chain, p_vout->psz_filter_chain ) ) )
173             {
174                 p_vout->b_filter_change = VLC_FALSE;
175             }
176
177             if( psz_filter_chain ) free( psz_filter_chain );
178         }
179
180         if( ( p_vout->render.i_width != i_width ) ||
181             ( p_vout->render.i_height != i_height ) ||
182             ( p_vout->render.i_chroma != i_chroma ) ||
183             ( p_vout->render.i_aspect != i_aspect
184                     && !p_vout->b_override_aspect ) ||
185             p_vout->b_filter_change )
186         {
187             /* We are not interested in this format, close this vout */
188             vlc_object_detach( p_vout );
189             vlc_object_release( p_vout );
190             vout_Destroy( p_vout );
191             p_vout = NULL;
192         }
193         else
194         {
195             /* This video output is cool! Hijack it. */
196             vlc_object_detach( p_vout );
197             vlc_object_attach( p_vout, p_this );
198             vout_AttachSPU( p_vout, VLC_TRUE );
199             vlc_object_release( p_vout );
200         }
201     }
202
203     if( !p_vout )
204     {
205         msg_Dbg( p_this, "no usable vout present, spawning one" );
206
207         p_vout = vout_Create( p_this, i_width, i_height, i_chroma, i_aspect );
208     }
209
210     return p_vout;
211 }
212
213 /*****************************************************************************
214  * vout_Create: creates a new video output thread
215  *****************************************************************************
216  * This function creates a new video output thread, and returns a pointer
217  * to its description. On error, it returns NULL.
218  *****************************************************************************/
219 vout_thread_t * __vout_Create( vlc_object_t *p_parent,
220                                unsigned int i_width, unsigned int i_height,
221                                vlc_fourcc_t i_chroma, unsigned int i_aspect )
222 {
223     vout_thread_t  * p_vout;                            /* thread descriptor */
224     input_thread_t * p_input_thread;
225     int              i_index;                               /* loop variable */
226     char           * psz_plugin;
227     vlc_value_t      val, text;
228
229     /* Allocate descriptor */
230     p_vout = vlc_object_create( p_parent, VLC_OBJECT_VOUT );
231     if( p_vout == NULL )
232     {
233         msg_Err( p_parent, "out of memory" );
234         return NULL;
235     }
236
237     /* Initialize pictures - translation tables and functions
238      * will be initialized later in InitThread */
239     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++)
240     {
241         p_vout->p_picture[i_index].pf_lock = NULL;
242         p_vout->p_picture[i_index].pf_unlock = NULL;
243         p_vout->p_picture[i_index].i_status = FREE_PICTURE;
244         p_vout->p_picture[i_index].i_type   = EMPTY_PICTURE;
245         p_vout->p_picture[i_index].b_slow   = 0;
246     }
247
248     /* No images in the heap */
249     p_vout->i_heap_size = 0;
250
251     /* Register the default subpicture channel */
252     p_vout->p_default_channel = NULL;
253     p_vout->i_channel_count = 1;
254
255     /* Initialize the rendering heap */
256     I_RENDERPICTURES = 0;
257     p_vout->render.i_width    = i_width;
258     p_vout->render.i_height   = i_height;
259     p_vout->render.i_chroma   = i_chroma;
260     p_vout->render.i_aspect   = i_aspect;
261
262     p_vout->render.i_rmask    = 0;
263     p_vout->render.i_gmask    = 0;
264     p_vout->render.i_bmask    = 0;
265
266     p_vout->render.i_last_used_pic = -1;
267     p_vout->render.b_allow_modify_pics = 1;
268
269     /* Zero the output heap */
270     I_OUTPUTPICTURES = 0;
271     p_vout->output.i_width    = 0;
272     p_vout->output.i_height   = 0;
273     p_vout->output.i_chroma   = 0;
274     p_vout->output.i_aspect   = 0;
275
276     p_vout->output.i_rmask    = 0;
277     p_vout->output.i_gmask    = 0;
278     p_vout->output.i_bmask    = 0;
279
280     /* Initialize misc stuff */
281     p_vout->i_changes    = 0;
282     p_vout->f_gamma      = 0;
283     p_vout->b_grayscale  = 0;
284     p_vout->b_info       = 0;
285     p_vout->b_interface  = 0;
286     p_vout->b_scale      = 1;
287     p_vout->b_fullscreen = 0;
288     p_vout->i_alignment  = 0;
289     p_vout->render_time  = 10;
290     p_vout->c_fps_samples = 0;
291     p_vout->b_filter_change = 0;
292     p_vout->pf_control = 0;
293     p_vout->p_parent_intf = 0;
294
295     /* Initialize locks */
296     vlc_mutex_init( p_vout, &p_vout->picture_lock );
297     vlc_mutex_init( p_vout, &p_vout->subpicture_lock );
298     vlc_mutex_init( p_vout, &p_vout->change_lock );
299
300     /* Attach the new object now so we can use var inheritance below */
301     vlc_object_attach( p_vout, p_parent );
302
303     /* Take care of some "interface/control" related initialisations */
304     vout_IntfInit( p_vout );
305
306     p_vout->b_override_aspect = VLC_FALSE;
307
308     /* If the parent is not a VOUT object, that means we are at the start of
309      * the video output pipe */
310     if( p_parent->i_object_type != VLC_OBJECT_VOUT )
311     {
312         var_Get( p_vout, "aspect-ratio", &val );
313
314         /* Check whether the user tried to override aspect ratio */
315         if( val.psz_string )
316         {
317             unsigned int i_new_aspect = i_aspect;
318             char *psz_parser = strchr( val.psz_string, ':' );
319
320             if( psz_parser )
321             {
322                 *psz_parser++ = '\0';
323                 i_new_aspect = atoi( val.psz_string ) * VOUT_ASPECT_FACTOR
324                                                       / atoi( psz_parser );
325             }
326             else
327             {
328                 i_new_aspect = i_width * VOUT_ASPECT_FACTOR
329                                        * atof( val.psz_string )
330                                        / i_height;
331             }
332
333             free( val.psz_string );
334
335             if( i_new_aspect && i_new_aspect != i_aspect )
336             {
337                 unsigned int i_aspect_x, i_aspect_y;
338
339                 vout_AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
340
341                 msg_Dbg( p_vout, "overriding source aspect ratio to %i:%i",
342                          i_aspect_x, i_aspect_y );
343
344                 p_vout->render.i_aspect = i_new_aspect;
345
346                 p_vout->b_override_aspect = VLC_TRUE;
347             }
348         }
349
350         /* Look for the default filter configuration */
351         var_Create( p_vout, "filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
352         var_Get( p_vout, "filter", &val );
353         p_vout->psz_filter_chain = val.psz_string;
354     }
355     else
356     {
357         /* continue the parent's filter chain */
358         char *psz_end;
359
360         psz_end = strchr( ((vout_thread_t *)p_parent)->psz_filter_chain, ':' );
361         if( psz_end && *(psz_end+1) )
362             p_vout->psz_filter_chain = strdup( psz_end+1 );
363         else p_vout->psz_filter_chain = NULL;
364     }
365
366     /* Choose the video output module */
367     if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
368     {
369         var_Create( p_vout, "vout", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
370         var_Get( p_vout, "vout", &val );
371         psz_plugin = val.psz_string;
372     }
373     else
374     {
375         /* the filter chain is a string list of filters separated by double
376          * colons */
377         char *psz_end;
378
379         psz_end = strchr( p_vout->psz_filter_chain, ':' );
380         if( psz_end )
381             psz_plugin = strndup( p_vout->psz_filter_chain,
382                                   psz_end - p_vout->psz_filter_chain );
383         else psz_plugin = strdup( p_vout->psz_filter_chain );
384     }
385
386     /* Initialize the dimensions of the video window */
387     InitWindowSize( p_vout, &p_vout->i_window_width,
388                     &p_vout->i_window_height );
389
390     /* Create the vout thread */
391     p_vout->p_module = module_Need( p_vout,
392         ( p_vout->psz_filter_chain && *p_vout->psz_filter_chain ) ?
393         "video filter" : "video output", psz_plugin, 0 );
394
395     if( psz_plugin ) free( psz_plugin );
396     if( p_vout->p_module == NULL )
397     {
398         msg_Err( p_vout, "no suitable vout module" );
399         vlc_object_detach( p_vout );
400         vlc_object_destroy( p_vout );
401         return NULL;
402     }
403
404     /* Initialize subpicture unit */
405     vout_InitSPU( p_vout );
406
407     /* Create a few object variables for interface interaction */
408     var_Create( p_vout, "deinterlace", VLC_VAR_STRING | VLC_VAR_HASCHOICE );
409     text.psz_string = _("Deinterlace");
410     var_Change( p_vout, "deinterlace", VLC_VAR_SETTEXT, &text, NULL );
411     val.psz_string = ""; text.psz_string = _("Disable");
412     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
413     val.psz_string = "discard"; text.psz_string = _("Discard");
414     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
415     val.psz_string = "blend"; text.psz_string = _("Blend");
416     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
417     val.psz_string = "mean"; text.psz_string = _("Mean");
418     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
419     val.psz_string = "bob"; text.psz_string = _("Bob");
420     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
421     val.psz_string = "linear"; text.psz_string = _("Linear");
422     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
423     if( var_Get( p_vout, "deinterlace-mode", &val ) == VLC_SUCCESS )
424     {
425         var_Set( p_vout, "deinterlace", val );
426         if( val.psz_string ) free( val.psz_string );
427     }
428     var_AddCallback( p_vout, "deinterlace", DeinterlaceCallback, NULL );
429
430
431     var_Create( p_vout, "filter", VLC_VAR_STRING );
432     text.psz_string = _("Filters");
433     var_Change( p_vout, "filter", VLC_VAR_SETTEXT, &text, NULL );
434     var_Change( p_vout, "filter", VLC_VAR_INHERITVALUE, &val, NULL );
435     if( val.psz_string )
436     {
437         var_Set( p_vout, "filter", val );
438         free( val.psz_string );
439     }
440     var_AddCallback( p_vout, "filter", FilterCallback, NULL );
441
442     /* Calculate delay created by internal caching */
443     p_input_thread = (input_thread_t *)vlc_object_find( p_vout,
444                                            VLC_OBJECT_INPUT, FIND_ANYWHERE );
445     if( p_input_thread )
446     {
447         p_vout->i_pts_delay = p_input_thread->i_pts_delay;
448         vlc_object_release( p_input_thread );
449     }
450     else
451     {
452         p_vout->i_pts_delay = DEFAULT_PTS_DELAY;
453     }
454
455     if( vlc_thread_create( p_vout, "video output", RunThread,
456                            VLC_THREAD_PRIORITY_OUTPUT, VLC_TRUE ) )
457     {
458         msg_Err( p_vout, "out of memory" );
459         module_Unneed( p_vout, p_vout->p_module );
460         vlc_object_detach( p_vout );
461         vlc_object_destroy( p_vout );
462         return NULL;
463     }
464
465     if( p_vout->b_error )
466     {
467         msg_Err( p_vout, "video output creation failed" );
468
469         /* Make sure the thread is destroyed */
470         p_vout->b_die = VLC_TRUE;
471
472         vlc_thread_join( p_vout );
473
474         vlc_object_detach( p_vout );
475         vlc_object_destroy( p_vout );
476         return NULL;
477     }
478
479     return p_vout;
480 }
481
482 /*****************************************************************************
483  * vout_Destroy: destroys a previously created video output
484  *****************************************************************************
485  * Destroy a terminated thread.
486  * The function will request a destruction of the specified thread. If pi_error
487  * is NULL, it will return once the thread is destroyed. Else, it will be
488  * update using one of the THREAD_* constants.
489  *****************************************************************************/
490 void vout_Destroy( vout_thread_t *p_vout )
491 {
492     vlc_object_t *p_playlist;
493
494     /* Request thread destruction */
495     p_vout->b_die = VLC_TRUE;
496     vlc_thread_join( p_vout );
497
498     var_Destroy( p_vout, "intf-change" );
499
500     p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST,
501                                   FIND_ANYWHERE );
502
503     if( p_vout->psz_filter_chain ) free( p_vout->psz_filter_chain );
504
505     /* Free structure */
506     vlc_object_destroy( p_vout );
507
508     /* If it was the last vout, tell the interface to show up */
509     if( p_playlist != NULL )
510     {
511         vout_thread_t *p_another_vout = vlc_object_find( p_playlist,
512                                             VLC_OBJECT_VOUT, FIND_ANYWHERE );
513         if( p_another_vout == NULL )
514         {
515             vlc_value_t val;
516             val.b_bool = VLC_TRUE;
517             var_Set( p_playlist, "intf-show", val );
518         }
519         else
520         {
521             vlc_object_release( p_another_vout );
522         }
523         vlc_object_release( p_playlist );
524     }
525 }
526
527 /*****************************************************************************
528  * InitThread: initialize video output thread
529  *****************************************************************************
530  * This function is called from RunThread and performs the second step of the
531  * initialization. It returns 0 on success. Note that the thread's flag are not
532  * modified inside this function.
533  *****************************************************************************/
534 static int InitThread( vout_thread_t *p_vout )
535 {
536     int i;
537     unsigned int i_aspect_x, i_aspect_y;
538
539     vlc_mutex_lock( &p_vout->change_lock );
540
541 #ifdef STATS
542     p_vout->c_loops = 0;
543 #endif
544
545     /* Initialize output method, it allocates direct buffers for us */
546     if( p_vout->pf_init( p_vout ) )
547     {
548         vlc_mutex_unlock( &p_vout->change_lock );
549         return VLC_EGENERIC;
550     }
551
552     if( !I_OUTPUTPICTURES )
553     {
554         msg_Err( p_vout, "plugin was unable to allocate at least "
555                          "one direct buffer" );
556         p_vout->pf_end( p_vout );
557         vlc_mutex_unlock( &p_vout->change_lock );
558         return VLC_EGENERIC;
559     }
560
561     if( I_OUTPUTPICTURES > VOUT_MAX_PICTURES )
562     {
563         msg_Err( p_vout, "plugin allocated too many direct buffers, "
564                          "our internal buffers must have overflown." );
565         p_vout->pf_end( p_vout );
566         vlc_mutex_unlock( &p_vout->change_lock );
567         return VLC_EGENERIC;
568     }
569
570     msg_Dbg( p_vout, "got %i direct buffer(s)", I_OUTPUTPICTURES );
571
572 #if 0
573     if( !p_vout->psz_filter_chain )
574     {
575         char *psz_aspect = config_GetPsz( p_vout, "pixel-ratio" );
576
577         if( psz_aspect )
578         {
579             int i_new_aspect = p_vout->output.i_width * VOUT_ASPECT_FACTOR
580                                                       * atof( psz_aspect )
581                                                       / p_vout->output.i_height;
582             free( psz_aspect );
583
584             if( i_new_aspect && i_new_aspect != p_vout->output.i_aspect )
585             {
586                 vout_AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
587
588                 msg_Dbg( p_vout, "output ratio forced to %i:%i\n",
589                          i_aspect_x, i_aspect_y );
590                 p_vout->output.i_aspect = i_new_aspect;
591             }
592         }
593     }
594 #endif
595
596     vout_AspectRatio( p_vout->render.i_aspect, &i_aspect_x, &i_aspect_y );
597     msg_Dbg( p_vout,
598              "picture in %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
599              p_vout->render.i_width, p_vout->render.i_height,
600              p_vout->render.i_chroma, (char*)&p_vout->render.i_chroma,
601              i_aspect_x, i_aspect_y );
602
603     vout_AspectRatio( p_vout->output.i_aspect, &i_aspect_x, &i_aspect_y );
604     msg_Dbg( p_vout,
605              "picture out %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
606              p_vout->output.i_width, p_vout->output.i_height,
607              p_vout->output.i_chroma, (char*)&p_vout->output.i_chroma,
608              i_aspect_x, i_aspect_y );
609
610     /* Calculate shifts from system-updated masks */
611     MaskToShift( &p_vout->output.i_lrshift, &p_vout->output.i_rrshift,
612                  p_vout->output.i_rmask );
613     MaskToShift( &p_vout->output.i_lgshift, &p_vout->output.i_rgshift,
614                  p_vout->output.i_gmask );
615     MaskToShift( &p_vout->output.i_lbshift, &p_vout->output.i_rbshift,
616                  p_vout->output.i_bmask );
617
618     /* Check whether we managed to create direct buffers similar to
619      * the render buffers, ie same size and chroma */
620     if( ( p_vout->output.i_width == p_vout->render.i_width )
621      && ( p_vout->output.i_height == p_vout->render.i_height )
622      && ( vout_ChromaCmp( p_vout->output.i_chroma, p_vout->render.i_chroma ) ) )
623     {
624         /* Cool ! We have direct buffers, we can ask the decoder to
625          * directly decode into them ! Map the first render buffers to
626          * the first direct buffers, but keep the first direct buffer
627          * for memcpy operations */
628         p_vout->b_direct = 1;
629
630         for( i = 1; i < VOUT_MAX_PICTURES; i++ )
631         {
632             if( p_vout->p_picture[ i ].i_type != DIRECT_PICTURE &&
633                 I_RENDERPICTURES >= VOUT_MIN_DIRECT_PICTURES - 1 &&
634                 p_vout->p_picture[ i - 1 ].i_type == DIRECT_PICTURE )
635             {
636                 /* We have enough direct buffers so there's no need to
637                  * try to use system memory buffers. */
638                 break;
639             }
640             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
641             I_RENDERPICTURES++;
642         }
643
644         msg_Dbg( p_vout, "direct render, mapping "
645                  "render pictures 0-%i to system pictures 1-%i",
646                  VOUT_MAX_PICTURES - 2, VOUT_MAX_PICTURES - 1 );
647     }
648     else
649     {
650         /* Rats... Something is wrong here, we could not find an output
651          * plugin able to directly render what we decode. See if we can
652          * find a chroma plugin to do the conversion */
653         p_vout->b_direct = 0;
654
655         /* Choose the best module */
656         p_vout->chroma.p_module = module_Need( p_vout, "chroma", NULL, 0 );
657
658         if( p_vout->chroma.p_module == NULL )
659         {
660             msg_Err( p_vout, "no chroma module for %4.4s to %4.4s",
661                      (char*)&p_vout->render.i_chroma,
662                      (char*)&p_vout->output.i_chroma );
663             p_vout->pf_end( p_vout );
664             vlc_mutex_unlock( &p_vout->change_lock );
665             return VLC_EGENERIC;
666         }
667
668         msg_Dbg( p_vout, "indirect render, mapping "
669                  "render pictures 0-%i to system pictures %i-%i",
670                  VOUT_MAX_PICTURES - 1, I_OUTPUTPICTURES,
671                  I_OUTPUTPICTURES + VOUT_MAX_PICTURES - 1 );
672
673         /* Append render buffers after the direct buffers */
674         for( i = I_OUTPUTPICTURES; i < 2 * VOUT_MAX_PICTURES; i++ )
675         {
676             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
677             I_RENDERPICTURES++;
678
679             /* Check if we have enough render pictures */
680             if( I_RENDERPICTURES == VOUT_MAX_PICTURES )
681                 break;
682         }
683     }
684
685     /* Link pictures back to their heap */
686     for( i = 0 ; i < I_RENDERPICTURES ; i++ )
687     {
688         PP_RENDERPICTURE[ i ]->p_heap = &p_vout->render;
689     }
690
691     for( i = 0 ; i < I_OUTPUTPICTURES ; i++ )
692     {
693         PP_OUTPUTPICTURE[ i ]->p_heap = &p_vout->output;
694     }
695
696 /* XXX XXX mark thread ready */
697     return VLC_SUCCESS;
698 }
699
700 /*****************************************************************************
701  * RunThread: video output thread
702  *****************************************************************************
703  * Video output thread. This function does only returns when the thread is
704  * terminated. It handles the pictures arriving in the video heap and the
705  * display device events.
706  *****************************************************************************/
707 static void RunThread( vout_thread_t *p_vout)
708 {
709     int             i_index;                                /* index in heap */
710     int             i_idle_loops = 0;  /* loops without displaying a picture */
711     mtime_t         current_date;                            /* current date */
712     mtime_t         display_date;                            /* display date */
713
714     picture_t *     p_picture;                            /* picture pointer */
715     picture_t *     p_last_picture = NULL;                   /* last picture */
716     picture_t *     p_directbuffer;              /* direct buffer to display */
717
718     subpicture_t *  p_subpic;                          /* subpicture pointer */
719
720     /*
721      * Initialize thread
722      */
723     p_vout->b_error = InitThread( p_vout );
724
725     /* signal the creation of the vout */
726     vlc_thread_ready( p_vout );
727
728     if( p_vout->b_error )
729     {
730         /* Destroy thread structures allocated by Create and InitThread */
731         DestroyThread( p_vout );
732         return;
733     }
734
735     /*
736      * Main loop - it is not executed if an error occured during
737      * initialization
738      */
739     while( (!p_vout->b_die) && (!p_vout->b_error) )
740     {
741         /* Initialize loop variables */
742         p_picture = NULL;
743         display_date = 0;
744         current_date = mdate();
745
746 #if 0
747         p_vout->c_loops++;
748         if( !(p_vout->c_loops % VOUT_STATS_NB_LOOPS) )
749         {
750             msg_Dbg( p_vout, "picture heap: %d/%d",
751                      I_RENDERPICTURES, p_vout->i_heap_size );
752         }
753 #endif
754
755         /*
756          * Find the picture to display (the one with the earliest date).
757          * This operation does not need lock, since only READY_PICTUREs
758          * are handled. */
759         for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
760         {
761             if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
762                 && ( (p_picture == NULL) ||
763                      (PP_RENDERPICTURE[i_index]->date < display_date) ) )
764             {
765                 p_picture = PP_RENDERPICTURE[i_index];
766                 display_date = p_picture->date;
767             }
768         }
769
770         if( p_picture )
771         {
772             /* If we met the last picture, parse again to see whether there is
773              * a more appropriate one. */
774             if( p_picture == p_last_picture )
775             {
776                 for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
777                 {
778                     if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
779                         && (PP_RENDERPICTURE[i_index] != p_last_picture)
780                         && ((p_picture == p_last_picture) ||
781                             (PP_RENDERPICTURE[i_index]->date < display_date)) )
782                     {
783                         p_picture = PP_RENDERPICTURE[i_index];
784                         display_date = p_picture->date;
785                     }
786                 }
787             }
788
789             /* If we found better than the last picture, destroy it */
790             if( p_last_picture && p_picture != p_last_picture )
791             {
792                 vlc_mutex_lock( &p_vout->picture_lock );
793                 if( p_last_picture->i_refcount )
794                 {
795                     p_last_picture->i_status = DISPLAYED_PICTURE;
796                 }
797                 else
798                 {
799                     p_last_picture->i_status = DESTROYED_PICTURE;
800                     p_vout->i_heap_size--;
801                 }
802                 vlc_mutex_unlock( &p_vout->picture_lock );
803                 p_last_picture = NULL;
804             }
805
806             /* Compute FPS rate */
807             p_vout->p_fps_sample[ p_vout->c_fps_samples++ % VOUT_FPS_SAMPLES ]
808                 = display_date;
809
810             if( !p_picture->b_force &&
811                 p_picture != p_last_picture &&
812                 display_date < current_date + p_vout->render_time )
813             {
814                 /* Picture is late: it will be destroyed and the thread
815                  * will directly choose the next picture */
816                 vlc_mutex_lock( &p_vout->picture_lock );
817                 if( p_picture->i_refcount )
818                 {
819                     /* Pretend we displayed the picture, but don't destroy
820                      * it since the decoder might still need it. */
821                     p_picture->i_status = DISPLAYED_PICTURE;
822                 }
823                 else
824                 {
825                     /* Destroy the picture without displaying it */
826                     p_picture->i_status = DESTROYED_PICTURE;
827                     p_vout->i_heap_size--;
828                 }
829                 msg_Warn( p_vout, "late picture skipped ("I64Fd")",
830                                   current_date - display_date );
831                 vlc_mutex_unlock( &p_vout->picture_lock );
832
833                 continue;
834             }
835
836             if( display_date >
837                 current_date + p_vout->i_pts_delay + VOUT_BOGUS_DELAY )
838             {
839                 /* Picture is waaay too early: it will be destroyed */
840                 vlc_mutex_lock( &p_vout->picture_lock );
841                 if( p_picture->i_refcount )
842                 {
843                     /* Pretend we displayed the picture, but don't destroy
844                      * it since the decoder might still need it. */
845                     p_picture->i_status = DISPLAYED_PICTURE;
846                 }
847                 else
848                 {
849                     /* Destroy the picture without displaying it */
850                     p_picture->i_status = DESTROYED_PICTURE;
851                     p_vout->i_heap_size--;
852                 }
853                 msg_Warn( p_vout, "vout warning: early picture skipped "
854                           "("I64Fd")", display_date - current_date
855                           - p_vout->i_pts_delay );
856                 vlc_mutex_unlock( &p_vout->picture_lock );
857
858                 continue;
859             }
860
861             if( display_date > current_date + VOUT_DISPLAY_DELAY )
862             {
863                 /* A picture is ready to be rendered, but its rendering date
864                  * is far from the current one so the thread will perform an
865                  * empty loop as if no picture were found. The picture state
866                  * is unchanged */
867                 p_picture    = NULL;
868                 display_date = 0;
869             }
870             else if( p_picture == p_last_picture )
871             {
872                 /* We are asked to repeat the previous picture, but we first
873                  * wait for a couple of idle loops */
874                 if( i_idle_loops < 4 )
875                 {
876                     p_picture    = NULL;
877                     display_date = 0;
878                 }
879                 else
880                 {
881                     /* We set the display date to something high, otherwise
882                      * we'll have lots of problems with late pictures */
883                     display_date = current_date + p_vout->render_time;
884                 }
885             }
886         }
887
888         if( p_picture == NULL )
889         {
890             i_idle_loops++;
891         }
892
893         /*
894          * Check for subpictures to display
895          */
896         p_subpic = vout_SortSubPictures( p_vout, display_date );
897
898         /*
899          * Perform rendering
900          */
901         p_directbuffer = vout_RenderPicture( p_vout, p_picture, p_subpic );
902
903         /*
904          * Call the plugin-specific rendering method if there is one
905          */
906         if( p_picture != NULL && p_directbuffer != NULL && p_vout->pf_render )
907         {
908             /* Render the direct buffer returned by vout_RenderPicture */
909             p_vout->pf_render( p_vout, p_directbuffer );
910         }
911
912         /*
913          * Sleep, wake up
914          */
915         if( display_date != 0 && p_directbuffer != NULL )
916         {
917             mtime_t current_render_time = mdate() - current_date;
918             /* if render time is very large we don't include it in the mean */
919             if( current_render_time < p_vout->render_time +
920                 VOUT_DISPLAY_DELAY )
921             {
922                 /* Store render time using a sliding mean weighting to
923                  * current value in a 3 to 1 ratio*/
924                 p_vout->render_time *= 3;
925                 p_vout->render_time += current_render_time;
926                 p_vout->render_time >>= 2;
927             }
928         }
929
930         /* Give back change lock */
931         vlc_mutex_unlock( &p_vout->change_lock );
932
933         /* Sleep a while or until a given date */
934         if( display_date != 0 )
935         {
936             /* If there are filters in the chain, better give them the picture
937              * in advance */
938             if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
939             {
940                 mwait( display_date - VOUT_MWAIT_TOLERANCE );
941             }
942         }
943         else
944         {
945             msleep( VOUT_IDLE_SLEEP );
946         }
947
948         /* On awakening, take back lock and send immediately picture
949          * to display. */
950         vlc_mutex_lock( &p_vout->change_lock );
951
952         /*
953          * Display the previously rendered picture
954          */
955         if( p_picture != NULL && p_directbuffer != NULL )
956         {
957             /* Display the direct buffer returned by vout_RenderPicture */
958             if( p_vout->pf_display )
959             {
960                 p_vout->pf_display( p_vout, p_directbuffer );
961             }
962
963             /* Reinitialize idle loop count */
964             i_idle_loops = 0;
965
966             /* Tell the vout this was the last picture and that it does not
967              * need to be forced anymore. */
968             p_last_picture = p_picture;
969             p_last_picture->b_force = 0;
970         }
971
972         /*
973          * Check events and manage thread
974          */
975         if( p_vout->pf_manage && p_vout->pf_manage( p_vout ) )
976         {
977             /* A fatal error occured, and the thread must terminate
978              * immediately, without displaying anything - setting b_error to 1
979              * causes the immediate end of the main while() loop. */
980             p_vout->b_error = 1;
981         }
982
983         if( p_vout->i_changes & VOUT_SIZE_CHANGE )
984         {
985             /* this must only happen when the vout plugin is incapable of
986              * rescaling the picture itself. In this case we need to destroy
987              * the current picture buffers and recreate new ones with the right
988              * dimensions */
989             int i;
990
991             p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
992
993             p_vout->pf_end( p_vout );
994             for( i = 0; i < I_OUTPUTPICTURES; i++ )
995                  p_vout->p_picture[ i ].i_status = FREE_PICTURE;
996
997             I_OUTPUTPICTURES = 0;
998             if( p_vout->pf_init( p_vout ) )
999             {
1000                 msg_Err( p_vout, "cannot resize display" );
1001                 /* FIXME: pf_end will be called again in EndThread() */
1002                 p_vout->b_error = 1;
1003             }
1004
1005             /* Need to reinitialise the chroma plugin */
1006             if( p_vout->chroma.p_module )
1007             {
1008                 if( p_vout->chroma.p_module->pf_deactivate )
1009                     p_vout->chroma.p_module->pf_deactivate( VLC_OBJECT(p_vout) );
1010                 p_vout->chroma.p_module->pf_activate( VLC_OBJECT(p_vout) );
1011             }
1012         }
1013
1014         if( p_vout->i_changes & VOUT_PICTURE_BUFFERS_CHANGE )
1015         {
1016             /* This happens when the picture buffers need to be recreated.
1017              * This is useful on multimonitor displays for instance.
1018              *
1019              * Warning: This only works when the vout creates only 1 picture
1020              * buffer!! */
1021             p_vout->i_changes &= ~VOUT_PICTURE_BUFFERS_CHANGE;
1022
1023             if( !p_vout->b_direct )
1024             {
1025                 module_Unneed( p_vout, p_vout->chroma.p_module );
1026             }
1027
1028             vlc_mutex_lock( &p_vout->picture_lock );
1029
1030             p_vout->pf_end( p_vout );
1031
1032             I_OUTPUTPICTURES = I_RENDERPICTURES = 0;
1033
1034             p_vout->b_error = InitThread( p_vout );
1035
1036             vlc_mutex_unlock( &p_vout->picture_lock );
1037         }
1038     }
1039
1040     /*
1041      * Error loop - wait until the thread destruction is requested
1042      */
1043     if( p_vout->b_error )
1044     {
1045         ErrorThread( p_vout );
1046     }
1047
1048     /* End of thread */
1049     EndThread( p_vout );
1050
1051     /* Destroy thread structures allocated by CreateThread */
1052     DestroyThread( p_vout );
1053 }
1054
1055 /*****************************************************************************
1056  * ErrorThread: RunThread() error loop
1057  *****************************************************************************
1058  * This function is called when an error occured during thread main's loop. The
1059  * thread can still receive feed, but must be ready to terminate as soon as
1060  * possible.
1061  *****************************************************************************/
1062 static void ErrorThread( vout_thread_t *p_vout )
1063 {
1064     /* Wait until a `die' order */
1065     while( !p_vout->b_die )
1066     {
1067         /* Sleep a while */
1068         msleep( VOUT_IDLE_SLEEP );
1069     }
1070 }
1071
1072 /*****************************************************************************
1073  * EndThread: thread destruction
1074  *****************************************************************************
1075  * This function is called when the thread ends after a sucessful
1076  * initialization. It frees all resources allocated by InitThread.
1077  *****************************************************************************/
1078 static void EndThread( vout_thread_t *p_vout )
1079 {
1080     int     i_index;                                        /* index in heap */
1081
1082 #ifdef STATS
1083     {
1084         struct tms cpu_usage;
1085         times( &cpu_usage );
1086
1087         msg_Dbg( p_vout, "cpu usage (user: %d, system: %d)",
1088                  cpu_usage.tms_utime, cpu_usage.tms_stime );
1089     }
1090 #endif
1091
1092     if( !p_vout->b_direct )
1093     {
1094         module_Unneed( p_vout, p_vout->chroma.p_module );
1095     }
1096
1097     /* Destroy all remaining pictures */
1098     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++ )
1099     {
1100         if ( p_vout->p_picture[i_index].i_type == MEMORY_PICTURE )
1101         {
1102             free( p_vout->p_picture[i_index].p_data_orig );
1103         }
1104     }
1105
1106     /* Destroy subpicture unit */
1107     vout_DestroySPU( p_vout );
1108
1109     /* Destroy translation tables */
1110     p_vout->pf_end( p_vout );
1111
1112     /* Release the change lock */
1113     vlc_mutex_unlock( &p_vout->change_lock );
1114 }
1115
1116 /*****************************************************************************
1117  * DestroyThread: thread destruction
1118  *****************************************************************************
1119  * This function is called when the thread ends. It frees all ressources
1120  * allocated by CreateThread. Status is available at this stage.
1121  *****************************************************************************/
1122 static void DestroyThread( vout_thread_t *p_vout )
1123 {
1124     /* Destroy the locks */
1125     vlc_mutex_destroy( &p_vout->picture_lock );
1126     vlc_mutex_destroy( &p_vout->subpicture_lock );
1127     vlc_mutex_destroy( &p_vout->change_lock );
1128
1129     /* Release the module */
1130     if( p_vout && p_vout->p_module )
1131     {
1132         module_Unneed( p_vout, p_vout->p_module );
1133     }
1134 }
1135
1136 /* following functions are local */
1137
1138 static int ReduceHeight( int i_ratio )
1139 {
1140     int i_dummy = VOUT_ASPECT_FACTOR;
1141     int i_pgcd  = 1;
1142
1143     if( !i_ratio )
1144     {
1145         return i_pgcd;
1146     }
1147
1148     /* VOUT_ASPECT_FACTOR is (2^7 * 3^3 * 5^3), we just check for 2, 3 and 5 */
1149     while( !(i_ratio & 1) && !(i_dummy & 1) )
1150     {
1151         i_ratio >>= 1;
1152         i_dummy >>= 1;
1153         i_pgcd  <<= 1;
1154     }
1155
1156     while( !(i_ratio % 3) && !(i_dummy % 3) )
1157     {
1158         i_ratio /= 3;
1159         i_dummy /= 3;
1160         i_pgcd  *= 3;
1161     }
1162
1163     while( !(i_ratio % 5) && !(i_dummy % 5) )
1164     {
1165         i_ratio /= 5;
1166         i_dummy /= 5;
1167         i_pgcd  *= 5;
1168     }
1169
1170     return i_pgcd;
1171 }
1172
1173 /*****************************************************************************
1174  * BinaryLog: computes the base 2 log of a binary value
1175  *****************************************************************************
1176  * This functions is used by MaskToShift, to get a bit index from a binary
1177  * value.
1178  *****************************************************************************/
1179 static int BinaryLog( uint32_t i )
1180 {
1181     int i_log = 0;
1182
1183     if( i == 0 ) return -31337;
1184
1185     if( i & 0xffff0000 ) i_log += 16;
1186     if( i & 0xff00ff00 ) i_log += 8;
1187     if( i & 0xf0f0f0f0 ) i_log += 4;
1188     if( i & 0xcccccccc ) i_log += 2;
1189     if( i & 0xaaaaaaaa ) i_log += 1;
1190
1191     return i_log;
1192 }
1193
1194 /*****************************************************************************
1195  * MaskToShift: transform a color mask into right and left shifts
1196  *****************************************************************************
1197  * This function is used for obtaining color shifts from masks.
1198  *****************************************************************************/
1199 static void MaskToShift( int *pi_left, int *pi_right, uint32_t i_mask )
1200 {
1201     uint32_t i_low, i_high;            /* lower hand higher bits of the mask */
1202
1203     if( !i_mask )
1204     {
1205         *pi_left = *pi_right = 0;
1206         return;
1207     }
1208
1209     /* Get bits */
1210     i_low =  i_mask & (- (int32_t)i_mask);          /* lower bit of the mask */
1211     i_high = i_mask + i_low;                       /* higher bit of the mask */
1212
1213     /* Transform bits into an index */
1214     i_low =  BinaryLog (i_low);
1215     i_high = BinaryLog (i_high);
1216
1217     /* Update pointers and return */
1218     *pi_left =   i_low;
1219     *pi_right = (8 - i_high + i_low);
1220 }
1221
1222 /*****************************************************************************
1223  * InitWindowSize: find the initial dimensions the video window should have.
1224  *****************************************************************************
1225  * This function will check the "width", "height" and "zoom" config options and
1226  * will calculate the size that the video window should have.
1227  *****************************************************************************/
1228 static void InitWindowSize( vout_thread_t *p_vout, int *pi_width,
1229                             int *pi_height )
1230 {
1231     vlc_value_t val;
1232     int i_width, i_height;
1233     uint64_t ll_zoom;
1234
1235 #define FP_FACTOR 1000                             /* our fixed point factor */
1236
1237     var_Get( p_vout, "align", &val );
1238     p_vout->i_alignment = val.i_int;
1239
1240     var_Get( p_vout, "width", &val );
1241     i_width = val.i_int;
1242     var_Get( p_vout, "height", &val );
1243     i_height = val.i_int;
1244     var_Get( p_vout, "zoom", &val );
1245     ll_zoom = (uint64_t)( FP_FACTOR * val.f_float );
1246
1247     if( i_width > 0 && i_height > 0)
1248     {
1249         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1250         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1251         return;
1252     }
1253     else if( i_width > 0 )
1254     {
1255         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1256         *pi_height = (int)( i_width * ll_zoom * VOUT_ASPECT_FACTOR /
1257                             p_vout->render.i_aspect / FP_FACTOR );
1258         return;
1259     }
1260     else if( i_height > 0 )
1261     {
1262         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1263         *pi_width = (int)( i_height * ll_zoom * p_vout->render.i_aspect /
1264                            VOUT_ASPECT_FACTOR / FP_FACTOR );
1265         return;
1266     }
1267
1268     if( p_vout->render.i_height * p_vout->render.i_aspect
1269         >= p_vout->render.i_width * VOUT_ASPECT_FACTOR )
1270     {
1271         *pi_width = (int)( p_vout->render.i_height * ll_zoom
1272           * p_vout->render.i_aspect / VOUT_ASPECT_FACTOR / FP_FACTOR );
1273         *pi_height = (int)( p_vout->render.i_height * ll_zoom / FP_FACTOR );
1274     }
1275     else
1276     {
1277         *pi_width = (int)( p_vout->render.i_width * ll_zoom / FP_FACTOR );
1278         *pi_height = (int)( p_vout->render.i_width * ll_zoom
1279           * VOUT_ASPECT_FACTOR / p_vout->render.i_aspect / FP_FACTOR );
1280     }
1281
1282 #undef FP_FACTOR
1283 }
1284
1285 /*****************************************************************************
1286  * vout_VarCallback: generic callback for intf variables
1287  *****************************************************************************/
1288 int vout_VarCallback( vlc_object_t * p_this, const char * psz_variable,
1289                       vlc_value_t old_value, vlc_value_t new_value,
1290                       void * unused )
1291 {
1292     vout_thread_t * p_vout = (vout_thread_t *)p_this;
1293     vlc_value_t val;
1294     val.b_bool = VLC_TRUE;
1295     var_Set( p_vout, "intf-change", val );
1296     return VLC_SUCCESS;
1297 }
1298
1299 /*****************************************************************************
1300  * object variables callbacks: a bunch of object variables are used by the
1301  * interfaces to interact with the vout.
1302  *****************************************************************************/
1303 static int DeinterlaceCallback( vlc_object_t *p_this, char const *psz_cmd,
1304                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1305 {
1306     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1307     input_thread_t *p_input;
1308     vlc_value_t val;
1309
1310     char *psz_mode = newval.psz_string;
1311     char *psz_filter;
1312     unsigned int  i;
1313
1314     psz_filter = config_GetPsz( p_vout, "filter" );
1315
1316     if( !psz_mode || !*psz_mode )
1317     {
1318         config_PutPsz( p_vout, "filter", "" );
1319     }
1320     else
1321     {
1322         if( !psz_filter || !*psz_filter )
1323         {
1324             config_PutPsz( p_vout, "filter", "deinterlace" );
1325         }
1326         else
1327         {
1328             if( strstr( psz_filter, "deinterlace" ) == NULL )
1329             {
1330                 psz_filter = realloc( psz_filter, strlen( psz_filter ) + 20 );
1331                 strcat( psz_filter, ",deinterlace" );
1332             }
1333             config_PutPsz( p_vout, "filter", psz_filter );
1334         }
1335     }
1336
1337     if( psz_filter ) free( psz_filter );
1338
1339
1340     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1341                                                  FIND_PARENT );
1342     if( !p_input ) return VLC_EGENERIC;
1343
1344     if( psz_mode && *psz_mode )
1345     {
1346         val.psz_string = psz_mode;
1347         var_Set( p_vout, "deinterlace-mode", val );
1348         /* Modify input as well because the vout might have to be restarted */
1349         var_Create( p_input, "deinterlace-mode", VLC_VAR_STRING );
1350         var_Set( p_input, "deinterlace-mode", val );
1351     }
1352
1353     /* FIXME FIXME input2 --fenrir */
1354 #if 0
1355     /* now restart all video streams */
1356     vlc_mutex_lock( &p_input->stream.stream_lock );
1357
1358     p_vout->b_filter_change = VLC_TRUE;
1359
1360 #define ES p_input->stream.pp_es[i]
1361
1362     for( i = 0 ; i < p_input->stream.i_es_number ; i++ )
1363     {
1364         if( ( ES->i_cat == VIDEO_ES ) && ES->p_dec != NULL )
1365         {
1366             input_UnselectES( p_input, ES );
1367             input_SelectES( p_input, ES );
1368         }
1369 #undef ES
1370     }
1371     vlc_mutex_unlock( &p_input->stream.stream_lock );
1372
1373     vlc_object_release( p_input );
1374 #endif
1375
1376     val.b_bool = VLC_TRUE;
1377     var_Set( p_vout, "intf-change", val );
1378     return VLC_SUCCESS;
1379 }
1380
1381 static int FilterCallback( vlc_object_t *p_this, char const *psz_cmd,
1382                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1383 {
1384     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1385     input_thread_t *p_input;
1386     vlc_value_t val;
1387     unsigned int i;
1388
1389     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1390                                                  FIND_PARENT );
1391
1392     if (!p_input)
1393     {
1394         msg_Err( p_vout, "Input not found" );
1395         return( VLC_EGENERIC );
1396     }
1397
1398     /* FIXME FIXME input2 --fenrir */
1399 #if 0
1400     /* Restart the video stream */
1401     vlc_mutex_lock( &p_input->stream.stream_lock );
1402
1403     p_vout->b_filter_change = VLC_TRUE;
1404
1405 #define ES p_input->stream.pp_es[i]
1406
1407     for( i = 0 ; i < p_input->stream.i_es_number ; i++ )
1408     {
1409         if( ( ES->i_cat == VIDEO_ES ) && ES->p_dec != NULL )
1410         {
1411             input_UnselectES( p_input, ES );
1412             input_SelectES( p_input, ES );
1413         }
1414 #undef ES
1415     }
1416     vlc_mutex_unlock( &p_input->stream.stream_lock );
1417
1418     vlc_object_release( p_input );
1419 #endif
1420
1421     val.b_bool = VLC_TRUE;
1422     var_Set( p_vout, "intf-change", val );
1423     return VLC_SUCCESS;
1424 }