]> git.sesse.net Git - vlc/blob - src/video_output/video_output.c
* Spelling fixes.
[vlc] / src / video_output / video_output.c
1 /*****************************************************************************
2  * video_output.c : video output thread
3  * This module describes the programming interface for video output threads.
4  * It includes functions allowing to open a new thread, send pictures to a
5  * thread, and destroy a previously oppened video output thread.
6  *****************************************************************************
7  * Copyright (C) 2000-2004 VideoLAN
8  * $Id$
9  *
10  * Authors: Vincent Seguin <seguin@via.ecp.fr>
11  *
12  * This program is free software; you can redistribute it and/or modify
13  * it under the terms of the GNU General Public License as published by
14  * the Free Software Foundation; either version 2 of the License, or
15  * (at your option) any later version.
16  *
17  * This program is distributed in the hope that it will be useful,
18  * but WITHOUT ANY WARRANTY; without even the implied warranty of
19  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
20  * GNU General Public License for more details.
21  *
22  * You should have received a copy of the GNU General Public License
23  * along with this program; if not, write to the Free Software
24  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111, USA.
25  *****************************************************************************/
26
27 /*****************************************************************************
28  * Preamble
29  *****************************************************************************/
30 #include <stdlib.h>                                                /* free() */
31
32 #include <vlc/vlc.h>
33
34 #ifdef HAVE_SYS_TIMES_H
35 #   include <sys/times.h>
36 #endif
37
38 #include "vlc_video.h"
39 #include "video_output.h"
40 #include <vlc/input.h>                 /* for input_thread_t and i_pts_delay */
41
42 #if defined( SYS_DARWIN )
43 #include "darwin_specific.h"
44 #endif
45
46 /*****************************************************************************
47  * Local prototypes
48  *****************************************************************************/
49 static int      InitThread        ( vout_thread_t * );
50 static void     RunThread         ( vout_thread_t * );
51 static void     ErrorThread       ( vout_thread_t * );
52 static void     EndThread         ( vout_thread_t * );
53 static void     DestroyThread     ( vout_thread_t * );
54
55 static int      ReduceHeight      ( int );
56 static int      BinaryLog         ( uint32_t );
57 static void     MaskToShift       ( int *, int *, uint32_t );
58 static void     InitWindowSize    ( vout_thread_t *, int *, int * );
59
60 /* Object variables callbacks */
61 static int DeinterlaceCallback( vlc_object_t *, char const *,
62                                 vlc_value_t, vlc_value_t, void * );
63 static int FilterCallback( vlc_object_t *, char const *,
64                            vlc_value_t, vlc_value_t, void * );
65
66 /**
67  * vout_AspectRatio
68  *
69  * Set the i_aspect_x and i_aspect_y from i_aspect.
70  */
71 void vout_AspectRatio( unsigned int i_aspect,
72                        /*out*/ unsigned int *i_aspect_x,
73                        /*out*/ unsigned int *i_aspect_y )
74 {
75   unsigned int i_pgcd = ReduceHeight( i_aspect );
76   *i_aspect_x = i_aspect / i_pgcd;
77   *i_aspect_y = VOUT_ASPECT_FACTOR / i_pgcd;
78 }
79
80 /*****************************************************************************
81  * vout_Request: find a video output thread, create one, or destroy one.
82  *****************************************************************************
83  * This function looks for a video output thread matching the current
84  * properties. If not found, it spawns a new one.
85  *****************************************************************************/
86 vout_thread_t * __vout_Request ( vlc_object_t *p_this, vout_thread_t *p_vout,
87                                  unsigned int i_width, unsigned int i_height,
88                                  vlc_fourcc_t i_chroma, unsigned int i_aspect )
89 {
90     if( !i_width || !i_height || !i_chroma )
91     {
92         /* Reattach video output to input before bailing out */
93         if( p_vout )
94         {
95             vlc_object_t *p_playlist;
96
97             p_playlist = vlc_object_find( p_this, VLC_OBJECT_PLAYLIST,
98                                           FIND_ANYWHERE );
99
100             if( p_playlist )
101             {
102                 vout_AttachSPU( p_vout, VLC_FALSE );
103                 vlc_object_detach( p_vout );
104                 vlc_object_attach( p_vout, p_playlist );
105
106                 vlc_object_release( p_playlist );
107             }
108             else
109             {
110                 msg_Dbg( p_this, "cannot find playlist, destroying vout" );
111                 vlc_object_detach( p_vout );
112                 vout_Destroy( p_vout );
113             }
114         }
115         return NULL;
116     }
117
118     /* If a video output was provided, lock it, otherwise look for one. */
119     if( p_vout )
120     {
121         vlc_object_yield( p_vout );
122     }
123     else
124     {
125         p_vout = vlc_object_find( p_this, VLC_OBJECT_VOUT, FIND_CHILD );
126
127         if( !p_vout )
128         {
129             vlc_object_t *p_playlist;
130
131             p_playlist = vlc_object_find( p_this,
132                                           VLC_OBJECT_PLAYLIST, FIND_ANYWHERE );
133             if( p_playlist )
134             {
135                 p_vout = vlc_object_find( p_playlist,
136                                           VLC_OBJECT_VOUT, FIND_CHILD );
137                 /* only first children of p_input for unused vout */
138                 if( p_vout && p_vout->p_parent != p_playlist )
139                 {
140                     vlc_object_release( p_vout );
141                     p_vout = NULL;
142                 }
143                 vlc_object_release( p_playlist );
144             }
145         }
146     }
147
148     /* If we now have a video output, check it has the right properties */
149     if( p_vout )
150     {
151         char *psz_filter_chain;
152
153         /* We don't directly check for the "filter" variable for obvious
154          * performance reasons. */
155         if( p_vout->b_filter_change )
156         {
157             psz_filter_chain = config_GetPsz( p_this, "filter" );
158
159             if( psz_filter_chain && !*psz_filter_chain )
160             {
161                 free( psz_filter_chain );
162                 psz_filter_chain = NULL;
163             }
164             if( p_vout->psz_filter_chain && !*p_vout->psz_filter_chain )
165             {
166                 free( p_vout->psz_filter_chain );
167                 p_vout->psz_filter_chain = NULL;
168             }
169
170             if( ( !psz_filter_chain && !p_vout->psz_filter_chain ) ||
171                 ( psz_filter_chain && p_vout->psz_filter_chain &&
172                   !strcmp( psz_filter_chain, p_vout->psz_filter_chain ) ) )
173             {
174                 p_vout->b_filter_change = VLC_FALSE;
175             }
176
177             if( psz_filter_chain ) free( psz_filter_chain );
178         }
179
180         if( ( p_vout->render.i_width != i_width ) ||
181             ( p_vout->render.i_height != i_height ) ||
182             ( p_vout->render.i_chroma != i_chroma ) ||
183             ( p_vout->render.i_aspect != i_aspect
184                     && !p_vout->b_override_aspect ) ||
185             p_vout->b_filter_change )
186         {
187             /* We are not interested in this format, close this vout */
188             vlc_object_detach( p_vout );
189             vlc_object_release( p_vout );
190             vout_Destroy( p_vout );
191             p_vout = NULL;
192         }
193         else
194         {
195             /* This video output is cool! Hijack it. */
196             vlc_object_detach( p_vout );
197             vlc_object_attach( p_vout, p_this );
198             vout_AttachSPU( p_vout, VLC_TRUE );
199             vlc_object_release( p_vout );
200         }
201     }
202
203     if( !p_vout )
204     {
205         msg_Dbg( p_this, "no usable vout present, spawning one" );
206
207         p_vout = vout_Create( p_this, i_width, i_height, i_chroma, i_aspect );
208     }
209
210     return p_vout;
211 }
212
213 /*****************************************************************************
214  * vout_Create: creates a new video output thread
215  *****************************************************************************
216  * This function creates a new video output thread, and returns a pointer
217  * to its description. On error, it returns NULL.
218  *****************************************************************************/
219 vout_thread_t * __vout_Create( vlc_object_t *p_parent,
220                                unsigned int i_width, unsigned int i_height,
221                                vlc_fourcc_t i_chroma, unsigned int i_aspect )
222 {
223     vout_thread_t  * p_vout;                            /* thread descriptor */
224     input_thread_t * p_input_thread;
225     int              i_index;                               /* loop variable */
226     char           * psz_plugin;
227     vlc_value_t      val, text;
228
229     /* Allocate descriptor */
230     p_vout = vlc_object_create( p_parent, VLC_OBJECT_VOUT );
231     if( p_vout == NULL )
232     {
233         msg_Err( p_parent, "out of memory" );
234         return NULL;
235     }
236
237     /* Initialize pictures - translation tables and functions
238      * will be initialized later in InitThread */
239     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++)
240     {
241         p_vout->p_picture[i_index].pf_lock = NULL;
242         p_vout->p_picture[i_index].pf_unlock = NULL;
243         p_vout->p_picture[i_index].i_status = FREE_PICTURE;
244         p_vout->p_picture[i_index].i_type   = EMPTY_PICTURE;
245         p_vout->p_picture[i_index].b_slow   = 0;
246     }
247
248     /* No images in the heap */
249     p_vout->i_heap_size = 0;
250
251     /* Register the default subpicture channel */
252     p_vout->p_default_channel = NULL;
253     p_vout->i_channel_count = 1;
254
255     /* Initialize the rendering heap */
256     I_RENDERPICTURES = 0;
257     p_vout->render.i_width    = i_width;
258     p_vout->render.i_height   = i_height;
259     p_vout->render.i_chroma   = i_chroma;
260     p_vout->render.i_aspect   = i_aspect;
261
262     p_vout->render.i_rmask    = 0;
263     p_vout->render.i_gmask    = 0;
264     p_vout->render.i_bmask    = 0;
265
266     p_vout->render.i_last_used_pic = -1;
267     p_vout->render.b_allow_modify_pics = 1;
268
269     /* Zero the output heap */
270     I_OUTPUTPICTURES = 0;
271     p_vout->output.i_width    = 0;
272     p_vout->output.i_height   = 0;
273     p_vout->output.i_chroma   = 0;
274     p_vout->output.i_aspect   = 0;
275
276     p_vout->output.i_rmask    = 0;
277     p_vout->output.i_gmask    = 0;
278     p_vout->output.i_bmask    = 0;
279
280     /* Initialize misc stuff */
281     p_vout->i_changes    = 0;
282     p_vout->f_gamma      = 0;
283     p_vout->b_grayscale  = 0;
284     p_vout->b_info       = 0;
285     p_vout->b_interface  = 0;
286     p_vout->b_scale      = 1;
287     p_vout->b_fullscreen = 0;
288     p_vout->i_alignment  = 0;
289     p_vout->render_time  = 10;
290     p_vout->c_fps_samples = 0;
291     p_vout->b_filter_change = 0;
292     p_vout->pf_control = 0;
293     p_vout->p_parent_intf = 0;
294
295     /* Initialize locks */
296     vlc_mutex_init( p_vout, &p_vout->picture_lock );
297     vlc_mutex_init( p_vout, &p_vout->subpicture_lock );
298     vlc_mutex_init( p_vout, &p_vout->change_lock );
299
300     /* Mouse coordinates */
301     var_Create( p_vout, "mouse-x", VLC_VAR_INTEGER );
302     var_Create( p_vout, "mouse-y", VLC_VAR_INTEGER );
303     var_Create( p_vout, "mouse-button-down", VLC_VAR_INTEGER );
304     var_Create( p_vout, "mouse-moved", VLC_VAR_BOOL );
305     var_Create( p_vout, "mouse-clicked", VLC_VAR_INTEGER );
306
307     /* Attach the new object now so we can use var inheritance below */
308     vlc_object_attach( p_vout, p_parent );
309
310     /* Take care of some "interface/control" related initialisations */
311     vout_IntfInit( p_vout );
312
313     p_vout->b_override_aspect = VLC_FALSE;
314
315     /* If the parent is not a VOUT object, that means we are at the start of
316      * the video output pipe */
317     if( p_parent->i_object_type != VLC_OBJECT_VOUT )
318     {
319         var_Get( p_vout, "aspect-ratio", &val );
320
321         /* Check whether the user tried to override aspect ratio */
322         if( val.psz_string )
323         {
324             unsigned int i_new_aspect = i_aspect;
325             char *psz_parser = strchr( val.psz_string, ':' );
326
327             if( psz_parser )
328             {
329                 *psz_parser++ = '\0';
330                 i_new_aspect = atoi( val.psz_string ) * VOUT_ASPECT_FACTOR
331                                                       / atoi( psz_parser );
332             }
333             else
334             {
335                 i_new_aspect = i_width * VOUT_ASPECT_FACTOR
336                                        * atof( val.psz_string )
337                                        / i_height;
338             }
339
340             free( val.psz_string );
341
342             if( i_new_aspect && i_new_aspect != i_aspect )
343             {
344                 unsigned int i_aspect_x, i_aspect_y;
345
346                 vout_AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
347
348                 msg_Dbg( p_vout, "overriding source aspect ratio to %i:%i",
349                          i_aspect_x, i_aspect_y );
350
351                 p_vout->render.i_aspect = i_new_aspect;
352
353                 p_vout->b_override_aspect = VLC_TRUE;
354             }
355         }
356
357         /* Look for the default filter configuration */
358         var_Create( p_vout, "filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
359         var_Get( p_vout, "filter", &val );
360         p_vout->psz_filter_chain = val.psz_string;
361     }
362     else
363     {
364         /* continue the parent's filter chain */
365         char *psz_end;
366
367         psz_end = strchr( ((vout_thread_t *)p_parent)->psz_filter_chain, ':' );
368         if( psz_end && *(psz_end+1) )
369             p_vout->psz_filter_chain = strdup( psz_end+1 );
370         else p_vout->psz_filter_chain = NULL;
371     }
372
373     /* Choose the video output module */
374     if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
375     {
376         var_Create( p_vout, "vout", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
377         var_Get( p_vout, "vout", &val );
378         psz_plugin = val.psz_string;
379     }
380     else
381     {
382         /* the filter chain is a string list of filters separated by double
383          * colons */
384         char *psz_end;
385
386         psz_end = strchr( p_vout->psz_filter_chain, ':' );
387         if( psz_end )
388             psz_plugin = strndup( p_vout->psz_filter_chain,
389                                   psz_end - p_vout->psz_filter_chain );
390         else psz_plugin = strdup( p_vout->psz_filter_chain );
391     }
392
393     /* Initialize the dimensions of the video window */
394     InitWindowSize( p_vout, &p_vout->i_window_width,
395                     &p_vout->i_window_height );
396
397     /* Create the vout thread */
398     p_vout->p_module = module_Need( p_vout,
399         ( p_vout->psz_filter_chain && *p_vout->psz_filter_chain ) ?
400         "video filter" : "video output", psz_plugin, 0 );
401
402     if( psz_plugin ) free( psz_plugin );
403     if( p_vout->p_module == NULL )
404     {
405         msg_Err( p_vout, "no suitable vout module" );
406         vlc_object_detach( p_vout );
407         vlc_object_destroy( p_vout );
408         return NULL;
409     }
410
411     /* Initialize subpicture unit */
412     vout_InitSPU( p_vout );
413
414     /* Create a few object variables for interface interaction */
415     var_Create( p_vout, "deinterlace", VLC_VAR_STRING | VLC_VAR_HASCHOICE );
416     text.psz_string = _("Deinterlace");
417     var_Change( p_vout, "deinterlace", VLC_VAR_SETTEXT, &text, NULL );
418     val.psz_string = ""; text.psz_string = _("Disable");
419     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
420     val.psz_string = "discard"; text.psz_string = _("Discard");
421     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
422     val.psz_string = "blend"; text.psz_string = _("Blend");
423     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
424     val.psz_string = "mean"; text.psz_string = _("Mean");
425     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
426     val.psz_string = "bob"; text.psz_string = _("Bob");
427     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
428     val.psz_string = "linear"; text.psz_string = _("Linear");
429     var_Change( p_vout, "deinterlace", VLC_VAR_ADDCHOICE, &val, &text );
430     if( var_Get( p_vout, "deinterlace-mode", &val ) == VLC_SUCCESS )
431     {
432         var_Set( p_vout, "deinterlace", val );
433         if( val.psz_string ) free( val.psz_string );
434     }
435     var_AddCallback( p_vout, "deinterlace", DeinterlaceCallback, NULL );
436
437
438     var_Create( p_vout, "filter", VLC_VAR_STRING );
439     text.psz_string = _("Filters");
440     var_Change( p_vout, "filter", VLC_VAR_SETTEXT, &text, NULL );
441     var_Change( p_vout, "filter", VLC_VAR_INHERITVALUE, &val, NULL );
442     if( val.psz_string )
443     {
444         var_Set( p_vout, "filter", val );
445         free( val.psz_string );
446     }
447     var_AddCallback( p_vout, "filter", FilterCallback, NULL );
448
449     /* Calculate delay created by internal caching */
450     p_input_thread = (input_thread_t *)vlc_object_find( p_vout,
451                                            VLC_OBJECT_INPUT, FIND_ANYWHERE );
452     if( p_input_thread )
453     {
454         p_vout->i_pts_delay = p_input_thread->i_pts_delay;
455         vlc_object_release( p_input_thread );
456     }
457     else
458     {
459         p_vout->i_pts_delay = DEFAULT_PTS_DELAY;
460     }
461
462     if( vlc_thread_create( p_vout, "video output", RunThread,
463                            VLC_THREAD_PRIORITY_OUTPUT, VLC_TRUE ) )
464     {
465         msg_Err( p_vout, "out of memory" );
466         module_Unneed( p_vout, p_vout->p_module );
467         vlc_object_detach( p_vout );
468         vlc_object_destroy( p_vout );
469         return NULL;
470     }
471
472     if( p_vout->b_error )
473     {
474         msg_Err( p_vout, "video output creation failed" );
475
476         /* Make sure the thread is destroyed */
477         p_vout->b_die = VLC_TRUE;
478
479         vlc_thread_join( p_vout );
480
481         vlc_object_detach( p_vout );
482         vlc_object_destroy( p_vout );
483         return NULL;
484     }
485
486     return p_vout;
487 }
488
489 /*****************************************************************************
490  * vout_Destroy: destroys a previously created video output
491  *****************************************************************************
492  * Destroy a terminated thread.
493  * The function will request a destruction of the specified thread. If pi_error
494  * is NULL, it will return once the thread is destroyed. Else, it will be
495  * update using one of the THREAD_* constants.
496  *****************************************************************************/
497 void vout_Destroy( vout_thread_t *p_vout )
498 {
499     vlc_object_t *p_playlist;
500
501     /* Request thread destruction */
502     p_vout->b_die = VLC_TRUE;
503     vlc_thread_join( p_vout );
504
505     var_Destroy( p_vout, "intf-change" );
506
507     p_playlist = vlc_object_find( p_vout, VLC_OBJECT_PLAYLIST,
508                                   FIND_ANYWHERE );
509
510     if( p_vout->psz_filter_chain ) free( p_vout->psz_filter_chain );
511
512     /* Free structure */
513     vlc_object_destroy( p_vout );
514
515     /* If it was the last vout, tell the interface to show up */
516     if( p_playlist != NULL )
517     {
518         vout_thread_t *p_another_vout = vlc_object_find( p_playlist,
519                                             VLC_OBJECT_VOUT, FIND_ANYWHERE );
520         if( p_another_vout == NULL )
521         {
522             vlc_value_t val;
523             val.b_bool = VLC_TRUE;
524             var_Set( p_playlist, "intf-show", val );
525         }
526         else
527         {
528             vlc_object_release( p_another_vout );
529         }
530         vlc_object_release( p_playlist );
531     }
532 }
533
534 /*****************************************************************************
535  * InitThread: initialize video output thread
536  *****************************************************************************
537  * This function is called from RunThread and performs the second step of the
538  * initialization. It returns 0 on success. Note that the thread's flag are not
539  * modified inside this function.
540  *****************************************************************************/
541 static int InitThread( vout_thread_t *p_vout )
542 {
543     int i;
544     unsigned int i_aspect_x, i_aspect_y;
545
546     vlc_mutex_lock( &p_vout->change_lock );
547
548 #ifdef STATS
549     p_vout->c_loops = 0;
550 #endif
551
552     /* Initialize output method, it allocates direct buffers for us */
553     if( p_vout->pf_init( p_vout ) )
554     {
555         vlc_mutex_unlock( &p_vout->change_lock );
556         return VLC_EGENERIC;
557     }
558
559     if( !I_OUTPUTPICTURES )
560     {
561         msg_Err( p_vout, "plugin was unable to allocate at least "
562                          "one direct buffer" );
563         p_vout->pf_end( p_vout );
564         vlc_mutex_unlock( &p_vout->change_lock );
565         return VLC_EGENERIC;
566     }
567
568     if( I_OUTPUTPICTURES > VOUT_MAX_PICTURES )
569     {
570         msg_Err( p_vout, "plugin allocated too many direct buffers, "
571                          "our internal buffers must have overflown." );
572         p_vout->pf_end( p_vout );
573         vlc_mutex_unlock( &p_vout->change_lock );
574         return VLC_EGENERIC;
575     }
576
577     msg_Dbg( p_vout, "got %i direct buffer(s)", I_OUTPUTPICTURES );
578
579 #if 0
580     if( !p_vout->psz_filter_chain )
581     {
582         char *psz_aspect = config_GetPsz( p_vout, "pixel-ratio" );
583
584         if( psz_aspect )
585         {
586             int i_new_aspect = p_vout->output.i_width * VOUT_ASPECT_FACTOR
587                                                       * atof( psz_aspect )
588                                                       / p_vout->output.i_height;
589             free( psz_aspect );
590
591             if( i_new_aspect && i_new_aspect != p_vout->output.i_aspect )
592             {
593                 vout_AspectRatio( i_new_aspect, &i_aspect_x, &i_aspect_y );
594
595                 msg_Dbg( p_vout, "output ratio forced to %i:%i\n",
596                          i_aspect_x, i_aspect_y );
597                 p_vout->output.i_aspect = i_new_aspect;
598             }
599         }
600     }
601 #endif
602
603     vout_AspectRatio( p_vout->render.i_aspect, &i_aspect_x, &i_aspect_y );
604     msg_Dbg( p_vout,
605              "picture in %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
606              p_vout->render.i_width, p_vout->render.i_height,
607              p_vout->render.i_chroma, (char*)&p_vout->render.i_chroma,
608              i_aspect_x, i_aspect_y );
609
610     vout_AspectRatio( p_vout->output.i_aspect, &i_aspect_x, &i_aspect_y );
611     msg_Dbg( p_vout,
612              "picture out %ix%i, chroma 0x%.8x (%4.4s), aspect ratio %i:%i",
613              p_vout->output.i_width, p_vout->output.i_height,
614              p_vout->output.i_chroma, (char*)&p_vout->output.i_chroma,
615              i_aspect_x, i_aspect_y );
616
617     /* Calculate shifts from system-updated masks */
618     MaskToShift( &p_vout->output.i_lrshift, &p_vout->output.i_rrshift,
619                  p_vout->output.i_rmask );
620     MaskToShift( &p_vout->output.i_lgshift, &p_vout->output.i_rgshift,
621                  p_vout->output.i_gmask );
622     MaskToShift( &p_vout->output.i_lbshift, &p_vout->output.i_rbshift,
623                  p_vout->output.i_bmask );
624
625     /* Check whether we managed to create direct buffers similar to
626      * the render buffers, ie same size and chroma */
627     if( ( p_vout->output.i_width == p_vout->render.i_width )
628      && ( p_vout->output.i_height == p_vout->render.i_height )
629      && ( vout_ChromaCmp( p_vout->output.i_chroma, p_vout->render.i_chroma ) ) )
630     {
631         /* Cool ! We have direct buffers, we can ask the decoder to
632          * directly decode into them ! Map the first render buffers to
633          * the first direct buffers, but keep the first direct buffer
634          * for memcpy operations */
635         p_vout->b_direct = 1;
636
637         for( i = 1; i < VOUT_MAX_PICTURES; i++ )
638         {
639             if( p_vout->p_picture[ i ].i_type != DIRECT_PICTURE &&
640                 I_RENDERPICTURES >= VOUT_MIN_DIRECT_PICTURES - 1 &&
641                 p_vout->p_picture[ i - 1 ].i_type == DIRECT_PICTURE )
642             {
643                 /* We have enough direct buffers so there's no need to
644                  * try to use system memory buffers. */
645                 break;
646             }
647             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
648             I_RENDERPICTURES++;
649         }
650
651         msg_Dbg( p_vout, "direct render, mapping "
652                  "render pictures 0-%i to system pictures 1-%i",
653                  VOUT_MAX_PICTURES - 2, VOUT_MAX_PICTURES - 1 );
654     }
655     else
656     {
657         /* Rats... Something is wrong here, we could not find an output
658          * plugin able to directly render what we decode. See if we can
659          * find a chroma plugin to do the conversion */
660         p_vout->b_direct = 0;
661
662         /* Choose the best module */
663         p_vout->chroma.p_module = module_Need( p_vout, "chroma", NULL, 0 );
664
665         if( p_vout->chroma.p_module == NULL )
666         {
667             msg_Err( p_vout, "no chroma module for %4.4s to %4.4s",
668                      (char*)&p_vout->render.i_chroma,
669                      (char*)&p_vout->output.i_chroma );
670             p_vout->pf_end( p_vout );
671             vlc_mutex_unlock( &p_vout->change_lock );
672             return VLC_EGENERIC;
673         }
674
675         msg_Dbg( p_vout, "indirect render, mapping "
676                  "render pictures 0-%i to system pictures %i-%i",
677                  VOUT_MAX_PICTURES - 1, I_OUTPUTPICTURES,
678                  I_OUTPUTPICTURES + VOUT_MAX_PICTURES - 1 );
679
680         /* Append render buffers after the direct buffers */
681         for( i = I_OUTPUTPICTURES; i < 2 * VOUT_MAX_PICTURES; i++ )
682         {
683             PP_RENDERPICTURE[ I_RENDERPICTURES ] = &p_vout->p_picture[ i ];
684             I_RENDERPICTURES++;
685
686             /* Check if we have enough render pictures */
687             if( I_RENDERPICTURES == VOUT_MAX_PICTURES )
688                 break;
689         }
690     }
691
692     /* Link pictures back to their heap */
693     for( i = 0 ; i < I_RENDERPICTURES ; i++ )
694     {
695         PP_RENDERPICTURE[ i ]->p_heap = &p_vout->render;
696     }
697
698     for( i = 0 ; i < I_OUTPUTPICTURES ; i++ )
699     {
700         PP_OUTPUTPICTURE[ i ]->p_heap = &p_vout->output;
701     }
702
703 /* XXX XXX mark thread ready */
704     return VLC_SUCCESS;
705 }
706
707 /*****************************************************************************
708  * RunThread: video output thread
709  *****************************************************************************
710  * Video output thread. This function does only returns when the thread is
711  * terminated. It handles the pictures arriving in the video heap and the
712  * display device events.
713  *****************************************************************************/
714 static void RunThread( vout_thread_t *p_vout)
715 {
716     int             i_index;                                /* index in heap */
717     int             i_idle_loops = 0;  /* loops without displaying a picture */
718     mtime_t         current_date;                            /* current date */
719     mtime_t         display_date;                            /* display date */
720
721     picture_t *     p_picture;                            /* picture pointer */
722     picture_t *     p_last_picture = NULL;                   /* last picture */
723     picture_t *     p_directbuffer;              /* direct buffer to display */
724
725     subpicture_t *  p_subpic;                          /* subpicture pointer */
726
727     /*
728      * Initialize thread
729      */
730     p_vout->b_error = InitThread( p_vout );
731
732     /* signal the creation of the vout */
733     vlc_thread_ready( p_vout );
734
735     if( p_vout->b_error )
736     {
737         /* Destroy thread structures allocated by Create and InitThread */
738         DestroyThread( p_vout );
739         return;
740     }
741
742     /*
743      * Main loop - it is not executed if an error occurred during
744      * initialization
745      */
746     while( (!p_vout->b_die) && (!p_vout->b_error) )
747     {
748         /* Initialize loop variables */
749         p_picture = NULL;
750         display_date = 0;
751         current_date = mdate();
752
753 #if 0
754         p_vout->c_loops++;
755         if( !(p_vout->c_loops % VOUT_STATS_NB_LOOPS) )
756         {
757             msg_Dbg( p_vout, "picture heap: %d/%d",
758                      I_RENDERPICTURES, p_vout->i_heap_size );
759         }
760 #endif
761
762         /*
763          * Find the picture to display (the one with the earliest date).
764          * This operation does not need lock, since only READY_PICTUREs
765          * are handled. */
766         for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
767         {
768             if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
769                 && ( (p_picture == NULL) ||
770                      (PP_RENDERPICTURE[i_index]->date < display_date) ) )
771             {
772                 p_picture = PP_RENDERPICTURE[i_index];
773                 display_date = p_picture->date;
774             }
775         }
776
777         if( p_picture )
778         {
779             /* If we met the last picture, parse again to see whether there is
780              * a more appropriate one. */
781             if( p_picture == p_last_picture )
782             {
783                 for( i_index = 0; i_index < I_RENDERPICTURES; i_index++ )
784                 {
785                     if( (PP_RENDERPICTURE[i_index]->i_status == READY_PICTURE)
786                         && (PP_RENDERPICTURE[i_index] != p_last_picture)
787                         && ((p_picture == p_last_picture) ||
788                             (PP_RENDERPICTURE[i_index]->date < display_date)) )
789                     {
790                         p_picture = PP_RENDERPICTURE[i_index];
791                         display_date = p_picture->date;
792                     }
793                 }
794             }
795
796             /* If we found better than the last picture, destroy it */
797             if( p_last_picture && p_picture != p_last_picture )
798             {
799                 vlc_mutex_lock( &p_vout->picture_lock );
800                 if( p_last_picture->i_refcount )
801                 {
802                     p_last_picture->i_status = DISPLAYED_PICTURE;
803                 }
804                 else
805                 {
806                     p_last_picture->i_status = DESTROYED_PICTURE;
807                     p_vout->i_heap_size--;
808                 }
809                 vlc_mutex_unlock( &p_vout->picture_lock );
810                 p_last_picture = NULL;
811             }
812
813             /* Compute FPS rate */
814             p_vout->p_fps_sample[ p_vout->c_fps_samples++ % VOUT_FPS_SAMPLES ]
815                 = display_date;
816
817             if( !p_picture->b_force &&
818                 p_picture != p_last_picture &&
819                 display_date < current_date + p_vout->render_time )
820             {
821                 /* Picture is late: it will be destroyed and the thread
822                  * will directly choose the next picture */
823                 vlc_mutex_lock( &p_vout->picture_lock );
824                 if( p_picture->i_refcount )
825                 {
826                     /* Pretend we displayed the picture, but don't destroy
827                      * it since the decoder might still need it. */
828                     p_picture->i_status = DISPLAYED_PICTURE;
829                 }
830                 else
831                 {
832                     /* Destroy the picture without displaying it */
833                     p_picture->i_status = DESTROYED_PICTURE;
834                     p_vout->i_heap_size--;
835                 }
836                 msg_Warn( p_vout, "late picture skipped ("I64Fd")",
837                                   current_date - display_date );
838                 vlc_mutex_unlock( &p_vout->picture_lock );
839
840                 continue;
841             }
842
843             if( display_date >
844                 current_date + p_vout->i_pts_delay + VOUT_BOGUS_DELAY )
845             {
846                 /* Picture is waaay too early: it will be destroyed */
847                 vlc_mutex_lock( &p_vout->picture_lock );
848                 if( p_picture->i_refcount )
849                 {
850                     /* Pretend we displayed the picture, but don't destroy
851                      * it since the decoder might still need it. */
852                     p_picture->i_status = DISPLAYED_PICTURE;
853                 }
854                 else
855                 {
856                     /* Destroy the picture without displaying it */
857                     p_picture->i_status = DESTROYED_PICTURE;
858                     p_vout->i_heap_size--;
859                 }
860                 msg_Warn( p_vout, "vout warning: early picture skipped "
861                           "("I64Fd")", display_date - current_date
862                           - p_vout->i_pts_delay );
863                 vlc_mutex_unlock( &p_vout->picture_lock );
864
865                 continue;
866             }
867
868             if( display_date > current_date + VOUT_DISPLAY_DELAY )
869             {
870                 /* A picture is ready to be rendered, but its rendering date
871                  * is far from the current one so the thread will perform an
872                  * empty loop as if no picture were found. The picture state
873                  * is unchanged */
874                 p_picture    = NULL;
875                 display_date = 0;
876             }
877             else if( p_picture == p_last_picture )
878             {
879                 /* We are asked to repeat the previous picture, but we first
880                  * wait for a couple of idle loops */
881                 if( i_idle_loops < 4 )
882                 {
883                     p_picture    = NULL;
884                     display_date = 0;
885                 }
886                 else
887                 {
888                     /* We set the display date to something high, otherwise
889                      * we'll have lots of problems with late pictures */
890                     display_date = current_date + p_vout->render_time;
891                 }
892             }
893         }
894
895         if( p_picture == NULL )
896         {
897             i_idle_loops++;
898         }
899
900         /*
901          * Check for subpictures to display
902          */
903         p_subpic = vout_SortSubPictures( p_vout, display_date );
904
905         /*
906          * Perform rendering
907          */
908         p_directbuffer = vout_RenderPicture( p_vout, p_picture, p_subpic );
909
910         /*
911          * Call the plugin-specific rendering method if there is one
912          */
913         if( p_picture != NULL && p_directbuffer != NULL && p_vout->pf_render )
914         {
915             /* Render the direct buffer returned by vout_RenderPicture */
916             p_vout->pf_render( p_vout, p_directbuffer );
917         }
918
919         /*
920          * Sleep, wake up
921          */
922         if( display_date != 0 && p_directbuffer != NULL )
923         {
924             mtime_t current_render_time = mdate() - current_date;
925             /* if render time is very large we don't include it in the mean */
926             if( current_render_time < p_vout->render_time +
927                 VOUT_DISPLAY_DELAY )
928             {
929                 /* Store render time using a sliding mean weighting to
930                  * current value in a 3 to 1 ratio*/
931                 p_vout->render_time *= 3;
932                 p_vout->render_time += current_render_time;
933                 p_vout->render_time >>= 2;
934             }
935         }
936
937         /* Give back change lock */
938         vlc_mutex_unlock( &p_vout->change_lock );
939
940         /* Sleep a while or until a given date */
941         if( display_date != 0 )
942         {
943             /* If there are filters in the chain, better give them the picture
944              * in advance */
945             if( !p_vout->psz_filter_chain || !*p_vout->psz_filter_chain )
946             {
947                 mwait( display_date - VOUT_MWAIT_TOLERANCE );
948             }
949         }
950         else
951         {
952             msleep( VOUT_IDLE_SLEEP );
953         }
954
955         /* On awakening, take back lock and send immediately picture
956          * to display. */
957         vlc_mutex_lock( &p_vout->change_lock );
958
959         /*
960          * Display the previously rendered picture
961          */
962         if( p_picture != NULL && p_directbuffer != NULL )
963         {
964             /* Display the direct buffer returned by vout_RenderPicture */
965             if( p_vout->pf_display )
966             {
967                 p_vout->pf_display( p_vout, p_directbuffer );
968             }
969
970             /* Reinitialize idle loop count */
971             i_idle_loops = 0;
972
973             /* Tell the vout this was the last picture and that it does not
974              * need to be forced anymore. */
975             p_last_picture = p_picture;
976             p_last_picture->b_force = 0;
977         }
978
979         /*
980          * Check events and manage thread
981          */
982         if( p_vout->pf_manage && p_vout->pf_manage( p_vout ) )
983         {
984             /* A fatal error occurred, and the thread must terminate
985              * immediately, without displaying anything - setting b_error to 1
986              * causes the immediate end of the main while() loop. */
987             p_vout->b_error = 1;
988         }
989
990         if( p_vout->i_changes & VOUT_SIZE_CHANGE )
991         {
992             /* this must only happen when the vout plugin is incapable of
993              * rescaling the picture itself. In this case we need to destroy
994              * the current picture buffers and recreate new ones with the right
995              * dimensions */
996             int i;
997
998             p_vout->i_changes &= ~VOUT_SIZE_CHANGE;
999
1000             p_vout->pf_end( p_vout );
1001             for( i = 0; i < I_OUTPUTPICTURES; i++ )
1002                  p_vout->p_picture[ i ].i_status = FREE_PICTURE;
1003
1004             I_OUTPUTPICTURES = 0;
1005             if( p_vout->pf_init( p_vout ) )
1006             {
1007                 msg_Err( p_vout, "cannot resize display" );
1008                 /* FIXME: pf_end will be called again in EndThread() */
1009                 p_vout->b_error = 1;
1010             }
1011
1012             /* Need to reinitialise the chroma plugin */
1013             if( p_vout->chroma.p_module )
1014             {
1015                 if( p_vout->chroma.p_module->pf_deactivate )
1016                     p_vout->chroma.p_module->pf_deactivate( VLC_OBJECT(p_vout) );
1017                 p_vout->chroma.p_module->pf_activate( VLC_OBJECT(p_vout) );
1018             }
1019         }
1020
1021         if( p_vout->i_changes & VOUT_PICTURE_BUFFERS_CHANGE )
1022         {
1023             /* This happens when the picture buffers need to be recreated.
1024              * This is useful on multimonitor displays for instance.
1025              *
1026              * Warning: This only works when the vout creates only 1 picture
1027              * buffer!! */
1028             p_vout->i_changes &= ~VOUT_PICTURE_BUFFERS_CHANGE;
1029
1030             if( !p_vout->b_direct )
1031             {
1032                 module_Unneed( p_vout, p_vout->chroma.p_module );
1033             }
1034
1035             vlc_mutex_lock( &p_vout->picture_lock );
1036
1037             p_vout->pf_end( p_vout );
1038
1039             I_OUTPUTPICTURES = I_RENDERPICTURES = 0;
1040
1041             p_vout->b_error = InitThread( p_vout );
1042
1043             vlc_mutex_unlock( &p_vout->picture_lock );
1044         }
1045     }
1046
1047     /*
1048      * Error loop - wait until the thread destruction is requested
1049      */
1050     if( p_vout->b_error )
1051     {
1052         ErrorThread( p_vout );
1053     }
1054
1055     /* End of thread */
1056     EndThread( p_vout );
1057
1058     /* Destroy thread structures allocated by CreateThread */
1059     DestroyThread( p_vout );
1060 }
1061
1062 /*****************************************************************************
1063  * ErrorThread: RunThread() error loop
1064  *****************************************************************************
1065  * This function is called when an error occurred during thread main's loop.
1066  * The thread can still receive feed, but must be ready to terminate as soon
1067  * as possible.
1068  *****************************************************************************/
1069 static void ErrorThread( vout_thread_t *p_vout )
1070 {
1071     /* Wait until a `die' order */
1072     while( !p_vout->b_die )
1073     {
1074         /* Sleep a while */
1075         msleep( VOUT_IDLE_SLEEP );
1076     }
1077 }
1078
1079 /*****************************************************************************
1080  * EndThread: thread destruction
1081  *****************************************************************************
1082  * This function is called when the thread ends after a sucessful
1083  * initialization. It frees all resources allocated by InitThread.
1084  *****************************************************************************/
1085 static void EndThread( vout_thread_t *p_vout )
1086 {
1087     int     i_index;                                        /* index in heap */
1088
1089 #ifdef STATS
1090     {
1091         struct tms cpu_usage;
1092         times( &cpu_usage );
1093
1094         msg_Dbg( p_vout, "cpu usage (user: %d, system: %d)",
1095                  cpu_usage.tms_utime, cpu_usage.tms_stime );
1096     }
1097 #endif
1098
1099     if( !p_vout->b_direct )
1100     {
1101         module_Unneed( p_vout, p_vout->chroma.p_module );
1102     }
1103
1104     /* Destroy all remaining pictures */
1105     for( i_index = 0; i_index < 2 * VOUT_MAX_PICTURES + 1; i_index++ )
1106     {
1107         if ( p_vout->p_picture[i_index].i_type == MEMORY_PICTURE )
1108         {
1109             free( p_vout->p_picture[i_index].p_data_orig );
1110         }
1111     }
1112
1113     /* Destroy subpicture unit */
1114     vout_DestroySPU( p_vout );
1115
1116     /* Destroy translation tables */
1117     p_vout->pf_end( p_vout );
1118
1119     /* Release the change lock */
1120     vlc_mutex_unlock( &p_vout->change_lock );
1121 }
1122
1123 /*****************************************************************************
1124  * DestroyThread: thread destruction
1125  *****************************************************************************
1126  * This function is called when the thread ends. It frees all ressources
1127  * allocated by CreateThread. Status is available at this stage.
1128  *****************************************************************************/
1129 static void DestroyThread( vout_thread_t *p_vout )
1130 {
1131     /* Destroy the locks */
1132     vlc_mutex_destroy( &p_vout->picture_lock );
1133     vlc_mutex_destroy( &p_vout->subpicture_lock );
1134     vlc_mutex_destroy( &p_vout->change_lock );
1135
1136     /* Release the module */
1137     if( p_vout && p_vout->p_module )
1138     {
1139         module_Unneed( p_vout, p_vout->p_module );
1140     }
1141 }
1142
1143 /* following functions are local */
1144
1145 static int ReduceHeight( int i_ratio )
1146 {
1147     int i_dummy = VOUT_ASPECT_FACTOR;
1148     int i_pgcd  = 1;
1149
1150     if( !i_ratio )
1151     {
1152         return i_pgcd;
1153     }
1154
1155     /* VOUT_ASPECT_FACTOR is (2^7 * 3^3 * 5^3), we just check for 2, 3 and 5 */
1156     while( !(i_ratio & 1) && !(i_dummy & 1) )
1157     {
1158         i_ratio >>= 1;
1159         i_dummy >>= 1;
1160         i_pgcd  <<= 1;
1161     }
1162
1163     while( !(i_ratio % 3) && !(i_dummy % 3) )
1164     {
1165         i_ratio /= 3;
1166         i_dummy /= 3;
1167         i_pgcd  *= 3;
1168     }
1169
1170     while( !(i_ratio % 5) && !(i_dummy % 5) )
1171     {
1172         i_ratio /= 5;
1173         i_dummy /= 5;
1174         i_pgcd  *= 5;
1175     }
1176
1177     return i_pgcd;
1178 }
1179
1180 /*****************************************************************************
1181  * BinaryLog: computes the base 2 log of a binary value
1182  *****************************************************************************
1183  * This functions is used by MaskToShift, to get a bit index from a binary
1184  * value.
1185  *****************************************************************************/
1186 static int BinaryLog( uint32_t i )
1187 {
1188     int i_log = 0;
1189
1190     if( i == 0 ) return -31337;
1191
1192     if( i & 0xffff0000 ) i_log += 16;
1193     if( i & 0xff00ff00 ) i_log += 8;
1194     if( i & 0xf0f0f0f0 ) i_log += 4;
1195     if( i & 0xcccccccc ) i_log += 2;
1196     if( i & 0xaaaaaaaa ) i_log += 1;
1197
1198     return i_log;
1199 }
1200
1201 /*****************************************************************************
1202  * MaskToShift: transform a color mask into right and left shifts
1203  *****************************************************************************
1204  * This function is used for obtaining color shifts from masks.
1205  *****************************************************************************/
1206 static void MaskToShift( int *pi_left, int *pi_right, uint32_t i_mask )
1207 {
1208     uint32_t i_low, i_high;            /* lower hand higher bits of the mask */
1209
1210     if( !i_mask )
1211     {
1212         *pi_left = *pi_right = 0;
1213         return;
1214     }
1215
1216     /* Get bits */
1217     i_low =  i_mask & (- (int32_t)i_mask);          /* lower bit of the mask */
1218     i_high = i_mask + i_low;                       /* higher bit of the mask */
1219
1220     /* Transform bits into an index */
1221     i_low =  BinaryLog (i_low);
1222     i_high = BinaryLog (i_high);
1223
1224     /* Update pointers and return */
1225     *pi_left =   i_low;
1226     *pi_right = (8 - i_high + i_low);
1227 }
1228
1229 /*****************************************************************************
1230  * InitWindowSize: find the initial dimensions the video window should have.
1231  *****************************************************************************
1232  * This function will check the "width", "height" and "zoom" config options and
1233  * will calculate the size that the video window should have.
1234  *****************************************************************************/
1235 static void InitWindowSize( vout_thread_t *p_vout, int *pi_width,
1236                             int *pi_height )
1237 {
1238     vlc_value_t val;
1239     int i_width, i_height;
1240     uint64_t ll_zoom;
1241
1242 #define FP_FACTOR 1000                             /* our fixed point factor */
1243
1244     var_Get( p_vout, "align", &val );
1245     p_vout->i_alignment = val.i_int;
1246
1247     var_Get( p_vout, "width", &val );
1248     i_width = val.i_int;
1249     var_Get( p_vout, "height", &val );
1250     i_height = val.i_int;
1251     var_Get( p_vout, "zoom", &val );
1252     ll_zoom = (uint64_t)( FP_FACTOR * val.f_float );
1253
1254     if( i_width > 0 && i_height > 0)
1255     {
1256         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1257         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1258         return;
1259     }
1260     else if( i_width > 0 )
1261     {
1262         *pi_width = (int)( i_width * ll_zoom / FP_FACTOR );
1263         *pi_height = (int)( i_width * ll_zoom * VOUT_ASPECT_FACTOR /
1264                             p_vout->render.i_aspect / FP_FACTOR );
1265         return;
1266     }
1267     else if( i_height > 0 )
1268     {
1269         *pi_height = (int)( i_height * ll_zoom / FP_FACTOR );
1270         *pi_width = (int)( i_height * ll_zoom * p_vout->render.i_aspect /
1271                            VOUT_ASPECT_FACTOR / FP_FACTOR );
1272         return;
1273     }
1274
1275     if( p_vout->render.i_height * p_vout->render.i_aspect
1276         >= p_vout->render.i_width * VOUT_ASPECT_FACTOR )
1277     {
1278         *pi_width = (int)( p_vout->render.i_height * ll_zoom
1279           * p_vout->render.i_aspect / VOUT_ASPECT_FACTOR / FP_FACTOR );
1280         *pi_height = (int)( p_vout->render.i_height * ll_zoom / FP_FACTOR );
1281     }
1282     else
1283     {
1284         *pi_width = (int)( p_vout->render.i_width * ll_zoom / FP_FACTOR );
1285         *pi_height = (int)( p_vout->render.i_width * ll_zoom
1286           * VOUT_ASPECT_FACTOR / p_vout->render.i_aspect / FP_FACTOR );
1287     }
1288
1289 #undef FP_FACTOR
1290 }
1291
1292 /*****************************************************************************
1293  * vout_VarCallback: generic callback for intf variables
1294  *****************************************************************************/
1295 int vout_VarCallback( vlc_object_t * p_this, const char * psz_variable,
1296                       vlc_value_t old_value, vlc_value_t new_value,
1297                       void * unused )
1298 {
1299     vout_thread_t * p_vout = (vout_thread_t *)p_this;
1300     vlc_value_t val;
1301     val.b_bool = VLC_TRUE;
1302     var_Set( p_vout, "intf-change", val );
1303     return VLC_SUCCESS;
1304 }
1305
1306 /*****************************************************************************
1307  * object variables callbacks: a bunch of object variables are used by the
1308  * interfaces to interact with the vout.
1309  *****************************************************************************/
1310 static int DeinterlaceCallback( vlc_object_t *p_this, char const *psz_cmd,
1311                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1312 {
1313     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1314     input_thread_t *p_input;
1315     vlc_value_t val;
1316
1317     char *psz_mode = newval.psz_string;
1318     char *psz_filter;
1319     unsigned int  i;
1320
1321     psz_filter = config_GetPsz( p_vout, "filter" );
1322
1323     if( !psz_mode || !*psz_mode )
1324     {
1325         config_PutPsz( p_vout, "filter", "" );
1326     }
1327     else
1328     {
1329         if( !psz_filter || !*psz_filter )
1330         {
1331             config_PutPsz( p_vout, "filter", "deinterlace" );
1332         }
1333         else
1334         {
1335             if( strstr( psz_filter, "deinterlace" ) == NULL )
1336             {
1337                 psz_filter = realloc( psz_filter, strlen( psz_filter ) + 20 );
1338                 strcat( psz_filter, ",deinterlace" );
1339             }
1340             config_PutPsz( p_vout, "filter", psz_filter );
1341         }
1342     }
1343
1344     if( psz_filter ) free( psz_filter );
1345
1346
1347     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1348                                                  FIND_PARENT );
1349     if( !p_input ) return VLC_EGENERIC;
1350
1351     if( psz_mode && *psz_mode )
1352     {
1353         val.psz_string = psz_mode;
1354         var_Set( p_vout, "deinterlace-mode", val );
1355         /* Modify input as well because the vout might have to be restarted */
1356         var_Create( p_input, "deinterlace-mode", VLC_VAR_STRING );
1357         var_Set( p_input, "deinterlace-mode", val );
1358     }
1359
1360     /* FIXME FIXME input2 --fenrir */
1361 #if 0
1362     /* now restart all video streams */
1363     vlc_mutex_lock( &p_input->stream.stream_lock );
1364
1365     p_vout->b_filter_change = VLC_TRUE;
1366
1367 #define ES p_input->stream.pp_es[i]
1368
1369     for( i = 0 ; i < p_input->stream.i_es_number ; i++ )
1370     {
1371         if( ( ES->i_cat == VIDEO_ES ) && ES->p_dec != NULL )
1372         {
1373             input_UnselectES( p_input, ES );
1374             input_SelectES( p_input, ES );
1375         }
1376 #undef ES
1377     }
1378     vlc_mutex_unlock( &p_input->stream.stream_lock );
1379
1380     vlc_object_release( p_input );
1381 #endif
1382
1383     val.b_bool = VLC_TRUE;
1384     var_Set( p_vout, "intf-change", val );
1385     return VLC_SUCCESS;
1386 }
1387
1388 static int FilterCallback( vlc_object_t *p_this, char const *psz_cmd,
1389                        vlc_value_t oldval, vlc_value_t newval, void *p_data )
1390 {
1391     vout_thread_t *p_vout = (vout_thread_t *)p_this;
1392     input_thread_t *p_input;
1393     vlc_value_t val;
1394     unsigned int i;
1395
1396     p_input = (input_thread_t *)vlc_object_find( p_this, VLC_OBJECT_INPUT,
1397                                                  FIND_PARENT );
1398
1399     if (!p_input)
1400     {
1401         msg_Err( p_vout, "Input not found" );
1402         return( VLC_EGENERIC );
1403     }
1404
1405     /* FIXME FIXME input2 --fenrir */
1406 #if 0
1407     /* Restart the video stream */
1408     vlc_mutex_lock( &p_input->stream.stream_lock );
1409
1410     p_vout->b_filter_change = VLC_TRUE;
1411
1412 #define ES p_input->stream.pp_es[i]
1413
1414     for( i = 0 ; i < p_input->stream.i_es_number ; i++ )
1415     {
1416         if( ( ES->i_cat == VIDEO_ES ) && ES->p_dec != NULL )
1417         {
1418             input_UnselectES( p_input, ES );
1419             input_SelectES( p_input, ES );
1420         }
1421 #undef ES
1422     }
1423     vlc_mutex_unlock( &p_input->stream.stream_lock );
1424
1425     vlc_object_release( p_input );
1426 #endif
1427
1428     val.b_bool = VLC_TRUE;
1429     var_Set( p_vout, "intf-change", val );
1430     return VLC_SUCCESS;
1431 }