]> git.sesse.net Git - vlc/blob - src/video_output/vout_subpictures.c
Cosmetics.
[vlc] / src / video_output / vout_subpictures.c
1 /*****************************************************************************
2  * vout_subpictures.c : subpicture management functions
3  *****************************************************************************
4  * Copyright (C) 2000-2007 the VideoLAN team
5  * $Id$
6  *
7  * Authors: Vincent Seguin <seguin@via.ecp.fr>
8  *          Samuel Hocevar <sam@zoy.org>
9  *          Gildas Bazin <gbazin@videolan.org>
10  *
11  * This program is free software; you can redistribute it and/or modify
12  * it under the terms of the GNU General Public License as published by
13  * the Free Software Foundation; either version 2 of the License, or
14  * (at your option) any later version.
15  *
16  * This program is distributed in the hope that it will be useful,
17  * but WITHOUT ANY WARRANTY; without even the implied warranty of
18  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
19  * GNU General Public License for more details.
20  *
21  * You should have received a copy of the GNU General Public License
22  * along with this program; if not, write to the Free Software
23  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
24  *****************************************************************************/
25
26 /*****************************************************************************
27  * Preamble
28  *****************************************************************************/
29 #include <stdlib.h>                                                /* free() */
30 #include <stdio.h>                                              /* sprintf() */
31 #include <string.h>                                            /* strerror() */
32
33 #include <vlc/vlc.h>
34 #include <vlc_vout.h>
35 #include <vlc_block.h>
36 #include <vlc_filter.h>
37 #include <vlc_osd.h>
38
39 /*****************************************************************************
40  * Local prototypes
41  *****************************************************************************/
42 static void UpdateSPU   ( spu_t *, vlc_object_t * );
43 static int  CropCallback( vlc_object_t *, char const *,
44                           vlc_value_t, vlc_value_t, void * );
45
46 static int spu_vaControlDefault( spu_t *, int, va_list );
47
48 static subpicture_t *sub_new_buffer( filter_t * );
49 static void sub_del_buffer( filter_t *, subpicture_t * );
50 static subpicture_t *spu_new_buffer( filter_t * );
51 static void spu_del_buffer( filter_t *, subpicture_t * );
52 static picture_t *spu_new_video_buffer( filter_t * );
53 static void spu_del_video_buffer( filter_t *, picture_t * );
54
55 static int spu_ParseChain( spu_t * );
56 static void spu_DeleteChain( spu_t * );
57 static int SubFilterCallback( vlc_object_t *, char const *,
58                               vlc_value_t, vlc_value_t, void * );
59
60 struct filter_owner_sys_t
61 {
62     spu_t *p_spu;
63     int i_channel;
64 };
65
66 /**
67  * Creates the subpicture unit
68  *
69  * \param p_this the parent object which creates the subpicture unit
70  */
71 spu_t *__spu_Create( vlc_object_t *p_this )
72 {
73     int i_index;
74     spu_t *p_spu = vlc_object_create( p_this, VLC_OBJECT_SPU );
75
76     for( i_index = 0; i_index < VOUT_MAX_SUBPICTURES; i_index++)
77     {
78         p_spu->p_subpicture[i_index].i_status = FREE_SUBPICTURE;
79     }
80
81     p_spu->p_blend = NULL;
82     p_spu->p_text = NULL;
83     p_spu->p_scale = NULL;
84     p_spu->i_filter = 0;
85     p_spu->pf_control = spu_vaControlDefault;
86
87     /* Register the default subpicture channel */
88     p_spu->i_channel = 2;
89
90     vlc_mutex_init( p_this, &p_spu->subpicture_lock );
91
92     vlc_object_attach( p_spu, p_this );
93
94     return p_spu;
95 }
96
97 /**
98  * Initialise the subpicture unit
99  *
100  * \param p_spu the subpicture unit object
101  */
102 int spu_Init( spu_t *p_spu )
103 {
104     vlc_value_t val;
105
106     /* If the user requested a sub margin, we force the position. */
107     var_Create( p_spu, "sub-margin", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT );
108     var_Get( p_spu, "sub-margin", &val );
109     p_spu->i_margin = val.i_int;
110
111     var_Create( p_spu, "sub-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
112     var_AddCallback( p_spu, "sub-filter", SubFilterCallback, p_spu );
113
114     spu_ParseChain( p_spu );
115
116     return VLC_EGENERIC;
117 }
118
119 int spu_ParseChain( spu_t *p_spu )
120 {
121     char *psz_parser;
122     vlc_value_t val;
123     var_Get( p_spu, "sub-filter", &val );
124     psz_parser = val.psz_string;
125
126     while( psz_parser && *psz_parser )
127     {
128         config_chain_t *p_cfg;
129         char *psz_name;
130
131         psz_parser = config_ChainCreate( &psz_name, &p_cfg, psz_parser );
132
133         msg_Dbg( p_spu, "adding sub-filter: %s", psz_name );
134
135         p_spu->pp_filter[p_spu->i_filter] =
136             vlc_object_create( p_spu, VLC_OBJECT_FILTER );
137         vlc_object_attach( p_spu->pp_filter[p_spu->i_filter], p_spu );
138         p_spu->pp_filter[p_spu->i_filter]->pf_sub_buffer_new = sub_new_buffer;
139         p_spu->pp_filter[p_spu->i_filter]->pf_sub_buffer_del = sub_del_buffer;
140         p_spu->pp_filter[p_spu->i_filter]->p_cfg = p_cfg;
141         p_spu->pp_filter[p_spu->i_filter]->p_module =
142             module_Need( p_spu->pp_filter[p_spu->i_filter],
143                          "sub filter", psz_name, VLC_TRUE );
144         if( p_spu->pp_filter[p_spu->i_filter]->p_module )
145         {
146             filter_owner_sys_t *p_sys = malloc( sizeof(filter_owner_sys_t) );
147             p_spu->pp_filter[p_spu->i_filter]->p_owner = p_sys;
148             spu_Control( p_spu, SPU_CHANNEL_REGISTER, &p_sys->i_channel );
149             p_sys->p_spu = p_spu;
150             p_spu->i_filter++;
151         }
152         else
153         {
154             msg_Dbg( p_spu, "no sub filter found" );
155             config_ChainDestroy( p_spu->pp_filter[p_spu->i_filter]->p_cfg );
156             vlc_object_detach( p_spu->pp_filter[p_spu->i_filter] );
157             vlc_object_destroy( p_spu->pp_filter[p_spu->i_filter] );
158         }
159
160         if( p_spu->i_filter >= 10 )
161         {
162             msg_Dbg( p_spu, "can't add anymore filters" );
163         }
164
165         free( psz_name );
166     }
167     if( val.psz_string ) free( val.psz_string );
168
169     return VLC_EGENERIC;
170 }
171
172 /**
173  * Destroy the subpicture unit
174  *
175  * \param p_this the parent object which destroys the subpicture unit
176  */
177 void spu_Destroy( spu_t *p_spu )
178 {
179     int i_index;
180
181     vlc_object_detach( p_spu );
182
183     /* Destroy all remaining subpictures */
184     for( i_index = 0; i_index < VOUT_MAX_SUBPICTURES; i_index++ )
185     {
186         if( p_spu->p_subpicture[i_index].i_status != FREE_SUBPICTURE )
187         {
188             spu_DestroySubpicture( p_spu, &p_spu->p_subpicture[i_index] );
189         }
190     }
191
192     if( p_spu->p_blend )
193     {
194         if( p_spu->p_blend->p_module )
195             module_Unneed( p_spu->p_blend, p_spu->p_blend->p_module );
196
197         vlc_object_detach( p_spu->p_blend );
198         vlc_object_destroy( p_spu->p_blend );
199     }
200
201     if( p_spu->p_text )
202     {
203         if( p_spu->p_text->p_module )
204             module_Unneed( p_spu->p_text, p_spu->p_text->p_module );
205
206         vlc_object_detach( p_spu->p_text );
207         vlc_object_destroy( p_spu->p_text );
208     }
209
210     if( p_spu->p_scale )
211     {
212         if( p_spu->p_scale->p_module )
213             module_Unneed( p_spu->p_scale, p_spu->p_scale->p_module );
214
215         vlc_object_detach( p_spu->p_scale );
216         vlc_object_destroy( p_spu->p_scale );
217     }
218
219     spu_DeleteChain( p_spu );
220
221     vlc_mutex_destroy( &p_spu->subpicture_lock );
222     vlc_object_destroy( p_spu );
223 }
224
225 static void spu_DeleteChain( spu_t *p_spu )
226 {
227     if( p_spu->i_filter )
228     while( p_spu->i_filter-- )
229     {
230         module_Unneed( p_spu->pp_filter[p_spu->i_filter],
231                        p_spu->pp_filter[p_spu->i_filter]->p_module );
232         free( p_spu->pp_filter[p_spu->i_filter]->p_owner );
233         config_ChainDestroy( p_spu->pp_filter[p_spu->i_filter]->p_cfg );
234         vlc_object_detach( p_spu->pp_filter[p_spu->i_filter] );
235         vlc_object_destroy( p_spu->pp_filter[p_spu->i_filter] );
236     }
237 }
238
239 /**
240  * Attach/Detach the SPU from any input
241  *
242  * \param p_this the object in which to destroy the subpicture unit
243  * \param b_attach to select attach or detach
244  */
245 void spu_Attach( spu_t *p_spu, vlc_object_t *p_this, vlc_bool_t b_attach )
246 {
247     vlc_object_t *p_input;
248
249     p_input = vlc_object_find( p_this, VLC_OBJECT_INPUT, FIND_PARENT );
250     if( !p_input ) return;
251
252     if( b_attach )
253     {
254         UpdateSPU( p_spu, VLC_OBJECT(p_input) );
255         var_AddCallback( p_input, "highlight", CropCallback, p_spu );
256         vlc_object_release( p_input );
257     }
258     else
259     {
260         /* Delete callback */
261         var_DelCallback( p_input, "highlight", CropCallback, p_spu );
262         vlc_object_release( p_input );
263     }
264 }
265
266 /**
267  * Create a subpicture region
268  *
269  * \param p_this vlc_object_t
270  * \param p_fmt the format that this subpicture region should have
271  */
272 static void RegionPictureRelease( picture_t *p_pic )
273 {
274     if( p_pic->p_data_orig ) free( p_pic->p_data_orig );
275 }
276 subpicture_region_t *__spu_CreateRegion( vlc_object_t *p_this,
277                                          video_format_t *p_fmt )
278 {
279     subpicture_region_t *p_region = malloc( sizeof(subpicture_region_t) );
280     if( !p_region ) return NULL;
281
282     memset( p_region, 0, sizeof(subpicture_region_t) );
283     p_region->p_next = 0;
284     p_region->p_cache = 0;
285     p_region->fmt = *p_fmt;
286     p_region->psz_text = 0;
287     p_region->p_style = NULL;
288
289     if( p_fmt->i_chroma == VLC_FOURCC('Y','U','V','P') )
290         p_fmt->p_palette = p_region->fmt.p_palette =
291             malloc( sizeof(video_palette_t) );
292     else p_fmt->p_palette = p_region->fmt.p_palette = NULL;
293
294     p_region->picture.p_data_orig = NULL;
295
296     if( p_fmt->i_chroma == VLC_FOURCC('T','E','X','T') ) return p_region;
297
298     vout_AllocatePicture( p_this, &p_region->picture, p_fmt->i_chroma,
299                           p_fmt->i_width, p_fmt->i_height, p_fmt->i_aspect );
300
301     if( !p_region->picture.i_planes )
302     {
303         free( p_region );
304         if( p_fmt->p_palette ) free( p_fmt->p_palette );
305         return NULL;
306     }
307
308     p_region->picture.pf_release = RegionPictureRelease;
309
310     return p_region;
311 }
312
313 /**
314  * Make a subpicture region from an existing picture_t
315  *
316  * \param p_this vlc_object_t
317  * \param p_fmt the format that this subpicture region should have
318  * \param p_pic a pointer to the picture creating the region (not freed)
319  */
320 subpicture_region_t *__spu_MakeRegion( vlc_object_t *p_this,
321                                        video_format_t *p_fmt,
322                                        picture_t *p_pic )
323 {
324     subpicture_region_t *p_region = malloc( sizeof(subpicture_region_t) );
325     (void)p_this;
326     memset( p_region, 0, sizeof(subpicture_region_t) );
327     p_region->p_next = 0;
328     p_region->p_cache = 0;
329     p_region->fmt = *p_fmt;
330     p_region->psz_text = 0;
331     p_region->p_style = NULL;
332
333     if( p_fmt->i_chroma == VLC_FOURCC('Y','U','V','P') )
334         p_fmt->p_palette = p_region->fmt.p_palette =
335             malloc( sizeof(video_palette_t) );
336     else p_fmt->p_palette = p_region->fmt.p_palette = NULL;
337
338     memcpy( &p_region->picture, p_pic, sizeof(picture_t) );
339     p_region->picture.pf_release = RegionPictureRelease;
340
341     return p_region;
342 }
343
344 /**
345  * Destroy a subpicture region
346  *
347  * \param p_this vlc_object_t
348  * \param p_region the subpicture region to destroy
349  */
350 void __spu_DestroyRegion( vlc_object_t *p_this, subpicture_region_t *p_region )
351 {
352     if( !p_region ) return;
353     if( p_region->picture.pf_release )
354         p_region->picture.pf_release( &p_region->picture );
355     if( p_region->fmt.p_palette ) free( p_region->fmt.p_palette );
356     if( p_region->p_cache ) __spu_DestroyRegion( p_this, p_region->p_cache );
357
358     if( p_region->psz_text )
359         free( p_region->psz_text );
360     if( p_region->psz_html )
361         free( p_region->psz_html );
362     //free( p_region->p_style ); FIXME --fenrir plugin does not allocate the memory for it. I think it might lead to segfault, video renderer can live longer than the decoder
363     free( p_region );
364 }
365
366 /**
367  * Display a subpicture
368  *
369  * Remove the reservation flag of a subpicture, which will cause it to be
370  * ready for display.
371  * \param p_spu the subpicture unit object
372  * \param p_subpic the subpicture to display
373  */
374 void spu_DisplaySubpicture( spu_t *p_spu, subpicture_t *p_subpic )
375 {
376     /* Check if status is valid */
377     if( p_subpic->i_status != RESERVED_SUBPICTURE )
378     {
379         msg_Err( p_spu, "subpicture %p has invalid status #%d",
380                  p_subpic, p_subpic->i_status );
381     }
382
383     /* Remove reservation flag */
384     p_subpic->i_status = READY_SUBPICTURE;
385
386     if( p_subpic->i_channel == DEFAULT_CHAN )
387     {
388         p_subpic->i_channel = 0xFFFF;
389         spu_Control( p_spu, SPU_CHANNEL_CLEAR, DEFAULT_CHAN );
390         p_subpic->i_channel = DEFAULT_CHAN;
391     }
392 }
393
394 /**
395  * Allocate a subpicture in the spu heap.
396  *
397  * This function create a reserved subpicture in the spu heap.
398  * A null pointer is returned if the function fails. This method provides an
399  * already allocated zone of memory in the spu data fields. It needs locking
400  * since several pictures can be created by several producers threads.
401  * \param p_spu the subpicture unit in which to create the subpicture
402  * \return NULL on error, a reserved subpicture otherwise
403  */
404 subpicture_t *spu_CreateSubpicture( spu_t *p_spu )
405 {
406     int                 i_subpic;                        /* subpicture index */
407     subpicture_t *      p_subpic = NULL;            /* first free subpicture */
408
409     /* Get lock */
410     vlc_mutex_lock( &p_spu->subpicture_lock );
411
412     /*
413      * Look for an empty place
414      */
415     p_subpic = NULL;
416     for( i_subpic = 0; i_subpic < VOUT_MAX_SUBPICTURES; i_subpic++ )
417     {
418         if( p_spu->p_subpicture[i_subpic].i_status == FREE_SUBPICTURE )
419         {
420             /* Subpicture is empty and ready for allocation */
421             p_subpic = &p_spu->p_subpicture[i_subpic];
422             p_spu->p_subpicture[i_subpic].i_status = RESERVED_SUBPICTURE;
423             break;
424         }
425     }
426
427     /* If no free subpicture could be found */
428     if( p_subpic == NULL )
429     {
430         msg_Err( p_spu, "subpicture heap is full" );
431         vlc_mutex_unlock( &p_spu->subpicture_lock );
432         return NULL;
433     }
434
435     /* Copy subpicture information, set some default values */
436     memset( p_subpic, 0, sizeof(subpicture_t) );
437     p_subpic->i_status   = RESERVED_SUBPICTURE;
438     p_subpic->b_absolute = VLC_TRUE;
439     p_subpic->b_pausable = VLC_FALSE;
440     p_subpic->b_fade     = VLC_FALSE;
441     p_subpic->i_alpha    = 0xFF;
442     p_subpic->p_region   = 0;
443     p_subpic->pf_render  = 0;
444     p_subpic->pf_destroy = 0;
445     p_subpic->p_sys      = 0;
446     vlc_mutex_unlock( &p_spu->subpicture_lock );
447
448     p_subpic->pf_create_region = __spu_CreateRegion;
449     p_subpic->pf_make_region = __spu_MakeRegion;
450     p_subpic->pf_destroy_region = __spu_DestroyRegion;
451
452     return p_subpic;
453 }
454
455 /**
456  * Remove a subpicture from the heap
457  *
458  * This function frees a previously reserved subpicture.
459  * It is meant to be used when the construction of a picture aborted.
460  * This function does not need locking since reserved subpictures are ignored
461  * by the spu.
462  */
463 void spu_DestroySubpicture( spu_t *p_spu, subpicture_t *p_subpic )
464 {
465     /* Get lock */
466     vlc_mutex_lock( &p_spu->subpicture_lock );
467
468     /* There can be race conditions so we need to check the status */
469     if( p_subpic->i_status == FREE_SUBPICTURE )
470     {
471         vlc_mutex_unlock( &p_spu->subpicture_lock );
472         return;
473     }
474
475     /* Check if status is valid */
476     if( ( p_subpic->i_status != RESERVED_SUBPICTURE )
477            && ( p_subpic->i_status != READY_SUBPICTURE ) )
478     {
479         msg_Err( p_spu, "subpicture %p has invalid status %d",
480                          p_subpic, p_subpic->i_status );
481     }
482
483     while( p_subpic->p_region )
484     {
485         subpicture_region_t *p_region = p_subpic->p_region;
486         p_subpic->p_region = p_region->p_next;
487         spu_DestroyRegion( p_spu, p_region );
488     }
489
490     if( p_subpic->pf_destroy )
491     {
492         p_subpic->pf_destroy( p_subpic );
493     }
494
495     p_subpic->i_status = FREE_SUBPICTURE;
496
497     vlc_mutex_unlock( &p_spu->subpicture_lock );
498 }
499
500 /*****************************************************************************
501  * spu_RenderSubpictures: render a subpicture list
502  *****************************************************************************
503  * This function renders all sub picture units in the list.
504  *****************************************************************************/
505 void spu_RenderSubpictures( spu_t *p_spu, video_format_t *p_fmt,
506                             picture_t *p_pic_dst, picture_t *p_pic_src,
507                             subpicture_t *p_subpic,
508                             int i_scale_width_orig, int i_scale_height_orig )
509 {
510     /* Get lock */
511     vlc_mutex_lock( &p_spu->subpicture_lock );
512
513     /* Check i_status again to make sure spudec hasn't destroyed the subpic */
514     while( p_subpic != NULL && p_subpic->i_status != FREE_SUBPICTURE )
515     {
516         subpicture_region_t *p_region = p_subpic->p_region;
517         int i_scale_width, i_scale_height;
518         int i_subpic_x = p_subpic->i_x;
519
520         /* Load the blending module */
521         if( !p_spu->p_blend && p_region )
522         {
523             p_spu->p_blend = vlc_object_create( p_spu, VLC_OBJECT_FILTER );
524             vlc_object_attach( p_spu->p_blend, p_spu );
525             p_spu->p_blend->fmt_out.video.i_x_offset =
526                 p_spu->p_blend->fmt_out.video.i_y_offset = 0;
527             p_spu->p_blend->fmt_out.video.i_aspect = p_fmt->i_aspect;
528             p_spu->p_blend->fmt_out.video.i_chroma = p_fmt->i_chroma;
529             p_spu->p_blend->fmt_in.video.i_chroma = VLC_FOURCC('Y','U','V','P');
530             /* XXX: We'll also be using it for YUVA and RGBA blending ... */
531
532             p_spu->p_blend->p_module =
533                 module_Need( p_spu->p_blend, "video blending", 0, 0 );
534         }
535
536         /* Load the text rendering module */
537         if( !p_spu->p_text && p_region
538          && p_region->fmt.i_chroma == VLC_FOURCC('T','E','X','T') )
539         {
540             char *psz_modulename = NULL;
541
542             p_spu->p_text = vlc_object_create( p_spu, VLC_OBJECT_FILTER );
543             vlc_object_attach( p_spu->p_text, p_spu );
544
545             p_spu->p_text->fmt_out.video.i_width =
546                 p_spu->p_text->fmt_out.video.i_visible_width =
547                 p_fmt->i_width;
548             p_spu->p_text->fmt_out.video.i_height =
549                 p_spu->p_text->fmt_out.video.i_visible_height =
550                 p_fmt->i_height;
551
552             p_spu->p_text->pf_sub_buffer_new = spu_new_buffer;
553             p_spu->p_text->pf_sub_buffer_del = spu_del_buffer;
554
555             psz_modulename = var_CreateGetString( p_spu, "text-renderer" );
556             if( psz_modulename && *psz_modulename )
557             {
558                 p_spu->p_text->p_module =
559                     module_Need( p_spu->p_text, "text renderer",
560                                  psz_modulename, VLC_TRUE );
561             }
562             if( !p_spu->p_text->p_module )
563             {
564                 p_spu->p_text->p_module =
565                     module_Need( p_spu->p_text, "text renderer", 0, 0 );
566             }
567             if( psz_modulename ) free( psz_modulename );
568         }
569         if( p_spu->p_text )
570         {
571             if( (p_subpic->i_original_picture_height > 0) &&
572                 (p_subpic->i_original_picture_width  > 0) )
573             {
574                 p_spu->p_text->fmt_out.video.i_width =
575                     p_spu->p_text->fmt_out.video.i_visible_width =
576                     p_subpic->i_original_picture_width;
577                 p_spu->p_text->fmt_out.video.i_height =
578                     p_spu->p_text->fmt_out.video.i_visible_height =
579                     p_subpic->i_original_picture_height;
580             }
581             else
582             {
583                 p_spu->p_text->fmt_out.video.i_width =
584                     p_spu->p_text->fmt_out.video.i_visible_width =
585                     p_fmt->i_width;
586                 p_spu->p_text->fmt_out.video.i_height =
587                     p_spu->p_text->fmt_out.video.i_visible_height =
588                     p_fmt->i_height;
589             }
590         }
591
592         i_scale_width = i_scale_width_orig;
593         i_scale_height = i_scale_height_orig;
594
595         if( (p_subpic->i_original_picture_height > 0) &&
596             (p_subpic->i_original_picture_width  > 0) )
597         {
598             i_scale_width = i_scale_width * p_fmt->i_width /
599                              p_subpic->i_original_picture_width;
600             i_scale_height = i_scale_height * p_fmt->i_height /
601                              p_subpic->i_original_picture_height;
602         }
603         else if( p_subpic->i_original_picture_height > 0 )
604         {
605             i_scale_height = i_scale_height * p_fmt->i_height /
606                              p_subpic->i_original_picture_height;
607             i_scale_width = i_scale_height * i_scale_height / p_fmt->i_height;
608         }
609
610         /* Set default subpicture aspect ratio */
611         if( p_region && p_region->fmt.i_aspect &&
612             (!p_region->fmt.i_sar_num || !p_region->fmt.i_sar_den) )
613         {
614             p_region->fmt.i_sar_den = p_region->fmt.i_aspect;
615             p_region->fmt.i_sar_num = VOUT_ASPECT_FACTOR;
616         }
617         if( p_region &&
618             (!p_region->fmt.i_sar_num || !p_region->fmt.i_sar_den) )
619         {
620             p_region->fmt.i_sar_den = p_fmt->i_sar_den;
621             p_region->fmt.i_sar_num = p_fmt->i_sar_num;
622         }
623
624         /* Take care of the aspect ratio */
625         if( p_region && p_region->fmt.i_sar_num * p_fmt->i_sar_den !=
626             p_region->fmt.i_sar_den * p_fmt->i_sar_num )
627         {
628             i_scale_width = i_scale_width *
629                 (int64_t)p_region->fmt.i_sar_num * p_fmt->i_sar_den /
630                 p_region->fmt.i_sar_den / p_fmt->i_sar_num;
631             i_subpic_x = p_subpic->i_x * i_scale_width / 1000;
632         }
633
634         /* Load the scaling module */
635         if( !p_spu->p_scale &&
636             ((i_scale_width > 0) || (i_scale_height > 0)) &&
637             ((i_scale_width != 1000) || (i_scale_height != 1000)) )
638         {
639             p_spu->p_scale = vlc_object_create( p_spu, VLC_OBJECT_FILTER );
640             vlc_object_attach( p_spu->p_scale, p_spu );
641             p_spu->p_scale->fmt_out.video.i_chroma =
642                 p_spu->p_scale->fmt_in.video.i_chroma =
643                     VLC_FOURCC('Y','U','V','P');
644             /* XXX: We'll also be using it for YUVA and RGBA blending ... */
645             p_spu->p_scale->fmt_in.video.i_width =
646                 p_spu->p_scale->fmt_in.video.i_height = 32;
647             p_spu->p_scale->fmt_out.video.i_width =
648                 p_spu->p_scale->fmt_out.video.i_height = 16;
649
650             p_spu->p_scale->pf_vout_buffer_new = spu_new_video_buffer;
651             p_spu->p_scale->pf_vout_buffer_del = spu_del_video_buffer;
652             p_spu->p_scale->p_module =
653                 module_Need( p_spu->p_scale, "video filter2", 0, 0 );
654         }
655
656         while( p_region && p_spu->p_blend && p_spu->p_blend->pf_video_blend )
657         {
658             video_format_t orig_fmt = p_region->fmt;
659             vlc_bool_t b_rerender_text = VLC_FALSE;
660             int i_fade_alpha = 255;
661             int i_x_offset = p_region->i_x + i_subpic_x;
662             int i_y_offset = p_region->i_y + p_subpic->i_y;
663
664             if( p_region->fmt.i_chroma == VLC_FOURCC('T','E','X','T') )
665             {
666                 if( p_spu->p_text && p_spu->p_text->p_module )
667                 {
668                     vlc_value_t  val;
669
670                     /* Setup 3 variables which can be used to render
671                      * time-dependent text (and effects). The first indicates
672                      * the total amount of time the text will be on screen,
673                      * the second the amount of time it has already been on
674                      * screen (can be a negative value as text is layed out
675                      * before it is rendered) and the third is a feedback
676                      * variable from the renderer - if the renderer sets it
677                      * then this particular text is time-dependent, eg. the
678                      * visual progress bar inside the text in karaoke and the
679                      * text needs to be rendered multiple times in order for
680                      * the effect to work - we therefore need to return the
681                      * region to its original state at the end of the loop,
682                      * instead of leaving it in YUVA or YUVP.
683                      * Any renderer which is unaware of how to render
684                      * time-dependent text can happily ignore the variables
685                      * and render the text the same as usual - it should at
686                      * least show up on screen, but the effect won't change
687                      * the text over time.
688                      */
689
690                     var_Create( p_spu->p_text, "spu-duration", VLC_VAR_TIME );
691                     val.i_time = p_subpic->i_stop - p_subpic->i_start;
692                     var_Set( p_spu->p_text, "spu-duration", val );
693
694                     var_Create( p_spu->p_text, "spu-elapsed", VLC_VAR_TIME );
695                     val.i_time = mdate() - p_subpic->i_start;
696                     var_Set( p_spu->p_text, "spu-elapsed", val );
697
698                     var_Create( p_spu->p_text, "text-rerender", VLC_VAR_BOOL );
699                     var_SetBool( p_spu->p_text, "text-rerender", VLC_FALSE );
700
701                     if( p_spu->p_text->pf_render_html && p_region->psz_html )
702                     {
703                         p_spu->p_text->pf_render_html( p_spu->p_text,
704                                                        p_region, p_region );
705                     }
706                     else if( p_spu->p_text->pf_render_text )
707                     {
708                         p_spu->p_text->pf_render_text( p_spu->p_text,
709                                                        p_region, p_region );
710                     }
711                     b_rerender_text = var_GetBool( p_spu->p_text, "text-rerender" );
712
713                     var_Destroy( p_spu->p_text, "spu-duration" );
714                     var_Destroy( p_spu->p_text, "spu-elapsed" );
715                     var_Destroy( p_spu->p_text, "text-rerender" );
716
717                 }
718             }
719
720             /* Force palette if requested */
721             if( p_spu->b_force_palette &&
722                 (VLC_FOURCC('Y','U','V','P') == p_region->fmt.i_chroma) )
723             {
724                 memcpy( p_region->fmt.p_palette->palette,
725                         p_spu->palette, 16 );
726             }
727
728             /* Scale SPU if necessary */
729             if( p_region->p_cache )
730             {
731                 if( i_scale_width * p_region->fmt.i_width / 1000 !=
732                     p_region->p_cache->fmt.i_width ||
733                     i_scale_height * p_region->fmt.i_height / 1000 !=
734                     p_region->p_cache->fmt.i_height )
735                 {
736                     p_subpic->pf_destroy_region( VLC_OBJECT(p_spu),
737                                                  p_region->p_cache );
738                     p_region->p_cache = 0;
739                 }
740             }
741
742             if( ((i_scale_width != 1000) || (i_scale_height != 1000)) &&
743                 ((i_scale_width > 0) || (i_scale_height > 0)) &&
744                 p_spu->p_scale && !p_region->p_cache )
745             {
746                 picture_t *p_pic;
747
748                 p_spu->p_scale->fmt_in.video = p_region->fmt;
749                 p_spu->p_scale->fmt_out.video = p_region->fmt;
750
751                 p_region->p_cache =
752                     p_subpic->pf_create_region( VLC_OBJECT(p_spu),
753                         &p_spu->p_scale->fmt_out.video );
754                 if( p_spu->p_scale->fmt_out.video.p_palette )
755                     *p_spu->p_scale->fmt_out.video.p_palette =
756                         *p_region->fmt.p_palette;
757                 p_region->p_cache->p_next = p_region->p_next;
758
759                 vout_CopyPicture( p_spu, &p_region->p_cache->picture,
760                                   &p_region->picture );
761
762                 p_spu->p_scale->fmt_out.video.i_width =
763                     p_region->fmt.i_width * i_scale_width / 1000;
764                 p_spu->p_scale->fmt_out.video.i_visible_width =
765                     p_region->fmt.i_visible_width * i_scale_width / 1000;
766                 p_spu->p_scale->fmt_out.video.i_height =
767                     p_region->fmt.i_height * i_scale_height / 1000;
768                 p_spu->p_scale->fmt_out.video.i_visible_height =
769                     p_region->fmt.i_visible_height * i_scale_height / 1000;
770                 p_region->p_cache->fmt = p_spu->p_scale->fmt_out.video;
771                 p_region->p_cache->i_x = p_region->i_x * i_scale_width / 1000;
772                 p_region->p_cache->i_y = p_region->i_y * i_scale_height / 1000;
773                 p_region->p_cache->i_align = p_region->i_align;
774
775                 p_pic = p_spu->p_scale->pf_video_filter(
776                                  p_spu->p_scale, &p_region->p_cache->picture );
777                 if( p_pic )
778                 {
779                     picture_t p_pic_tmp = p_region->p_cache->picture;
780                     p_region->p_cache->picture = *p_pic;
781                     *p_pic = p_pic_tmp;
782                     free( p_pic );
783                 }
784             }
785             if( ((i_scale_width != 1000) || (i_scale_height != 1000)) &&
786                 ((i_scale_width > 0) || (i_scale_height > 0)) &&
787                 p_spu->p_scale && p_region->p_cache )
788             {
789                 p_region = p_region->p_cache;
790             }
791
792             if( p_region->i_align & SUBPICTURE_ALIGN_BOTTOM )
793             {
794                 i_y_offset = p_fmt->i_height - p_region->fmt.i_height -
795                     p_subpic->i_y - p_region->i_y;
796             }
797             else if ( !(p_region->i_align & SUBPICTURE_ALIGN_TOP) )
798             {
799                 i_y_offset = p_fmt->i_height / 2 - p_region->fmt.i_height / 2;
800             }
801
802             if( p_region->i_align & SUBPICTURE_ALIGN_RIGHT )
803             {
804                 i_x_offset = p_fmt->i_width - p_region->fmt.i_width -
805                     i_subpic_x - p_region->i_x;
806             }
807             else if ( !(p_region->i_align & SUBPICTURE_ALIGN_LEFT) )
808             {
809                 i_x_offset = p_fmt->i_width / 2 - p_region->fmt.i_width / 2;
810             }
811
812             if( p_subpic->b_absolute )
813             {
814                 i_x_offset = p_region->i_x +
815                     i_subpic_x * i_scale_width / 1000;
816                 i_y_offset = p_region->i_y +
817                     p_subpic->i_y * i_scale_height / 1000;
818
819             }
820
821             i_x_offset = __MAX( i_x_offset, 0 );
822             i_y_offset = __MAX( i_y_offset, 0 );
823
824             if( p_spu->i_margin != 0 && p_spu->b_force_crop == VLC_FALSE )
825             {
826                 int i_diff = 0;
827                 int i_low = i_y_offset - p_spu->i_margin;
828                 int i_high = i_y_offset + p_region->fmt.i_height
829                              - p_spu->i_margin;
830
831                 /* crop extra margin to keep within bounds */
832                 if( i_low < 0 )
833                     i_diff = i_low;
834                 if( i_high > (int)p_fmt->i_height )
835                     i_diff = i_high - p_fmt->i_height;
836                 i_y_offset -= ( p_spu->i_margin + i_diff );
837             }
838
839             p_spu->p_blend->fmt_in.video = p_region->fmt;
840
841             /* Force cropping if requested */
842             if( p_spu->b_force_crop )
843             {
844                 video_format_t *p_fmt = &p_spu->p_blend->fmt_in.video;
845                 int i_crop_x = p_spu->i_crop_x * i_scale_width / 1000;
846                 int i_crop_y = p_spu->i_crop_y * i_scale_height / 1000;
847                 int i_crop_width = p_spu->i_crop_width * i_scale_width / 1000;
848                 int i_crop_height = p_spu->i_crop_height * i_scale_height/1000;
849
850                 /* Find the intersection */
851                 if( i_crop_x + i_crop_width <= i_x_offset ||
852                     i_x_offset + (int)p_fmt->i_visible_width < i_crop_x ||
853                     i_crop_y + i_crop_height <= i_y_offset ||
854                     i_y_offset + (int)p_fmt->i_visible_height < i_crop_y )
855                 {
856                     /* No intersection */
857                     p_fmt->i_visible_width = p_fmt->i_visible_height = 0;
858                 }
859                 else
860                 {
861                     int i_x, i_y, i_x_end, i_y_end;
862                     i_x = __MAX( i_crop_x, i_x_offset );
863                     i_y = __MAX( i_crop_y, i_y_offset );
864                     i_x_end = __MIN( i_crop_x + i_crop_width,
865                                    i_x_offset + (int)p_fmt->i_visible_width );
866                     i_y_end = __MIN( i_crop_y + i_crop_height,
867                                    i_y_offset + (int)p_fmt->i_visible_height );
868
869                     p_fmt->i_x_offset = i_x - i_x_offset;
870                     p_fmt->i_y_offset = i_y - i_y_offset;
871                     p_fmt->i_visible_width = i_x_end - i_x;
872                     p_fmt->i_visible_height = i_y_end - i_y;
873
874                     i_x_offset = i_x;
875                     i_y_offset = i_y;
876                 }
877             }
878
879             /* Update the output picture size */
880             p_spu->p_blend->fmt_out.video.i_width =
881                 p_spu->p_blend->fmt_out.video.i_visible_width =
882                     p_fmt->i_width;
883             p_spu->p_blend->fmt_out.video.i_height =
884                 p_spu->p_blend->fmt_out.video.i_visible_height =
885                     p_fmt->i_height;
886
887             if( p_subpic->b_fade )
888             {
889                 mtime_t i_fade_start = ( p_subpic->i_stop +
890                                          p_subpic->i_start ) / 2;
891                 mtime_t i_now = mdate();
892                 if( i_now >= i_fade_start && p_subpic->i_stop > i_fade_start )
893                 {
894                     i_fade_alpha = 255 * ( p_subpic->i_stop - i_now ) /
895                                    ( p_subpic->i_stop - i_fade_start );
896                 }
897             }
898
899             i_x_offset = __MAX( i_x_offset, 0 );
900             i_y_offset = __MAX( i_y_offset, 0 );
901
902             p_spu->p_blend->pf_video_blend( p_spu->p_blend, p_pic_dst,
903                 p_pic_src, &p_region->picture, i_x_offset, i_y_offset,
904                 i_fade_alpha * p_subpic->i_alpha / 255 );
905
906             if( b_rerender_text )
907             {
908                 /* Some forms of subtitles need to be re-rendered more than
909                  * once, eg. karaoke. We therefore restore the region to its
910                  * pre-rendered state, so the next time through everything is
911                  * calculated again.
912                  */
913                 p_region->picture.pf_release( &p_region->picture );
914                 memset( &p_region->picture, 0, sizeof( picture_t ) );
915                 p_region->fmt = orig_fmt;
916             }
917             p_region = p_region->p_next;
918         }
919
920         p_subpic = p_subpic->p_next;
921     }
922
923     vlc_mutex_unlock( &p_spu->subpicture_lock );
924 }
925
926 /*****************************************************************************
927  * spu_SortSubpictures: find the subpictures to display
928  *****************************************************************************
929  * This function parses all subpictures and decides which ones need to be
930  * displayed. This operation does not need lock, since only READY_SUBPICTURE
931  * are handled. If no picture has been selected, display_date will depend on
932  * the subpicture.
933  * We also check for ephemer DVD subpictures (subpictures that have
934  * to be removed if a newer one is available), which makes it a lot
935  * more difficult to guess if a subpicture has to be rendered or not.
936  *****************************************************************************/
937 subpicture_t *spu_SortSubpictures( spu_t *p_spu, mtime_t display_date,
938                                    vlc_bool_t b_paused )
939 {
940     int i_index, i_channel;
941     subpicture_t *p_subpic = NULL;
942     subpicture_t *p_ephemer;
943     mtime_t      ephemer_date;
944
945     /* Run subpicture filters */
946     for( i_index = 0; i_index < p_spu->i_filter; i_index++ )
947     {
948         subpicture_t *p_subpic_filter;
949         p_subpic_filter = p_spu->pp_filter[i_index]->
950             pf_sub_filter( p_spu->pp_filter[i_index], display_date );
951         if( p_subpic_filter )
952         {
953             spu_DisplaySubpicture( p_spu, p_subpic_filter );
954         }
955     }
956
957     /* We get an easily parsable chained list of subpictures which
958      * ends with NULL since p_subpic was initialized to NULL. */
959     for( i_channel = 0; i_channel < p_spu->i_channel; i_channel++ )
960     {
961         p_ephemer = 0;
962         ephemer_date = 0;
963
964         for( i_index = 0; i_index < VOUT_MAX_SUBPICTURES; i_index++ )
965         {
966             if( p_spu->p_subpicture[i_index].i_channel != i_channel ||
967                 p_spu->p_subpicture[i_index].i_status != READY_SUBPICTURE )
968             {
969                 continue;
970             }
971             if( display_date &&
972                 display_date < p_spu->p_subpicture[i_index].i_start )
973             {
974                 /* Too early, come back next monday */
975                 continue;
976             }
977
978             if( p_spu->p_subpicture[i_index].i_start > ephemer_date )
979                 ephemer_date = p_spu->p_subpicture[i_index].i_start;
980
981             if( display_date > p_spu->p_subpicture[i_index].i_stop &&
982                 ( !p_spu->p_subpicture[i_index].b_ephemer ||
983                   p_spu->p_subpicture[i_index].i_stop >
984                   p_spu->p_subpicture[i_index].i_start ) &&
985                 !( p_spu->p_subpicture[i_index].b_pausable &&
986                    b_paused ) )
987             {
988                 /* Too late, destroy the subpic */
989                 spu_DestroySubpicture( p_spu, &p_spu->p_subpicture[i_index] );
990                 continue;
991             }
992
993             /* If this is an ephemer subpic, add it to our list */
994             if( p_spu->p_subpicture[i_index].b_ephemer )
995             {
996                 p_spu->p_subpicture[i_index].p_next = p_ephemer;
997                 p_ephemer = &p_spu->p_subpicture[i_index];
998
999                 continue;
1000             }
1001
1002             p_spu->p_subpicture[i_index].p_next = p_subpic;
1003             p_subpic = &p_spu->p_subpicture[i_index];
1004         }
1005
1006         /* If we found ephemer subpictures, check if they have to be
1007          * displayed or destroyed */
1008         while( p_ephemer != NULL )
1009         {
1010             subpicture_t *p_tmp = p_ephemer;
1011             p_ephemer = p_ephemer->p_next;
1012
1013             if( p_tmp->i_start < ephemer_date )
1014             {
1015                 /* Ephemer subpicture has lived too long */
1016                 spu_DestroySubpicture( p_spu, p_tmp );
1017             }
1018             else
1019             {
1020                 /* Ephemer subpicture can still live a bit */
1021                 p_tmp->p_next = p_subpic;
1022                 p_subpic = p_tmp;
1023             }
1024         }
1025     }
1026
1027     return p_subpic;
1028 }
1029
1030 /*****************************************************************************
1031  * SpuClearChannel: clear an spu channel
1032  *****************************************************************************
1033  * This function destroys the subpictures which belong to the spu channel
1034  * corresponding to i_channel_id.
1035  *****************************************************************************/
1036 static void SpuClearChannel( spu_t *p_spu, int i_channel )
1037 {
1038     int          i_subpic;                               /* subpicture index */
1039     subpicture_t *p_subpic = NULL;                  /* first free subpicture */
1040
1041     vlc_mutex_lock( &p_spu->subpicture_lock );
1042
1043     for( i_subpic = 0; i_subpic < VOUT_MAX_SUBPICTURES; i_subpic++ )
1044     {
1045         p_subpic = &p_spu->p_subpicture[i_subpic];
1046         if( p_subpic->i_status == FREE_SUBPICTURE
1047             || ( p_subpic->i_status != RESERVED_SUBPICTURE
1048                  && p_subpic->i_status != READY_SUBPICTURE ) )
1049         {
1050             continue;
1051         }
1052
1053         if( p_subpic->i_channel == i_channel )
1054         {
1055             while( p_subpic->p_region )
1056             {
1057                 subpicture_region_t *p_region = p_subpic->p_region;
1058                 p_subpic->p_region = p_region->p_next;
1059                 spu_DestroyRegion( p_spu, p_region );
1060             }
1061
1062             if( p_subpic->pf_destroy ) p_subpic->pf_destroy( p_subpic );
1063             p_subpic->i_status = FREE_SUBPICTURE;
1064         }
1065     }
1066
1067     vlc_mutex_unlock( &p_spu->subpicture_lock );
1068 }
1069
1070 /*****************************************************************************
1071  * spu_ControlDefault: default methods for the subpicture unit control.
1072  *****************************************************************************/
1073 static int spu_vaControlDefault( spu_t *p_spu, int i_query, va_list args )
1074 {
1075     int *pi, i;
1076
1077     switch( i_query )
1078     {
1079     case SPU_CHANNEL_REGISTER:
1080         pi = (int *)va_arg( args, int * );
1081         if( pi ) *pi = p_spu->i_channel++;
1082         break;
1083
1084     case SPU_CHANNEL_CLEAR:
1085         i = (int)va_arg( args, int );
1086         SpuClearChannel( p_spu, i );
1087         break;
1088
1089     default:
1090         msg_Dbg( p_spu, "control query not supported" );
1091         return VLC_EGENERIC;
1092     }
1093
1094     return VLC_SUCCESS;
1095 }
1096
1097 /*****************************************************************************
1098  * Object variables callbacks
1099  *****************************************************************************/
1100
1101 /*****************************************************************************
1102  * UpdateSPU: update subpicture settings
1103  *****************************************************************************
1104  * This function is called from CropCallback and at initialization time, to
1105  * retrieve crop information from the input.
1106  *****************************************************************************/
1107 static void UpdateSPU( spu_t *p_spu, vlc_object_t *p_object )
1108 {
1109     vlc_value_t val;
1110
1111     p_spu->b_force_palette = VLC_FALSE;
1112     p_spu->b_force_crop = VLC_FALSE;
1113
1114     if( var_Get( p_object, "highlight", &val ) || !val.b_bool ) return;
1115
1116     p_spu->b_force_crop = VLC_TRUE;
1117     var_Get( p_object, "x-start", &val );
1118     p_spu->i_crop_x = val.i_int;
1119     var_Get( p_object, "y-start", &val );
1120     p_spu->i_crop_y = val.i_int;
1121     var_Get( p_object, "x-end", &val );
1122     p_spu->i_crop_width = val.i_int - p_spu->i_crop_x;
1123     var_Get( p_object, "y-end", &val );
1124     p_spu->i_crop_height = val.i_int - p_spu->i_crop_y;
1125
1126     if( var_Get( p_object, "menu-palette", &val ) == VLC_SUCCESS )
1127     {
1128         memcpy( p_spu->palette, val.p_address, 16 );
1129         p_spu->b_force_palette = VLC_TRUE;
1130     }
1131
1132     msg_Dbg( p_object, "crop: %i,%i,%i,%i, palette forced: %i",
1133              p_spu->i_crop_x, p_spu->i_crop_y,
1134              p_spu->i_crop_width, p_spu->i_crop_height,
1135              p_spu->b_force_palette );
1136 }
1137
1138 /*****************************************************************************
1139  * CropCallback: called when the highlight properties are changed
1140  *****************************************************************************
1141  * This callback is called from the input thread when we need cropping
1142  *****************************************************************************/
1143 static int CropCallback( vlc_object_t *p_object, char const *psz_var,
1144                          vlc_value_t oldval, vlc_value_t newval, void *p_data )
1145 {
1146     (void)psz_var; (void)oldval; (void)newval;
1147     UpdateSPU( (spu_t *)p_data, p_object );
1148     return VLC_SUCCESS;
1149 }
1150
1151 /*****************************************************************************
1152  * Buffers allocation callbacks for the filters
1153  *****************************************************************************/
1154 static subpicture_t *sub_new_buffer( filter_t *p_filter )
1155 {
1156     filter_owner_sys_t *p_sys = p_filter->p_owner;
1157     subpicture_t *p_subpicture = spu_CreateSubpicture( p_sys->p_spu );
1158     if( p_subpicture ) p_subpicture->i_channel = p_sys->i_channel;
1159     return p_subpicture;
1160 }
1161
1162 static void sub_del_buffer( filter_t *p_filter, subpicture_t *p_subpic )
1163 {
1164     filter_owner_sys_t *p_sys = p_filter->p_owner;
1165     spu_DestroySubpicture( p_sys->p_spu, p_subpic );
1166 }
1167
1168 static subpicture_t *spu_new_buffer( filter_t *p_filter )
1169 {
1170     subpicture_t *p_subpic = (subpicture_t *)malloc(sizeof(subpicture_t));
1171     (void)p_filter;
1172     memset( p_subpic, 0, sizeof(subpicture_t) );
1173     p_subpic->b_absolute = VLC_TRUE;
1174
1175     p_subpic->pf_create_region = __spu_CreateRegion;
1176     p_subpic->pf_make_region = __spu_MakeRegion;
1177     p_subpic->pf_destroy_region = __spu_DestroyRegion;
1178
1179     return p_subpic;
1180 }
1181
1182 static void spu_del_buffer( filter_t *p_filter, subpicture_t *p_subpic )
1183 {
1184     while( p_subpic->p_region )
1185     {
1186         subpicture_region_t *p_region = p_subpic->p_region;
1187         p_subpic->p_region = p_region->p_next;
1188         p_subpic->pf_destroy_region( VLC_OBJECT(p_filter), p_region );
1189     }
1190
1191     free( p_subpic );
1192 }
1193
1194 static picture_t *spu_new_video_buffer( filter_t *p_filter )
1195 {
1196     picture_t *p_picture = malloc( sizeof(picture_t) );
1197
1198     if( vout_AllocatePicture( p_filter, p_picture,
1199                               p_filter->fmt_out.video.i_chroma,
1200                               p_filter->fmt_out.video.i_width,
1201                               p_filter->fmt_out.video.i_height,
1202                               p_filter->fmt_out.video.i_aspect )
1203         != VLC_SUCCESS )
1204     {
1205         free( p_picture );
1206         return NULL;
1207     }
1208
1209     p_picture->pf_release = RegionPictureRelease;
1210
1211     return p_picture;
1212 }
1213
1214 static void spu_del_video_buffer( filter_t *p_filter, picture_t *p_pic )
1215 {
1216     (void)p_filter;
1217     if( p_pic && p_pic->p_data_orig ) free( p_pic->p_data_orig );
1218     if( p_pic ) free( p_pic );
1219 }
1220
1221 static int SubFilterCallback( vlc_object_t *p_object, char const *psz_var,
1222                          vlc_value_t oldval, vlc_value_t newval, void *p_data )
1223 {
1224     (void)p_object; (void)oldval; (void)newval;
1225
1226     if( !strcmp( psz_var, "sub-filter" ) )
1227     {
1228         spu_t *p_spu = (spu_t *)p_data;
1229         vlc_mutex_lock( &p_spu->subpicture_lock );
1230         spu_DeleteChain( p_spu );
1231         spu_ParseChain( p_spu );
1232         vlc_mutex_unlock( &p_spu->subpicture_lock );
1233     }
1234     return VLC_SUCCESS;
1235 }