Fix some more very unlikely Coverity Scan issues.

[nageru] / futatabi / main.cpp

diff --git a/futatabi/main.cpp b/futatabi/main.cpp
index c4b31f55c231ed86b1d6ab61f5792e9ecfa81193..33a486a56440eb9ca93f62e61a51a3fdc55fa135 100644 (file)
--- a/futatabi/main.cpp
+++ b/futatabi/main.cpp
@@ -240,7 +240,10 @@ int main(int argc, char **argv)
        {
                QSurface *surface = create_surface();
                QOpenGLContext *context = create_context(surface);
-               make_current(context, surface);
+               if (!make_current(context, surface)) {
+                       printf("oops\n");
+                       exit(1);
+               }
                CHECK(movit::init_movit(MOVIT_SHADER_DIR, movit::MOVIT_DEBUG_OFF));
                delete_context(context);
                // TODO: Delete the surface, too.
@@ -279,7 +282,7 @@ void load_frame_file(const char *filename, const string &basename, unsigned file
        if (!all_frames.empty()) {
                // We already had this cached in the database, so no need to look in the file.
                for (const DB::FrameOnDiskAndStreamIdx &frame : all_frames) {
-                       if (frame.stream_idx >= 0 && frame.stream_idx < MAX_STREAMS) {
+                       if (frame.stream_idx < MAX_STREAMS) {
                                frames[frame.stream_idx].push_back(frame.frame);
                                start_pts = max(start_pts, frame.frame.pts);
                        }
@@ -341,6 +344,10 @@ void load_frame_file(const char *filename, const string &basename, unsigned file
                FrameOnDisk frame;
                frame.pts = hdr.pts();
                frame.offset = ftell(fp);
+               if (frame.offset == -1) {
+                       fprintf(stderr, "WARNING: %s: ftell() failed (%s).\n", filename, strerror(errno));
+                       break;
+               }
                frame.filename_idx = filename_idx;
                frame.size = hdr.file_size();
 
@@ -361,7 +368,11 @@ void load_frame_file(const char *filename, const string &basename, unsigned file
                        filename, skipped_bytes);
        }
 
-       size_t size = ftell(fp);
+       off_t size = ftell(fp);
+       if (size == -1) {
+               fprintf(stderr, "WARNING: %s: ftell() failed (%s).\n", filename, strerror(errno));
+               return;
+       }
        fclose(fp);
 
        db->store_frame_file(basename, size, all_frames);
@@ -431,6 +442,7 @@ void load_existing_frames()
                // Add a gap of one second from the old frames to the new ones.
                start_pts += TIMEBASE;
        }
+       current_pts = start_pts;
 
        for (int stream_idx = 0; stream_idx < MAX_STREAMS; ++stream_idx) {
                sort(frames[stream_idx].begin(), frames[stream_idx].end(),
@@ -486,15 +498,7 @@ int record_thread_func()
                        FrameOnDisk frame = write_frame(pkt.stream_index, pts, pkt.data, pkt.size, &db);
 
                        post_to_main_thread([pkt, frame] {
-                               if (pkt.stream_index == 0) {
-                                       global_mainwindow->ui->input1_display->setFrame(pkt.stream_index, frame);
-                               } else if (pkt.stream_index == 1) {
-                                       global_mainwindow->ui->input2_display->setFrame(pkt.stream_index, frame);
-                               } else if (pkt.stream_index == 2) {
-                                       global_mainwindow->ui->input3_display->setFrame(pkt.stream_index, frame);
-                               } else if (pkt.stream_index == 3) {
-                                       global_mainwindow->ui->input4_display->setFrame(pkt.stream_index, frame);
-                               }
+                               global_mainwindow->display_frame(pkt.stream_index, frame);
                        });
 
                        if (last_pts != -1 && global_flags.slow_down_input) {