]> git.sesse.net Git - vlc/blobdiff - modules/demux/mkv/matroska_segment_parse.cpp
MKV: fix playback of AC-3 with bogus default duration
[vlc] / modules / demux / mkv / matroska_segment_parse.cpp
index 3964674f02fa4fb3211bdb494e24d4cd64e3c4b9..d0bd4edfd04fee490418037aa20fb889a3d97f64 100644 (file)
@@ -1,34 +1,57 @@
 /*****************************************************************************
  * matroska_segment_parse.cpp : matroska demuxer
  *****************************************************************************
- * Copyright (C) 2003-2010 the VideoLAN team
+ * Copyright (C) 2003-2010 VLC authors and VideoLAN
  * $Id$
  *
  * Authors: Laurent Aimar <fenrir@via.ecp.fr>
  *          Steve Lhomme <steve.lhomme@free.fr>
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; either version 2.1 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
-
+#include "mkv.hpp"
 #include "matroska_segment.hpp"
-
 #include "chapters.hpp"
-
 #include "demux.hpp"
-
 #include "Ebml_parser.hpp"
+#include "util.hpp"
+
+extern "C" {
+#include "../vobsub.h"
+#include "../xiph.h"
+#include "../windows_audio_commons.h"
+#include "../mp4/libmp4.h"
+}
+
+#include <vlc_codecs.h>
+
+/* GetFourCC helper */
+#define GetFOURCC( p )  __GetFOURCC( (uint8_t*)p )
+static vlc_fourcc_t __GetFOURCC( uint8_t *p )
+{
+    return VLC_FOURCC( p[0], p[1], p[2], p[3] );
+}
+
+static inline void fill_extra_data( mkv_track_t *p_tk, unsigned int offset )
+{
+    if(p_tk->i_extra_data <= offset) return;
+    p_tk->fmt.i_extra = p_tk->i_extra_data - offset;
+    p_tk->fmt.p_extra = xmalloc( p_tk->fmt.i_extra );
+    if(!p_tk->fmt.p_extra) { p_tk->fmt.i_extra = 0; return; };
+    memcpy( p_tk->fmt.p_extra, p_tk->p_extra_data + offset, p_tk->fmt.i_extra );
+}
 
 /*****************************************************************************
  * Some functions to manipulate memory
@@ -66,68 +89,80 @@ void matroska_segment_c::ParseSeekHead( KaxSeekHead *seekhead )
             msg_Dbg( &sys.demuxer, "|   |   + Seek" );
 #endif
             ep->Down();
-            while( ( l = ep->Get() ) != NULL )
+            try
             {
-                if( MKV_IS_ID( l, KaxSeekID ) )
-                {
-                    KaxSeekID &sid = *(KaxSeekID*)l;
-                    sid.ReadData( es.I_O() );
-                    id = EbmlId( sid.GetBuffer(), sid.GetSize() );
-                }
-                else if( MKV_IS_ID( l, KaxSeekPosition ) )
+                while( ( l = ep->Get() ) != NULL )
                 {
-                    KaxSeekPosition &spos = *(KaxSeekPosition*)l;
-                    spos.ReadData( es.I_O() );
-                    i_pos = (int64_t)segment->GetGlobalPosition( uint64( spos ) );
-                }
-                else
-                {
-                    /* Many mkvmerge files hit this case. It seems to be a broken SeekHead */
-                    msg_Dbg( &sys.demuxer, "|   |   + Unknown (%s)", typeid(*l).name()  );
+                    if( unlikely( !l->ValidateSize() ) )
+                    {
+                        msg_Err( &sys.demuxer,"%s too big... skipping it",  typeid(*l).name() );
+                        continue;
+                    }
+                    if( MKV_IS_ID( l, KaxSeekID ) )
+                    {
+                        KaxSeekID &sid = *(KaxSeekID*)l;
+                        sid.ReadData( es.I_O() );
+                        id = EbmlId( sid.GetBuffer(), sid.GetSize() );
+                    }
+                    else if( MKV_IS_ID( l, KaxSeekPosition ) )
+                    {
+                        KaxSeekPosition &spos = *(KaxSeekPosition*)l;
+                        spos.ReadData( es.I_O() );
+                        i_pos = (int64_t)segment->GetGlobalPosition( uint64( spos ) );
+                    }
+                    else
+                    {
+                        /* Many mkvmerge files hit this case. It seems to be a broken SeekHead */
+                        msg_Dbg( &sys.demuxer, "|   |   + Unknown (%s)", typeid(*l).name() );
+                    }
                 }
             }
+            catch(...)
+            {
+                msg_Err( &sys.demuxer,"Error while reading %s",  typeid(*l).name() );
+            }
             ep->Up();
 
             if( i_pos >= 0 )
             {
                 if( id == EBML_ID(KaxCues) )
                 {
-                    msg_Dbg( &sys.demuxer, "|   - cues at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - cues at %" PRId64, i_pos );
                     LoadSeekHeadItem( EBML_INFO(KaxCues), i_pos );
                 }
                 else if( id == EBML_ID(KaxInfo) )
                 {
-                    msg_Dbg( &sys.demuxer, "|   - info at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - info at %" PRId64, i_pos );
                     LoadSeekHeadItem( EBML_INFO(KaxInfo), i_pos );
                 }
                 else if( id == EBML_ID(KaxChapters) )
                 {
-                    msg_Dbg( &sys.demuxer, "|   - chapters at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - chapters at %" PRId64, i_pos );
                     LoadSeekHeadItem( EBML_INFO(KaxChapters), i_pos );
                 }
                 else if( id == EBML_ID(KaxTags) )
                 {
-                    msg_Dbg( &sys.demuxer, "|   - tags at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - tags at %" PRId64, i_pos );
                     LoadSeekHeadItem( EBML_INFO(KaxTags), i_pos );
                 }
                 else if( id == EBML_ID(KaxSeekHead) )
                 {
-                    msg_Dbg( &sys.demuxer, "|   - chained seekhead at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - chained seekhead at %" PRId64, i_pos );
                     LoadSeekHeadItem( EBML_INFO(KaxSeekHead), i_pos );
                 }
                 else if( id == EBML_ID(KaxTracks) )
                 {
-                    msg_Dbg( &sys.demuxer, "|   - tracks at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - tracks at %" PRId64, i_pos );
                     LoadSeekHeadItem( EBML_INFO(KaxTracks), i_pos );
                 }
                 else if( id == EBML_ID(KaxAttachments) )
                 {
-                    msg_Dbg( &sys.demuxer, "|   - attachments at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - attachments at %" PRId64, i_pos );
                     LoadSeekHeadItem( EBML_INFO(KaxAttachments), i_pos );
                 }
 #ifdef MKV_DEBUG
                 else
-                    msg_Dbg( &sys.demuxer, "|   - unknown seekhead reference at %"PRId64, i_pos );
+                    msg_Dbg( &sys.demuxer, "|   - unknown seekhead reference at %" PRId64, i_pos );
 #endif
             }
         }
@@ -156,7 +191,7 @@ static void MkvTree( demux_t & demuxer, int i_level, const char *psz_format, ...
     psz_foo2[ 4 * i_level ] = '+';
     psz_foo2[ 4 * i_level + 1 ] = ' ';
     strcpy( &psz_foo2[ 4 * i_level + 2 ], psz_format );
-    msg_GenericVa( &demuxer,VLC_MSG_DBG, "mkv", psz_foo2, args );
+    msg_GenericVa( &demuxer,VLC_MSG_DBG, psz_foo2, args );
     free( psz_foo2 );
     va_end( args );
 }
@@ -174,6 +209,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
     memset( tk, 0, sizeof( mkv_track_t ) );
 
     es_format_Init( &tk->fmt, UNKNOWN_ES, 0 );
+    tk->p_es = NULL;
     tk->fmt.psz_language       = strdup("English");
     tk->fmt.psz_description    = NULL;
 
@@ -187,6 +223,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
     tk->psz_codec              = NULL;
     tk->b_dts_only             = false;
     tk->i_default_duration     = 0;
+    tk->b_no_duration          = false;
     tk->f_timecodescale        = 1.0;
 
     tk->b_inited               = false;
@@ -199,6 +236,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
     tk->psz_codec_download_url = NULL;
 
     tk->i_compression_type     = MATROSKA_COMPRESSION_NONE;
+    tk->i_encoding_scope       = MATROSKA_ENCODING_SCOPE_ALL_FRAMES;
     tk->p_compression_data     = NULL;
 
     msg_Dbg( &sys.demuxer, "|   |   + Track Entry" );
@@ -230,6 +268,8 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                 case track_audio:
                     psz_type = "audio";
                     tk->fmt.i_cat = AUDIO_ES;
+                    tk->fmt.audio.i_channels = 1;
+                    tk->fmt.audio.i_rate = 8000;
                     break;
                 case track_video:
                     psz_type = "video";
@@ -295,13 +335,14 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
             KaxTrackDefaultDuration &defd = *(KaxTrackDefaultDuration*)l;
 
             tk->i_default_duration = uint64(defd);
-            msg_Dbg( &sys.demuxer, "|   |   |   + Track Default Duration=%"PRId64, uint64(defd) );
+            msg_Dbg( &sys.demuxer, "|   |   |   + Track Default Duration=%" PRId64, uint64(defd) );
         }
         else  if( MKV_IS_ID( l, KaxTrackTimecodeScale ) )
         {
             KaxTrackTimecodeScale &ttcs = *(KaxTrackTimecodeScale*)l;
 
             tk->f_timecodescale = float( ttcs );
+            if ( tk->f_timecodescale <= 0 ) tk->f_timecodescale = 1.0;
             msg_Dbg( &sys.demuxer, "|   |   |   + Track TimeCodeScale=%f", tk->f_timecodescale );
         }
         else  if( MKV_IS_ID( l, KaxMaxBlockAdditionID ) ) // UNUSED
@@ -343,7 +384,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                 tk->p_extra_data = (uint8_t*)malloc( tk->i_extra_data );
                 memcpy( tk->p_extra_data, cpriv.GetBuffer(), tk->i_extra_data );
             }
-            msg_Dbg( &sys.demuxer, "|   |   |   + Track CodecPrivate size=%"PRId64, cpriv.GetSize() );
+            msg_Dbg( &sys.demuxer, "|   |   |   + Track CodecPrivate size=%" PRId64, cpriv.GetSize() );
         }
         else if( MKV_IS_ID( l, KaxCodecName ) )
         {
@@ -365,6 +406,21 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
 
             msg_Dbg( &sys.demuxer, "|   |   |   + Track Overlay=%u", uint32( tovr ) );
         }
+#if LIBMATROSKA_VERSION >= 0x010401
+        else if( MKV_IS_ID( l, KaxCodecDelay ) )
+        {
+            KaxCodecDelay &codecdelay = *(KaxCodecDelay*)l;
+            tk->i_codec_delay = uint64_t( codecdelay ) / 1000;
+            msg_Dbg( &sys.demuxer, "|   |   |   + Track Codec Delay =%" PRIu64,
+                     tk->i_codec_delay );
+        }
+        else if( MKV_IS_ID( l, KaxSeekPreRoll ) )
+        {
+            KaxSeekPreRoll &spr = *(KaxSeekPreRoll*)l;
+            tk->i_seek_preroll = uint64_t(spr) / 1000;
+            msg_Dbg( &sys.demuxer, "|   |   |   + Track Seek Preroll =%" PRIu64, tk->i_seek_preroll );
+        }
+#endif
         else if( MKV_IS_ID( l, KaxContentEncodings ) )
         {
             EbmlMaster *cencs = static_cast<EbmlMaster*>(l);
@@ -392,6 +448,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                         else if( MKV_IS_ID( l3, KaxContentEncodingScope ) )
                         {
                             KaxContentEncodingScope &encscope = *(KaxContentEncodingScope*)l3;
+                            tk->i_encoding_scope = uint32( encscope );
                             MkvTree( sys.demuxer, 5, "Scope: %i", uint32( encscope ) );
                         }
                         else if( MKV_IS_ID( l3, KaxContentEncodingType ) )
@@ -566,7 +623,7 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
                 {
                     KaxVideoFrameRate &vfps = *(KaxVideoFrameRate*)l;
 
-                    tk->f_fps = float( vfps );
+                    tk->f_fps = __MAX( float( vfps ), 1 );
                     msg_Dbg( &sys.demuxer, "   |   |   |   + fps=%f", float( vfps ) );
                 }
 //                else if( MKV_IS_ID( l, KaxVideoGamma) ) //DEPRECATED by Matroska
@@ -601,6 +658,10 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
         {
             EbmlMaster *tka = static_cast<EbmlMaster*>(l);
 
+            /* Initialize default values */
+            tk->fmt.audio.i_channels = 1;
+            tk->fmt.audio.i_rate = 8000;
+
             msg_Dbg( &sys.demuxer, "|   |   |   + Track Audio" );
 
             for( unsigned int j = 0; j < tka->ListSize(); j++ )
@@ -650,11 +711,27 @@ void matroska_segment_c::ParseTrackEntry( KaxTrackEntry *m )
 
     if ( bSupported )
     {
+#ifdef HAVE_ZLIB_H
+        if( tk->i_compression_type == MATROSKA_COMPRESSION_ZLIB &&
+            tk->i_encoding_scope & MATROSKA_ENCODING_SCOPE_PRIVATE &&
+            tk->i_extra_data && tk->p_extra_data &&
+            zlib_decompress_extra( &sys.demuxer, tk) )
+            return;
+#endif
+        if( TrackInit( tk ) )
+        {
+            msg_Err(&sys.demuxer, "Couldn't init track %d", tk->i_number );
+            free(tk->p_extra_data);
+            delete tk;
+            return;
+        }
+
         tracks.push_back( tk );
     }
     else
     {
         msg_Err( &sys.demuxer, "Track Entry %d not supported", tk->i_number );
+        free(tk->p_extra_data);
         delete tk;
     }
 }
@@ -668,7 +745,20 @@ void matroska_segment_c::ParseTracks( KaxTracks *tracks )
     int i_upper_level = 0;
 
     /* Master elements */
-    tracks->Read( es, EBML_CONTEXT(tracks), i_upper_level, el, true );
+    if( unlikely( tracks->IsFiniteSize() && tracks->GetSize() >= SIZE_MAX ) )
+    {
+        msg_Err( &sys.demuxer, "Track too big, aborting" );
+        return;
+    }
+    try
+    {
+        tracks->Read( es, EBML_CONTEXT(tracks), i_upper_level, el, true );
+    }
+    catch(...)
+    {
+        msg_Err( &sys.demuxer, "Couldn't read tracks" );
+        return;
+    }
 
     for( size_t i = 0; i < tracks->ListSize(); i++ )
     {
@@ -696,7 +786,20 @@ void matroska_segment_c::ParseInfo( KaxInfo *info )
 
     /* Master elements */
     m = static_cast<EbmlMaster *>(info);
-    m->Read( es, EBML_CONTEXT(info), i_upper_level, el, true );
+    if( unlikely( m->IsFiniteSize() && m->GetSize() >= SIZE_MAX ) )
+    {
+        msg_Err( &sys.demuxer, "Info too big, aborting" );
+        return;
+    }
+    try
+    {
+        m->Read( es, EBML_CONTEXT(info), i_upper_level, el, true );
+    }
+    catch(...)
+    {
+        msg_Err( &sys.demuxer, "Couldn't read info" );
+        return;
+    }   
 
     for( size_t i = 0; i < m->ListSize(); i++ )
     {
@@ -735,7 +838,7 @@ void matroska_segment_c::ParseInfo( KaxInfo *info )
 
             i_timescale = uint64(tcs);
 
-            msg_Dbg( &sys.demuxer, "|   |   + TimecodeScale=%"PRId64,
+            msg_Dbg( &sys.demuxer, "|   |   + TimecodeScale=%" PRId64,
                      i_timescale );
         }
         else if( MKV_IS_ID( l, KaxDuration ) )
@@ -744,7 +847,7 @@ void matroska_segment_c::ParseInfo( KaxInfo *info )
 
             i_duration = mtime_t( double( dur ) );
 
-            msg_Dbg( &sys.demuxer, "|   |   + Duration=%"PRId64,
+            msg_Dbg( &sys.demuxer, "|   |   + Duration=%" PRId64,
                      i_duration );
         }
         else if( MKV_IS_ID( l, KaxMuxingApp ) )
@@ -809,28 +912,41 @@ void matroska_segment_c::ParseInfo( KaxInfo *info )
         else if( MKV_IS_ID( l, KaxChapterTranslate ) )
         {
             KaxChapterTranslate *p_trans = static_cast<KaxChapterTranslate*>( l );
-            chapter_translation_c *p_translate = new chapter_translation_c();
-
-            p_trans->Read( es, EBML_CONTEXT(p_trans), i_upper_level, el, true );
-            for( size_t j = 0; j < p_trans->ListSize(); j++ )
+            try
             {
-                EbmlElement *l = (*p_trans)[j];
-
-                if( MKV_IS_ID( l, KaxChapterTranslateEditionUID ) )
+                if( unlikely( p_trans->IsFiniteSize() && p_trans->GetSize() >= SIZE_MAX ) )
                 {
-                    p_translate->editions.push_back( uint64( *static_cast<KaxChapterTranslateEditionUID*>( l ) ) );
+                    msg_Err( &sys.demuxer, "Chapter translate too big, aborting" );
+                    continue;
                 }
-                else if( MKV_IS_ID( l, KaxChapterTranslateCodec ) )
-                {
-                    p_translate->codec_id = uint32( *static_cast<KaxChapterTranslateCodec*>( l ) );
-                }
-                else if( MKV_IS_ID( l, KaxChapterTranslateID ) )
+
+                p_trans->Read( es, EBML_CONTEXT(p_trans), i_upper_level, el, true );
+                chapter_translation_c *p_translate = new chapter_translation_c();
+
+                for( size_t j = 0; j < p_trans->ListSize(); j++ )
                 {
-                    p_translate->p_translated = new KaxChapterTranslateID( *static_cast<KaxChapterTranslateID*>( l ) );
+                    EbmlElement *l = (*p_trans)[j];
+
+                    if( MKV_IS_ID( l, KaxChapterTranslateEditionUID ) )
+                    {
+                        p_translate->editions.push_back( uint64( *static_cast<KaxChapterTranslateEditionUID*>( l ) ) );
+                    }
+                    else if( MKV_IS_ID( l, KaxChapterTranslateCodec ) )
+                    {
+                        p_translate->codec_id = uint32( *static_cast<KaxChapterTranslateCodec*>( l ) );
+                    }
+                    else if( MKV_IS_ID( l, KaxChapterTranslateID ) )
+                    {
+                        p_translate->p_translated = new KaxChapterTranslateID( *static_cast<KaxChapterTranslateID*>( l ) );
+                    }
                 }
-            }
 
-            translations.push_back( p_translate );
+                translations.push_back( p_translate );
+            }
+            catch(...)
+            {
+                msg_Err( &sys.demuxer, "Error while reading Chapter Tranlate");
+            }
         }
         else
         {
@@ -857,7 +973,7 @@ void matroska_segment_c::ParseChapterAtom( int i_level, KaxChapterAtom *ca, chap
         if( MKV_IS_ID( l, KaxChapterUID ) )
         {
             chapters.i_uid = uint64_t(*(KaxChapterUID*)l);
-            msg_Dbg( &sys.demuxer, "|   |   |   |   + ChapterUID: %"PRIu64"", chapters.i_uid );
+            msg_Dbg( &sys.demuxer, "|   |   |   |   + ChapterUID: %" PRIu64, chapters.i_uid );
         }
         else if( MKV_IS_ID( l, KaxChapterFlagHidden ) )
         {
@@ -877,25 +993,25 @@ void matroska_segment_c::ParseChapterAtom( int i_level, KaxChapterAtom *ca, chap
             chapters.p_segment_edition_uid = new KaxChapterSegmentEditionUID( *static_cast<KaxChapterSegmentEditionUID*>(l) );
             msg_Dbg( &sys.demuxer, "|   |   |   |   + ChapterSegmentEditionUID= %u",
 #if LIBMATROSKA_VERSION < 0x010300
-            *(uint32*)chapters.p_segment_edition_uid->GetBuffer()
+                     *(uint32*)chapters.p_segment_edition_uid->GetBuffer()
 #else
-            *(uint32*)chapters.p_segment_edition_uid
+                     *(uint32*)chapters.p_segment_edition_uid
 #endif
-            );
+                   );
         }
         else if( MKV_IS_ID( l, KaxChapterTimeStart ) )
         {
             KaxChapterTimeStart &start =*(KaxChapterTimeStart*)l;
             chapters.i_start_time = uint64( start ) / INT64_C(1000);
 
-            msg_Dbg( &sys.demuxer, "|   |   |   |   + ChapterTimeStart: %"PRId64"", chapters.i_start_time );
+            msg_Dbg( &sys.demuxer, "|   |   |   |   + ChapterTimeStart: %" PRId64, chapters.i_start_time );
         }
         else if( MKV_IS_ID( l, KaxChapterTimeEnd ) )
         {
             KaxChapterTimeEnd &end =*(KaxChapterTimeEnd*)l;
             chapters.i_end_time = uint64( end ) / INT64_C(1000);
 
-            msg_Dbg( &sys.demuxer, "|   |   |   |   + ChapterTimeEnd: %"PRId64"", chapters.i_end_time );
+            msg_Dbg( &sys.demuxer, "|   |   |   |   + ChapterTimeEnd: %" PRId64, chapters.i_end_time );
         }
         else if( MKV_IS_ID( l, KaxChapterDisplay ) )
         {
@@ -922,16 +1038,14 @@ void matroska_segment_c::ParseChapterAtom( int i_level, KaxChapterAtom *ca, chap
                 else if( MKV_IS_ID( l, KaxChapterLanguage ) )
                 {
                     KaxChapterLanguage &lang =*(KaxChapterLanguage*)l;
-                    const char *psz = string( lang ).c_str();
-
-                    msg_Dbg( &sys.demuxer, "|   |   |   |   |    + ChapterLanguage '%s'", psz );
+                    msg_Dbg( &sys.demuxer, "|   |   |   |   |    + ChapterLanguage '%s'",
+                             string( lang ).c_str() );
                 }
                 else if( MKV_IS_ID( l, KaxChapterCountry ) )
                 {
                     KaxChapterCountry &ct =*(KaxChapterCountry*)l;
-                    const char *psz = string( ct ).c_str();
-
-                    msg_Dbg( &sys.demuxer, "|   |   |   |   |    + ChapterCountry '%s'", psz );
+                    msg_Dbg( &sys.demuxer, "|   |   |   |   |    + ChapterCountry '%s'",
+                             string( ct ).c_str() );
                 }
             }
         }
@@ -994,34 +1108,50 @@ void matroska_segment_c::ParseAttachments( KaxAttachments *attachments )
     EbmlElement *el;
     int i_upper_level = 0;
 
-    attachments->Read( es, EBML_CONTEXT(attachments), i_upper_level, el, true );
+    if( unlikely( attachments->IsFiniteSize() && attachments->GetSize() >= SIZE_MAX ) )
+    {
+        msg_Err( &sys.demuxer, "Attachments too big, aborting" );
+        return;
+    }
+    try
+    {
+        attachments->Read( es, EBML_CONTEXT(attachments), i_upper_level, el, true );
+    }
+    catch(...)
+    {
+        msg_Err( &sys.demuxer, "Error while reading attachments" );
+        return;
+    }
 
     KaxAttached *attachedFile = FindChild<KaxAttached>( *attachments );
 
     while( attachedFile && ( attachedFile->GetSize() > 0 ) )
     {
         KaxFileData  &img_data     = GetChild<KaxFileData>( *attachedFile );
-        attachment_c *new_attachment = new attachment_c( ToUTF8( UTFstring( GetChild<KaxFileName>( *attachedFile ) ) ),
-                                                        GetChild<KaxMimeType>( *attachedFile ),
-                                                        img_data.GetSize() );
+        char *psz_tmp_utf8 =  ToUTF8( UTFstring( GetChild<KaxFileName>( *attachedFile ) ) );
+        std::string attached_filename(psz_tmp_utf8);
+        free(psz_tmp_utf8);
+        attachment_c *new_attachment = new attachment_c( attached_filename,
+                                                         GetChild<KaxMimeType>( *attachedFile ),
+                                                         img_data.GetSize() );
 
         msg_Dbg( &sys.demuxer, "|   |   - %s (%s)", new_attachment->fileName(), new_attachment->mimeType() );
 
         if( new_attachment->init() )
         {
-             memcpy( new_attachment->p_data, img_data.GetBuffer(), img_data.GetSize() );
-             sys.stored_attachments.push_back( new_attachment );
-             if( !strncmp( new_attachment->mimeType(), "image/", 6 ) )
-             {
-                 char *psz_url;
-                 if( asprintf( &psz_url, "attachment://%s",
-                             new_attachment->fileName() ) == -1 )
-                     continue;
-                 if( !sys.meta )
-                     sys.meta = vlc_meta_New();
-                 vlc_meta_SetArtURL( sys.meta, psz_url );
-                 free( psz_url );
-             }
+            memcpy( new_attachment->p_data, img_data.GetBuffer(), img_data.GetSize() );
+            sys.stored_attachments.push_back( new_attachment );
+            if( !strncmp( new_attachment->mimeType(), "image/", 6 ) )
+            {
+                char *psz_url;
+                if( asprintf( &psz_url, "attachment://%s",
+                              new_attachment->fileName() ) == -1 )
+                    continue;
+                if( !sys.meta )
+                    sys.meta = vlc_meta_New();
+                vlc_meta_SetArtURL( sys.meta, psz_url );
+                free( psz_url );
+            }
         }
         else
         {
@@ -1041,7 +1171,20 @@ void matroska_segment_c::ParseChapters( KaxChapters *chapters )
     int i_upper_level = 0;
 
     /* Master elements */
-    chapters->Read( es, EBML_CONTEXT(chapters), i_upper_level, el, true );
+    if( unlikely( chapters->IsFiniteSize() && chapters->GetSize() >= SIZE_MAX ) )
+    {
+        msg_Err( &sys.demuxer, "Chapters too big, aborting" );
+        return;
+    }
+    try
+    {
+        chapters->Read( es, EBML_CONTEXT(chapters), i_upper_level, el, true );
+    }
+    catch(...)
+    {
+        msg_Err( &sys.demuxer, "Error while reading chapters" );
+        return;
+    }
 
     for( size_t i = 0; i < chapters->ListSize(); i++ )
     {
@@ -1094,7 +1237,7 @@ void matroska_segment_c::ParseChapters( KaxChapters *chapters )
     }
 }
 
-void matroska_segment_c::ParseCluster( )
+void matroska_segment_c::ParseCluster( KaxCluster *cluster, bool b_update_start_time, ScopeMode read_fully )
 {
     EbmlElement *el;
     EbmlMaster  *m;
@@ -1102,7 +1245,20 @@ void matroska_segment_c::ParseCluster( )
 
     /* Master elements */
     m = static_cast<EbmlMaster *>( cluster );
-    m->Read( es, EBML_CONTEXT(cluster), i_upper_level, el, true );
+    if( unlikely( m->IsFiniteSize() && m->GetSize() >= SIZE_MAX ) )
+    {
+        msg_Err( &sys.demuxer, "Cluster too big, aborting" );
+        return;
+    }
+    try
+    {
+        m->Read( es, EBML_CONTEXT(cluster), i_upper_level, el, true, read_fully );
+    }
+    catch(...)
+    {
+        msg_Err( &sys.demuxer, "Error while reading cluster" );
+        return;
+    }
 
     for( unsigned int i = 0; i < m->ListSize(); i++ )
     {
@@ -1117,6 +1273,559 @@ void matroska_segment_c::ParseCluster( )
         }
     }
 
-    i_start_time = cluster->GlobalTimecode() / 1000;
+    if( b_update_start_time )
+        i_start_time = cluster->GlobalTimecode() / 1000;
 }
 
+
+int32_t matroska_segment_c::TrackInit( mkv_track_t * p_tk )
+{
+    es_format_t *p_fmt = &p_tk->fmt;
+
+    if( p_tk->psz_codec == NULL )
+    {
+        msg_Err( &sys.demuxer, "Empty codec id" );
+        p_tk->fmt.i_codec = VLC_FOURCC( 'u', 'n', 'd', 'f' );
+        return 0;
+    }
+
+    if( !strcmp( p_tk->psz_codec, "V_MS/VFW/FOURCC" ) )
+    {
+        if( p_tk->i_extra_data < (int)sizeof( VLC_BITMAPINFOHEADER ) )
+        {
+            msg_Err( &sys.demuxer, "missing/invalid VLC_BITMAPINFOHEADER" );
+            p_tk->fmt.i_codec = VLC_FOURCC( 'u', 'n', 'd', 'f' );
+        }
+        else
+        {
+            VLC_BITMAPINFOHEADER *p_bih = (VLC_BITMAPINFOHEADER*)p_tk->p_extra_data;
+
+            p_tk->fmt.video.i_width = GetDWLE( &p_bih->biWidth );
+            p_tk->fmt.video.i_height= GetDWLE( &p_bih->biHeight );
+            p_tk->fmt.i_codec       = GetFOURCC( &p_bih->biCompression );
+
+            p_tk->fmt.i_extra       = GetDWLE( &p_bih->biSize ) - sizeof( VLC_BITMAPINFOHEADER );
+            if( p_tk->fmt.i_extra > 0 )
+            {
+                /* Very unlikely yet possible: bug #5659*/
+                size_t maxlen = p_tk->i_extra_data - sizeof( VLC_BITMAPINFOHEADER );
+                p_tk->fmt.i_extra = ( (unsigned)p_tk->fmt.i_extra < maxlen )?
+                    p_tk->fmt.i_extra : maxlen;
+
+                p_tk->fmt.p_extra = xmalloc( p_tk->fmt.i_extra );
+                memcpy( p_tk->fmt.p_extra, &p_bih[1], p_tk->fmt.i_extra );
+            }
+        }
+        p_tk->b_dts_only = true;
+    }
+    else if( !strcmp( p_tk->psz_codec, "V_MPEG1" ) ||
+             !strcmp( p_tk->psz_codec, "V_MPEG2" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_MPGV;
+        if( p_tk->i_extra_data )
+            fill_extra_data( p_tk, 0 );
+    }
+    else if( !strncmp( p_tk->psz_codec, "V_THEORA", 8 ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_THEORA;
+        fill_extra_data( p_tk, 0 );
+        p_tk->b_pts_only = true;
+    }
+    else if( !strncmp( p_tk->psz_codec, "V_REAL/RV", 9 ) )
+    {
+        uint8_t *p = p_tk->p_extra_data;
+
+        if( !strcmp( p_tk->psz_codec, "V_REAL/RV10" ) )
+            p_fmt->i_codec = VLC_CODEC_RV10;
+        else if( !strcmp( p_tk->psz_codec, "V_REAL/RV20" ) )
+            p_fmt->i_codec = VLC_CODEC_RV20;
+        else if( !strcmp( p_tk->psz_codec, "V_REAL/RV30" ) )
+            p_fmt->i_codec = VLC_CODEC_RV30;
+        else if( !strcmp( p_tk->psz_codec, "V_REAL/RV40" ) )
+            p_fmt->i_codec = VLC_CODEC_RV40;
+
+        /* Extract the framerate from the header */
+        if( p_tk->i_extra_data >= 26 &&
+            p[4] == 'V' && p[5] == 'I' && p[6] == 'D' && p[7] == 'O' &&
+            p[8] == 'R' && p[9] == 'V' &&
+            (p[10] == '3' || p[10] == '4') && p[11] == '0' )
+        {
+            p_tk->fmt.video.i_frame_rate =
+                p[22] << 24 | p[23] << 16 | p[24] << 8 | p[25] << 0;
+            p_tk->fmt.video.i_frame_rate_base = 65536;
+        }
+
+        fill_extra_data( p_tk, 26 );
+        p_tk->b_dts_only = true;
+    }
+    else if( !strncmp( p_tk->psz_codec, "V_DIRAC", 7 ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_DIRAC;
+    }
+    else if( !strncmp( p_tk->psz_codec, "V_VP8", 5 ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_VP8;
+        p_tk->b_pts_only = true;
+    }
+    else if( !strncmp( p_tk->psz_codec, "V_VP9", 5 ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_VP9;
+        fill_extra_data( p_tk, 0 );
+    }
+    else if( !strncmp( p_tk->psz_codec, "V_MPEG4", 7 ) )
+    {
+        if( !strcmp( p_tk->psz_codec, "V_MPEG4/MS/V3" ) )
+        {
+            p_tk->fmt.i_codec = VLC_CODEC_DIV3;
+        }
+        else if( !strncmp( p_tk->psz_codec, "V_MPEG4/ISO", 11 ) )
+        {
+            /* A MPEG 4 codec, SP, ASP, AP or AVC */
+            if( !strcmp( p_tk->psz_codec, "V_MPEG4/ISO/AVC" ) )
+                p_tk->fmt.i_codec = VLC_FOURCC( 'a', 'v', 'c', '1' );
+            else
+                p_tk->fmt.i_codec = VLC_CODEC_MP4V;
+            fill_extra_data( p_tk, 0 );
+        }
+    }
+    else if( !strncmp( p_tk->psz_codec, "V_MPEGH/ISO/HEVC", 16) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_HEVC;
+        fill_extra_data( p_tk, 0 );
+    } 
+    else if( !strcmp( p_tk->psz_codec, "V_QUICKTIME" ) )
+    {
+        MP4_Box_t *p_box = (MP4_Box_t*)xmalloc( sizeof( MP4_Box_t ) );
+        stream_t *p_mp4_stream = stream_MemoryNew( VLC_OBJECT(&sys.demuxer),
+                                                   p_tk->p_extra_data,
+                                                   p_tk->i_extra_data,
+                                                   true );
+        if( MP4_ReadBoxCommon( p_mp4_stream, p_box ) &&
+            MP4_ReadBox_sample_vide( p_mp4_stream, p_box ) )
+        {
+            p_tk->fmt.i_codec = p_box->i_type;
+            uint32_t i_width = p_box->data.p_sample_vide->i_width;
+            uint32_t i_height = p_box->data.p_sample_vide->i_height;
+            if( i_width && i_height )
+            {
+                p_tk->fmt.video.i_width = i_width;
+                p_tk->fmt.video.i_height = i_height;
+            }
+            p_tk->fmt.i_extra = p_box->data.p_sample_vide->i_qt_image_description;
+            p_tk->fmt.p_extra = xmalloc( p_tk->fmt.i_extra );
+            memcpy( p_tk->fmt.p_extra, p_box->data.p_sample_vide->p_qt_image_description, p_tk->fmt.i_extra );
+            MP4_FreeBox_sample_vide( p_box );
+        }
+        else
+        {
+            free( p_box );
+        }
+        stream_Delete( p_mp4_stream );
+    }
+    else if( !strcmp( p_tk->psz_codec, "V_MJPEG" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_MJPG;
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_MS/ACM" ) )
+    {
+        if( p_tk->i_extra_data < (int)sizeof( WAVEFORMATEX ) )
+        {
+            msg_Err( &sys.demuxer, "missing/invalid WAVEFORMATEX" );
+            p_tk->fmt.i_codec = VLC_FOURCC( 'u', 'n', 'd', 'f' );
+        }
+        else
+        {
+            WAVEFORMATEX *p_wf = (WAVEFORMATEX*)p_tk->p_extra_data;
+
+            p_tk->fmt.audio.i_channels   = GetWLE( &p_wf->nChannels );
+            p_tk->fmt.audio.i_rate = GetDWLE( &p_wf->nSamplesPerSec );
+            p_tk->fmt.i_bitrate    = GetDWLE( &p_wf->nAvgBytesPerSec ) * 8;
+            p_tk->fmt.audio.i_blockalign = GetWLE( &p_wf->nBlockAlign );;
+            p_tk->fmt.audio.i_bitspersample = GetWLE( &p_wf->wBitsPerSample );
+
+            p_tk->fmt.i_extra            = GetWLE( &p_wf->cbSize );
+            if( p_tk->fmt.i_extra > 0 )
+            {
+                p_tk->fmt.p_extra = xmalloc( p_tk->fmt.i_extra );
+                if( p_tk->fmt.p_extra )
+                    memcpy( p_tk->fmt.p_extra, &p_wf[1], p_tk->fmt.i_extra );
+                else
+                    p_tk->fmt.i_extra = 0;
+            }
+
+            if( p_wf->wFormatTag == WAVE_FORMAT_EXTENSIBLE && 
+                p_tk->i_extra_data >= sizeof(WAVEFORMATEXTENSIBLE) )
+            {
+                WAVEFORMATEXTENSIBLE * p_wext = (WAVEFORMATEXTENSIBLE*) p_wf;
+                sf_tag_to_fourcc( &p_wext->SubFormat,  &p_tk->fmt.i_codec, NULL);
+                /* FIXME should we use Samples */
+
+                if( p_tk->fmt.audio.i_channels > 2 &&
+                    ( p_tk->fmt.i_codec != VLC_FOURCC( 'u', 'n', 'd', 'f' ) ) ) 
+                {
+                    uint32_t wfextcm = GetDWLE( &p_wext->dwChannelMask );
+                    int match;
+                    unsigned i_channel_mask = getChannelMask( &wfextcm,
+                                                              p_tk->fmt.audio.i_channels,
+                                                              &match );
+                    p_tk->fmt.i_codec = vlc_fourcc_GetCodecAudio( p_tk->fmt.i_codec,
+                                                                  p_tk->fmt.audio.i_bitspersample );
+                    if( i_channel_mask )
+                    {
+                        p_tk->i_chans_to_reorder = aout_CheckChannelReorder(
+                            pi_channels_aout, NULL,
+                            i_channel_mask,
+                            p_tk->pi_chan_table );
+
+                        p_tk->fmt.audio.i_physical_channels =
+                        p_tk->fmt.audio.i_original_channels = i_channel_mask;
+                    }
+                }
+            }
+            else
+                wf_tag_to_fourcc( GetWLE( &p_wf->wFormatTag ), &p_tk->fmt.i_codec, NULL );
+
+            if( p_tk->fmt.i_codec == VLC_FOURCC( 'u', 'n', 'd', 'f' ) )
+                msg_Err( &sys.demuxer, "Unrecognized wf tag: 0x%x", GetWLE( &p_wf->wFormatTag ) );
+        }
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_MPEG/L3" ) ||
+             !strcmp( p_tk->psz_codec, "A_MPEG/L2" ) ||
+             !strcmp( p_tk->psz_codec, "A_MPEG/L1" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_MPGA;
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_AC3" ) )
+    {
+        // the AC-3 default duration cannot be trusted, see #8512
+        if ( p_tk->fmt.audio.i_rate == 8000 )
+        {
+            p_tk->b_no_duration = true;
+            p_tk->i_default_duration = 0;
+        }
+        p_tk->fmt.i_codec = VLC_CODEC_A52;
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_EAC3" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_EAC3;
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_DTS" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_DTS;
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_MLP" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_MLP;
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_TRUEHD" ) )
+    {
+        /* FIXME when more samples arrive */
+        p_tk->fmt.i_codec = VLC_CODEC_TRUEHD;
+        p_fmt->b_packetized = false;
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_FLAC" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_FLAC;
+        fill_extra_data( p_tk, 8 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_VORBIS" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_VORBIS;
+        fill_extra_data( p_tk, 0 );
+    }
+    else if( !strncmp( p_tk->psz_codec, "A_OPUS", 6 ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_OPUS;
+        if( !p_tk->fmt.audio.i_rate )
+        {
+            msg_Err( &sys.demuxer,"No sampling rate, defaulting to 48kHz");
+            p_tk->fmt.audio.i_rate = 48000;
+        }
+        const uint8_t tags[16] = {'O','p','u','s','T','a','g','s',
+                                   0, 0, 0, 0, 0, 0, 0, 0};
+        unsigned ps[2] = { p_tk->i_extra_data, 16 };
+        const void *pkt[2] = { (const void *)p_tk->p_extra_data,
+                              (const void *) tags };
+
+        if( xiph_PackHeaders( &p_tk->fmt.i_extra,
+                              &p_tk->fmt.p_extra,
+                              ps, pkt, 2 ) )
+            msg_Err( &sys.demuxer, "Couldn't pack OPUS headers");
+
+    }
+    else if( !strncmp( p_tk->psz_codec, "A_AAC/MPEG2/", strlen( "A_AAC/MPEG2/" ) ) ||
+             !strncmp( p_tk->psz_codec, "A_AAC/MPEG4/", strlen( "A_AAC/MPEG4/" ) ) )
+    {
+        int i_profile, i_srate, sbr = 0;
+        static const unsigned int i_sample_rates[] =
+        {
+            96000, 88200, 64000, 48000, 44100, 32000, 24000, 22050,
+            16000, 12000, 11025,  8000,  7350,     0,     0,     0
+        };
+
+        p_tk->fmt.i_codec = VLC_CODEC_MP4A;
+        /* create data for faad (MP4DecSpecificDescrTag)*/
+
+        if( !strcmp( &p_tk->psz_codec[12], "MAIN" ) )
+        {
+            i_profile = 0;
+        }
+        else if( !strcmp( &p_tk->psz_codec[12], "LC" ) )
+        {
+            i_profile = 1;
+        }
+        else if( !strcmp( &p_tk->psz_codec[12], "SSR" ) )
+        {
+            i_profile = 2;
+        }
+        else if( !strcmp( &p_tk->psz_codec[12], "LC/SBR" ) )
+        {
+            i_profile = 1;
+            sbr = 1;
+        }
+        else
+        {
+            i_profile = 3;
+        }
+
+        for( i_srate = 0; i_srate < 13; i_srate++ )
+        {
+            if( i_sample_rates[i_srate] == p_tk->i_original_rate )
+            {
+                break;
+            }
+        }
+        msg_Dbg( &sys.demuxer, "profile=%d srate=%d", i_profile, i_srate );
+
+        p_tk->fmt.i_extra = sbr ? 5 : 2;
+        p_tk->fmt.p_extra = xmalloc( p_tk->fmt.i_extra );
+        ((uint8_t*)p_tk->fmt.p_extra)[0] = ((i_profile + 1) << 3) | ((i_srate&0xe) >> 1);
+        ((uint8_t*)p_tk->fmt.p_extra)[1] = ((i_srate & 0x1) << 7) | (p_tk->fmt.audio.i_channels << 3);
+        if (sbr != 0)
+        {
+            int syncExtensionType = 0x2B7;
+            int iDSRI;
+            for (iDSRI=0; iDSRI<13; iDSRI++)
+                if( i_sample_rates[iDSRI] == p_tk->fmt.audio.i_rate )
+                    break;
+            ((uint8_t*)p_tk->fmt.p_extra)[2] = (syncExtensionType >> 3) & 0xFF;
+            ((uint8_t*)p_tk->fmt.p_extra)[3] = ((syncExtensionType & 0x7) << 5) | 5;
+            ((uint8_t*)p_tk->fmt.p_extra)[4] = ((1 & 0x1) << 7) | (iDSRI << 3);
+        }
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_AAC" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_MP4A;
+        fill_extra_data( p_tk, 0 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_ALAC" ) )
+    {
+        p_tk->fmt.i_codec =  VLC_CODEC_ALAC;
+        fill_extra_data( p_tk, 0 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_WAVPACK4" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_WAVPACK;
+        fill_extra_data( p_tk, 0 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_TTA1" ) )
+    {
+        p_fmt->i_codec = VLC_CODEC_TTA;
+        if( p_tk->i_extra_data > 0 )
+        {
+            fill_extra_data( p_tk, 0 );
+        }
+        else
+        {
+            p_fmt->i_extra = 30;
+            p_fmt->p_extra = xmalloc( p_fmt->i_extra );
+            uint8_t *p_extra = (uint8_t*)p_fmt->p_extra;
+            memcpy( &p_extra[ 0], "TTA1", 4 );
+            SetWLE( &p_extra[ 4], 1 );
+            SetWLE( &p_extra[ 6], p_fmt->audio.i_channels );
+            SetWLE( &p_extra[ 8], p_fmt->audio.i_bitspersample );
+            SetDWLE( &p_extra[10], p_fmt->audio.i_rate );
+            SetDWLE( &p_extra[14], 0xffffffff );
+            memset( &p_extra[18], 0, 30  - 18 );
+        }
+    }
+    else if( !strcmp( p_tk->psz_codec, "A_PCM/INT/BIG" ) ||
+             !strcmp( p_tk->psz_codec, "A_PCM/INT/LIT" ) ||
+             !strcmp( p_tk->psz_codec, "A_PCM/FLOAT/IEEE" ) )
+    {
+        if( !strcmp( p_tk->psz_codec, "A_PCM/INT/BIG" ) )
+        {
+            p_tk->fmt.i_codec = VLC_FOURCC( 't', 'w', 'o', 's' );
+        }
+        else
+        {
+            p_tk->fmt.i_codec = VLC_FOURCC( 'a', 'r', 'a', 'w' );
+        }
+        p_tk->fmt.audio.i_blockalign = ( p_tk->fmt.audio.i_bitspersample + 7 ) / 8 * p_tk->fmt.audio.i_channels;
+    }
+    else if( !strncmp( p_tk->psz_codec, "A_REAL/", 7 ) )
+    {
+        if( !strcmp( p_tk->psz_codec, "A_REAL/14_4" ) )
+        {
+            p_fmt->i_codec = VLC_CODEC_RA_144;
+            p_fmt->audio.i_channels = 1;
+            p_fmt->audio.i_rate = 8000;
+            p_fmt->audio.i_blockalign = 0x14;
+        }
+        else if( p_tk->i_extra_data > 28 )
+        {
+            uint8_t *p = p_tk->p_extra_data;
+            if( memcmp( p, ".ra", 3 ) ) {
+                msg_Err( &sys.demuxer, "Invalid Real ExtraData 0x%4.4s", (char *)p );
+                p_tk->fmt.i_codec = VLC_FOURCC( 'u', 'n', 'd', 'f' );
+            }
+            else
+            {
+                real_audio_private * priv = (real_audio_private*) p_tk->p_extra_data;
+                if( !strcmp( p_tk->psz_codec, "A_REAL/COOK" ) )
+                {
+                    p_tk->fmt.i_codec = VLC_CODEC_COOK;
+                    p_tk->fmt.audio.i_blockalign = hton16(priv->sub_packet_size);
+                }
+                else if( !strcmp( p_tk->psz_codec, "A_REAL/ATRC" ) )
+                    p_tk->fmt.i_codec = VLC_CODEC_ATRAC3;
+                else if( !strcmp( p_tk->psz_codec, "A_REAL/28_8" ) )
+                    p_tk->fmt.i_codec = VLC_CODEC_RA_288;
+                /* FIXME RALF and SIPR */
+                uint16_t version = (uint16_t) hton16(priv->version);
+                p_tk->p_sys =
+                    new Cook_PrivateTrackData( hton16(priv->sub_packet_h),
+                                               hton16(priv->frame_size),
+                                               hton16(priv->sub_packet_size));
+                if( unlikely( !p_tk->p_sys ) )
+                    return 1;
+
+                if( unlikely( p_tk->p_sys->Init() ) )
+                    return 1;
+
+                if( version == 4 )
+                {
+                    real_audio_private_v4 * v4 = (real_audio_private_v4*) priv;
+                    p_tk->fmt.audio.i_channels = hton16(v4->channels);
+                    p_tk->fmt.audio.i_bitspersample = hton16(v4->sample_size);
+                    p_tk->fmt.audio.i_rate = hton16(v4->sample_rate);
+                }
+                else if( version == 5 )
+                {
+                    real_audio_private_v5 * v5 = (real_audio_private_v5*) priv;
+                    p_tk->fmt.audio.i_channels = hton16(v5->channels);
+                    p_tk->fmt.audio.i_bitspersample = hton16(v5->sample_size);
+                    p_tk->fmt.audio.i_rate = hton16(v5->sample_rate);
+                }
+                msg_Dbg(&sys.demuxer, "%d channels %d bits %d Hz",p_tk->fmt.audio.i_channels, p_tk->fmt.audio.i_bitspersample, p_tk->fmt.audio.i_rate);
+
+                fill_extra_data( p_tk, p_tk->fmt.i_codec == VLC_CODEC_RA_288 ? 0 : 78);
+            }
+        }
+    }
+    else if( !strncmp( p_tk->psz_codec, "A_QUICKTIME", 11 ) )
+    {
+        p_tk->fmt.i_cat = AUDIO_ES;
+        if ( !strncmp( p_tk->psz_codec+11, "/QDM2", 5 ) )
+            p_tk->fmt.i_codec = VLC_CODEC_QDM2;
+        else if( !strncmp( p_tk->psz_codec+11, "/QDMC", 5 ) )
+            p_tk->fmt.i_codec = VLC_FOURCC('Q','D','M','C');
+        else if( p_tk->i_extra_data >= 8)
+            p_tk->fmt.i_codec = VLC_FOURCC(p_tk->p_extra_data[4],
+                                           p_tk->p_extra_data[5],
+                                           p_tk->p_extra_data[6],
+                                           p_tk->p_extra_data[7]);
+        fill_extra_data( p_tk, 0 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "S_KATE" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_KATE;
+        p_tk->fmt.subs.psz_encoding = strdup( "UTF-8" );
+
+        fill_extra_data( p_tk, 0 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "S_TEXT/ASCII" ) )
+    {
+        p_fmt->i_codec = VLC_CODEC_SUBT;
+        p_fmt->subs.psz_encoding = strdup( "ASCII" );
+    }
+    else if( !strcmp( p_tk->psz_codec, "S_TEXT/UTF8" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_SUBT;
+        p_tk->fmt.subs.psz_encoding = strdup( "UTF-8" );
+    }
+    else if( !strcmp( p_tk->psz_codec, "S_TEXT/USF" ) )
+    {
+        p_tk->fmt.i_codec = VLC_FOURCC( 'u', 's', 'f', ' ' );
+        p_tk->fmt.subs.psz_encoding = strdup( "UTF-8" );
+        if( p_tk->i_extra_data )
+            fill_extra_data( p_tk, 0 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "S_TEXT/SSA" ) ||
+             !strcmp( p_tk->psz_codec, "S_TEXT/ASS" ) ||
+             !strcmp( p_tk->psz_codec, "S_SSA" ) ||
+             !strcmp( p_tk->psz_codec, "S_ASS" ))
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_SSA;
+        p_tk->fmt.subs.psz_encoding = strdup( "UTF-8" );
+        if( p_tk->i_extra_data )
+            fill_extra_data( p_tk, 0 );
+    }
+    else if( !strcmp( p_tk->psz_codec, "S_VOBSUB" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_SPU;
+        p_tk->b_no_duration = true;
+        if( p_tk->i_extra_data )
+        {
+            char *psz_start;
+            char *psz_buf = (char *)malloc( p_tk->i_extra_data + 1);
+            if( psz_buf != NULL )
+            {
+                memcpy( psz_buf, p_tk->p_extra_data , p_tk->i_extra_data );
+                psz_buf[p_tk->i_extra_data] = '\0';
+
+                psz_start = strstr( psz_buf, "size:" );
+                if( psz_start &&
+                    vobsub_size_parse( psz_start,
+                                       &p_tk->fmt.subs.spu.i_original_frame_width,
+                                       &p_tk->fmt.subs.spu.i_original_frame_height ) == VLC_SUCCESS )
+                {
+                    msg_Dbg( &sys.demuxer, "original frame size vobsubs: %dx%d",
+                             p_tk->fmt.subs.spu.i_original_frame_width,
+                             p_tk->fmt.subs.spu.i_original_frame_height );
+                }
+                else
+                {
+                    msg_Warn( &sys.demuxer, "reading original frame size for vobsub failed" );
+                }
+
+                psz_start = strstr( psz_buf, "palette:" );
+                if( psz_start &&
+                    vobsub_palette_parse( psz_start, &p_tk->fmt.subs.spu.palette[1] ) == VLC_SUCCESS )
+                {
+                    p_tk->fmt.subs.spu.palette[0] =  0xBeef;
+                    msg_Dbg( &sys.demuxer, "vobsub palette read" );
+                }
+                else
+                {
+                    msg_Warn( &sys.demuxer, "reading original palette failed" );
+                }
+                free( psz_buf );
+            }
+        }
+    }
+    else if( !strcmp( p_tk->psz_codec, "S_HDMV/PGS" ) )
+    {
+        p_tk->fmt.i_codec = VLC_CODEC_BD_PG;
+    }
+    else if( !strcmp( p_tk->psz_codec, "B_VOBBTN" ) )
+    {
+        p_tk->fmt.i_cat = NAV_ES;
+    }
+    else
+    {
+        msg_Err( &sys.demuxer, "unknown codec id=`%s'", p_tk->psz_codec );
+        p_tk->fmt.i_codec = VLC_FOURCC( 'u', 'n', 'd', 'f' );
+    }
+    return 0;
+}