2.0. Fixed rendering stalls caused by ogl frame allocation delays.

[casparcg] / modules / ffmpeg / producer / ffmpeg_producer.cpp

diff --git a/modules/ffmpeg/producer/ffmpeg_producer.cpp b/modules/ffmpeg/producer/ffmpeg_producer.cpp
index d20cbaca4f0a73f4d0280d3e121e1720b8ccdbd1..d1ca8c0295a97d0f420c87ef472398903f3f0778 100644 (file)
--- a/modules/ffmpeg/producer/ffmpeg_producer.cpp
+++ b/modules/ffmpeg/producer/ffmpeg_producer.cpp
@@ -99,8 +99,22 @@ public:
                graph_->set_color("frame-time", diagnostics::color(0.1f, 1.0f, 0.1f));\r
                graph_->set_color("underflow", diagnostics::color(0.6f, 0.3f, 0.9f));   \r
                \r
-               for(int n = 0; n < 32 && muxer_.empty(); ++n)\r
-                       decode_frame(0);\r
+               // Do some pre-work in order to not block rendering thread for initialization and allocations.\r
+\r
+               push_packets();\r
+               auto video_frames = video_decoder_.poll();\r
+               if(!video_frames.empty())\r
+               {\r
+                       auto& video_frame = video_frames.front();\r
+                       auto  desc                = get_pixel_format_desc(static_cast<PixelFormat>(video_frame->format), video_frame->width, video_frame->height);\r
+                       if(desc.pix_fmt == core::pixel_format::invalid)\r
+                               get_pixel_format_desc(PIX_FMT_BGRA, video_frame->width, video_frame->height);\r
+                       \r
+                       for(int n = 0; n < 3; ++n)\r
+                               frame_factory->create_frame(this, desc);\r
+               }\r
+               BOOST_FOREACH(auto& video, video_frames)                        \r
+                       muxer_.push(video, 0);  \r
        }\r
                        \r
        virtual safe_ptr<core::basic_frame> receive(int hints)\r
@@ -132,7 +146,7 @@ public:
                return disable_audio(last_frame_);\r
        }\r
 \r
-       void decode_frame(int hints)\r
+       void push_packets()\r
        {\r
                for(int n = 0; n < 16 && ((!muxer_.video_ready() && !video_decoder_.ready()) || (!muxer_.audio_ready() && !audio_decoder_.ready())); ++n) \r
                {\r
@@ -143,6 +157,11 @@ public:
                                audio_decoder_.push(pkt);\r
                        }\r
                }\r
+       }\r
+\r
+       void decode_frame(int hints)\r
+       {\r
+               push_packets();\r
                \r
                tbb::parallel_invoke(\r
                [&]\r
@@ -197,7 +216,7 @@ public:
        {\r
                return L"ffmpeg[" + boost::filesystem::wpath(filename_).filename() + L"|" \r
                                                  + boost::lexical_cast<std::wstring>(width_) + L"x" + boost::lexical_cast<std::wstring>(height_)\r
-                                                 + (is_progressive_ ? L"p" : L"i")  + boost::lexical_cast<std::wstring>(fps_)\r
+                                                 + (is_progressive_ ? L"p" : L"i")  + boost::lexical_cast<std::wstring>(is_progressive_ ? fps_ : 2.0 * fps_)\r
                                                  + L"]";\r
        }\r
 };\r