]> git.sesse.net Git - vlc/blobdiff - modules/gui/qt4/menus.cpp
Various strings change and capitalisation changes to match the guidelines.
[vlc] / modules / gui / qt4 / menus.cpp
index 8dec77397f7a76ce7cd3c1cafd1422528b44ea02..5962c192d2c540098a64a7b7da9dcb7b78501a8d 100644 (file)
@@ -1,16 +1,17 @@
 /*****************************************************************************
  * menus.cpp : Qt menus
  *****************************************************************************
- * Copyright (C) 2006-2007 the VideoLAN team
+ * Copyright © 2006-2008 the VideoLAN team
  * $Id$
  *
- * Authors: Clément Stenac <zorglub@videolan.org>
+ * Authors: Clément Stenac <zorglub@videolan.org>
  *          Jean-Baptiste Kempf <jb@videolan.org>
+ *          Jean-Philippe André <jpeg@videolan.org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
+ * ( at your option ) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 
-#include <QMenu>
-#include <QMenuBar>
-#include <QAction>
-#include <QActionGroup>
-#include <QSignalMapper>
+/** \todo
+ * - Remove static currentGroup
+ */
 
-#ifndef WIN32
-#   include <signal.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
 #endif
 
+#include <vlc_common.h>
+
 #include <vlc_intf_strings.h>
 
 #include "main_interface.hpp"
 #include "dialogs_provider.hpp"
 #include "input_manager.hpp"
 
+#include <QMenu>
+#include <QMenuBar>
+#include <QAction>
+#include <QActionGroup>
+#include <QSignalMapper>
+#include <QSystemTrayIcon>
+
+/*
+  This file defines the main menus and the pop-up menu (right-click menu)
+  and the systray menu (in that order in the file)
+
+  There are 3 menus that have to be rebuilt everytime there are called:
+  Audio, Video, Navigation
+  3 functions are building those menus: AudioMenu, VideoMenu, NavigMenu
+  and 3 functions associated are collecting the objects :
+  InputAutoMenuBuilder, AudioAutoMenuBuilder, VideoAutoMenuBuilder.
+
+  A QSignalMapper decides when to rebuild those menus cf MenuFunc in the .hpp
+  Just before one of those menus are aboutToShow(), they are rebuild.
+
+
+  */
+
 enum
 {
     ITEM_NORMAL,
@@ -49,64 +73,101 @@ enum
 static QActionGroup *currentGroup;
 
 // Add static entries to menus
-#define DP_SADD( text, help, icon, slot, shortcut ) \
-    { \
-    if( strlen(icon) > 0 ) \
-    { \
-        if( strlen(shortcut) > 0 ) \
-        { \
-            menu->addAction( QIcon(icon), text, THEDP, SLOT( slot ), \
-                    tr(shortcut) );\
-        } \
-        else \
-        { \
-            menu->addAction( QIcon(icon), text, THEDP, SLOT( slot ) );\
-        } \
-    } \
-    else \
-    { \
-        if( strlen(shortcut) > 0 ) \
-        { \
-            menu->addAction( text, THEDP, SLOT( slot ), \
-                   qtr(shortcut) ); \
-        } \
-        else \
-        { \
-            menu->addAction( text, THEDP, SLOT( slot ) ); \
-        } \
-    } \
-    }
-#define MIM_SADD( text, help, icon, slot ) \
-    { \
-    if( strlen(icon) > 0 ) \
-    { \
-        QAction *action = menu->addAction( text, THEMIM, SLOT( slot ) ); \
-        action->setIcon(QIcon(icon)); \
-    } \
-    else \
-    { \
-        menu->addAction( text, THEMIM, SLOT( slot ) ); \
-    } \
-    }
-#define PL_SADD
+void addDPStaticEntry( QMenu *menu,
+                       const QString text,
+                       const char *help,
+                       const char *icon,
+                       const char *member,
+                       const char *shortcut = NULL )
+{
+    QAction *action = NULL;
+    if( !EMPTY_STR( icon ) > 0 )
+    {
+        if( !EMPTY_STR( shortcut ) > 0 )
+            action = menu->addAction( QIcon( icon ), text, THEDP,
+                                      member, qtr( shortcut ) );
+        else
+            action = menu->addAction( QIcon( icon ), text, THEDP, member );
+    }
+    else
+    {
+        if( !EMPTY_STR( shortcut ) > 0 )
+            action = menu->addAction( text, THEDP, member, qtr( shortcut ) );
+        else
+            action = menu->addAction( text, THEDP, member );
+    }
+    action->setData( "_static_" );
+}
+
+void addMIMStaticEntry( intf_thread_t *p_intf,
+                        QMenu *menu,
+                        const QString text,
+                        const char *help,
+                        const char *icon,
+                        const char *member )
+{
+    if( strlen( icon ) > 0 )
+    {
+        QAction *action = menu->addAction( text, THEMIM,  member );
+        action->setIcon( QIcon( icon ) );
+    }
+    else
+    {
+        menu->addAction( text, THEMIM, member );
+    }
+}
+
+void EnableDPStaticEntries( QMenu *menu, bool enable = true )
+{
+    if( !menu )
+        return;
+
+    QAction *action;
+    foreach( action, menu->actions() )
+    {
+        if( action->data().toString() == "_static_" )
+            action->setEnabled( enable );
+    }
+}
+
+/**
+ * \return Number of static entries
+ */
+int DeleteNonStaticEntries( QMenu *menu )
+{
+    int i_ret = 0;
+    QAction *action;
+    if( !menu )
+        return VLC_EGENERIC;
+    foreach( action, menu->actions() )
+    {
+        if( action->data().toString() != "_static_" )
+            delete action;
+        else
+            i_ret++;
+    }
+}
 
 /*****************************************************************************
  * Definitions of variables for the dynamic menus
  *****************************************************************************/
 #define PUSH_VAR( var ) varnames.push_back( var ); \
-                        objects.push_back( p_object->i_object_id )
+    objects.push_back( p_object ? p_object->i_object_id : 0 )
+
+#define PUSH_INPUTVAR( var ) varnames.push_back( var ); \
+    objects.push_back( p_input ? p_input->i_object_id : 0 );
 
 #define PUSH_SEPARATOR if( objects.size() != i_last_separator ) { \
-                           objects.push_back( 0 ); varnames.push_back( "" ); \
-                           i_last_separator = objects.size(); }
+    objects.push_back( 0 ); varnames.push_back( "" ); \
+    i_last_separator = objects.size(); }
 
 static int InputAutoMenuBuilder( vlc_object_t *p_object,
-                                 vector<int> &objects,
-                                 vector<const char *> &varnames )
+        vector<int> &objects,
+        vector<const char *> &varnames )
 {
-    PUSH_VAR( "bookmark");
+    PUSH_VAR( "bookmark" );
     PUSH_VAR( "title" );
-    PUSH_VAR ("chapter" );
+    PUSH_VAR"chapter" );
     PUSH_VAR( "program" );
     PUSH_VAR( "navigation" );
     PUSH_VAR( "dvd_menus" );
@@ -114,9 +175,12 @@ static int InputAutoMenuBuilder( vlc_object_t *p_object,
 }
 
 static int VideoAutoMenuBuilder( vlc_object_t *p_object,
-                                 vector<int> &objects,
-                                 vector<const char *> &varnames )
+        input_thread_t *p_input,
+        vector<int> &objects,
+        vector<const char *> &varnames )
 {
+    PUSH_INPUTVAR( "video-es" );
+    PUSH_INPUTVAR( "spu-es" );
     PUSH_VAR( "fullscreen" );
     PUSH_VAR( "zoom" );
     PUSH_VAR( "deinterlace" );
@@ -126,141 +190,236 @@ static int VideoAutoMenuBuilder( vlc_object_t *p_object,
     PUSH_VAR( "directx-wallpaper" );
     PUSH_VAR( "video-snapshot" );
 
-    vlc_object_t *p_dec_obj = (vlc_object_t *)vlc_object_find( p_object,
-                                                 VLC_OBJECT_DECODER,
-                                                 FIND_PARENT );
-    if( p_dec_obj != NULL )
+    if( p_object )
     {
-        vlc_object_t *p_object = p_dec_obj;
-        PUSH_VAR( "ffmpeg-pp-q" );
-        vlc_object_release( p_dec_obj );
+        vlc_object_t *p_dec_obj = ( vlc_object_t * )vlc_object_find( p_object,
+                VLC_OBJECT_DECODER,
+                FIND_PARENT );
+        if( p_dec_obj )
+        {
+            vlc_object_t *p_object = p_dec_obj;
+            PUSH_VAR( "ffmpeg-pp-q" );
+            vlc_object_release( p_dec_obj );
+        }
     }
     return VLC_SUCCESS;
 }
 
 static int AudioAutoMenuBuilder( vlc_object_t *p_object,
-                                 vector<int> &objects,
-                                 vector<const char *> &varnames )
+        input_thread_t *p_input,
+        vector<int> &objects,
+        vector<const char *> &varnames )
 {
+    PUSH_INPUTVAR( "audio-es" );
     PUSH_VAR( "audio-device" );
     PUSH_VAR( "audio-channels" );
-    PUSH_VAR( "visual" );
     PUSH_VAR( "equalizer" );
+    PUSH_VAR( "visual" );
     return VLC_SUCCESS;
 }
 
+static QAction * FindActionWithVar( QMenu *menu, const char *psz_var )
+{
+    QAction *action;
+    foreach( action, menu->actions() )
+    {
+        if( action->data().toString() == psz_var )
+            return action;
+    }
+    return NULL;
+}
+
+static QAction * FindActionWithText( QMenu *menu, QString &text )
+{
+    QAction *action;
+    foreach( action, menu->actions() )
+    {
+        if( action->text() == text )
+            return action;
+    }
+    return NULL;
+}
+
 /*****************************************************************************
  * All normal menus
+ * Simple Code
  *****************************************************************************/
 
 #define BAR_ADD( func, title ) { \
-    QMenu *menu = func; menu->setTitle( title  ); bar->addMenu( menu ); }
+    QMenu *_menu = func; _menu->setTitle( title ); bar->addMenu( _menu ); }
 
 #define BAR_DADD( func, title, id ) { \
-    QMenu *menu = func; menu->setTitle( title  ); bar->addMenu( menu ); \
-    MenuFunc *f = new MenuFunc( menu, id ); \
-    CONNECT( menu, aboutToShow(), THEDP->menusUpdateMapper, map() ); \
-    THEDP->menusUpdateMapper->setMapping( menu, f ); }
-
-void QVLCMenu::createMenuBar( MainInterface *mi, intf_thread_t *p_intf,
-                              bool playlist, bool adv_controls_enabled,
+    QMenu *_menu = func; _menu->setTitle( title ); bar->addMenu( _menu ); \
+    MenuFunc *f = new MenuFunc( _menu, id ); \
+    CONNECT( _menu, aboutToShow(), THEDP->menusUpdateMapper, map() ); \
+    THEDP->menusUpdateMapper->setMapping( _menu, f ); }
+
+#define ACT_ADD( _menu, val, title ) { \
+    QAction *_action = new QAction( title, _menu ); _action->setData( val ); \
+    _menu->addAction( _action ); }
+
+/**
+ * Main Menu Bar Creation
+ **/
+void QVLCMenu::createMenuBar( MainInterface *mi,
+                              intf_thread_t *p_intf,
                               bool visual_selector_enabled )
 {
-#ifndef WIN32
-    /* Ugly klugde
-     * Remove SIGCHLD from the ignored signal the time to initialise
-     * Qt because it call gconf to get the icon theme */
-    sigset_t set;
-
-    sigemptyset( &set );
-    sigaddset( &set, SIGCHLD );
-    pthread_sigmask (SIG_UNBLOCK, &set, NULL);
-#endif
+    /* QMainWindows->menuBar()
+       gives the QProcess::destroyed timeout issue on Cleanlooks style with
+       setDesktopAware set to false */
     QMenuBar *bar = mi->menuBar();
-#ifndef WIN32 
-    pthread_sigmask (SIG_BLOCK, &set, NULL);
-#endif
-    BAR_ADD( FileMenu(), qtr("&Media") );
-    if( playlist )
-    {
-        BAR_ADD( PlaylistMenu( mi,p_intf ), qtr("&Playlist" ) );
-    }
-    BAR_ADD( ToolsMenu( p_intf, mi, adv_controls_enabled,
-                        visual_selector_enabled ), qtr("&Tools") );
-    BAR_DADD( VideoMenu( p_intf, NULL ), qtr("&Video"), 1 );
-    BAR_DADD( AudioMenu( p_intf, NULL ), qtr("&Audio"), 2 );
-    BAR_DADD( NavigMenu( p_intf, NULL ), qtr("&Navigation"), 3 );
-
-    BAR_ADD( HelpMenu(), qtr("&Help" ) );
+    BAR_ADD( FileMenu(), qtr( "&Media" ) );
+    BAR_ADD( PlaylistMenu( p_intf, mi ), qtr( "&Playlist" ) );
+    BAR_ADD( ToolsMenu( p_intf, NULL, mi, visual_selector_enabled, true ),
+             qtr( "&Tools" ) );
+    BAR_DADD( AudioMenu( p_intf, NULL ), qtr( "&Audio" ), 1 );
+    BAR_DADD( VideoMenu( p_intf, NULL ), qtr( "&Video" ), 2 );
+    BAR_DADD( NavigMenu( p_intf, NULL ), qtr( "&Playback" ), 3 );
+    BAR_ADD( HelpMenu( NULL ), qtr( "&Help" ) );
 }
+#undef BAR_ADD
+#undef BAR_DADD
+
+/**
+ * Media ( File ) Menu
+ * Opening, streaming and quit
+ **/
 QMenu *QVLCMenu::FileMenu()
 {
     QMenu *menu = new QMenu();
-    DP_SADD( qtr("Open &File..." ), "", "", openFileDialog(), "Ctrl+O" );
-    DP_SADD( qtr("Open &Disc..." ), "", "", openDiscDialog(), "Ctrl+D" );
-    DP_SADD( qtr("Open &Network..." ), "", "", openNetDialog(), "Ctrl+N" );
-    DP_SADD( qtr("Open &Capture Device..." ), "", "", openCaptureDialog(),
-            "Ctrl+C" );
+
+    addDPStaticEntry( menu, qtr( "&Open File..." ), "",
+        ":/pixmaps/file-asym_16px.png", SLOT( openFileDialog() ), "Ctrl+O" );
+    addDPStaticEntry( menu, qtr( I_OPEN_FOLDER ), "",
+        ":/pixmaps/folder-grey_16px.png", SLOT( PLAppendDir() ), "Ctrl+F" );
+    addDPStaticEntry( menu, qtr( "Open &Disc..." ), "",
+        ":/pixmaps/disc_16px.png", SLOT( openDiscDialog() ), "Ctrl+D" );
+    addDPStaticEntry( menu, qtr( "Open &Network..." ), "",
+        ":/pixmaps/network_16px.png", SLOT( openNetDialog() ), "Ctrl+N" );
+    addDPStaticEntry( menu, qtr( "Open &Capture Device..." ), "",
+        ":/pixmaps/capture-card_16px.png", SLOT( openCaptureDialog() ),
+        "Ctrl+C" );
     menu->addSeparator();
-    DP_SADD( qtr("&Streaming..."), "", "", openThenStreamingDialogs(), 
-            "Ctrl+S" );
-    DP_SADD( qtr("Conve&rt / Save..."), "", "", openThenTranscodingDialogs(), 
-            "Ctrl+R" );
+
+    addDPStaticEntry( menu, qtr( "&Streaming..." ), "",
+        ":/pixmaps/menus_stream_16px.png", SLOT( openThenStreamingDialogs() ),
+        "Ctrl+S" );
+    addDPStaticEntry( menu, qtr( "Conve&rt / Save..." ), "", "",
+        SLOT( openThenTranscodingDialogs() ), "Ctrl+R" );
     menu->addSeparator();
-    DP_SADD( qtr("&Quit") , "", "", quit(), "Ctrl+Q");
+
+    addDPStaticEntry( menu, qtr( "&Quit" ) , "",
+        ":/pixmaps/menus_quit_16px.png", SLOT( quit() ), "Ctrl+Q" );
     return menu;
 }
 
-QMenu *QVLCMenu::PlaylistMenu( MainInterface *mi, intf_thread_t *p_intf )
+/* Playlist/MediaLibrary Control */
+QMenu *QVLCMenu::PlaylistMenu( intf_thread_t *p_intf, MainInterface *mi )
 {
     QMenu *menu = new QMenu();
     menu->addMenu( SDMenu( p_intf ) );
+    menu->addAction( QIcon( ":/pixmaps/playlist_16px.png" ),
+                     qtr( "Show Playlist" ), mi, SLOT( togglePlaylist() ) );
     menu->addSeparator();
 
-    DP_SADD( qtr(I_PL_LOAD), "", "", openPlaylist(), "Ctrl+L" );
-    DP_SADD( qtr(I_PL_SAVE), "", "", savePlaylist(), "Ctrl+K" );
+    addDPStaticEntry( menu, qtr( I_PL_LOAD ), "", "", SLOT( openAPlaylist() ),
+        "Ctrl+X" );
+    addDPStaticEntry( menu, qtr( I_PL_SAVE ), "", "", SLOT( saveAPlaylist() ),
+        "Ctrl+Y" );
     menu->addSeparator();
-    menu->addAction( qtr("Undock from interface"), mi,
-                     SLOT( undockPlaylist() ), qtr("Ctrl+U") );
+    menu->addAction( qtr( "Undock from Interface" ), mi,
+                     SLOT( undockPlaylist() ), qtr( "Ctrl+U" ) );
     return menu;
 }
 
-QMenu *QVLCMenu::ToolsMenu( intf_thread_t *p_intf, MainInterface *mi,
-                            bool adv_controls_enabled,
-                            bool visual_selector_enabled, bool with_intf )
+/**
+ * Tools/View Menu
+ * This is kept in the same menu for now, but could change if it gets much
+ * longer.
+ * This menu can be an interface menu but also a right click menu.
+ **/
+QMenu *QVLCMenu::ToolsMenu( intf_thread_t *p_intf,
+                            QMenu *current,
+                            MainInterface *mi,
+                            bool visual_selector_enabled,
+                            bool with_intf )
 {
-    QMenu *menu = new QMenu();
+    QMenu *menu = new QMenu( current );
+    if( mi )
+    {
+        menu->addAction( QIcon( ":/pixmaps/playlist_16px.png" ),
+                         qtr( "Playlist..." ), mi, SLOT( togglePlaylist() ),
+                         qtr( "Ctrl+L" ) );
+    }
+    addDPStaticEntry( menu, qtr( I_MENU_EXT ), "",
+        ":/pixmaps/menus_settings_16px.png", SLOT( extendedDialog() ),
+        "Ctrl+E" );
+
+    menu->addSeparator();
+
     if( with_intf )
     {
-        QMenu *intfmenu = InterfacesMenu( p_intf, NULL );
-        intfmenu->setTitle( qtr("Interfaces" ) );
+        QMenu *intfmenu = InterfacesMenu( p_intf, menu );
+        intfmenu->setTitle( qtr( "Add Interfaces" ) );
+        MenuFunc *f = new MenuFunc( intfmenu, 4 );
+        CONNECT( intfmenu, aboutToShow(), THEDP->menusUpdateMapper, map() );
+        THEDP->menusUpdateMapper->setMapping( intfmenu, f );
         menu->addMenu( intfmenu );
         menu->addSeparator();
     }
-    DP_SADD( qtr(I_MENU_MSG), "", "", messagesDialog(), "Ctrl+M" );
-    DP_SADD( qtr(I_MENU_INFO) , "", "", mediaInfoDialog(), "Ctrl+J" );
-    DP_SADD( qtr(I_MENU_CODECINFO) , "", "", mediaCodecDialog(), "Ctrl+I" );
-    menu->addSeparator();
     if( mi )
     {
-        QAction *adv = menu->addAction( qtr("Advanced controls" ),
-                                        mi, SLOT( advanced() ) );
-        adv->setCheckable( true );
-        if( adv_controls_enabled ) adv->setChecked( true );
-#if 0
-        adv = menu->addAction( qtr("Visualizations selector" ),
-                               mi, SLOT( visual() ) );
+        /* Minimal View */
+        QAction *action = menu->addAction( qtr( "Minimal View..." ), mi,
+                                SLOT( toggleMinimalView() ), qtr( "Ctrl+H" ) );
+        action->setCheckable( true );
+        if( mi->getControlsVisibilityStatus() & CONTROLS_VISIBLE )
+            action->setChecked( true );
+
+        /* FullScreen View */
+        action = menu->addAction( qtr( "Toggle Fullscreen Interface" ), mi,
+                                  SLOT( toggleFullScreen() ), QString( "F11" ) );
+
+        /* Advanced Controls */
+        action = menu->addAction( qtr( "Advanced Controls" ), mi,
+                                  SLOT( toggleAdvanced() ) );
+        action->setCheckable( true );
+        if( mi->getControlsVisibilityStatus() & CONTROLS_ADVANCED )
+            action->setChecked( true );
+#if 0 /* For Visualisations. Not yet working */
+        adv = menu->addAction( qtr( "Visualizations selector" ),
+                mi, SLOT( visual() ) );
         adv->setCheckable( true );
         if( visual_selector_enabled ) adv->setChecked( true );
 #endif
     }
-    DP_SADD( qtr(I_MENU_EXT), "","",extendedDialog(), "Ctrl+E" );
-    DP_SADD( qtr(I_MENU_GOTOTIME), "","",gotoTimeDialog(), "Ctrl+T" );
+
     menu->addSeparator();
-    DP_SADD( qtr("Preferences"), "", "", prefsDialog(), "Ctrl+P" );
+
+    addDPStaticEntry( menu, qtr( I_MENU_MSG ), "",
+        ":/pixmaps/menus_messages_16px.png", SLOT( messagesDialog() ),
+        "Ctrl+M" );
+    addDPStaticEntry( menu, qtr( I_MENU_INFO ) , "", "",
+        SLOT( mediaInfoDialog() ), "Ctrl+I" );
+    addDPStaticEntry( menu, qtr( I_MENU_CODECINFO ) , "",
+        ":/pixmaps/menus_info_16px.png", SLOT( mediaCodecDialog() ), "Ctrl+J" );
+    addDPStaticEntry( menu, qtr( I_MENU_BOOKMARK ), "","",
+                      SLOT( bookmarksDialog() ), "Ctrl+B" );
+#ifdef ENABLE_VLM
+    addDPStaticEntry( menu, qtr( I_MENU_VLM ), "", "", SLOT( vlmDialog() ),
+        "Ctrl+W" );
+#endif
+
+    menu->addSeparator();
+    addDPStaticEntry( menu, qtr( "Preferences..." ), "",
+        ":/pixmaps/menus_preferences_16px.png", SLOT( prefsDialog() ), "Ctrl+P" );
     return menu;
 }
 
+/**
+ * Interface Sub-Menu, to list extras interface and skins
+ **/
 QMenu *QVLCMenu::InterfacesMenu( intf_thread_t *p_intf, QMenu *current )
 {
     vector<int> objects;
@@ -269,139 +428,201 @@ QMenu *QVLCMenu::InterfacesMenu( intf_thread_t *p_intf, QMenu *current )
     varnames.push_back( "intf-add" );
     objects.push_back( p_intf->i_object_id );
 
-    QMenu *menu = Populate( p_intf, current, varnames, objects );
-
-    if( !p_intf->pf_show_dialog )
-    {
-        menu->addSeparator();
-        menu->addAction( qtr("Switch to skins"), THEDP, SLOT(switchToSkins()),
-                 qtr("Ctrl+Z") );
-    }
+    QMenu *submenu = new QMenu( current );
+    QMenu *menu = Populate( p_intf, submenu, varnames, objects );
 
-    CONNECT( menu, aboutToShow(), THEDP->menusUpdateMapper, map() );
-    THEDP->menusUpdateMapper->setMapping( menu, 4 );
     return menu;
 }
 
+/**
+ * Main Audio Menu
+ */
 QMenu *QVLCMenu::AudioMenu( intf_thread_t *p_intf, QMenu * current )
 {
     vector<int> objects;
     vector<const char *> varnames;
+    vlc_object_t *p_aout;
+    input_thread_t *p_input;
 
-    vlc_object_t *p_object = (vlc_object_t *)vlc_object_find( p_intf,
-                                        VLC_OBJECT_INPUT, FIND_ANYWHERE );
-    if( p_object != NULL )
-    {
-        PUSH_VAR( "audio-es" );
-        vlc_object_release( p_object );
-    }
+    if( !current ) current = new QMenu();
 
-    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_AOUT,
-                                                FIND_ANYWHERE );
-    if( p_object )
+    if( current->isEmpty() )
     {
-        AudioAutoMenuBuilder( p_object, objects, varnames );
-        vlc_object_release( p_object );
+        ACT_ADD( current, "audio-es", qtr( "Audio &Track" ) );
+        ACT_ADD( current, "audio-device", qtr( "Audio &Device" ) );
+        ACT_ADD( current, "audio-channels", qtr( "Audio &Channels" ) );
+        ACT_ADD( current, "equalizer", qtr( "&Equalizer" ) );
+        current->addSeparator();
+        ACT_ADD( current, "visual", qtr( "&Visualizations" ) );
     }
+
+    p_input = THEMIM->getInput();
+    if( p_input )
+        vlc_object_yield( p_input );
+    p_aout = ( vlc_object_t * ) vlc_object_find( p_intf,
+                                                 VLC_OBJECT_AOUT,
+                                                 FIND_ANYWHERE );
+
+    AudioAutoMenuBuilder( p_aout, p_input, objects, varnames );
+
+    if( p_aout )
+        vlc_object_release( p_aout );
+    if( p_input )
+        vlc_object_release( p_input );
+
     return Populate( p_intf, current, varnames, objects );
 }
 
-
+/**
+ * Main Video Menu
+ * Subtitles are part of Video.
+ **/
 QMenu *QVLCMenu::VideoMenu( intf_thread_t *p_intf, QMenu *current )
 {
-    vlc_object_t *p_object;
+    vlc_object_t *p_vout;
+    input_thread_t *p_input;
     vector<int> objects;
     vector<const char *> varnames;
 
-    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_INPUT,
-                                                FIND_ANYWHERE );
-    if( p_object != NULL )
-    {
-        PUSH_VAR( "video-es" );
-        PUSH_VAR( "spu-es" );
-        vlc_object_release( p_object );
-    }
+    if( !current ) current = new QMenu();
 
-    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_VOUT,
-                                                FIND_ANYWHERE );
-    if( p_object != NULL )
+    if( current->isEmpty() )
     {
-        VideoAutoMenuBuilder( p_object, objects, varnames );
-        vlc_object_release( p_object );
+        ACT_ADD( current, "video-es", qtr( "Video &Track" ) );
+
+        QAction *action;
+        QMenu *submenu = new QMenu( qtr( "&Subtitles Track" ), current );
+        action = current->addMenu( submenu );
+        action->setData( "spu-es" );
+        addDPStaticEntry( submenu, qtr( "Load File..." ), "", "",
+                          SLOT( loadSubtitlesFile() ) );
+        submenu->addSeparator();
+
+        ACT_ADD( current, "fullscreen", qtr( "Toggle &Fullscreen" ) );
+        ACT_ADD( current, "zoom", qtr( "&Zoom" ) );
+        ACT_ADD( current, "deinterlace", qtr( "&Deinterlace" ) );
+        ACT_ADD( current, "aspect-ratio", qtr( "&Aspect Ratio" ) );
+        ACT_ADD( current, "crop", qtr( "&Crop" ) );
+        ACT_ADD( current, "video-on-top", qtr( "Always &On Top" ) );
+        /* ACT_ADD( current, "directx-wallpaper", qtr( "DirectX Wallpaper" ) ); */
+        ACT_ADD( current, "video-snapshot", qtr( "Snapshot" ) );
+        /* ACT_ADD( current, "ffmpeg-pp-q", qtr( "Decoder" ) ); */
     }
+
+    p_input = THEMIM->getInput();
+    if( p_input )
+        vlc_object_yield( p_input );
+    p_vout = ( vlc_object_t * )vlc_object_find( p_intf, VLC_OBJECT_VOUT,
+            FIND_ANYWHERE );
+
+    VideoAutoMenuBuilder( p_vout, p_input, objects, varnames );
+
+    if( p_vout )
+        vlc_object_release( p_vout );
+    if( p_input )
+        vlc_object_release( p_input );
+
     return Populate( p_intf, current, varnames, objects );
 }
 
-QMenu *QVLCMenu::NavigMenu( intf_thread_t *p_intf, QMenu *current )
+/**
+ * Navigation Menu
+ * For DVD, MP4, MOV and other chapter based format
+ **/
+QMenu *QVLCMenu::NavigMenu( intf_thread_t *p_intf, QMenu *menu )
 {
     vlc_object_t *p_object;
     vector<int> objects;
     vector<const char *> varnames;
 
-    /* FIXME */
-    p_object = (vlc_object_t *)vlc_object_find( p_intf, VLC_OBJECT_INPUT,
-                                                FIND_ANYWHERE );
-    if( p_object != NULL )
+    if( !menu ) menu = new QMenu();
+
+    if( menu->isEmpty() )
+    {
+        addDPStaticEntry( menu, qtr( I_MENU_GOTOTIME ), "","",
+                          SLOT( gotoTimeDialog() ), "Ctrl+T" );
+        menu->addSeparator();
+
+        ACT_ADD( menu, "bookmark", qtr( "&Bookmarks" ) );
+        ACT_ADD( menu, "title", qtr( "&Title" ) );
+        ACT_ADD( menu, "chapter", qtr( "&Chapter" ) );
+        ACT_ADD( menu, "program", qtr( "&Program" ) );
+        ACT_ADD( menu, "navigation", qtr( "&Navigation" ) );
+    }
+
+    p_object = ( vlc_object_t * )vlc_object_find( p_intf, VLC_OBJECT_INPUT,
+            FIND_ANYWHERE );
+    InputAutoMenuBuilder(  p_object, objects, varnames );
+    PUSH_VAR( "prev-title" );
+    PUSH_VAR( "next-title" );
+    PUSH_VAR( "prev-chapter" );
+    PUSH_VAR( "next-chapter" );
+    EnableDPStaticEntries( menu, ( p_object != NULL ) );
+    if( p_object )
     {
-        InputAutoMenuBuilder( p_object, objects, varnames );
-        PUSH_VAR( "prev-title"); PUSH_VAR ( "next-title" );
-        PUSH_VAR( "prev-chapter"); PUSH_VAR( "next-chapter" );
         vlc_object_release( p_object );
     }
-    return Populate( p_intf, current, varnames, objects );
+    return Populate( p_intf, menu, varnames, objects, true );
 }
 
+/**
+ * Service Discovery SubMenu
+ **/
 QMenu *QVLCMenu::SDMenu( intf_thread_t *p_intf )
 {
     QMenu *menu = new QMenu();
-    menu->setTitle( qtr(I_PL_SD) );
-    vlc_list_t *p_list = vlc_list_find( p_intf, VLC_OBJECT_MODULE,
-                                        FIND_ANYWHERE );
-    int i_num = 0;
-    for( int i_index = 0 ; i_index < p_list->i_count; i_index++ )
-    {
-        module_t * p_parser = (module_t *)p_list->p_values[i_index].p_object ;
-        if( !strcmp( p_parser->psz_capability, "services_discovery" ) )
-            i_num++;
-    }
-    for( int i_index = 0 ; i_index < p_list->i_count; i_index++ )
+    menu->setTitle( qtr( I_PL_SD ) );
+    char **ppsz_longnames;
+    char **ppsz_names = services_discovery_GetServicesNames( p_intf,
+                                                             &ppsz_longnames );
+    if( !ppsz_names )
+        return menu;
+
+    char **ppsz_name = ppsz_names, **ppsz_longname = ppsz_longnames;
+    for( ; *ppsz_name; ppsz_name++, ppsz_longname++ )
     {
-        module_t * p_parser = (module_t *)p_list->p_values[i_index].p_object;
-        if( !strcmp( p_parser->psz_capability, "services_discovery" ) )
+        QAction *a = new QAction( qfu( *ppsz_longname ), menu );
+        a->setCheckable( true );
+        if( playlist_IsServicesDiscoveryLoaded( THEPL, *ppsz_name ) )
+            a->setChecked( true );
+        CONNECT( a , triggered(), THEDP->SDMapper, map() );
+        THEDP->SDMapper->setMapping( a, QString( *ppsz_name ) );
+        menu->addAction( a );
+
+        if( !strcmp( *ppsz_name, "podcast" ) )
         {
-            QAction *a = new QAction( qfu( p_parser->psz_longname ), menu );
-            a->setCheckable( true );
-            /* hack to handle submodules properly */
-            int i = -1;
-            while( p_parser->pp_shortcuts[++i] != NULL );
-            i--;
-            if( playlist_IsServicesDiscoveryLoaded( THEPL,
-                 i>=0?p_parser->pp_shortcuts[i] : p_parser->psz_object_name ) )
-            {
-                a->setChecked( true );
-            }
-            CONNECT( a , triggered(), THEDP->SDMapper, map() );
-            THEDP->SDMapper->setMapping( a, i>=0? p_parser->pp_shortcuts[i] :
-                                                  p_parser->psz_object_name );
-            menu->addAction( a );
+            QAction *b = new QAction( qfu( "Configure podcasts..." ), menu );
+            //b->setEnabled( a->isChecked() );
+            menu->addAction( b );
+            CONNECT( b, triggered(), THEDP, podcastConfigureDialog() );
         }
+        free( *ppsz_name );
+        free( *ppsz_longname );
     }
-    vlc_list_release( p_list );
+    free( ppsz_names );
+    free( ppsz_longnames );
     return menu;
 }
-
-QMenu *QVLCMenu::HelpMenu()
+/**
+ * Help/About Menu
+**/
+QMenu *QVLCMenu::HelpMenu( QMenu *current )
 {
-    QMenu *menu = new QMenu();
-    DP_SADD( qtr("Help") , "", "", helpDialog(), "F1" );
+    QMenu *menu = new QMenu( current );
+    addDPStaticEntry( menu, qtr( "Help..." ) , "",
+        ":/pixmaps/menus_help_16px.png", SLOT( helpDialog() ), "F1" );
+#ifdef UPDATE_CHECK
+    addDPStaticEntry( menu, qtr( "Check for Updates..." ) , "", "",
+                      SLOT( updateDialog() ), "");
+#endif
     menu->addSeparator();
-    DP_SADD( qtr(I_MENU_ABOUT), "", "", aboutDialog(), "Ctrl+F1");
+    addDPStaticEntry( menu, qtr( I_MENU_ABOUT ), "", "", SLOT( aboutDialog() ),
+        "Ctrl+F1" );
     return menu;
 }
 
-
 /*****************************************************************************
- * Popup menus
+ * Popup menus - Right Click menus                                           *
  *****************************************************************************/
 #define POPUP_BOILERPLATE \
     unsigned int i_last_separator = 0; \
@@ -410,220 +631,341 @@ QMenu *QVLCMenu::HelpMenu()
     input_thread_t *p_input = THEMIM->getInput();
 
 #define CREATE_POPUP \
-    QMenu *menu = new QMenu(); \
     Populate( p_intf, menu, varnames, objects ); \
     p_intf->p_sys->p_popup_menu = menu; \
     menu->popup( QCursor::pos() ); \
     p_intf->p_sys->p_popup_menu = NULL; \
     i_last_separator = 0;
 
-#define POPUP_STATIC_ENTRIES \
-    vlc_value_t val; \
-    if( p_input ) \
-    { \
-        var_Get( p_input, "state", &val ); \
-        if( val.i_int == PAUSE_S ) \
-            MIM_SADD( qtr("Play"), "", "", togglePlayPause() ) \
-        else \
-            MIM_SADD( qtr("Pause"), "", "", togglePlayPause() ) \
-    } \
-    else if( THEPL->items.i_size && THEPL->i_enabled ) \
-        MIM_SADD( qtr("Play"), "", "", togglePlayPause() );\
-    \
-    MIM_SADD( qtr("Stop"), "", "", stop() ); \
-    MIM_SADD( qtr("Previous"), "", "", prev() ); \
-    MIM_SADD( qtr("Next"), "", "", next() ); \
-    menu->addSeparator(); \
-    QMenu *intfmenu = InterfacesMenu( p_intf, NULL ); \
-    intfmenu->setTitle( qtr("Interfaces" ) ); \
-    menu->addMenu( intfmenu ); \
-    \
-    QMenu *toolsmenu = ToolsMenu( p_intf, NULL, false, false ); \
-    toolsmenu->setTitle( qtr("Tools" ) ); \
-    menu->addMenu( toolsmenu ); \
-    DP_SADD( qtr("Quit"), "", "", quit() , "Ctrl+Q" );
+void QVLCMenu::PopupMenuControlEntries( QMenu *menu,
+                                        intf_thread_t *p_intf,
+                                        input_thread_t *p_input )
+{
+    if( p_input )
+    {
+        vlc_value_t val;
+        var_Get( p_input, "state", &val );
+        if( val.i_int == PLAYING_S )
+            addMIMStaticEntry( p_intf, menu, qtr( "Pause" ), "",
+                    ":/pixmaps/pause_16px.png", SLOT( togglePlayPause() ) );
+        else
+            addMIMStaticEntry( p_intf, menu, qtr( "Play" ), "",
+                    ":/pixmaps/play_16px.png", SLOT( togglePlayPause() ) );
+    }
+    else if( THEPL->items.i_size )
+        addMIMStaticEntry( p_intf, menu, qtr( "Play" ), "",
+                ":/pixmaps/play_16px.png", SLOT( togglePlayPause() ) );
+    else
+        addDPStaticEntry( menu, qtr( "Play" ), "",
+                ":/pixmaps/play_16px.png", SLOT( openDialog() ) );
+
+    addMIMStaticEntry( p_intf, menu, qtr( "Stop" ), "",
+            ":/pixmaps/stop_16px.png", SLOT( stop() ) );
+    addMIMStaticEntry( p_intf, menu, qtr( "Previous" ), "",
+            ":/pixmaps/previous_16px.png", SLOT( prev() ) );
+    addMIMStaticEntry( p_intf, menu, qtr( "Next" ), "",
+            ":/pixmaps/next_16px.png", SLOT( next() ) );
+}
+
+void QVLCMenu::PopupMenuStaticEntries( intf_thread_t *p_intf, QMenu *menu )
+{
+#if 0
+    QMenu *toolsmenu = ToolsMenu( p_intf, menu, false, true );
+    toolsmenu->setTitle( qtr( "Tools" ) );
+    menu->addMenu( toolsmenu );
+#endif
+
+    QMenu *openmenu = new QMenu( qtr( "Open" ), menu );
+    addDPStaticEntry( openmenu, qtr( "&Open File..." ), "",
+        ":/pixmaps/file-asym_16px.png", SLOT( openFileDialog() ) );
+    addDPStaticEntry( openmenu, qtr( I_OPEN_FOLDER ), "",
+        ":/pixmaps/folder-grey_16px.png", SLOT( PLAppendDir() ) );
+    addDPStaticEntry( openmenu, qtr( "Open &Disc..." ), "",
+        ":/pixmaps/disc_16px.png", SLOT( openDiscDialog() ) );
+    addDPStaticEntry( openmenu, qtr( "Open &Network..." ), "",
+        ":/pixmaps/network_16px.png", SLOT( openNetDialog() ) );
+    addDPStaticEntry( openmenu, qtr( "Open &Capture Device..." ), "",
+        ":/pixmaps/capture-card_16px.png", SLOT( openCaptureDialog() ) );
+    menu->addMenu( openmenu );
+
+    menu->addSeparator();
+#if 0
+    QMenu *helpmenu = HelpMenu( menu );
+    helpmenu->setTitle( qtr( "Help" ) );
+    menu->addMenu( helpmenu );
+#endif
+
+    addDPStaticEntry( menu, qtr( "Quit" ), "", ":/pixmaps/menus_quit_16px.png",
+                      SLOT( quit() ), "Ctrl+Q" );
+}
 
+/* Video Tracks and Subtitles tracks */
 void QVLCMenu::VideoPopupMenu( intf_thread_t *p_intf )
 {
     POPUP_BOILERPLATE;
     if( p_input )
     {
         vlc_object_yield( p_input );
-        varnames.push_back( "video-es" );
-        objects.push_back( p_input->i_object_id );
-        varnames.push_back( "spu-es" );
-        objects.push_back( p_input->i_object_id );
-        vlc_object_t *p_vout = (vlc_object_t *)vlc_object_find( p_input,
-                                                VLC_OBJECT_VOUT, FIND_CHILD );
+        vlc_object_t *p_vout = ( vlc_object_t * )vlc_object_find( p_input,
+                VLC_OBJECT_VOUT, FIND_CHILD );
         if( p_vout )
         {
-            VideoAutoMenuBuilder( p_vout, objects, varnames );
+            VideoAutoMenuBuilder( p_vout, p_input, objects, varnames );
             vlc_object_release( p_vout );
         }
         vlc_object_release( p_input );
     }
+    QMenu *menu = new QMenu();
     CREATE_POPUP;
 }
 
+/* Audio Tracks */
 void QVLCMenu::AudioPopupMenu( intf_thread_t *p_intf )
 {
     POPUP_BOILERPLATE;
     if( p_input )
     {
         vlc_object_yield( p_input );
-        varnames.push_back( "audio-es" );
-        objects.push_back( p_input->i_object_id );
-        vlc_object_t *p_aout = (vlc_object_t *)vlc_object_find( p_input,
-                                             VLC_OBJECT_AOUT, FIND_ANYWHERE );
+        vlc_object_t *p_aout = ( vlc_object_t * )vlc_object_find( p_input,
+                VLC_OBJECT_AOUT, FIND_ANYWHERE );
+        AudioAutoMenuBuilder( p_aout, p_input, objects, varnames );
         if( p_aout )
-        {
-            AudioAutoMenuBuilder( p_aout, objects, varnames );
             vlc_object_release( p_aout );
-        }
         vlc_object_release( p_input );
     }
+    QMenu *menu = new QMenu();
     CREATE_POPUP;
 }
 
-/* Navigation stuff, and general */
+/* Navigation stuff, and general menus ( open ) */
 void QVLCMenu::MiscPopupMenu( intf_thread_t *p_intf )
 {
+    vlc_value_t val;
     POPUP_BOILERPLATE;
+
     if( p_input )
     {
         vlc_object_yield( p_input );
         varnames.push_back( "audio-es" );
-        InputAutoMenuBuilder( VLC_OBJECT(p_input), objects, varnames );
+        InputAutoMenuBuilder( VLC_OBJECT( p_input ), objects, varnames );
         PUSH_SEPARATOR;
     }
 
     QMenu *menu = new QMenu();
     Populate( p_intf, menu, varnames, objects );
+
+    menu->addSeparator();
+    PopupMenuControlEntries( menu, p_intf, p_input );
+
     menu->addSeparator();
-    POPUP_STATIC_ENTRIES;
+    PopupMenuStaticEntries( p_intf, menu );
 
     p_intf->p_sys->p_popup_menu = menu;
     menu->popup( QCursor::pos() );
     p_intf->p_sys->p_popup_menu = NULL;
 }
 
+/* Main Menu that sticks everything together  */
 void QVLCMenu::PopupMenu( intf_thread_t *p_intf, bool show )
 {
+    MainInterface *mi = p_intf->p_sys->p_mi;
     if( show )
     {
-       // create a  popup if there is none
-        if( ! p_intf->p_sys->p_popup_menu )
-       {
-           POPUP_BOILERPLATE;
-           if( p_input )
-           {
-               vlc_object_yield( p_input );
-               InputAutoMenuBuilder( VLC_OBJECT(p_input), objects, varnames );
-
-               /* Video menu */
-               PUSH_SEPARATOR;
-               varnames.push_back( "video-es" );
-               objects.push_back( p_input->i_object_id );
-               varnames.push_back( "spu-es" );
-               objects.push_back( p_input->i_object_id );
-               vlc_object_t *p_vout = (vlc_object_t *)vlc_object_find( p_input,
-                                                       VLC_OBJECT_VOUT, FIND_CHILD );
-               if( p_vout )
-               {
-                   VideoAutoMenuBuilder( p_vout, objects, varnames );
-                   vlc_object_release( p_vout );
-               }
-               /* Audio menu */
-               PUSH_SEPARATOR
-               varnames.push_back( "audio-es" );
-               objects.push_back( p_input->i_object_id );
-               vlc_object_t *p_aout = (vlc_object_t *)vlc_object_find( p_input,
-                                                    VLC_OBJECT_AOUT, FIND_ANYWHERE );
-               if( p_aout )
-               {
-                   AudioAutoMenuBuilder( p_aout, objects, varnames );
-                   vlc_object_release( p_aout );
-               }
-           }
-
-           QMenu *menu = new QMenu();
-           Populate( p_intf, menu, varnames, objects );
-           menu->addSeparator();
-           POPUP_STATIC_ENTRIES;
-
-           p_intf->p_sys->p_popup_menu = menu;
-       }
-       p_intf->p_sys->p_popup_menu->popup( QCursor::pos() );
+        /* Delete and recreate a popup if there is one */
+        if( p_intf->p_sys->p_popup_menu )
+            delete p_intf->p_sys->p_popup_menu;
+
+        QMenu *menu = new QMenu();
+        QMenu *submenu;
+        QAction *action;
+        bool b_isFullscreen = false;
+
+        POPUP_BOILERPLATE;
+
+        PopupMenuControlEntries( menu, p_intf, p_input );
+        menu->addSeparator();
+
+        if( p_input )
+        {
+            vlc_object_t *p_vout = (vlc_object_t *)
+                vlc_object_find( p_input, VLC_OBJECT_VOUT, FIND_CHILD );
+
+            /* Add a fullscreen switch button */
+            if( p_vout )
+            {
+                vlc_value_t val;
+                var_Get( p_vout, "fullscreen", &val );
+                b_isFullscreen = !( !val.b_bool );
+                if( b_isFullscreen )
+                    CreateAndConnect( menu, "fullscreen",
+                            qtr( "Leave Fullscreen" ),"" , ITEM_NORMAL,
+                            p_vout->i_object_id, val, VLC_VAR_BOOL,
+                            b_isFullscreen );
+                vlc_object_release( p_vout );
+            }
+
+            menu->addSeparator();
+
+            vlc_object_yield( p_input );
+            InputAutoMenuBuilder( VLC_OBJECT( p_input ), objects, varnames );
+            vlc_object_release( p_input );
+
+            submenu = new QMenu( menu );
+            action = menu->addMenu( AudioMenu( p_intf, submenu ) );
+            action->setText( qtr( "&Audio" ) );
+            if( action->menu()->isEmpty() )
+                action->setEnabled( false );
+
+            submenu = new QMenu( menu );
+            action = menu->addMenu( VideoMenu( p_intf, submenu ) );
+            action->setText( qtr( "&Video" ) );
+            if( action->menu()->isEmpty() )
+                action->setEnabled( false );
+
+            submenu = new QMenu( menu );
+            action = menu->addMenu( NavigMenu( p_intf, submenu ) );
+            action->setText( qtr( "&Playback" ) );
+            if( action->menu()->isEmpty() )
+                action->setEnabled( false );
+        }
+
+        menu->addSeparator();
+
+        /* Add some special entries for windowed mode: Interface Menu */
+        if( !b_isFullscreen )
+        {
+            submenu = new QMenu( qtr( "Interface" ), menu );
+            submenu->addAction( QIcon( ":/pixmaps/playlist_16px.png" ),
+                     qtr( "Show Playlist" ), mi, SLOT( togglePlaylist() ) );
+            addDPStaticEntry( submenu, qtr( I_MENU_EXT ), "",
+                ":/pixmaps/menus_settings_16px.png", SLOT( extendedDialog() ) );
+            action = submenu->addAction( QIcon( "" ),
+                 qtr( "Minimal View..." ), mi, SLOT( toggleMinimalView() ) );
+            action->setCheckable( true );
+            action->setChecked( !( mi->getControlsVisibilityStatus() &
+                                   CONTROLS_VISIBLE ) );
+            action = submenu->addAction( QIcon( "" ),
+                 qtr( "Toggle Fullscreen Interface" ),
+                 mi, SLOT( toggleFullScreen() ) );
+            action->setCheckable( true );
+            action->setChecked( mi->isFullScreen() );
+            menu->addMenu( submenu );
+        }
+
+        PopupMenuStaticEntries( p_intf, menu );
+
+        p_intf->p_sys->p_popup_menu = menu;
+        p_intf->p_sys->p_popup_menu->popup( QCursor::pos() );
     }
     else
-    {  
-       // destroy popup if there is one
-       delete p_intf->p_sys->p_popup_menu;
-       p_intf->p_sys->p_popup_menu = NULL;
+    {
+        // destroy popup if there is one
+        delete p_intf->p_sys->p_popup_menu;
+        p_intf->p_sys->p_popup_menu = NULL;
     }
 }
 
+#undef ACT_ADD
+
+/************************************************************************
+ * Systray Menu                                                         *
+ ************************************************************************/
+
+void QVLCMenu::updateSystrayMenu( MainInterface *mi,
+                                  intf_thread_t *p_intf,
+                                  bool b_force_visible )
+{
+    POPUP_BOILERPLATE;
+
+    /* Get the systray menu and clean it */
+    QMenu *sysMenu = mi->getSysTrayMenu();
+    sysMenu->clear();
+
+    /* Hide / Show VLC and cone */
+    if( mi->isVisible() || b_force_visible )
+    {
+        sysMenu->addAction( QIcon( ":/vlc16.png" ),
+                            qtr( "Hide VLC media player in taskbar" ), mi,
+                            SLOT( toggleUpdateSystrayMenu() ) );
+    }
+    else
+    {
+        sysMenu->addAction( QIcon( ":/vlc16.png" ),
+                            qtr( "Show VLC media player" ), mi,
+                            SLOT( toggleUpdateSystrayMenu() ) );
+    }
+
+    sysMenu->addSeparator();
+    PopupMenuControlEntries( sysMenu, p_intf, p_input );
+
+    sysMenu->addSeparator();
+    addDPStaticEntry( sysMenu, qtr( "&Open Media" ), "",
+            ":/pixmaps/file-wide_16px.png", SLOT( openFileDialog() ), "" );
+    addDPStaticEntry( sysMenu, qtr( "&Quit" ) , "",
+            ":/pixmaps/menus_quit_16px.png", SLOT( quit() ), "" );
+
+    /* Set the menu */
+    mi->getSysTray()->setContextMenu( sysMenu );
+}
+
 #undef PUSH_VAR
 #undef PUSH_SEPARATOR
 
 /*************************************************************************
  * Builders for automenus
  *************************************************************************/
-QMenu * QVLCMenu::Populate( intf_thread_t *p_intf, QMenu *current,
+QMenu * QVLCMenu::Populate( intf_thread_t *p_intf,
+                            QMenu *current,
                             vector< const char *> & varnames,
-                            vector<int> & objects, bool append )
+                            vector<int> & objects,
+                            bool append )
 {
     QMenu *menu = current;
-    if( !menu )
-        menu = new QMenu();
-    else if( !append )
-        menu->clear();
+    if( !menu ) menu = new QMenu();
+
+    /* Disable all non static entries */
+    QAction *p_action;
+    foreach( p_action, menu->actions() )
+    {
+        if( p_action->data().toString() != "_static_" )
+            p_action->setEnabled( false );
+    }
 
     currentGroup = NULL;
 
     vlc_object_t *p_object;
-    vlc_bool_t b_section_empty = VLC_FALSE;
     int i;
 
-#define APPEND_EMPTY { QAction *action = menu->addAction( qtr("Empty" ) ); \
-                       action->setEnabled( false ); }
-
-    for( i = 0; i < (int)objects.size() ; i++ )
+    for( i = 0; i < ( int )objects.size() ; i++ )
     {
         if( !varnames[i] || !*varnames[i] )
         {
-            if( b_section_empty )
-                APPEND_EMPTY;
             menu->addSeparator();
-            b_section_empty = VLC_TRUE;
             continue;
         }
 
-        if( objects[i] == 0  )
+        if( objects[i] == 0 )
         {
-            /// \bug What is this ?
-            // Append( menu, varnames[i], NULL );
-            b_section_empty = VLC_FALSE;
-            continue;
+            p_object = NULL;
+        }
+        else
+        {
+            p_object = ( vlc_object_t * )vlc_object_get( objects[i] );
+            if( !p_object )
+            {
+                msg_Dbg( p_intf, "object %d not found !", objects[i] );
+                continue;
+            }
         }
 
-        p_object = (vlc_object_t *)vlc_object_get( p_intf,
-                                                   objects[i] );
-        if( p_object == NULL ) continue;
-
-        b_section_empty = VLC_FALSE;
         /* Ugly specific stuff */
-        if( strstr(varnames[i], "intf-add" ) )
-            CreateItem( menu, varnames[i], p_object, false );
+        if( strstr( varnames[i], "intf-add" ) )
+            UpdateItem( p_intf, menu, varnames[i], p_object, false );
         else
-            CreateItem( menu, varnames[i], p_object, true );
-        vlc_object_release( p_object );
+            UpdateItem( p_intf, menu, varnames[i], p_object, true );
+        if( p_object )
+            vlc_object_release( p_object );
     }
-
-    /* Special case for empty menus */
-    if( menu->actions().size() == 0 || b_section_empty )
-        APPEND_EMPTY
-
     return menu;
 }
 
@@ -631,8 +973,9 @@ QMenu * QVLCMenu::Populate( intf_thread_t *p_intf, QMenu *current,
  * Private methods.
  *****************************************************************************/
 
-static bool IsMenuEmpty( const char *psz_var, vlc_object_t *p_object,
-                         bool b_root = TRUE )
+static bool IsMenuEmpty( const char *psz_var,
+                         vlc_object_t *p_object,
+                         bool b_root = true )
 {
     vlc_value_t val, val_list;
     int i_type, i_result, i;
@@ -641,31 +984,29 @@ static bool IsMenuEmpty( const char *psz_var, vlc_object_t *p_object,
     i_type = var_Type( p_object, psz_var );
 
     /* Check if we want to display the variable */
-    if( !(i_type & VLC_VAR_HASCHOICE) ) return FALSE;
+    if( !( i_type & VLC_VAR_HASCHOICE ) ) return false;
 
     var_Change( p_object, psz_var, VLC_VAR_CHOICESCOUNT, &val, NULL );
-    if( val.i_int == 0 ) return TRUE;
+    if( val.i_int == 0 ) return true;
 
-    if( (i_type & VLC_VAR_TYPE) != VLC_VAR_VARIABLE )
+    if( ( i_type & VLC_VAR_TYPE ) != VLC_VAR_VARIABLE )
     {
-        /* Very evil hack ! intf-switch can have only one value */
-        if( !strcmp( psz_var, "intf-switch" ) ) return FALSE;
-        if( val.i_int == 1 && b_root ) return TRUE;
-        else return FALSE;
+        if( val.i_int == 1 && b_root ) return true;
+        else return false;
     }
 
     /* Check children variables in case of VLC_VAR_VARIABLE */
     if( var_Change( p_object, psz_var, VLC_VAR_GETLIST, &val_list, NULL ) < 0 )
     {
-        return TRUE;
+        return true;
     }
 
-    for( i = 0, i_result = TRUE; i < val_list.p_list->i_count; i++ )
+    for( i = 0, i_result = true; i < val_list.p_list->i_count; i++ )
     {
         if( !IsMenuEmpty( val_list.p_list->p_values[i].psz_string,
-                          p_object, FALSE ) )
+                    p_object, false ) )
         {
-            i_result = FALSE;
+            i_result = false;
             break;
         }
     }
@@ -676,45 +1017,88 @@ static bool IsMenuEmpty( const char *psz_var, vlc_object_t *p_object,
     return i_result;
 }
 
-void QVLCMenu::CreateItem( QMenu *menu, const char *psz_var,
-                           vlc_object_t *p_object, bool b_submenu )
+#define TEXT_OR_VAR qfu ( text.psz_string ? text.psz_string : psz_var )
+
+void QVLCMenu::UpdateItem( intf_thread_t *p_intf, QMenu *menu,
+        const char *psz_var, vlc_object_t *p_object, bool b_submenu )
 {
     vlc_value_t val, text;
     int i_type;
 
+    QAction *action = FindActionWithVar( menu, psz_var );
+    if( action )
+        DeleteNonStaticEntries( action->menu() );
+
+    if( !p_object )
+        return;
+
     /* Check the type of the object variable */
-    i_type = var_Type( p_object, psz_var );
+    if( !strcmp( psz_var, "audio-es" )
+     || !strcmp( psz_var, "video-es" ) )
+        i_type = VLC_VAR_INTEGER | VLC_VAR_HASCHOICE;
+    else
+        i_type = var_Type( p_object, psz_var );
 
     switch( i_type & VLC_VAR_TYPE )
     {
-    case VLC_VAR_VOID:
-    case VLC_VAR_BOOL:
-    case VLC_VAR_VARIABLE:
-    case VLC_VAR_STRING:
-    case VLC_VAR_INTEGER:
-    case VLC_VAR_FLOAT:
-        break;
-    default:
-        /* Variable doesn't exist or isn't handled */
-        return;
+        case VLC_VAR_VOID:
+        case VLC_VAR_BOOL:
+        case VLC_VAR_VARIABLE:
+        case VLC_VAR_STRING:
+        case VLC_VAR_INTEGER:
+        case VLC_VAR_FLOAT:
+            break;
+        default:
+            /* Variable doesn't exist or isn't handled */
+            return;
     }
 
     /* Make sure we want to display the variable */
-    if( IsMenuEmpty( psz_var, p_object ) )  return;
+    if( menu->isEmpty() && IsMenuEmpty( psz_var, p_object ) )
+        return;
 
     /* Get the descriptive name of the variable */
-    var_Change( p_object, psz_var, VLC_VAR_GETTEXT, &text, NULL );
+    int i_ret = var_Change( p_object, psz_var, VLC_VAR_GETTEXT, &text, NULL );
+    if( i_ret != VLC_SUCCESS )
+    {
+        text.psz_string = NULL;
+    }
+
+    if( !action )
+    {
+        action = new QAction( TEXT_OR_VAR, menu );
+        menu->addAction( action );
+        action->setData( psz_var );
+    }
+
+    /* Some specific stuff */
+    bool forceDisabled = false;
+    if( !strcmp( psz_var, "spu-es" ) )
+    {
+        vlc_object_t *p_vout = ( vlc_object_t* )( vlc_object_find( p_intf,
+                                    VLC_OBJECT_VOUT, FIND_ANYWHERE ) );
+        forceDisabled = ( p_vout == NULL );
+        if( p_vout )
+            vlc_object_release( p_vout );
+    }
 
     if( i_type & VLC_VAR_HASCHOICE )
     {
         /* Append choices menu */
         if( b_submenu )
         {
-            QMenu *submenu = new QMenu();
-            submenu->setTitle( qfu( text.psz_string ?
-                                    text.psz_string : psz_var ) );
-            if( CreateChoicesMenu( submenu, psz_var, p_object, true ) == 0)
-                menu->addMenu( submenu );
+            QMenu *submenu;
+            submenu = action->menu();
+            if( !submenu )
+            {
+                submenu = new QMenu( menu );
+                action->setMenu( submenu );
+            }
+
+            action->setEnabled(
+               CreateChoicesMenu( submenu, psz_var, p_object, true ) == 0 );
+            if( forceDisabled )
+                action->setEnabled( false );
         }
         else
             CreateChoicesMenu( menu, psz_var, p_object, true );
@@ -722,29 +1106,27 @@ void QVLCMenu::CreateItem( QMenu *menu, const char *psz_var,
         return;
     }
 
-#define TEXT_OR_VAR qfu ( text.psz_string ? text.psz_string : psz_var )
-
     switch( i_type & VLC_VAR_TYPE )
     {
-    case VLC_VAR_VOID:
-        var_Get( p_object, psz_var, &val );
-        CreateAndConnect( menu, psz_var, TEXT_OR_VAR, "", ITEM_NORMAL,
-                          p_object->i_object_id, val, i_type );
-        break;
+        case VLC_VAR_VOID:
+            var_Get( p_object, psz_var, &val );
+            CreateAndConnect( menu, psz_var, TEXT_OR_VAR, "", ITEM_NORMAL,
+                    p_object->i_object_id, val, i_type );
+            break;
 
-    case VLC_VAR_BOOL:
-        var_Get( p_object, psz_var, &val );
-        val.b_bool = !val.b_bool;
-        CreateAndConnect( menu, psz_var, TEXT_OR_VAR, "", ITEM_CHECK,
-                          p_object->i_object_id, val, i_type, !val.b_bool );
-        break;
+        case VLC_VAR_BOOL:
+            var_Get( p_object, psz_var, &val );
+            val.b_bool = !val.b_bool;
+            CreateAndConnect( menu, psz_var, TEXT_OR_VAR, "", ITEM_CHECK,
+                    p_object->i_object_id, val, i_type, !val.b_bool );
+            break;
     }
     FREENULL( text.psz_string );
 }
 
 
 int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
-                                 vlc_object_t *p_object, bool b_root )
+        vlc_object_t *p_object, bool b_root )
 {
     vlc_value_t val, val_list, text_list;
     int i_type, i;
@@ -753,29 +1135,31 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
     i_type = var_Type( p_object, psz_var );
 
     /* Make sure we want to display the variable */
-    if( IsMenuEmpty( psz_var, p_object, b_root ) ) return VLC_EGENERIC;
+    if( submenu->isEmpty() && IsMenuEmpty( psz_var, p_object, b_root ) )
+        return VLC_EGENERIC;
 
     switch( i_type & VLC_VAR_TYPE )
     {
-    case VLC_VAR_VOID:
-    case VLC_VAR_BOOL:
-    case VLC_VAR_VARIABLE:
-    case VLC_VAR_STRING:
-    case VLC_VAR_INTEGER:
-    case VLC_VAR_FLOAT:
-        break;
-    default:
-        /* Variable doesn't exist or isn't handled */
-        return VLC_EGENERIC;
+        case VLC_VAR_VOID:
+        case VLC_VAR_BOOL:
+        case VLC_VAR_VARIABLE:
+        case VLC_VAR_STRING:
+        case VLC_VAR_INTEGER:
+        case VLC_VAR_FLOAT:
+            break;
+        default:
+            /* Variable doesn't exist or isn't handled */
+            return VLC_EGENERIC;
     }
 
     if( var_Change( p_object, psz_var, VLC_VAR_GETLIST,
-                    &val_list, &text_list ) < 0 )
+                &val_list, &text_list ) < 0 )
     {
         return VLC_EGENERIC;
     }
+
 #define NORMAL_OR_RADIO i_type & VLC_VAR_ISCOMMAND ? ITEM_NORMAL: ITEM_RADIO
-#define NOTCOMMAND !(i_type & VLC_VAR_ISCOMMAND)
+#define NOTCOMMAND !( i_type & VLC_VAR_ISCOMMAND )
 #define CURVAL val_list.p_list->p_values[i]
 #define CURTEXT text_list.p_list->p_values[i].psz_string
 
@@ -783,48 +1167,48 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
     {
         vlc_value_t another_val;
         QString menutext;
-        QMenu *subsubmenu = new QMenu();
+        QMenu *subsubmenu = new QMenu( submenu );
 
         switch( i_type & VLC_VAR_TYPE )
         {
-        case VLC_VAR_VARIABLE:
-            CreateChoicesMenu( subsubmenu, CURVAL.psz_string, p_object, false );
-            subsubmenu->setTitle( qfu( CURTEXT ? CURTEXT :CURVAL.psz_string ) );
-            submenu->addMenu( subsubmenu );
-            break;
-
-        case VLC_VAR_STRING:
-          var_Get( p_object, psz_var, &val );
-          another_val.psz_string = strdup( CURVAL.psz_string );
-          menutext = qfu( CURTEXT ? CURTEXT : another_val.psz_string );
-          CreateAndConnect( submenu, psz_var, menutext, "", NORMAL_OR_RADIO,
-                            p_object->i_object_id, another_val, i_type,
-                            NOTCOMMAND && val.psz_string &&
-                            !strcmp( val.psz_string, CURVAL.psz_string ) );
-
-          if( val.psz_string ) free( val.psz_string );
-          break;
-
-        case VLC_VAR_INTEGER:
-          var_Get( p_object, psz_var, &val );
-          if( CURTEXT ) menutext = qfu( CURTEXT );
-          else menutext.sprintf( "%d", CURVAL.i_int);
-          CreateAndConnect( submenu, psz_var, menutext, "", NORMAL_OR_RADIO,
-                            p_object->i_object_id, CURVAL, i_type,
-                            NOTCOMMAND && CURVAL.i_int == val.i_int );
-          break;
-
-        case VLC_VAR_FLOAT:
-          var_Get( p_object, psz_var, &val );
-          if( CURTEXT ) menutext = qfu( CURTEXT );
-          else menutext.sprintf( "%.2f", CURVAL.f_float );
-          CreateAndConnect( submenu, psz_var, menutext, "", NORMAL_OR_RADIO,
-                            p_object->i_object_id, CURVAL, i_type,
-                            NOTCOMMAND && CURVAL.f_float == val.f_float );
-          break;
-
-        default:
-          break;
+            case VLC_VAR_VARIABLE:
+                CreateChoicesMenu( subsubmenu, CURVAL.psz_string, p_object, false );
+                subsubmenu->setTitle( qfu( CURTEXT ? CURTEXT :CURVAL.psz_string ) );
+                submenu->addMenu( subsubmenu );
+                break;
+
+            case VLC_VAR_STRING:
+                var_Get( p_object, psz_var, &val );
+                another_val.psz_string = strdup( CURVAL.psz_string );
+                menutext = qfu( CURTEXT ? CURTEXT : another_val.psz_string );
+                CreateAndConnect( submenu, psz_var, menutext, "", NORMAL_OR_RADIO,
+                        p_object->i_object_id, another_val, i_type,
+                        NOTCOMMAND && val.psz_string &&
+                        !strcmp( val.psz_string, CURVAL.psz_string ) );
+
+                free( val.psz_string );
+                break;
+
+            case VLC_VAR_INTEGER:
+                var_Get( p_object, psz_var, &val );
+                if( CURTEXT ) menutext = qfu( CURTEXT );
+                else menutext.sprintf( "%d", CURVAL.i_int );
+                CreateAndConnect( submenu, psz_var, menutext, "", NORMAL_OR_RADIO,
+                        p_object->i_object_id, CURVAL, i_type,
+                        NOTCOMMAND && CURVAL.i_int == val.i_int );
+                break;
+
+            case VLC_VAR_FLOAT:
+                var_Get( p_object, psz_var, &val );
+                if( CURTEXT ) menutext = qfu( CURTEXT );
+                else menutext.sprintf( "%.2f", CURVAL.f_float );
+                CreateAndConnect( submenu, psz_var, menutext, "", NORMAL_OR_RADIO,
+                        p_object->i_object_id, CURVAL, i_type,
+                        NOTCOMMAND && CURVAL.f_float == val.f_float );
+                break;
+
+            default:
+                break;
         }
     }
     currentGroup = NULL;
@@ -840,15 +1224,28 @@ int QVLCMenu::CreateChoicesMenu( QMenu *submenu, const char *psz_var,
 }
 
 void QVLCMenu::CreateAndConnect( QMenu *menu, const char *psz_var,
-                                 QString text, QString help,
-                                 int i_item_type, int i_object_id,
-                                 vlc_value_t val, int i_val_type,
-                                 bool checked )
+        QString text, QString help,
+        int i_item_type, int i_object_id,
+        vlc_value_t val, int i_val_type,
+        bool checked )
 {
-    QAction *action = new QAction( text, menu );
+    QAction *action = FindActionWithVar( menu, psz_var );
+    if( !action )
+    {
+        /* This is a value */
+        action = FindActionWithText( menu, text );
+        if( !action )
+        {
+            action = new QAction( text, menu );
+            menu->addAction( action );
+        }
+    }
+
     action->setText( text );
     action->setToolTip( help );
 
+    action->setEnabled( i_object_id != 0 );
+
     if( i_item_type == ITEM_CHECK )
     {
         action->setCheckable( true );
@@ -857,16 +1254,14 @@ void QVLCMenu::CreateAndConnect( QMenu *menu, const char *psz_var,
     {
         action->setCheckable( true );
         if( !currentGroup )
-            currentGroup = new QActionGroup(menu);
+            currentGroup = new QActionGroup( menu );
         currentGroup->addAction( action );
     }
 
-    if( checked )
-    {
-        action->setChecked( true );
-    }
+    action->setChecked( checked );
+
     MenuItemData *itemData = new MenuItemData( i_object_id, i_val_type,
-                                               val, psz_var );
+            val, psz_var );
     CONNECT( action, triggered(), THEDP->menusMapper, map() );
     THEDP->menusMapper->setMapping( action, itemData );
     menu->addAction( action );
@@ -874,11 +1269,11 @@ void QVLCMenu::CreateAndConnect( QMenu *menu, const char *psz_var,
 
 void QVLCMenu::DoAction( intf_thread_t *p_intf, QObject *data )
 {
-    MenuItemData *itemData = qobject_cast<MenuItemData *>(data);
-    vlc_object_t *p_object = (vlc_object_t *)vlc_object_get( p_intf,
-                                           itemData->i_object_id );
+    MenuItemData *itemData = qobject_cast<MenuItemData *>( data );
+    vlc_object_t *p_object = ( vlc_object_t * )vlc_object_get( itemData->i_object_id );
     if( p_object == NULL ) return;
 
     var_Set( p_object, itemData->psz_var, itemData->val );
     vlc_object_release( p_object );
 }
+