"as lyrics, album arts...\n" \
" - minimal mode with limited controls" )
-#define QT_NORMAL_MODE_TEXT N_( "Classic" )
-#define QT_ALWAYS_VIDEO_MODE_TEXT N_( "Complete (with information area)" )
-#define QT_MINIMAL_MODE_TEXT N_( "Minimal (without menu)" )
-
#define QT_FULLSCREEN_TEXT N_( "Show a controller in fullscreen mode" )
#define QT_NATIVEOPEN_TEXT N_( "Embed the file browser in open dialog" )
#define QT_AUTOLOAD_EXTENSIONS_LONGTEXT N_( "Automatically load the "\
"extensions module on startup" )
-/* Various modes definition */
-static const int i_mode_list[] =
- { QT_NORMAL_MODE, QT_ALWAYS_VIDEO_MODE, QT_MINIMAL_MODE };
-static const char *const psz_mode_list_text[] =
- { QT_NORMAL_MODE_TEXT, QT_ALWAYS_VIDEO_MODE_TEXT, QT_MINIMAL_MODE_TEXT };
-
+#define QT_MINIMAL_MODE_TEXT N_("Start in minimal view (without menus)" )
/**********************************************************************/
vlc_module_begin ()
set_callbacks( OpenIntf, Close )
add_shortcut("qt")
- add_integer( "qt-display-mode", QT_NORMAL_MODE, NULL,
- QT_MODE_TEXT, QT_MODE_LONGTEXT, false )
- change_integer_list( i_mode_list, psz_mode_list_text, NULL )
+
+ add_bool( "qt-minimal-view", false, NULL, QT_MINIMAL_MODE_TEXT,
+ QT_MINIMAL_MODE_TEXT, false );
add_bool( "qt-notification", true, NULL, NOTIFICATION_TEXT,
NOTIFICATION_LONGTEXT, false )
add_bool( "qt-privacy-ask", true, NULL, PRIVACY_TEXT, PRIVACY_TEXT,
false )
- change_internal ()
+ change_private ()
add_integer( "qt-fullscreen-screennumber", -1, NULL, FULLSCREEN_NUMBER_TEXT,
FULLSCREEN_NUMBER_LONGTEXT, false );
false )
add_obsolete_bool( "qt-blingbling" ) /* Suppressed since 1.0.0 */
+ add_obsolete_integer( "qt-display-mode" ) /* Suppressed since 1.1.0 */
+
+#ifdef WIN32
+ cannot_unload_broken_library()
+#endif
add_submodule ()
set_description( "Dialogs provider" )
#ifdef Q_WS_X11
static char *x11_display = NULL;
#endif
+static struct
+{
+ vlc_mutex_t lock;
+ bool busy;
+} one = { VLC_STATIC_MUTEX, false };
/*****************************************************************************
* Module callbacks
intf_thread_t *p_intf = (intf_thread_t *)p_this;
#ifdef Q_WS_X11
- x11_display = var_CreateGetNonEmptyString( p_intf, "x11-display" );
+ if( !XInitThreads() )
+ return VLC_EGENERIC;
+
+ char *display = var_CreateGetNonEmptyString( p_intf, "x11-display" );
Display *p_display = XOpenDisplay( x11_display );
if( !p_display )
{
msg_Err( p_intf, "Could not connect to X server" );
+ free (display);
return VLC_EGENERIC;
}
XCloseDisplay( p_display );
- putenv( (char *)"XLIB_SKIP_ARGB_VISUALS=1" );
+#else
+ char *display = NULL;
#endif
+ bool busy;
+ vlc_mutex_lock (&one.lock);
+ busy = one.busy;
+ one.busy = true;
+ vlc_mutex_unlock (&one.lock);
+ if (busy)
+ {
+ msg_Err (p_this, "cannot start Qt4 multiple times");
+ free (display);
+ return VLC_EGENERIC;
+ }
+
/* Allocations of p_sys */
intf_sys_t *p_sys = p_intf->p_sys = new intf_sys_t;
p_intf->p_sys->b_isDialogProvider = isDialogProvider;
- p_sys->p_popup_menu = NULL;
p_sys->p_mi = NULL;
p_sys->p_playlist = pl_Get( p_intf );
/* */
+#ifdef Q_WS_X11
+ x11_display = display;
+#endif
vlc_sem_init (&ready, 0);
if( vlc_clone( &p_sys->thread, Thread, p_intf, VLC_THREAD_PRIORITY_LOW ) )
{
delete p_sys;
+ free (display);
+ vlc_mutex_lock (&one.lock);
+ one.busy = false;
+ vlc_mutex_unlock (&one.lock);
return VLC_ENOMEM;
}
if( !p_sys->b_isDialogProvider )
{
- vlc_value_t val;
- var_Create (p_this->p_libvlc, "qt4-iface", VLC_VAR_ADDRESS);
- val.p_address = p_this;
- var_Set (p_this->p_libvlc, "qt4-iface", val);
+ playlist_t *pl = pl_Get(p_this);
+ var_Create (pl, "qt4-iface", VLC_VAR_ADDRESS);
+ var_SetAddress (pl, "qt4-iface", p_this);
}
return VLC_SUCCESS;
}
intf_sys_t *p_sys = p_intf->p_sys;
if( !p_sys->b_isDialogProvider )
- var_Destroy (p_this->p_libvlc, "qt4-iface");
+ var_Destroy (pl_Get(p_this), "qt4-iface");
QVLCApp::triggerQuit();
vlc_join (p_sys->thread, NULL);
- delete p_sys;
#ifdef Q_WS_X11
free (x11_display);
+ x11_display = NULL;
#endif
+ delete p_sys;
+ vlc_mutex_lock (&one.lock);
+ one.busy = false;
+ vlc_mutex_unlock (&one.lock);
}
static void *Thread( void *obj )
p_mi = new MainInterface( p_intf );
else
p_mi = NULL;
+ p_intf->p_sys->p_mi = p_mi;
/* Explain how to show a dialog :D */
p_intf->pf_show_dialog = ShowDialog;
/* */
- p_intf->p_sys->p_mi = p_mi;
vlc_sem_post (&ready);
/* Last settings */
app.exec();
/* And quit */
- msg_Dbg( p_intf, "Quitting the Qt4 Interface" );
-
QApplication::closeAllWindows();
if (p_mi != NULL)
{
- /* FIXME: are we sure that video window is already destroyed? */
+#warning BUG!
+ /* FIXME: the video window may still be registerd at this point */
+ /* See LP#448082 as an example. */
- msg_Dbg (p_intf, "destroying the main Qt4 interface");
p_intf->p_sys->p_mi = NULL;
/* Destroy first the main interface because it is connected to some
slots in the MainInputManager */
/* Destroy the MainInputManager */
MainInputManager::killInstance();
-
/* Delete the application automatically */
-#ifdef Q_WS_X11
- free( x11_display );
-#endif
return NULL;
}
/* */
if( p_wnd->cfg->is_standalone )
return VLC_EGENERIC;
+#if defined (Q_WS_X11)
+ if( var_InheritBool( p_obj, "video-wallpaper" ) )
+ return VLC_EGENERIC;
+#endif
vlc_value_t val;
-
- if( var_Get( p_obj->p_libvlc, "qt4-iface", &val ) )
+ if( var_Inherit( p_obj, "qt4-iface", VLC_VAR_ADDRESS, &val ) )
val.p_address = NULL;
intf_thread_t *p_intf = (intf_thread_t *)val.p_address;
projects / vlc / blobdiff