]> git.sesse.net Git - vlc/blobdiff - modules/services_discovery/sap.c
Removes trailing spaces. Removes tabs.
[vlc] / modules / services_discovery / sap.c
index 67d99a2095cd001bc3eb6efa5797e8e13c684e9c..23b8c946238a85387737fb9b505ce951f5f1d5a7 100644 (file)
 /*****************************************************************************
  * Includes
  *****************************************************************************/
-#define _GNU_SOURCE
-#include <stdlib.h>                                      /* malloc(), free() */
-
 #include <vlc/vlc.h>
+#include <assert.h>
+
 #include <vlc_playlist.h>
 #include <vlc_demux.h>
 
                               "can specify a specific address." )
 #define SAP_IPV4_TEXT N_( "IPv4 SAP" )
 #define SAP_IPV4_LONGTEXT N_( \
-      "Listen to IPv4 announcements " \
-      "on the standard address." )
+      "Listen to IPv4 announcements on the standard addresses." )
 #define SAP_IPV6_TEXT N_( "IPv6 SAP" )
 #define SAP_IPV6_LONGTEXT N_( \
-      "Listen to IPv6 announcements " \
-      "on the standard addresses." )
+      "Listen to IPv6 announcements on the standard addresses." )
 #define SAP_SCOPE_TEXT N_( "IPv6 SAP scope" )
 #define SAP_SCOPE_LONGTEXT N_( \
        "Scope for IPv6 announcements (default is 8)." )
@@ -147,7 +144,7 @@ vlc_module_begin();
     set_callbacks( Open, Close );
 
     add_submodule();
-        set_description( _("SDP file parser for UDP") );
+        set_description( _("SDP Descriptions parser") );
         add_shortcut( "sdp" );
         set_capability( "demux2", 51 );
         set_callbacks( OpenDemux, CloseDemux );
@@ -221,8 +218,6 @@ struct sap_announce_t
     sdp_t       *p_sdp;
 
     int i_input_id;
-    int i_item_id_cat;
-    int i_item_id_one;
 };
 
 struct services_discovery_sys_t
@@ -231,10 +226,6 @@ struct services_discovery_sys_t
     int i_fd;
     int *pi_fd;
 
-    /* playlist node */
-    playlist_item_t *p_node_cat;
-    playlist_item_t *p_node_one;
-
     /* Table of announces */
     int i_announces;
     struct sap_announce_t **pp_announces;
@@ -309,16 +300,11 @@ static int Open( vlc_object_t *p_this )
 #endif
 
     /* Cache sap_timeshift value */
-    p_sys->b_timeshift = var_CreateGetInteger( p_sd, "sap-timeshift" )
-            ? VLC_TRUE : VLC_FALSE;
+    p_sys->b_timeshift = var_CreateGetInteger( p_sd, "sap-timeshift" );
 
-    /* Create our playlist node */
-    pl_Yield( p_sd );
+    /* Set our name */
+    services_discovery_SetLocalizedName( p_sd, _("SAP") );
 
-    playlist_NodesPairCreate( pl_Get( p_sd ), _("SAP sessions"),
-                              &p_sys->p_node_cat, &p_sys->p_node_one,
-                              VLC_TRUE );
-    p_sys->p_node_cat->p_input->b_prefers_tree = VLC_TRUE;
     p_sys->i_announces = 0;
     p_sys->pp_announces = NULL;
 
@@ -331,11 +317,11 @@ static int Open( vlc_object_t *p_this )
 static int OpenDemux( vlc_object_t *p_this )
 {
     demux_t *p_demux = (demux_t *)p_this;
-    uint8_t *p_peek;
-    int i_max_sdp = 1024;
-    int i_sdp = 0;
+    const uint8_t *p_peek;
     char *psz_sdp = NULL;
     sdp_t *p_sdp = NULL;
+    int errval = VLC_EGENERIC;
+    size_t i_len;
 
     if( !var_CreateGetInteger( p_demux, "sap-parse" ) )
     {
@@ -343,44 +329,40 @@ static int OpenDemux( vlc_object_t *p_this )
         return VLC_EGENERIC;
     }
 
-    /* Probe for SDP */
-    if( p_demux->s )
-    {
-        if( stream_Peek( p_demux->s, &p_peek, 7 ) < 7 ) return VLC_EGENERIC;
+    assert( p_demux->s ); /* this is NOT an access_demux */
 
-        if( strncmp( (char*)p_peek, "v=0\r\n", 5 ) &&
-            strncmp( (char*)p_peek, "v=0\n", 4 ) &&
-            ( p_peek[0] < 'a' || p_peek[0] > 'z' || p_peek[1] != '=' ) )
-        {
-            return VLC_EGENERIC;
-        }
-    }
+    /* Probe for SDP */
+    if( stream_Peek( p_demux->s, &p_peek, 7 ) < 7 )
+        return VLC_EGENERIC;
 
-    psz_sdp = (char *)malloc( i_max_sdp );
-    if( !psz_sdp ) return VLC_EGENERIC;
+    if( memcmp( p_peek, "v=0\r\no=", 7 ) && memcmp( p_peek, "v=0\no=", 6 ) )
+        return VLC_EGENERIC;
 
     /* Gather the complete sdp file */
-    for( ;; )
+    for( i_len = 0, psz_sdp = NULL; i_len < 65536; )
     {
-        int i_read = stream_Read( p_demux->s,
-                                  &psz_sdp[i_sdp], i_max_sdp - i_sdp - 1 );
-
-        if( i_read < 0 )
+        const int i_read_max = 1024;
+        char *psz_sdp_new = realloc( psz_sdp, i_len + i_read_max );
+        size_t i_read;
+        if( psz_sdp_new == NULL )
         {
-            msg_Err( p_demux, "failed to read SDP" );
+            errval = VLC_ENOMEM;
             goto error;
         }
+        psz_sdp = psz_sdp_new;
 
-        i_sdp += i_read;
-
-        if( i_read < i_max_sdp - i_sdp - 1 )
+        i_read = stream_Read( p_demux->s, &psz_sdp[i_len], i_read_max );
+        if( i_read < 0 )
         {
-            psz_sdp[i_sdp] = '\0';
-            break;
+            msg_Err( p_demux, "cannot read SDP" );
+            goto error;
         }
+        i_len += i_read;
+
+        psz_sdp[i_len] = '\0';
 
-        i_max_sdp += 1000;
-        psz_sdp = (char *)realloc( psz_sdp, i_max_sdp );
+        if( i_read < i_read_max )
+            break; // EOF
     }
 
     p_sdp = ParseSDP( VLC_OBJECT(p_demux), psz_sdp );
@@ -413,7 +395,7 @@ error:
     FREENULL( psz_sdp );
     if( p_sdp ) FreeSDP( p_sdp ); p_sdp = NULL;
     stream_Seek( p_demux->s, 0 );
-    return VLC_EGENERIC;
+    return errval;
 }
 
 /*****************************************************************************
@@ -445,10 +427,6 @@ static void Close( vlc_object_t *p_this )
     }
     FREENULL( p_sys->pp_announces );
 
-    playlist_NodeDelete( pl_Get(p_sd), p_sys->p_node_cat, VLC_TRUE,
-                         VLC_TRUE );
-    playlist_NodeDelete( pl_Get(p_sd), p_sys->p_node_one, VLC_TRUE,
-                         VLC_TRUE );
     pl_Release( p_sd );
     free( p_sys );
 }
@@ -516,8 +494,8 @@ static void Run( services_discovery_t *p_sd )
         if( s != INVALID_SOCKET )
         {
             INTERFACE_INFO ifaces[10]; // Assume there will be no more than 10 IP interfaces
-            size_t len = sizeof(ifaces); 
-             
+            size_t len = sizeof(ifaces);
+
             if( SOCKET_ERROR != WSAIoctl(s, SIO_GET_INTERFACE_LIST, NULL, 0, &ifaces, len, &len, NULL, NULL) )
             {
                 unsigned ifcount = len/sizeof(INTERFACE_INFO);
@@ -612,13 +590,13 @@ static int Demux( demux_t *p_demux )
         return VLC_EGENERIC;
     }
 
-    p_parent_input = input_GetItem(p_input);
+    p_parent_input = input_GetItem( p_input );
+
+    input_item_SetURI( p_parent_input, p_sdp->psz_uri );
+    input_item_SetName( p_parent_input, p_sdp->psz_sessionname );
 
     vlc_mutex_lock( &p_parent_input->lock );
-    FREENULL( p_parent_input->psz_uri );
-    p_parent_input->psz_uri = strdup( p_sdp->psz_uri );
-    FREENULL( p_parent_input->psz_name );
-    p_parent_input->psz_name = strdup( p_sdp->psz_sessionname );
+
     p_parent_input->i_type = ITEM_TYPE_NET;
 
     if( p_playlist->status.p_item &&
@@ -787,7 +765,6 @@ sap_announce_t *CreateAnnounce( services_discovery_t *p_sd, uint16_t i_hash,
                                 sdp_t *p_sdp )
 {
     input_item_t *p_input;
-    playlist_item_t     *p_item, *p_child;
     const char *psz_value;
     sap_announce_t *p_sap = (sap_announce_t *)malloc(
                                         sizeof(sap_announce_t ) );
@@ -819,12 +796,13 @@ sap_announce_t *CreateAnnounce( services_discovery_t *p_sd, uint16_t i_hash,
     psz_value = GetAttribute( p_sap->p_sdp->pp_attributes, p_sap->p_sdp->i_attributes, "tool" );
     if( psz_value != NULL )
     {
-        input_ItemAddInfo( p_input, _("Session"),_("Tool"), psz_value );
+        input_ItemAddInfo( p_input, _("Session"), _("Tool"), "%s",
+                           psz_value );
     }
     if( strcmp( p_sdp->username, "-" ) )
     {
-        input_ItemAddInfo( p_input, _("Session"),
-                                _("User"), p_sdp->username );
+        input_ItemAddInfo( p_input, _("Session"), _("User"), "%s",
+                           p_sdp->username );
     }
 
     /* Handle group */
@@ -833,34 +811,7 @@ sap_announce_t *CreateAnnounce( services_discovery_t *p_sd, uint16_t i_hash,
     else
         psz_value = GetAttribute( p_sap->p_sdp->pp_attributes, p_sap->p_sdp->i_attributes, "x-plgroup" );
 
-    if( psz_value != NULL )
-    {
-        p_child = playlist_ChildSearchName( p_sys->p_node_cat, psz_value );
-
-        if( p_child == NULL )
-        {
-            p_child = playlist_NodeCreate( pl_Get( p_sd ), psz_value,
-                                           p_sys->p_node_cat, 0 );
-            p_child->i_flags &= ~PLAYLIST_SKIP_FLAG;
-        }
-    }
-    else
-    {
-        p_child = p_sys->p_node_cat;
-    }
-
-    p_item = playlist_NodeAddInput( pl_Get( p_sd ), p_input, p_child,
-                                    PLAYLIST_APPEND, PLAYLIST_END, VLC_FALSE );
-    p_item->i_flags &= ~PLAYLIST_SKIP_FLAG;
-    p_item->i_flags &= ~PLAYLIST_SAVE_FLAG;
-    p_sap->i_item_id_cat = p_item->i_id;
-
-    p_item = playlist_NodeAddInput( pl_Get( p_sd ), p_input,
-                        p_sys->p_node_one, PLAYLIST_APPEND, PLAYLIST_END,
-                        VLC_FALSE );
-    p_item->i_flags &= ~PLAYLIST_SKIP_FLAG;
-    p_item->i_flags &= ~PLAYLIST_SAVE_FLAG;
-    p_sap->i_item_id_one = p_item->i_id;
+    services_discovery_AddItem( p_sd, p_input, psz_value /* category name */ );
 
     TAB_APPEND( p_sys->i_announces, p_sys->pp_announces, p_sap );