Fix a Clang 19 warning.

[nageru] / nageru / kaeru.cpp

diff --git a/nageru/kaeru.cpp b/nageru/kaeru.cpp
index 1a63bb04337ca56841033b9628908c39b7083f8f..caa71c6527fc3bd0cdde79dc88cc9154bae34e5b 100644 (file)
--- a/nageru/kaeru.cpp
+++ b/nageru/kaeru.cpp
@@ -6,17 +6,46 @@
 #include "flags.h"
 #include "ffmpeg_capture.h"
 #include "mixer.h"
+#include "print_latency.h"
+#include "shared/ffmpeg_raii.h"
+#include "shared/httpd.h"
 #include "shared/mux.h"
 #include "quittable_sleeper.h"
+#include "shared/shared_defs.h"
 #include "shared/timebase.h"
 #include "x264_encoder.h"
 
 #include <assert.h>
-#include <fcntl.h>
-#include <signal.h>
-#include <unistd.h>
+#include <bmusb/bmusb.h>
 #include <chrono>
+#include <endian.h>
+#include <errno.h>
+#include <functional>
+#include <memory>
+#include <signal.h>
+#include <stddef.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
 #include <string>
+#include <vector>
+
+extern "C" {
+#include <libavcodec/bsf.h>
+#include <libavcodec/codec_par.h>
+#include <libavcodec/packet.h>
+#include <libavformat/avformat.h>
+#include <libavformat/avio.h>
+#include <libavformat/version.h>
+#include <libavutil/avutil.h>
+#include <libavutil/common.h>
+#include <libavutil/error.h>
+#include <libavutil/mathematics.h>
+#include <libavutil/mem.h>
+#include <libavutil/rational.h>
+#include <libavutil/version.h>
+}
 
 using namespace bmusb;
 using namespace movit;
@@ -59,10 +88,10 @@ int write_packet(void *opaque, uint8_t *buf, int buf_size, AVIODataMarkerType ty
 
 }  // namespace
 
-unique_ptr<Mux> create_mux(HTTPD *httpd, AVOutputFormat *oformat, X264Encoder *x264_encoder, AudioEncoder *audio_encoder)
+unique_ptr<Mux> create_mux(HTTPD *httpd, const AVOutputFormat *oformat, X264Encoder *x264_encoder, AudioEncoder *audio_encoder)
 {
        AVFormatContext *avctx = avformat_alloc_context();
-       avctx->oformat = oformat;
+       avctx->oformat = oformat;  // const_cast is a hack to work in FFmpeg both before and after 5.0.
 
        uint8_t *buf = (uint8_t *)av_malloc(MUX_BUFFER_SIZE);
        avctx->pb = avio_alloc_context(buf, MUX_BUFFER_SIZE, 1, httpd, nullptr, nullptr, nullptr);
@@ -89,8 +118,8 @@ void video_frame_callback(FFmpegCapture *video, X264Encoder *x264_encoder, Audio
                           int64_t video_pts, AVRational video_timebase,
                           int64_t audio_pts, AVRational audio_timebase,
                           uint16_t timecode,
-                         FrameAllocator::Frame video_frame, size_t video_offset, VideoFormat video_format,
-                         FrameAllocator::Frame audio_frame, size_t audio_offset, AudioFormat audio_format)
+                          FrameAllocator::Frame video_frame, size_t video_offset, VideoFormat video_format,
+                          FrameAllocator::Frame audio_frame, size_t audio_offset, AudioFormat audio_format)
 {
        if (video_pts >= 0 && video_frame.len > 0) {
                ReceivedTimestamps ts;
@@ -128,7 +157,7 @@ void video_frame_callback(FFmpegCapture *video, X264Encoder *x264_encoder, Audio
                }
                audio_pts = av_rescale_q(audio_pts, audio_timebase, AVRational{ 1, TIMEBASE });
                audio_encoder->encode_audio(float_samples, audio_pts);
-        }
+       }
 
        if (video_frame.owner) {
                video_frame.owner->release_frame(video_frame);
@@ -158,10 +187,8 @@ void filter_packet_callback(Mux *mux, int stream_index, AVBSFContext *bsfctx, co
                fprintf(stderr, "av_bsf_send_packet() failed with %d, ignoring\n", err);
        }
        for ( ;; ) {
-               AVPacket out_pkt;
-               unique_ptr<AVPacket, decltype(av_packet_unref) *> pkt_cleanup(&out_pkt, av_packet_unref);
-               av_init_packet(&out_pkt);
-               err = av_bsf_receive_packet(bsfctx, &out_pkt);
+               AVPacketWithDeleter out_pkt = av_packet_alloc_unique();
+               err = av_bsf_receive_packet(bsfctx, out_pkt.get());
                if (err == AVERROR(EAGAIN)) {
                        break;
                }
@@ -169,7 +196,7 @@ void filter_packet_callback(Mux *mux, int stream_index, AVBSFContext *bsfctx, co
                        fprintf(stderr, "av_bsf_receive_packet() failed with %d, ignoring\n", err);
                        return;
                }
-               mux->add_packet(out_pkt, out_pkt.pts, out_pkt.dts == AV_NOPTS_VALUE ? out_pkt.pts : out_pkt.dts, timebase, stream_index);
+               mux->add_packet(*out_pkt, out_pkt->pts, out_pkt->dts == AV_NOPTS_VALUE ? out_pkt->pts : out_pkt->dts, timebase, stream_index);
        }
 }
 
@@ -220,7 +247,7 @@ int main(int argc, char *argv[])
 
        HTTPD httpd;
 
-       AVOutputFormat *oformat = av_guess_format(global_flags.stream_mux_name.c_str(), nullptr, nullptr);
+       const AVOutputFormat *oformat = av_guess_format(global_flags.stream_mux_name.c_str(), nullptr, nullptr);
        assert(oformat != nullptr);
 
        unique_ptr<AudioEncoder> audio_encoder;
@@ -240,7 +267,7 @@ int main(int argc, char *argv[])
        }
        global_x264_encoder = x264_encoder.get();
 
-       FFmpegCapture video(argv[optind], global_flags.width, global_flags.height);
+       FFmpegCapture video(argv[optind], global_flags.width, global_flags.height, /*surface=*/nullptr);
        video.set_pixel_format(FFmpegCapture::PixelFormat_NV12);
        if (global_flags.transcode_video) {
                video.set_frame_callback(bind(video_frame_callback, &video, x264_encoder.get(), audio_encoder.get(), _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _11));