Fix a Clang 19 warning.

[nageru] / nageru / scene.cpp

diff --git a/nageru/scene.cpp b/nageru/scene.cpp
index 7a8e882fc038b1c092cdb2e4f68e5ac040586b01..74d0e9e1b271e15b3b3aae5899f997c9e004ebd1 100644 (file)
--- a/nageru/scene.cpp
+++ b/nageru/scene.cpp
@@ -1,8 +1,22 @@
+#include <algorithm>
+#include <array>
 #include <assert.h>
+#include <bitset>
+#include <bmusb/bmusb.h>
+#include <math.h>
+#include <stddef.h>
+#include <stdio.h>
+#include <functional>
+#include <map>
+#include <movit/effect.h>
+#include <mutex>
+#include <string>
+#include <utility>
+#include <vector>
 extern "C" {
 #include <lauxlib.h>
-#include <lua.hpp>
 }
+#include <lua.hpp>
 
 #ifdef HAVE_CEF
 #include "cef_capture.h"
@@ -209,6 +223,11 @@ int Scene::add_input(lua_State* L)
                if (lua_isnumber(L, 2)) {
                        block->alternatives.emplace_back(new EffectBlueprint(LIVE_INPUT_YCBCR));
                        block->alternatives.emplace_back(new EffectBlueprint(LIVE_INPUT_YCBCR_WITH_DEINTERLACE));
+#ifdef HAVE_SRT
+                       if (global_flags.srt_port >= 0) {
+                               block->alternatives.emplace_back(new EffectBlueprint(LIVE_INPUT_YCBCR_PLANAR));
+                       }
+#endif
 #ifdef HAVE_CEF
                } else if (luaL_testudata(L, 2, "HTMLInput")) {
                        block->alternatives.emplace_back(new EffectBlueprint(LIVE_INPUT_BGRA));
@@ -339,7 +358,7 @@ const Block *Scene::find_root_input_block(lua_State *L, const Block *block)
                const Block *parent = find_root_input_block(L, blocks[input_idx]);
                if (parent != nullptr) {
                        if (ret != nullptr) {
-                               luaL_error(L, "add_auto_white_balance() was connected to more than one input");
+                               luaL_error(L, "add_white_balance() was connected to more than one input");
                        }
                        ret = parent;
                }
@@ -347,7 +366,7 @@ const Block *Scene::find_root_input_block(lua_State *L, const Block *block)
        return ret;
 }
 
-int Scene::add_auto_white_balance(lua_State* L)
+int Scene::add_white_balance(lua_State* L)
 {
        assert(lua_gettop(L) >= 1);
        Scene *scene = (Scene *)luaL_checkudata(L, 1, "Scene");
@@ -375,10 +394,10 @@ int Scene::add_auto_white_balance(lua_State* L)
                block->inputs.push_back(find_block_from_arg(L, scene, 2)->idx);
                block->white_balance_controller_block = find_block_from_arg(L, scene, 3);
        } else {
-               luaL_error(L, "add_auto_white_balance([input], [white_balance_controller]) takes zero, one or two arguments");
+               luaL_error(L, "add_white_balance([input], [white_balance_controller]) takes zero, one or two arguments");
        }
        if (block->white_balance_controller_block == nullptr || !block->white_balance_controller_block->is_input) {
-               luaL_error(L, "add_auto_white_balance() does not get its white balance from an input");
+               luaL_error(L, "add_white_balance() does not get its white balance from an input");
        }
 
        scene->blocks.push_back(block);
@@ -417,7 +436,7 @@ Effect *Scene::instantiate_effects(const Block *block, size_t chain_idx, Scene::
                        pixel_format = bmusb::PixelFormat_8BitBGRA;
                } else if (chosen_type == LIVE_INPUT_YCBCR_PLANAR) {
                        pixel_format = bmusb::PixelFormat_8BitYCbCrPlanar;
-               } else if (global_flags.ten_bit_input) {
+               } else if (global_flags.bit_depth > 8) {
                        pixel_format = bmusb::PixelFormat_10BitYCbCr;
                } else {
                        pixel_format = bmusb::PixelFormat_8BitYCbCr;
@@ -470,7 +489,7 @@ int Scene::finalize(lua_State* L)
                }
        }
        const size_t total_cardinality = real_cardinality * (only_one_mode ? 1 : 2);
-       if (total_cardinality > 200) {
+       if (total_cardinality > 400) {
                print_warning(L, "The given Scene will instantiate %zu different versions. This will take a lot of time and RAM to compile; see if you could limit some options by e.g. locking the input type in some cases (by giving a fixed input to add_input()).\n",
                        total_cardinality);
        }
@@ -521,14 +540,22 @@ Scene::get_chain(Theme *theme, lua_State *L, unsigned num, const InputState &inp
        InputStateInfo info(input_state);
        for (Block *block : blocks) {
                if (block->is_input && block->signal_type_to_connect == Block::CONNECT_SIGNAL) {
-                       EffectType chosen_type = current_type(block);
-                       assert(chosen_type == LIVE_INPUT_YCBCR || chosen_type == LIVE_INPUT_YCBCR_WITH_DEINTERLACE);
                        int card_index = theme->map_signal_to_card(block->signal_to_connect);
                        if (info.last_interlaced[card_index]) {
+                               assert(info.last_pixel_format[card_index] == bmusb::PixelFormat_8BitYCbCr ||
+                                      info.last_pixel_format[card_index] == bmusb::PixelFormat_10BitYCbCr);
                                block->currently_chosen_alternative = find_index_of(block, LIVE_INPUT_YCBCR_WITH_DEINTERLACE);
+                       } else if (info.last_pixel_format[card_index] == bmusb::PixelFormat_8BitYCbCrPlanar) {
+                               block->currently_chosen_alternative = find_index_of(block, LIVE_INPUT_YCBCR_PLANAR);
+                       } else if (info.last_pixel_format[card_index] == bmusb::PixelFormat_8BitBGRA) {
+                               block->currently_chosen_alternative = find_index_of(block, LIVE_INPUT_BGRA);
                        } else {
                                block->currently_chosen_alternative = find_index_of(block, LIVE_INPUT_YCBCR);
                        }
+                       if (block->currently_chosen_alternative == -1) {
+                               fprintf(stderr, "ERROR: Input connected to a video card pixel format that it was not ready for.\n");
+                               abort();
+                       }
                }
        }