/* */
vlc_object_attach( p_blend, p_spu );
}
-static void SpuRenderUpdateBlend( spu_t *p_spu, const video_format_t *p_vfmt )
+static void SpuRenderUpdateBlend( spu_t *p_spu, int i_out_width, int i_out_height, const video_format_t *p_in_fmt )
{
filter_t *p_blend = p_spu->p_blend;
assert( p_blend );
/* */
- if( p_blend->p_module && p_blend->fmt_in.video.i_chroma != p_vfmt->i_chroma )
+ if( p_blend->p_module && p_blend->fmt_in.video.i_chroma != p_in_fmt->i_chroma )
{
/* The chroma is not the same, we need to reload the blend module
* XXX to match the old behaviour just test !p_blend->fmt_in.video.i_chroma */
}
/* */
- p_blend->fmt_in.video = *p_vfmt;
+ p_blend->fmt_in.video = *p_in_fmt;
+
+ /* */
+ p_blend->fmt_out.video.i_width =
+ p_blend->fmt_out.video.i_visible_width = i_out_width;
+ p_blend->fmt_out.video.i_height =
+ p_blend->fmt_out.video.i_visible_height = i_out_height;
/* */
if( !p_blend->p_module )
p_scale->p_module = module_Need( p_spu->p_scale, "video filter2", 0, 0 );
}
+static void SpuRenderText( spu_t *p_spu, bool *pb_rerender_text,
+ subpicture_t *p_subpic, subpicture_region_t *p_region, int i_min_scale_ratio )
+{
+ assert( p_region->fmt.i_chroma == VLC_FOURCC('T','E','X','T') );
+
+ if( !p_spu->p_text || !p_spu->p_text->p_module )
+ goto exit;
+
+ /* Setup 3 variables which can be used to render
+ * time-dependent text (and effects). The first indicates
+ * the total amount of time the text will be on screen,
+ * the second the amount of time it has already been on
+ * screen (can be a negative value as text is layed out
+ * before it is rendered) and the third is a feedback
+ * variable from the renderer - if the renderer sets it
+ * then this particular text is time-dependent, eg. the
+ * visual progress bar inside the text in karaoke and the
+ * text needs to be rendered multiple times in order for
+ * the effect to work - we therefore need to return the
+ * region to its original state at the end of the loop,
+ * instead of leaving it in YUVA or YUVP.
+ * Any renderer which is unaware of how to render
+ * time-dependent text can happily ignore the variables
+ * and render the text the same as usual - it should at
+ * least show up on screen, but the effect won't change
+ * the text over time.
+ */
+
+ /* FIXME why these variables are recreated every time and not
+ * when text renderer module was created ? */
+ var_Create( p_spu->p_text, "spu-duration", VLC_VAR_TIME );
+ var_Create( p_spu->p_text, "spu-elapsed", VLC_VAR_TIME );
+ var_Create( p_spu->p_text, "text-rerender", VLC_VAR_BOOL );
+ var_Create( p_spu->p_text, "scale", VLC_VAR_INTEGER );
+
+ var_SetTime( p_spu->p_text, "spu-duration", p_subpic->i_stop - p_subpic->i_start );
+ var_SetTime( p_spu->p_text, "spu-elapsed", mdate() - p_subpic->i_start );
+ var_SetBool( p_spu->p_text, "text-rerender", false );
+ var_SetInteger( p_spu->p_text, "scale", i_min_scale_ratio );
+
+ if( p_spu->p_text->pf_render_html && p_region->psz_html )
+ {
+ p_spu->p_text->pf_render_html( p_spu->p_text,
+ p_region, p_region );
+ }
+ else if( p_spu->p_text->pf_render_text )
+ {
+ p_spu->p_text->pf_render_text( p_spu->p_text,
+ p_region, p_region );
+ }
+ *pb_rerender_text = var_GetBool( p_spu->p_text, "text-rerender" );
+
+ var_Destroy( p_spu->p_text, "spu-duration" );
+ var_Destroy( p_spu->p_text, "spu-elapsed" );
+ var_Destroy( p_spu->p_text, "text-rerender" );
+ var_Destroy( p_spu->p_text, "scale" );
+
+exit:
+ p_region->i_align |= SUBPICTURE_RENDERED;
+}
+
static void SpuRenderRegion( spu_t *p_spu,
picture_t *p_pic_dst, picture_t *p_pic_src,
subpicture_t *p_subpic, subpicture_region_t *p_region,
const int pi_scale_height[SCALE_SIZE],
const video_format_t *p_fmt )
{
- video_format_t orig_fmt = p_region->fmt;
- bool b_rerender_text = false;
- int i_fade_alpha = 255;
+ video_format_t orig_fmt;
+ bool b_rerender_text;
+ int i_fade_alpha;
int i_x_offset;
int i_y_offset;
- int i_scale_idx = SCALE_DEFAULT;
- int i_inv_scale_x = 1000;
- int i_inv_scale_y = 1000;
+ int i_scale_idx;
+ int i_inv_scale_x;
+ int i_inv_scale_y;
+ orig_fmt = p_region->fmt;
+ b_rerender_text = false;
if( p_region->fmt.i_chroma == VLC_FOURCC('T','E','X','T') )
{
- if( p_spu->p_text && p_spu->p_text->p_module )
- {
- vlc_value_t val;
-
- /* Setup 3 variables which can be used to render
- * time-dependent text (and effects). The first indicates
- * the total amount of time the text will be on screen,
- * the second the amount of time it has already been on
- * screen (can be a negative value as text is layed out
- * before it is rendered) and the third is a feedback
- * variable from the renderer - if the renderer sets it
- * then this particular text is time-dependent, eg. the
- * visual progress bar inside the text in karaoke and the
- * text needs to be rendered multiple times in order for
- * the effect to work - we therefore need to return the
- * region to its original state at the end of the loop,
- * instead of leaving it in YUVA or YUVP.
- * Any renderer which is unaware of how to render
- * time-dependent text can happily ignore the variables
- * and render the text the same as usual - it should at
- * least show up on screen, but the effect won't change
- * the text over time.
- */
-
- var_Create( p_spu->p_text, "spu-duration", VLC_VAR_TIME );
- val.i_time = p_subpic->i_stop - p_subpic->i_start;
- var_Set( p_spu->p_text, "spu-duration", val );
-
- var_Create( p_spu->p_text, "spu-elapsed", VLC_VAR_TIME );
- val.i_time = mdate() - p_subpic->i_start;
- var_Set( p_spu->p_text, "spu-elapsed", val );
-
- var_Create( p_spu->p_text, "text-rerender", VLC_VAR_BOOL );
- var_SetBool( p_spu->p_text, "text-rerender", false );
-
- var_Create( p_spu->p_text, "scale", VLC_VAR_INTEGER );
- var_SetInteger( p_spu->p_text, "scale",
- __MIN(i_scale_width_orig, i_scale_height_orig) );
-
- if( p_spu->p_text->pf_render_html && p_region->psz_html )
- {
- p_spu->p_text->pf_render_html( p_spu->p_text,
- p_region, p_region );
- }
- else if( p_spu->p_text->pf_render_text )
- {
- p_spu->p_text->pf_render_text( p_spu->p_text,
- p_region, p_region );
- }
- b_rerender_text = var_GetBool( p_spu->p_text, "text-rerender" );
+ SpuRenderText( p_spu, &b_rerender_text, p_subpic, p_region, __MIN(i_scale_width_orig, i_scale_height_orig) );
- var_Destroy( p_spu->p_text, "spu-duration" );
- var_Destroy( p_spu->p_text, "spu-elapsed" );
- var_Destroy( p_spu->p_text, "text-rerender" );
- var_Destroy( p_spu->p_text, "scale" );
- }
- p_region->i_align |= SUBPICTURE_RENDERED;
+ /* Check if the rendering has failed ... */
+ if( p_region->fmt.i_chroma == VLC_FOURCC('T','E','X','T') )
+ goto exit;
}
if( p_region->i_align & SUBPICTURE_RENDERED )
{
+ /* We are using a region which come from rendered text */
i_scale_idx = SCALE_TEXT;
i_inv_scale_x = i_scale_width_orig;
i_inv_scale_y = i_scale_height_orig;
}
+ else
+ {
+ i_scale_idx = SCALE_DEFAULT;
+ i_inv_scale_x = 1000;
+ i_inv_scale_y = 1000;
+ }
i_x_offset = (p_region->i_x + pi_subpic_x[ i_scale_idx ]) * i_inv_scale_x / 1000;
i_y_offset = (p_region->i_y + p_subpic->i_y) * i_inv_scale_y / 1000;
/* Force palette if requested */
if( p_spu->b_force_palette &&
- ( VLC_FOURCC('Y','U','V','P') == p_region->fmt.i_chroma ) )
+ p_region->fmt.i_chroma == VLC_FOURCC('Y','U','V','P') )
{
- memcpy( p_region->fmt.p_palette->palette,
- p_spu->palette, 16 );
+ /* It looks so wrong I won't comment
+ * p_palette->palette is [256][4] with a int i_entries
+ * p_spu->palette is [4][4]
+ * */
+ memcpy( p_region->fmt.p_palette->palette, p_spu->palette, 16 );
}
- /* Scale SPU if necessary */
- if( p_region->p_cache &&
- ( p_region->fmt.i_chroma != VLC_FOURCC('T','E','X','T') ) )
+ if( p_spu->p_scale &&
+ ( ( pi_scale_width[i_scale_idx] > 0 && pi_scale_width[i_scale_idx] != 1000 ) ||
+ ( pi_scale_height[i_scale_idx] > 0 && pi_scale_height[i_scale_idx] != 1000 ) ) )
{
- if( pi_scale_width[ i_scale_idx ] * p_region->fmt.i_width / 1000 !=
- p_region->p_cache->fmt.i_width ||
- pi_scale_height[ i_scale_idx ] * p_region->fmt.i_height / 1000 !=
- p_region->p_cache->fmt.i_height )
+ const int i_dst_width = p_region->fmt.i_width * pi_scale_width[i_scale_idx] / 1000;
+ const int i_dst_height = p_region->fmt.i_height * pi_scale_height[i_scale_idx] / 1000;
+
+ /* Destroy if cache is unusable */
+ if( p_region->p_cache )
{
- p_subpic->pf_destroy_region( VLC_OBJECT(p_spu),
- p_region->p_cache );
- p_region->p_cache = 0;
+ if( p_region->p_cache->fmt.i_width != i_dst_width ||
+ p_region->p_cache->fmt.i_height != i_dst_height )
+ {
+ p_subpic->pf_destroy_region( VLC_OBJECT(p_spu),
+ p_region->p_cache );
+ p_region->p_cache = NULL;
+ }
}
- }
- if( ( ( pi_scale_width[ i_scale_idx ] != 1000 ) ||
- ( pi_scale_height[ i_scale_idx ] != 1000 ) ) &&
- ( ( pi_scale_width[ i_scale_idx ] > 0 ) ||
- ( pi_scale_height[ i_scale_idx ] > 0 ) ) &&
- p_spu->p_scale && !p_region->p_cache &&
- ( p_region->fmt.i_chroma != VLC_FOURCC('T','E','X','T') ) )
- {
- picture_t *p_pic;
-
- p_spu->p_scale->fmt_in.video = p_region->fmt;
- p_spu->p_scale->fmt_out.video = p_region->fmt;
-
- p_region->p_cache =
- p_subpic->pf_create_region( VLC_OBJECT(p_spu),
- &p_spu->p_scale->fmt_out.video );
- if( p_spu->p_scale->fmt_out.video.p_palette )
- *p_spu->p_scale->fmt_out.video.p_palette =
- *p_region->fmt.p_palette;
- p_region->p_cache->p_next = p_region->p_next;
-
- vout_CopyPicture( p_spu, &p_region->p_cache->picture,
- &p_region->picture );
-
- p_spu->p_scale->fmt_out.video.i_width =
- p_region->fmt.i_width * pi_scale_width[ i_scale_idx ] / 1000;
- p_spu->p_scale->fmt_out.video.i_visible_width =
- p_region->fmt.i_visible_width * pi_scale_width[ i_scale_idx ] / 1000;
- p_spu->p_scale->fmt_out.video.i_height =
- p_region->fmt.i_height * pi_scale_height[ i_scale_idx ] / 1000;
- p_spu->p_scale->fmt_out.video.i_visible_height =
- p_region->fmt.i_visible_height * pi_scale_height[ i_scale_idx ] / 1000;
- p_region->p_cache->fmt = p_spu->p_scale->fmt_out.video;
- p_region->p_cache->i_x = p_region->i_x * pi_scale_width[ i_scale_idx ] / 1000;
- p_region->p_cache->i_y = p_region->i_y * pi_scale_height[ i_scale_idx ] / 1000;
- p_region->p_cache->i_align = p_region->i_align;
- p_region->p_cache->i_alpha = p_region->i_alpha;
-
- p_pic = p_spu->p_scale->pf_video_filter(
- p_spu->p_scale, &p_region->p_cache->picture );
- if( p_pic )
+ /* Scale if needed into cache */
+ if( !p_region->p_cache )
{
- picture_t p_pic_tmp = p_region->p_cache->picture;
- p_region->p_cache->picture = *p_pic;
- *p_pic = p_pic_tmp;
- free( p_pic );
+ picture_t *p_pic;
+
+ p_spu->p_scale->fmt_in.video = p_region->fmt;
+ p_spu->p_scale->fmt_out.video = p_region->fmt;
+
+ p_region->p_cache =
+ p_subpic->pf_create_region( VLC_OBJECT(p_spu),
+ &p_spu->p_scale->fmt_out.video );
+ p_region->p_cache->p_next = p_region->p_next;
+
+ if( p_spu->p_scale->fmt_out.video.p_palette )
+ *p_spu->p_scale->fmt_out.video.p_palette =
+ *p_region->fmt.p_palette;
+
+ vout_CopyPicture( p_spu, &p_region->p_cache->picture,
+ &p_region->picture );
+
+ p_spu->p_scale->fmt_out.video.i_width = i_dst_width;
+ p_spu->p_scale->fmt_out.video.i_height = i_dst_height;
+
+ p_spu->p_scale->fmt_out.video.i_visible_width =
+ p_region->fmt.i_visible_width * pi_scale_width[ i_scale_idx ] / 1000;
+ p_spu->p_scale->fmt_out.video.i_visible_height =
+ p_region->fmt.i_visible_height * pi_scale_height[ i_scale_idx ] / 1000;
+
+ p_region->p_cache->fmt = p_spu->p_scale->fmt_out.video;
+ p_region->p_cache->i_x = p_region->i_x * pi_scale_width[ i_scale_idx ] / 1000;
+ p_region->p_cache->i_y = p_region->i_y * pi_scale_height[ i_scale_idx ] / 1000;
+ p_region->p_cache->i_align = p_region->i_align;
+ p_region->p_cache->i_alpha = p_region->i_alpha;
+
+ p_pic = p_spu->p_scale->pf_video_filter(
+ p_spu->p_scale, &p_region->p_cache->picture );
+ if( p_pic )
+ {
+ p_region->p_cache->picture = *p_pic;
+ free( p_pic );
+ }
}
- }
- if( ( ( pi_scale_width[ i_scale_idx ] != 1000 ) ||
- ( pi_scale_height[ i_scale_idx ] != 1000 ) ) &&
- ( ( pi_scale_width[ i_scale_idx ] > 0 ) ||
- ( pi_scale_height[ i_scale_idx ] > 0 ) ) &&
- p_spu->p_scale && p_region->p_cache &&
- ( p_region->fmt.i_chroma != VLC_FOURCC('T','E','X','T') ) )
- {
- p_region = p_region->p_cache;
+ /* And the use the scale picture */
+ if( p_region->p_cache )
+ p_region = p_region->p_cache;
}
if( p_region->i_align & SUBPICTURE_ALIGN_BOTTOM )
i_x_offset = __MAX( i_x_offset, 0 );
i_y_offset = __MAX( i_y_offset, 0 );
- if( ( p_spu->i_margin != 0 ) &&
- ( p_spu->b_force_crop == false ) )
+ if( p_spu->i_margin != 0 && !p_spu->b_force_crop )
{
int i_diff = 0;
int i_low = (i_y_offset - p_spu->i_margin) * i_inv_scale_y / 1000;
i_y_offset -= ( p_spu->i_margin * i_inv_scale_y / 1000 + i_diff );
}
+ /* Force cropping if requested */
+ if( p_spu->b_force_crop )
+ {
+ video_format_t *p_fmt = &p_region->fmt;
+ int i_crop_x = p_spu->i_crop_x * pi_scale_width[ i_scale_idx ] / 1000
+ * i_inv_scale_x / 1000;
+ int i_crop_y = p_spu->i_crop_y * pi_scale_height[ i_scale_idx ] / 1000
+ * i_inv_scale_y / 1000;
+ int i_crop_width = p_spu->i_crop_width * pi_scale_width[ i_scale_idx ] / 1000
+ * i_inv_scale_x / 1000;
+ int i_crop_height = p_spu->i_crop_height * pi_scale_height[ i_scale_idx ] / 1000
+ * i_inv_scale_y / 1000;
+
+ /* Find the intersection */
+ if( i_crop_x + i_crop_width <= i_x_offset ||
+ i_x_offset + (int)p_fmt->i_visible_width < i_crop_x ||
+ i_crop_y + i_crop_height <= i_y_offset ||
+ i_y_offset + (int)p_fmt->i_visible_height < i_crop_y )
+ {
+ /* No intersection */
+ p_fmt->i_visible_width = p_fmt->i_visible_height = 0;
+ }
+ else
+ {
+ int i_x, i_y, i_x_end, i_y_end;
+ i_x = __MAX( i_crop_x, i_x_offset );
+ i_y = __MAX( i_crop_y, i_y_offset );
+ i_x_end = __MIN( i_crop_x + i_crop_width,
+ i_x_offset + (int)p_fmt->i_visible_width );
+ i_y_end = __MIN( i_crop_y + i_crop_height,
+ i_y_offset + (int)p_fmt->i_visible_height );
+
+ p_fmt->i_x_offset = i_x - i_x_offset;
+ p_fmt->i_y_offset = i_y - i_y_offset;
+ p_fmt->i_visible_width = i_x_end - i_x;
+ p_fmt->i_visible_height = i_y_end - i_y;
+
+ i_x_offset = i_x;
+ i_y_offset = i_y;
+ }
+ }
+
+ i_x_offset = __MAX( i_x_offset, 0 );
+ i_y_offset = __MAX( i_y_offset, 0 );
+
+ /* Compute alpha blend value */
+ i_fade_alpha = 255;
if( p_subpic->b_fade )
{
mtime_t i_fade_start = ( p_subpic->i_stop +
}
}
- if( p_region->fmt.i_chroma != VLC_FOURCC('T','E','X','T') )
- {
- /* */
- SpuRenderUpdateBlend( p_spu, &p_region->fmt );
-
- /* Force cropping if requested */
- if( p_spu->b_force_crop )
- {
- video_format_t *p_fmt = &p_spu->p_blend->fmt_in.video;
- int i_crop_x = p_spu->i_crop_x * pi_scale_width[ i_scale_idx ] / 1000
- * i_inv_scale_x / 1000;
- int i_crop_y = p_spu->i_crop_y * pi_scale_height[ i_scale_idx ] / 1000
- * i_inv_scale_y / 1000;
- int i_crop_width = p_spu->i_crop_width * pi_scale_width[ i_scale_idx ] / 1000
- * i_inv_scale_x / 1000;
- int i_crop_height = p_spu->i_crop_height * pi_scale_height[ i_scale_idx ] / 1000
- * i_inv_scale_y / 1000;
-
- /* Find the intersection */
- if( i_crop_x + i_crop_width <= i_x_offset ||
- i_x_offset + (int)p_fmt->i_visible_width < i_crop_x ||
- i_crop_y + i_crop_height <= i_y_offset ||
- i_y_offset + (int)p_fmt->i_visible_height < i_crop_y )
- {
- /* No intersection */
- p_fmt->i_visible_width = p_fmt->i_visible_height = 0;
- }
- else
- {
- int i_x, i_y, i_x_end, i_y_end;
- i_x = __MAX( i_crop_x, i_x_offset );
- i_y = __MAX( i_crop_y, i_y_offset );
- i_x_end = __MIN( i_crop_x + i_crop_width,
- i_x_offset + (int)p_fmt->i_visible_width );
- i_y_end = __MIN( i_crop_y + i_crop_height,
- i_y_offset + (int)p_fmt->i_visible_height );
-
- p_fmt->i_x_offset = i_x - i_x_offset;
- p_fmt->i_y_offset = i_y - i_y_offset;
- p_fmt->i_visible_width = i_x_end - i_x;
- p_fmt->i_visible_height = i_y_end - i_y;
-
- i_x_offset = i_x;
- i_y_offset = i_y;
- }
- }
-
- i_x_offset = __MAX( i_x_offset, 0 );
- i_y_offset = __MAX( i_y_offset, 0 );
+ /* Update the blender */
+ SpuRenderUpdateBlend( p_spu, p_fmt->i_width, p_fmt->i_height, &p_region->fmt );
- /* Update the output picture size */
- p_spu->p_blend->fmt_out.video.i_width =
- p_spu->p_blend->fmt_out.video.i_visible_width =
- p_fmt->i_width;
- p_spu->p_blend->fmt_out.video.i_height =
- p_spu->p_blend->fmt_out.video.i_visible_height =
- p_fmt->i_height;
-
- if( p_spu->p_blend->p_module )
- {
- p_spu->p_blend->pf_video_blend( p_spu->p_blend, p_pic_dst,
- p_pic_src, &p_region->picture, i_x_offset, i_y_offset,
- i_fade_alpha * p_subpic->i_alpha * p_region->i_alpha / 65025 );
- }
- else
- {
- msg_Err( p_spu, "blending %4.4s to %4.4s failed",
- (char *)&p_spu->p_blend->fmt_out.video.i_chroma,
- (char *)&p_spu->p_blend->fmt_out.video.i_chroma );
- }
+ if( p_spu->p_blend->p_module )
+ {
+ p_spu->p_blend->pf_video_blend( p_spu->p_blend, p_pic_dst,
+ p_pic_src, &p_region->picture, i_x_offset, i_y_offset,
+ i_fade_alpha * p_subpic->i_alpha * p_region->i_alpha / 65025 );
+ }
+ else
+ {
+ msg_Err( p_spu, "blending %4.4s to %4.4s failed",
+ (char *)&p_spu->p_blend->fmt_out.video.i_chroma,
+ (char *)&p_spu->p_blend->fmt_out.video.i_chroma );
}
+exit:
if( b_rerender_text )
{
/* Some forms of subtitles need to be re-rendered more than
}
if( i_scale_width_orig <= 0 )
- i_scale_width_orig = 1;
+ i_scale_width_orig = 1000;
if( i_scale_height_orig <= 0 )
- i_scale_height_orig = 1;
+ i_scale_height_orig = 1000;
i_source_video_width = p_fmt->i_width * 1000 / i_scale_width_orig;
i_source_video_height = p_fmt->i_height * 1000 / i_scale_height_orig;
if( p_subpic->pf_update_regions )
{
- if ( p_subpic->p_region ) {
+ /* FIXME that part look like crap too if there is more than 1 region */
+
+ if( p_subpic->p_region )
spu_DestroyRegion( p_spu, p_subpic->p_region );
- }
/* TODO do not reverse the scaling that was done before calling
* spu_RenderSubpictures, just pass it along (or do it inside
fmt_org.i_height =
fmt_org.i_visible_height = i_source_video_height;
- p_subpic->p_region = p_region = p_subpic->pf_update_regions( &fmt_org, p_spu, p_subpic, mdate() );
- }
- else
- {
- p_region = p_subpic->p_region;
+ p_subpic->p_region = p_subpic->pf_update_regions( &fmt_org, p_spu, p_subpic, mdate() );
}
+ /* */
+ p_region = p_subpic->p_region;
+ if( !p_region )
+ continue;
+
/* Create the blending module */
- if( !p_spu->p_blend && p_region )
+ if( !p_spu->p_blend )
SpuRenderCreateBlend( p_spu, p_fmt->i_chroma, p_fmt->i_aspect );
/* Load the text rendering module; it is possible there is a
* text region somewhere in the subpicture other than the first
* element in the region list, so just load it anyway as we'll
* probably want it sooner or later. */
- if( !p_spu->p_text && p_region )
+ if( !p_spu->p_text )
SpuRenderCreateAndLoadText( p_spu, p_fmt->i_width, p_fmt->i_height );
if( p_spu->p_text )
* resolution, rather than video resolution.
*/
while( p_text_region &&
- ( p_text_region->fmt.i_chroma != VLC_FOURCC('T','E','X','T') ) )
+ p_text_region->fmt.i_chroma != VLC_FOURCC('T','E','X','T') )
{
p_text_region = p_text_region->p_next;
}
p_fmt->i_height;
}
}
+
+ /* */
+ pi_scale_width[SCALE_TEXT] = p_fmt->i_width * 1000 /
+ p_spu->p_text->fmt_out.video.i_width;
+ pi_scale_height[SCALE_TEXT]= p_fmt->i_height * 1000 /
+ p_spu->p_text->fmt_out.video.i_height;
}
pi_scale_width[ SCALE_DEFAULT ] = i_scale_width_orig;
pi_scale_height[ SCALE_DEFAULT ] = i_scale_height_orig;
- if( p_spu->p_text )
- {
- pi_scale_width[ SCALE_TEXT ] = ( p_fmt->i_width * 1000 ) /
- p_spu->p_text->fmt_out.video.i_width;
- pi_scale_height[ SCALE_TEXT ] = ( p_fmt->i_height * 1000 ) /
- p_spu->p_text->fmt_out.video.i_height;
- }
/* If we have an explicit size plane to render to, then turn off
* the fontsize rescaling.
*/
if( (p_subpic->i_original_picture_height > 0) &&
(p_subpic->i_original_picture_width > 0) )
{
+#if 1
/* FIXME That seems so wrong */
i_scale_width_orig = 1000;
i_scale_height_orig = 1000;
-
- /* It is probably that :
+#else
+ /* It is probably that :*/
pi_scale_width[ SCALE_DEFAULT ] = i_scale_width_orig * i_source_video_width / p_subpic->i_original_picture_width;
pi_scale_height[ SCALE_DEFAULT ] = i_scale_height_orig * i_source_video_height / p_subpic->i_original_picture_height;
- */
+#endif
}
for( k = 0; k < SCALE_SIZE ; k++ )
}
/* Set default subpicture aspect ratio */
- if( p_region && p_region->fmt.i_aspect &&
- ( !p_region->fmt.i_sar_num || !p_region->fmt.i_sar_den ) )
+ if( p_region->fmt.i_aspect && ( !p_region->fmt.i_sar_num || !p_region->fmt.i_sar_den ) )
{
p_region->fmt.i_sar_den = p_region->fmt.i_aspect;
p_region->fmt.i_sar_num = VOUT_ASPECT_FACTOR;
}
- if( p_region &&
- ( !p_region->fmt.i_sar_num || !p_region->fmt.i_sar_den ) )
+ if( !p_region->fmt.i_sar_num || !p_region->fmt.i_sar_den )
{
p_region->fmt.i_sar_den = p_fmt->i_sar_den;
p_region->fmt.i_sar_num = p_fmt->i_sar_num;
}
/* Take care of the aspect ratio */
- if( p_region &&
- ( ( p_region->fmt.i_sar_num * p_fmt->i_sar_den ) !=
- ( p_region->fmt.i_sar_den * p_fmt->i_sar_num ) ) )
+ if( ( p_region->fmt.i_sar_num * p_fmt->i_sar_den ) !=
+ ( p_region->fmt.i_sar_den * p_fmt->i_sar_num ) )
{
for( k = 0; k < SCALE_SIZE ; k++ )
{
}
}
- /* Load the scaling module */
- if( !p_spu->p_scale &&
- ((((pi_scale_width[ SCALE_TEXT ] > 0) || (pi_scale_height[ SCALE_TEXT ] > 0)) &&
- ((pi_scale_width[ SCALE_TEXT ] != 1000) || (pi_scale_height[ SCALE_TEXT ] != 1000))) ||
- (((pi_scale_width[ SCALE_DEFAULT ] > 0) || (pi_scale_height[ SCALE_DEFAULT ] > 0)) &&
- ((pi_scale_width[ SCALE_DEFAULT ] != 1000) || (pi_scale_height[ SCALE_DEFAULT ] != 1000)))) )
+ /* Load the scaling module when needed */
+ if( !p_spu->p_scale )
{
- SpuRenderCreateAndLoadScale( p_spu );
+ bool b_scale_used = false;
+
+ for( k = 0; k < SCALE_SIZE ; k++ )
+ {
+ const int i_scale_w = pi_scale_width[k];
+ const int i_scale_h = pi_scale_height[k];
+ if( ( i_scale_w > 0 && i_scale_w != 1000 ) || ( i_scale_h > 0 && i_scale_h != 1000 ) )
+ b_scale_used = true;
+ }
+
+ if( b_scale_used )
+ SpuRenderCreateAndLoadScale( p_spu );
}
for( ; p_region != NULL; p_region = p_region->p_next )
projects / vlc / blobdiff