]> git.sesse.net Git - vlc/commit
projects / vlc / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cb59549) | patch
Fixed subtitle/osd memory leaks (subpicture_region_t->psz_text was not freed).
authorLaurent Aimar <fenrir@videolan.org>
Thu, 22 Feb 2007 20:43:28 +0000 (20:43 +0000)
committerLaurent Aimar <fenrir@videolan.org>
Thu, 22 Feb 2007 20:43:28 +0000 (20:43 +0000)
commit0c9117de56d95e4b26c3bfd1de284a3d983a9a57
tree72485efef769f7ef1a66a2cd7198ddb66a34dcectree | snapshot
parentcb595496f9c3e6666ca947636b56bea074b5ddd3commit | diff
Fixed subtitle/osd memory leaks (subpicture_region_t->psz_text was not freed).

 I think we have a potential bug with the way subpicture_region_t->p_style
is used.
 Decoders allocate p_style memory in their context, so we don't free it in
spu_DestroyRegion. As vout object can live longer than decoder, I think
p_style might be used after the decoder has destroyed it.

 Can someone, who has worked on osd/spu internal, comment ?
src/video_output/vout_subpictures.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.