]> git.sesse.net Git - ffmpeg/commit
avutil/internal: remove FF_ALLOCx{_ARRAY}_OR_GOTO macros
authorLimin Wang <lance.lmwang@gmail.com>
Tue, 2 Jun 2020 11:18:32 +0000 (19:18 +0800)
committerLimin Wang <lance.lmwang@gmail.com>
Fri, 12 Jun 2020 22:59:19 +0000 (06:59 +0800)
commit2658680df4fc606522e5f65899afb9a98b47d287
tree7e98041eeb6bd5d144df86380b2265969f11e104
parenta408d03ee6eeda98e77301dcdea3bdf40c0d4afc
avutil/internal: remove FF_ALLOCx{_ARRAY}_OR_GOTO macros

These functions have a terrible design, let us fix them before extending
them.
First design mistake: no error code. A helper function for testing
memory allocation failure where AVERROR(ENOMEM) does not appear is
absurd.

Second design mistake: printing a message. Return the error code, let
the caller print the error message.

Third design mistake: hard-coded use of goto.

http://ffmpeg.org/pipermail/ffmpeg-devel/2020-May/262544.html

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
libavutil/internal.h