]> git.sesse.net Git - ffmpeg/commit
aviobuf: Increase the default SHORT_SEEK_THRESHOLD to 32 KB
authorMartin Storsjö <martin@martin.st>
Fri, 30 Oct 2020 10:59:03 +0000 (12:59 +0200)
committerMartin Storsjö <martin@martin.st>
Thu, 12 Nov 2020 12:05:43 +0000 (14:05 +0200)
commit3fcfde2cea55dcbf16c42d5378b6f0e662fece55
tree7996ab6a9e96af22982bc49909524237086eb5a4
parent454bee5be0c3721a5ca0b3b08cb6ed076f6c9e13
aviobuf: Increase the default SHORT_SEEK_THRESHOLD to 32 KB

The previous threshold, 4 KB, maybe was reasonable when it was set
(in 2010), but in today's settings and with typical network speeds
and data sizes, it's pretty small. 32 KB probably is a more reasonable
default now, regardless of input.

This changes the test references for two seek tests.

When using the normal seek function, which boils down to the lseek(2)
function, a seek to an out of bounds position doesn't return an error,
but that condition is only reported when doing the subsequent read
(which returns EOF). When doing more seeks by fast forwarding, the
fact that the seeked to destination is out of bounds is noticed and
reported sooner in these cases.

Signed-off-by: Martin Storsjö <martin@martin.st>
libavformat/aviobuf.c
tests/ref/seek/lavf-al
tests/ref/seek/lavf-ul