]> git.sesse.net Git - vlc/commit
Fix bug in taglib txxx handling
authorJohannes Weißl <jargon@molb.org>
Wed, 9 Feb 2011 13:23:25 +0000 (14:23 +0100)
committerRémi Denis-Courmont <remi@remlab.net>
Tue, 15 Feb 2011 21:06:07 +0000 (23:06 +0200)
commit5010066b9771f6862e71b53f36e27816500e04f3
treea339ac5d1ad7c233c1a74119a519f3e47fdcfd2a
parent26e35305c069d98e18d96113c104307724a2a5d5
Fix bug in taglib txxx handling

Currently, vlc puts the value *and* the description in the value field
for id3 TXXX tags, e.g. in Media Information:
REPLAYGAIN_TRACK_GAIN: REPLAYGAIN_TRACK_GAIN +3.30 dB

This leads to vlc_audio_replay_gain_MergeFromMeta() failing because it
can't parse the floating point value. Since the fieldList() of an
UserTextIdentificationFrame has exactly two members, it is safe to just
use the last (value) member. In Media Information:
REPLAYGAIN_TRACK_GAIN: +3.30 dB

This makes ReplayGain work for mp3 files.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
modules/meta_engine/taglib.cpp