]> git.sesse.net Git - ffmpeg/commit
avfilter/af_headphone: Fix segfault when using very short streams
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Fri, 28 Aug 2020 08:56:20 +0000 (10:56 +0200)
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Wed, 9 Sep 2020 11:45:59 +0000 (13:45 +0200)
commit7b74e02ef2d0099a2e1f1d1cefc1fce2e041f618
tree2dafe93b1ded96f9d196cfcd570b309e8b57ccec
parentdfd46e2d160afcb7e453d0e2394a6978cb447712
avfilter/af_headphone: Fix segfault when using very short streams

When the headphone filter does its processing in the time domain,
the lengths of the buffers involved are determined by three parameters,
only two of which are relevant here: ir_len and air_len. The former is
the length (in samples) of the longest HRIR input stream and the latter
is the smallest power-of-two bigger than ir_len.

Using optimized functions to calculate the convolution places
restrictions on the alignment of the length of the vectors whose scalar
product is calculated. Therefore said length, namely ir_len, is aligned
on 32; but the number of elements of the buffers used is given by air_len
and for ir_len < 16 a buffer overflow happens.

This commit fixes this by ensuring that air_len is always >= 32 if
processing happens in the time domain.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
libavfilter/af_headphone.c