]> git.sesse.net Git - ffmpeg/commit
avcodec/cbs: Remove redundant checks for CodedBitstreamContext.codec
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Tue, 9 Mar 2021 19:16:04 +0000 (20:16 +0100)
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Fri, 12 Mar 2021 22:21:35 +0000 (23:21 +0100)
commit85685297c28958f3a8fa50a50ed3a6171e7f34c2
tree6411945476ff0cd3208cf9a7207a6403e1fe1d2b
parent30cd7feb2dd497b16edb6d7c09a83eb49f89645d
avcodec/cbs: Remove redundant checks for CodedBitstreamContext.codec

Setting this field happens immediately after the allocation in
ff_cbs_init(), so the whole CBS code may presume that any
CodedBitstreamContext has this set. Lots of code already presumed this,
yet ff_cbs_close() did it inconsistently: It checked before checking
whether the CodedBitstreamType has a close function; yet it simply
unconditionally read ctx->codec->priv_class. Coverity complained about
this in issue #1473564, which this commit fixes.

Reviewed-by: Mark Thompson <sw@jkqxz.net>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
libavcodec/cbs.c