]> git.sesse.net Git - vlc/commit
Qt4: use explicit direct connections when passing VLC pointers...
authorRémi Denis-Courmont <remi@remlab.net>
Mon, 1 Mar 2010 19:06:10 +0000 (21:06 +0200)
committerRémi Denis-Courmont <remi@remlab.net>
Mon, 1 Mar 2010 19:08:38 +0000 (21:08 +0200)
commit88d39ceef6b983663ccae410be55a2ace26d9074
treed0c9344f62e7f1e33d530d7072dd4f3d40688a51
parent9bd636a7f94ebba26aa068570636efe9611afdaf
Qt4: use explicit direct connections when passing VLC pointers...

...without reference. With a direct connection, the call stack ensures
that the pointer remains valid until the slot returns. This is not the
case for asynchronous ("queued" in Qt4 documentation) signals.

Obviously, this means we have to emit the signals from the Qt4 main loop
thread, *or* alternatively not touch any Qt4 UI stuff fromt he slot.
Hopefully, any such bug would be easier to find this ways.
modules/gui/qt4/components/controller.cpp
modules/gui/qt4/components/interface_widgets.cpp
modules/gui/qt4/components/playlist/playlist.cpp
modules/gui/qt4/components/playlist/playlist_model.cpp
modules/gui/qt4/components/playlist/selector.cpp
modules/gui/qt4/components/playlist/standardpanel.cpp
modules/gui/qt4/dialogs/mediainfo.cpp
modules/gui/qt4/extensions_manager.cpp
modules/gui/qt4/input_manager.cpp
modules/gui/qt4/qt4.hpp