]> git.sesse.net Git - vlc/commit
skins2: fix some important playlist limitations or bugs
authorErwan Tulou <erwan10@videolan.org>
Tue, 17 May 2011 15:12:24 +0000 (17:12 +0200)
committerErwan Tulou <erwan10@videolan.org>
Mon, 6 Jun 2011 20:14:09 +0000 (22:14 +0200)
commita9beb4078c7fce9efdebbcb11de762f1792fe6ea
treefb1472bd6a973aeb8cf7d0f1af877a8d361ecb8e
parent1653a66d281fe2822356865780017800983f4b24
skins2: fix some important playlist limitations or bugs

This patch includes the following :
  - fix item misplacement (items were only appended instead of being inserted)
  - fix slider scrolling that could not adapt to the real size of the playlist
  - enhance drag&drop by allowing users to finely insert item being dropped
    into either the playlist or the media library.
  - optimise refresh (only rebuild playtree in case of visible item)
  - remove keeping a reference to a playlist_item_t* (since it is not
    refcounted, a lookup from the playlist with proper lock mechanism
    is needed)
  - remove the m_deleted flag (corner cases were never dealt with) and
    replace it with a notification prior to deletion
  - implement operator++ to simplify iterating visible items (cosmetics)

A deeper redesign/simplification and support for the new sql playlist would be a good thing though.
modules/gui/skins2/controls/ctrl_tree.cpp
modules/gui/skins2/controls/ctrl_tree.hpp
modules/gui/skins2/utils/var_percent.hpp
modules/gui/skins2/utils/var_tree.cpp
modules/gui/skins2/utils/var_tree.hpp
modules/gui/skins2/vars/playtree.cpp
modules/gui/skins2/vars/playtree.hpp