We are generating also king moves that give check !
Of course these moves are illegal so are in any case
filtered out in MovePicker. Neverthless we should avoid
to generate them.
Also simplify a bit the code.
No functional change.
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
// Direct checks
b = target & ~dc;
// Direct checks
b = target & ~dc;
- if (Piece != KING || b)
+ Bitboard checkSqs = pos.attacks_from<Piece>(ksq) & pos.empty_squares();
+ if (Piece == KING || !checkSqs)
+ return mlist;
+
+ while (b)
- Bitboard checkSqs = pos.attacks_from<Piece>(ksq) & pos.empty_squares();
- if (!checkSqs)
- return mlist;
+ Square from = pop_1st_bit(&b);
+ if ( (Piece == QUEEN && !(QueenPseudoAttacks[from] & checkSqs))
+ || (Piece == ROOK && !(RookPseudoAttacks[from] & checkSqs))
+ || (Piece == BISHOP && !(BishopPseudoAttacks[from] & checkSqs)))
+ continue;
- while (b)
- {
- Square from = pop_1st_bit(&b);
- if ( (Piece == QUEEN && !(QueenPseudoAttacks[from] & checkSqs))
- || (Piece == ROOK && !(RookPseudoAttacks[from] & checkSqs))
- || (Piece == BISHOP && !(BishopPseudoAttacks[from] & checkSqs)))
- continue;
-
- Bitboard bb = pos.attacks_from<Piece>(from) & checkSqs;
- SERIALIZE_MOVES(bb);
- }
+ Bitboard bb = pos.attacks_from<Piece>(from) & checkSqs;
+ SERIALIZE_MOVES(bb);