]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/libx264: check for param allocation failure error code
authorJames Almer <jamrial@gmail.com>
Fri, 10 Jul 2020 20:16:49 +0000 (17:16 -0300)
committerJames Almer <jamrial@gmail.com>
Fri, 17 Jul 2020 18:24:56 +0000 (15:24 -0300)
And return the proper AVERROR value.

Signed-off-by: James Almer <jamrial@gmail.com>
libavcodec/libx264.c

index 4a82e1ba2505dcdce5e5d23166b7de178f31484b..479dfe323cc8f54ad03880e0308a611e52bee2e3 100644 (file)
@@ -529,6 +529,12 @@ static int parse_opts(AVCodecContext *avctx, const char *opt, const char *param)
             av_log(avctx, AV_LOG_ERROR,
                    "bad option '%s': '%s'\n", opt, param);
             ret = AVERROR(EINVAL);
+#if X264_BUILD >= 161
+        } else if (ret == X264_PARAM_ALLOC_FAILED) {
+            av_log(avctx, AV_LOG_ERROR,
+                   "out of memory parsing option '%s': '%s'\n", opt, param);
+            ret = AVERROR(ENOMEM);
+#endif
         } else {
             av_log(avctx, AV_LOG_ERROR,
                    "bad value for '%s': '%s'\n", opt, param);
@@ -914,10 +920,15 @@ FF_ENABLE_DEPRECATION_WARNINGS
     {
         AVDictionaryEntry *en = NULL;
         while (en = av_dict_get(x4->x264_params, "", en, AV_DICT_IGNORE_SUFFIX)) {
-           if (x264_param_parse(&x4->params, en->key, en->value) < 0)
+           if ((ret = x264_param_parse(&x4->params, en->key, en->value)) < 0) {
                av_log(avctx, AV_LOG_WARNING,
                       "Error parsing option '%s = %s'.\n",
                        en->key, en->value);
+#if X264_BUILD >= 161
+               if (ret == X264_PARAM_ALLOC_FAILED)
+                   return AVERROR(ENOMEM);
+#endif
+           }
         }
     }