* Fixed a segfault in input.c when no input plugin was found for

   a given file.
 * Fixed a deadlock in the Gnome interface. Next time I'll initialize
   my mutexes, I promise.
 * Added Oct to the authors list in intf_gnome.glade :)

diff --git a/plugins/gnome/gnome_interface.c b/plugins/gnome/gnome_interface.c
index a9bd318fa63e7134ebce953eea584da9bb780632..91ee26c628dcade17b9823c5ac01948236abd01c 100644 (file)
--- a/plugins/gnome/gnome_interface.c
+++ b/plugins/gnome/gnome_interface.c
@@ -497,6 +497,7 @@ create_intf_about (void)
     "Régis Duchesne <regis@via.ecp.fr>",
     "Michel Lespinasse <walken@zoy.org>",
     "Olivier Pomel <pomel@via.ecp.fr>",
+    "Pierre Baillet <oct@zoy.org>",
     "Jean-Philippe Grimaldi <jeanphi@via.ecp.fr>",
     "Andres Krapf <dae@via.ecp.fr>",
     "Christophe Massiot <massiot@via.ecp.fr>",

diff --git a/plugins/gnome/intf_gnome.c b/plugins/gnome/intf_gnome.c
index 0fe313e16267478e276f0475f617f7c2554ab48b..4c32e74ebc350a45801bb5fc21485e6a8eab80fc 100644 (file)
--- a/plugins/gnome/intf_gnome.c
+++ b/plugins/gnome/intf_gnome.c
@@ -2,7 +2,7 @@
  * intf_gnome.c: Gnome interface
  *****************************************************************************
  * Copyright (C) 1999, 2000 VideoLAN
- * $Id: intf_gnome.c,v 1.16 2001/02/20 08:47:25 stef Exp $
+ * $Id: intf_gnome.c,v 1.17 2001/02/20 09:10:36 sam Exp $
  *
  * Authors: Samuel Hocevar <sam@zoy.org>
  *
@@ -140,6 +140,9 @@ static int intf_Open( intf_thread_t *p_intf )
     p_intf->p_sys->pf_gtk_callback = NULL;
     p_intf->p_sys->pf_gdk_callback = NULL;
 
+    /* Initialize lock */
+    vlc_mutex_init( &p_intf->p_sys->change_lock );
+
     return( 0 );
 }
 
@@ -148,6 +151,9 @@ static int intf_Open( intf_thread_t *p_intf )
  *****************************************************************************/
 static void intf_Close( intf_thread_t *p_intf )
 {
+    /* Destroy lock */
+    vlc_mutex_destroy( &p_intf->p_sys->change_lock );
+
     /* Destroy structure */
     free( p_intf->p_sys );
 }

diff --git a/plugins/gnome/intf_gnome.glade b/plugins/gnome/intf_gnome.glade
index 621d5e27a3ea8f8dc66ccc63aa28c5dcf351aa08..587bd797e97c7a1503b79f2b5935312795d165cd 100644 (file)
--- a/plugins/gnome/intf_gnome.glade
+++ b/plugins/gnome/intf_gnome.glade
@@ -590,6 +590,7 @@
   <authors>Régis Duchesne &lt;regis@via.ecp.fr&gt;
 Michel Lespinasse &lt;walken@zoy.org&gt;
 Olivier Pomel &lt;pomel@via.ecp.fr&gt;
+Pierre Baillet &lt;oct@zoy.org&gt;
 Jean-Philippe Grimaldi &lt;jeanphi@via.ecp.fr&gt;
 Andres Krapf &lt;dae@via.ecp.fr&gt;
 Christophe Massiot &lt;massiot@via.ecp.fr&gt;

diff --git a/src/input/input.c b/src/input/input.c
index c2efdb555600380729b5fe84dc3068ad087f86cf..8cb868a944325a14b2c5583a6883f646dd8b2dc2 100644 (file)
--- a/src/input/input.c
+++ b/src/input/input.c
@@ -4,7 +4,7 @@
  * decoders.
  *****************************************************************************
  * Copyright (C) 1998, 1999, 2000 VideoLAN
- * $Id: input.c,v 1.86 2001/02/20 08:47:25 stef Exp $
+ * $Id: input.c,v 1.87 2001/02/20 09:10:36 sam Exp $
  *
  * Authors: Christophe Massiot <massiot@via.ecp.fr>
  *
@@ -296,7 +296,6 @@ static int InitThread( input_thread_t * p_input )
     if( p_input->p_input_module == NULL )
     {
         intf_ErrMsg( "input error: no suitable input module" );
-        module_Unneed( p_main->p_bank, p_input->p_input_module );
         return( -1 );
     }