]> git.sesse.net Git - vlc/commitdiff
taglib: fix NULL deferences after dynamic cast
authorLukáš Lalinský <lalinsky@gmail.com>
Wed, 11 Aug 2010 19:02:30 +0000 (22:02 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Wed, 11 Aug 2010 19:07:26 +0000 (22:07 +0300)
Reported-by: FortiGuard Lab
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
modules/meta_engine/taglib.cpp

index 11bcfdf87c964a04bbb03d6954c4cdbea2b4040c..e1e03fbef29a6112bb7ac9b4c14e9491011c4a48 100644 (file)
@@ -132,6 +132,8 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t*
     {
         ID3v2::UniqueFileIdentifierFrame* p_ufid =
                 dynamic_cast<ID3v2::UniqueFileIdentifierFrame*>(*iter);
+        if( !p_ufid )
+            continue;
         const char *owner = p_ufid->owner().toCString();
         if (!strcmp( owner, "http://musicbrainz.org" ))
         {
@@ -152,6 +154,8 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t*
     {
         ID3v2::UserTextIdentificationFrame* p_txxx =
                 dynamic_cast<ID3v2::UserTextIdentificationFrame*>(*iter);
+        if( !p_txxx )
+            continue;
         vlc_meta_AddExtra( p_meta, p_txxx->description().toCString( true ),
                            p_txxx->fieldList().toString().toCString( true ) );
     }
@@ -208,6 +212,8 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_t* p_demux, demux_meta_t*
     {
         ID3v2::AttachedPictureFrame* p_apic =
             dynamic_cast<ID3v2::AttachedPictureFrame*>(*iter);
+        if( !p_apic )
+            continue;
         input_attachment_t *p_attachment;
 
         const char *psz_mime;