Qt4: Cosmetics about ClickLineEdit, QVLCFramelessButton

This removes useless member, useless parameter, useless empty dtor, and
adds a missing reference.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

diff --git a/modules/gui/qt4/util/customwidgets.cpp b/modules/gui/qt4/util/customwidgets.cpp
index 5b460c3a6ba95b890c22eae6a43aefe4329af355..00e0296c45e246aa4664984bc7647c965d777bfb 100644 (file)
--- a/modules/gui/qt4/util/customwidgets.cpp
+++ b/modules/gui/qt4/util/customwidgets.cpp
@@ -109,7 +109,7 @@ QVLCFramelessButton::QVLCFramelessButton( QWidget *parent )
     setSizePolicy( QSizePolicy::Preferred, QSizePolicy::Preferred );
 }
 
-void QVLCFramelessButton::paintEvent( QPaintEvent * event )
+void QVLCFramelessButton::paintEvent( QPaintEvent * )
 {
     QPainter painter( this );
     QPixmap pix = icon().pixmap( size() );

diff --git a/modules/gui/qt4/util/customwidgets.hpp b/modules/gui/qt4/util/customwidgets.hpp
index 13e685f22063e95ba416a84490972f2d2597d7cf..64d08dda335b06e6fd31c6c4d3ad4aad65dda367 100644 (file)
--- a/modules/gui/qt4/util/customwidgets.hpp
+++ b/modules/gui/qt4/util/customwidgets.hpp
@@ -45,9 +45,8 @@ class ClickLineEdit : public QLineEdit
     Q_PROPERTY( QString clickMessage READ clickMessage WRITE setClickMessage )
 public:
     ClickLineEdit( const QString &msg, QWidget *parent );
-    virtual ~ClickLineEdit() {};
     void setClickMessage( const QString &msg );
-    QString clickMessage() const { return mClickMessage; }
+    const QString& clickMessage() const { return mClickMessage; }
     virtual void setText( const QString& txt );
 protected:
     virtual void paintEvent( QPaintEvent *e );
@@ -83,7 +82,6 @@ private:
     void setMessageVisible( bool on );
     QVLCFramelessButton   *clearButton;
     bool message;
-    QLabel *msg;
 
 public slots:
     void clear();