Freeing stuff before using it is *stupid*. (<-- funman)

diff --git a/modules/meta_engine/musicbrainz.c b/modules/meta_engine/musicbrainz.c
index 3365d7dd6a56839891e5c1f14b40ad470e46eab6..ed6ce43af71369fe72d33c275f7bb654c4b96512 100644 (file)
--- a/modules/meta_engine/musicbrainz.c
+++ b/modules/meta_engine/musicbrainz.c
@@ -89,8 +89,6 @@ static int GetData( vlc_object_t *p_obj, input_item_t *p_item,
         free( psz_album );
         return VLC_EGENERIC;
     }
-    free( psz_artist );
-    free( psz_album );
 
     musicbrainz_t p_mb;
 
@@ -112,10 +110,14 @@ static int GetData( vlc_object_t *p_obj, input_item_t *p_item,
         "</mq:FindAlbum>\n", ppsz_args ) )
     {
         mb_GetQueryError( p_mb, psz_buf, 256 );
-        msg_Err( p_obj, "Query failed: %s\n", psz_buf );
+        msg_Err( p_obj, "Query failed: %s", psz_buf );
         mb_Delete( p_mb );
+        free( psz_artist );
+        free( psz_album );
         return VLC_EGENERIC;
     }
+    free( psz_artist );
+    free( psz_album );
 
     i_album_count = mb_GetResultInt( p_mb, MBE_GetNumAlbums );
     if( i_album_count < 1 )