vlc_common.h:

* Add some proper assert() to the vlc_gc_* function to spot errors.
* Correctly initialize the refcount to 1. (This will prevent freed pointer usage). (This may also introduce leaks in some module).
modules/*.c:
* Prevent some module to leak input_item_t.

diff --git a/include/vlc_common.h b/include/vlc_common.h
index aaf9814bd4984914bc32d8b4723f90cebca05cae..fa177d538b10e420380444c2815ed5cfe46740be 100644 (file)
--- a/include/vlc_common.h
+++ b/include/vlc_common.h
@@ -63,6 +63,7 @@
  *****************************************************************************/
 #include <stdlib.h>
 #include <stdarg.h>
+#include <assert.h>
 
 #include <string.h>
 #include <stdio.h>
@@ -610,25 +611,38 @@ struct gc_object_t
 
 static inline void __vlc_gc_incref( gc_object_t * p_gc )
 {
+    assert( p_gc->i_gc_refcount > 0 );
+
     p_gc->i_gc_refcount ++;
 };
 
 static inline void __vlc_gc_decref( gc_object_t *p_gc )
 {
+    if( !p_gc ) return;
+
+    assert( p_gc->i_gc_refcount > 0 );
+
     p_gc->i_gc_refcount -- ;
 
     if( p_gc->i_gc_refcount == 0 )
     {
         p_gc->pf_destructor( p_gc );
         /* Do not use the p_gc pointer from now on ! */
-     }
+    }
+}
+
+static inline void
+__vlc_gc_init( gc_object_t * p_gc, void (*pf_destructor)( gc_object_t * ),
+               void * arg)
+{
+    p_gc->i_gc_refcount = 1;
+    p_gc->pf_destructor = pf_destructor;
+    p_gc->p_destructor_arg = arg;
 }
 
 #define vlc_gc_incref( a ) __vlc_gc_incref( (gc_object_t *)a )
 #define vlc_gc_decref( a ) __vlc_gc_decref( (gc_object_t *)a )
-#define vlc_gc_init( a,b,c ) {  ((gc_object_t *)a)->i_gc_refcount = 0; \
-                              ((gc_object_t *)a)->pf_destructor = b; \
-                              ((gc_object_t *)a)->p_destructor_arg = c; }
+#define vlc_gc_init( a,b,c ) __vlc_gc_init( (gc_object_t *)a,b,c )
 
 
 /*****************************************************************************

diff --git a/modules/misc/lua/vlc.c b/modules/misc/lua/vlc.c
index fa686a68359a34f47482d51de319fbc8159dceff..cd0fac03b024269463b1f1c7cb18677b1260f133 100644 (file)
--- a/modules/misc/lua/vlc.c
+++ b/modules/misc/lua/vlc.c
@@ -753,7 +753,7 @@ int __vlclua_playlist_add_internal( vlc_object_t *p_this, lua_State *L,
                                            PLAYLIST_APPEND | PLAYLIST_PREPARSE,
                                            PLAYLIST_END, VLC_TRUE, VLC_FALSE );
                     i_count ++; /* increment counter */
-
+                    vlc_gc_decref( p_input );
                     while( i_options > 0 )
                         free( ppsz_options[--i_options] );
                     free( ppsz_options );

diff --git a/modules/services_discovery/bonjour.c b/modules/services_discovery/bonjour.c
index 2c658632e1e8e742417b86770122544b00ac360e..d5826834655983ee9226de5890a0ee6a8c0c20c6 100644 (file)
--- a/modules/services_discovery/bonjour.c
+++ b/modules/services_discovery/bonjour.c
@@ -189,6 +189,7 @@ static void resolve_callback(
             vlc_dictionary_insert( &p_sys->services_name_to_input_item,
                 name, p_input );
             services_discovery_AddItem( p_sd, p_input, NULL /* no category */ );
+            vlc_gc_decref( p_input );
        }
     }
 

diff --git a/modules/services_discovery/freebox.c b/modules/services_discovery/freebox.c
index 8df50c95996b6d3cf5ca38b763b40a27de15ba18..45ec03e3dba866d9da7ef70016e55495033429c2 100644 (file)
--- a/modules/services_discovery/freebox.c
+++ b/modules/services_discovery/freebox.c
@@ -88,7 +88,6 @@ static void Run( services_discovery_t *p_sd )
     input_item_t * p_input = input_ItemNewExt( p_sd, kpsz_freebox_playlist_url,
                                 _("Freebox TV"), 0, NULL, -1 );
     input_ItemAddOption( p_input, "no-playlist-autostart" );
-    vlc_gc_incref( p_input );
 
     vlc_event_attach( &p_input->event_manager, vlc_InputItemSubItemAdded, ItemAdded, p_sd );
     input_Read( p_sd, p_input, VLC_TRUE );

diff --git a/modules/services_discovery/hal.c b/modules/services_discovery/hal.c
index f8779366dc819bc16fe950731ca9e5b6ba689951..00ebc8fe71abf5ba4a1e68322afc54420bf33fff 100644 (file)
--- a/modules/services_discovery/hal.c
+++ b/modules/services_discovery/hal.c
@@ -201,6 +201,7 @@ static void AddItem( services_discovery_t *p_sd, input_item_t * p_input
     {
         return;
     }
+    vlc_gc_incref( p_input );
     p_udi_entry->p_item = p_input;
     p_udi_entry->psz_udi = strdup( psz_device );
     TAB_APPEND( p_sys->i_devices_number, p_sys->pp_devices, p_udi_entry );
@@ -238,6 +239,7 @@ static void AddDvd( services_discovery_t *p_sd, char *psz_device )
 #else
     AddItem( p_sd, p_input );
 #endif
+    vlc_gc_decref( p_input );
 }
 
 #ifdef HAVE_HAL_1
@@ -251,6 +253,7 @@ static void DelItem( services_discovery_t *p_sd, char* psz_udi )
         if( strcmp( psz_udi, p_sys->pp_devices[i]->psz_udi ) == 0 )
         { /* delete the corresponding item */    
             services_discovery_RemoveItem( p_sd, p_sys->pp_devices[i]->p_item );
+            vlc_gc_decref( p_sys->pp_devices[i]->p_item );
             if( p_sys->pp_devices[i]->psz_udi )
                 free( p_sys->pp_devices[i]->psz_udi );
             TAB_REMOVE( p_sys->i_devices_number, p_sys->pp_devices,
@@ -284,6 +287,7 @@ static void AddCdda( services_discovery_t *p_sd, char *psz_device )
 #else
     AddItem( p_sd, p_input );
 #endif
+    vlc_gc_decref( p_input );
 }
 
 static void ParseDevice( services_discovery_t *p_sd, char *psz_device )

diff --git a/modules/services_discovery/sap.c b/modules/services_discovery/sap.c
index 78223da31fdc23fdcf76d379f4281e0b55a5a2f7..92e89472853fa74c4167f6685c31eaea0875fa3a 100644 (file)
--- a/modules/services_discovery/sap.c
+++ b/modules/services_discovery/sap.c
@@ -895,7 +895,7 @@ sap_announce_t *CreateAnnounce( services_discovery_t *p_sd, uint16_t i_hash,
     services_discovery_AddItem( p_sd, p_input, psz_value /* category name */ );
 
     TAB_APPEND( p_sys->i_announces, p_sys->pp_announces, p_sap );
-
+    vlc_gc_decref( p_input );
     return p_sap;
 }
 

diff --git a/modules/services_discovery/shout.c b/modules/services_discovery/shout.c
index 230bbbd5bc0ac0f8dde410b2ba2ee6db3a685517..a0c0adf086f3f11802318e59eca189cf6703e94a 100644 (file)
--- a/modules/services_discovery/shout.c
+++ b/modules/services_discovery/shout.c
@@ -139,8 +139,6 @@ static int Open( vlc_object_t *p_this, int i_type )
                                 0, NULL, -1 );
             break;
     }
-    vlc_gc_incref( p_sys->p_input ); /* Refcount to 1, so we can release it
-                                      * in Close() */
 
     input_ItemAddOption( p_sys->p_input, "no-playlist-autostart" );
     return VLC_SUCCESS;