small cleanup

svn path=/trunk/kdenlive/; revision=5918

diff --git a/src/effectslist.cpp b/src/effectslist.cpp
index 31e632e4025ed6b12feb2c83ce450dc0362e838d..696fa44402b9803d6bfa33b59dae4d825ddb2ee9 100644 (file)
--- a/src/effectslist.cpp
+++ b/src/effectslist.cpp
@@ -285,7 +285,7 @@ int EffectsList::count() const
 
 bool EffectsList::isEmpty() const
 {
-    return m_baseElement.childNodes().count() == 0;
+    return !m_baseElement.hasChildNodes();
 }
 
 const QDomElement EffectsList::at(int ix) const

diff --git a/src/initeffects.cpp b/src/initeffects.cpp
index 1acd593cbd42b4dc7e6925578f21e7be80f4e9a6..521ac23ca29ea322aa9c20c3a8db2f9826325c2a 100644 (file)
--- a/src/initeffects.cpp
+++ b/src/initeffects.cpp
@@ -150,14 +150,16 @@ void initEffects::parseEffectFiles()
     // Retrieve the list of MLT's available effects.
     Mlt::Properties *filters = repository->filters();
     QStringList filtersList;
-    for (int i = 0; i < filters->count(); ++i)
+    int max = filters->count();
+    for (int i = 0; i < max; ++i)
         filtersList << filters->get_name(i);
     delete filters;
 
     // Retrieve the list of available producers.
     Mlt::Properties *producers = repository->producers();
     QStringList producersList;
-    for (int i = 0; i < producers->count(); ++i)
+    max = producers->count();
+    for (int i = 0; i < max; ++i)
         producersList << producers->get_name(i);
     KdenliveSettings::setProducerslist(producersList);
     delete producers;
@@ -165,7 +167,8 @@ void initEffects::parseEffectFiles()
     // Retrieve the list of available transitions.
     Mlt::Properties *transitions = repository->transitions();
     QStringList transitionsItemList;
-    for (int i = 0; i < transitions->count(); ++i)
+    max = transitions->count();
+    for (int i = 0; i < max; ++i)
         transitionsItemList << transitions->get_name(i);
     delete transitions;
 
@@ -214,7 +217,8 @@ void initEffects::parseEffectFiles()
     QMap<QString, QDomElement> audioEffectsMap;
 
     // Create transitions
-    for (int i = 0; i < MainWindow::transitions.count(); ++i) {
+    max = MainWindow::transitions.count();
+    for (int i = 0; i < max; ++i) {
         effectInfo = MainWindow::transitions.at(i);
         effectsMap.insert(effectInfo.firstChildElement("name").text().toLower().toUtf8().data(), effectInfo);
     }
@@ -261,7 +265,8 @@ void initEffects::parseEffectFiles()
     }
 
     // Create custom effects
-    for (int i = 0; i < MainWindow::customEffects.count(); ++i) {
+    max = MainWindow::customEffects.count();
+    for (int i = 0; i < max; ++i) {
         effectInfo = MainWindow::customEffects.at(i);
         effectsMap.insert(effectInfo.firstChildElement("name").text().toLower().toUtf8().data(), effectInfo);
     }
@@ -271,7 +276,8 @@ void initEffects::parseEffectFiles()
     effectsMap.clear();
 
     // Create audio effects
-    for (int i = 0; i < MainWindow::audioEffects.count(); ++i) {
+    max = MainWindow::audioEffects.count();
+    for (int i = 0; i < max; ++i) {
         effectInfo = MainWindow::audioEffects.at(i);
         audioEffectsMap.insert(effectInfo.firstChildElement("name").text().toLower().toUtf8().data(), effectInfo);
     }
@@ -280,7 +286,8 @@ void initEffects::parseEffectFiles()
         MainWindow::audioEffects.append(effect);
 
     // Create video effects
-    for (int i = 0; i < MainWindow::videoEffects.count(); ++i) {
+    max = MainWindow::videoEffects.count();
+    for (int i = 0; i < max; ++i) {
         effectInfo = MainWindow::videoEffects.at(i);
         videoEffectsMap.insert(effectInfo.firstChildElement("name").text().toLower().toUtf8().data(), effectInfo);
     }
@@ -325,7 +332,7 @@ void initEffects::parseCustomEffectsFile()
         }
     }
     foreach(const QDomElement & effect, effectsMap)
-    MainWindow::customEffects.append(effect);
+        MainWindow::customEffects.append(effect);
 }
 
 // static