]> git.sesse.net Git - vlc/commitdiff
input: remove INPUT_FSTAT_NB_READS
authorRémi Denis-Courmont <remi@remlab.net>
Wed, 17 Apr 2013 20:22:59 +0000 (23:22 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Wed, 17 Apr 2013 20:22:59 +0000 (23:22 +0300)
This was only used for INPUT_UPDATE_SIZE.

include/vlc_config.h
modules/access/file.c
modules/access/gnomevfs.c

index de36a931b01938e487e9d0bc2e044cc9f50910dd..c1cf96ca29d7a1c1e90fc1ce3505376c4d7c4464 100644 (file)
 /* Used in ErrorThread */
 #define INPUT_IDLE_SLEEP                (CLOCK_FREQ/10)
 
-/* Number of read() calls needed until we check the file size through
- * fstat() */
-#define INPUT_FSTAT_NB_READS            16
-
 /*
  * General limitations
  */
index 37c1a2bbe3a7ff9e9bd0eb883e6bc7ee002d59d1..72ee5678abf335234ed216d8676985424fb62900 100644 (file)
@@ -66,8 +66,6 @@
 
 struct access_sys_t
 {
-    unsigned int i_nb_reads;
-
     int fd;
 
     /* */
@@ -222,7 +220,6 @@ int FileOpen( vlc_object_t *p_this )
     p_access->pf_block = NULL;
     p_access->pf_control = FileControl;
     p_access->p_sys = p_sys;
-    p_sys->i_nb_reads = 0;
     p_sys->fd = fd;
 
     if (S_ISREG (st.st_mode) || S_ISBLK (st.st_mode))
@@ -305,11 +302,7 @@ static ssize_t FileRead (access_t *p_access, uint8_t *p_buffer, size_t i_len)
 
     p_access->info.i_pos += val;
     p_access->info.b_eof = !val;
-
-    p_sys->i_nb_reads++;
-
-    if (!(p_sys->i_nb_reads % INPUT_FSTAT_NB_READS)
-     || (p_access->info.i_pos > p_access->info.i_size))
+    if (p_access->info.i_pos >= p_access->info.i_size)
     {
         struct stat st;
 
index 051683692a7eb1034c1755747d381bf44ceb1242..4b63ee456cc8698cc64c342137fbe0deca2ec3c6 100644 (file)
@@ -63,7 +63,6 @@ static int     Control( access_t *, int, va_list );
 
 struct access_sys_t
 {
-    unsigned int i_nb_reads;
     char *psz_name;
 
     GnomeVFSHandle *p_handle;
@@ -105,7 +104,6 @@ static int Open( vlc_object_t *p_this )
     STANDARD_READ_ACCESS_INIT;
 
     p_sys->p_handle = p_handle;
-    p_sys->i_nb_reads = 0;
     p_sys->b_pace_control = true;
 
     if( strcmp( "gnomevfs", p_access->psz_access ) &&
@@ -288,35 +286,19 @@ static ssize_t Read( access_t *p_access, uint8_t *p_buffer, size_t i_len )
                                     gnome_vfs_result_to_string( i_ret ) );
         }
     }
-    else
-    {
-        p_sys->i_nb_reads++;
-        if( p_access->info.i_size != 0 &&
-            (p_sys->i_nb_reads % INPUT_FSTAT_NB_READS) == 0 &&
-            p_sys->b_local )
-        {
-            gnome_vfs_file_info_clear( p_sys->p_file_info );
-            i_ret = gnome_vfs_get_file_info_from_handle( p_sys->p_handle,
-                                                p_sys->p_file_info, 8 );
-            if( i_ret )
-            {
-                msg_Warn( p_access, "couldn't get file properties again (%s)",
-                                        gnome_vfs_result_to_string( i_ret ) );
-            }
-            else
-            {
-                p_access->info.i_size = (int64_t)(p_sys->p_file_info->size);
-            }
-        }
-    }
 
     p_access->info.i_pos += (int64_t)i_read_len;
-
-    /* Some Acces (http) never return EOF and loop on the file */
-    if( p_access->info.i_pos > p_access->info.i_size )
+    if( p_access->info.i_pos >= p_access->info.i_size
+     && p_access->info.i_size != 0 && p_sys->b_local )
     {
-        p_access->info.b_eof = true;
-        return 0;
+        gnome_vfs_file_info_clear( p_sys->p_file_info );
+        i_ret = gnome_vfs_get_file_info_from_handle( p_sys->p_handle,
+                                                     p_sys->p_file_info, 8 );
+        if( i_ret )
+            msg_Warn( p_access, "couldn't get file properties again (%s)",
+                      gnome_vfs_result_to_string( i_ret ) );
+        else
+            p_access->info.i_size = (int64_t)(p_sys->p_file_info->size);
     }
     return (int)i_read_len;
 }