]> git.sesse.net Git - vlc/commitdiff
Qt4: remove useless checks
authorRémi Denis-Courmont <remi@remlab.net>
Thu, 5 Feb 2015 18:56:47 +0000 (20:56 +0200)
committerRémi Denis-Courmont <remi@remlab.net>
Thu, 5 Feb 2015 19:23:44 +0000 (21:23 +0200)
An input thread always has a valid input item even if it is dead.
If not, the code would have had a ToCToU bug anyway.

modules/gui/qt4/components/playlist/playlist_model.cpp

index b5d68c467477704cdfe53d03c6cb581bf912cd41..1872ce33de4c1cbf6d9bb14d2979578fc7605576 100644 (file)
@@ -563,7 +563,7 @@ void PLModel::processInputItemUpdate( )
     input_thread_t *p_input = THEMIM->getInput();
     if( !p_input ) return;
 
-    if( p_input && !( p_input->b_dead || !vlc_object_alive( p_input ) ) )
+    if( p_input )
     {
         PLItem *item = findByInputId( rootItem, input_GetItem( p_input )->i_id );
         if( item ) emit currentIndexChanged( index( item, 0 ) );