modules: remove unnecessary checks

diff --git a/src/modules/entry.c b/src/modules/entry.c
index 6221f964692b2ddb75248adcee6a6a9b1d792fae..2865a3d25531f9892de238c71fd7d048b05f4e52 100644 (file)
--- a/src/modules/entry.c
+++ b/src/modules/entry.c
@@ -409,19 +409,14 @@ static int vlc_plugin_setter (void *plugin, void *tgt, int propid, ...)
 
             /* Copy textual descriptions */
             const char *const *text = va_arg (ap, const char *const *);
-            if (text != NULL)
+            char **dtext = malloc (sizeof (char *) * (len + 1));
+            if( dtext != NULL )
             {
-                char **dtext = malloc (sizeof (char *) * (len + 1));
-                if( dtext != NULL )
-                {
-                    for (size_t i = 0; i < len; i++)
-                        dtext[i] = text[i] ? strdup (text[i]) : NULL;
-                    dtext[len] = NULL;
-                }
-                item->ppsz_list_text = dtext;
+                for (size_t i = 0; i < len; i++)
+                    dtext[i] = text[i] ? strdup (text[i]) : NULL;
+                dtext[len] = NULL;
             }
-            else
-                item->ppsz_list_text = NULL;
+            item->ppsz_list_text = dtext;
 
             item->i_list = len;
             item->pf_update_list = va_arg (ap, vlc_callback_t);