Check for NULL pointer before using it, not after.

diff --git a/modules/video_filter/chain.c b/modules/video_filter/chain.c
index efbb066f321be626ecb4fe7c591b65904dc15478..dd65f08c141dec4f21242c5d2d5ae928e072cfad 100644 (file)
--- a/modules/video_filter/chain.c
+++ b/modules/video_filter/chain.c
@@ -221,13 +221,13 @@ static picture_t *Chain( filter_t *p_filter, picture_t *p_pic )
     if( !p_sys->p_tmp )
     {
         picture_t *p_tmp = malloc( sizeof( picture_t ) );
+        if( !p_tmp )
+            return NULL;
         vout_AllocatePicture( VLC_OBJECT( p_vout ), p_tmp,
                               p_sys->fmt_mid.i_chroma,
                               p_sys->fmt_mid.i_width,
                               p_sys->fmt_mid.i_height,
                               p_sys->fmt_mid.i_aspect );
-        if( !p_tmp )
-            return NULL;
         p_sys->p_tmp = p_tmp;
         p_tmp->pf_release = NULL;
         p_tmp->i_status = RESERVED_PICTURE;