]> git.sesse.net Git - vlc/commitdiff
audiobargraph: boundary check
authorRémi Denis-Courmont <remi@remlab.net>
Tue, 18 Nov 2014 21:27:54 +0000 (23:27 +0200)
committerRémi Denis-Courmont <remi@remlab.net>
Tue, 18 Nov 2014 21:27:54 +0000 (23:27 +0200)
modules/audio_filter/audiobargraph_a.c

index 81275d6be447ca8116a0bf3ad7165017a40bb26b..8fd9607f5e65f31f00865c5a6caf78f7da0cccae 100644 (file)
@@ -147,20 +147,17 @@ static int Open( vlc_object_t *p_this )
 
 static void SendValues(filter_t *p_filter, float *value, int nbChannels)
 {
-    char message[256];
+    char msg[256];
     size_t len = 0;
 
     for (int i = 0; i < nbChannels; i++) {
-        if (len >= sizeof(message))
+        if (len >= sizeof (msg))
             break;
-        len += snprintf(message + len, sizeof (message),"%f:", value[i]);
+        len += snprintf(msg + len, sizeof (msg) - len, "%f:", value[i]);
     }
 
-    message[len-1] = '\0';
     //msg_Dbg(p_filter, "values: %s", message);
-
-    var_SetString(p_filter->p_libvlc, "audiobargraph_v-i_values",
-            message);
+    var_SetString(p_filter->p_libvlc, "audiobargraph_v-i_values", msg);
 }
 
 /*****************************************************************************