]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/vc1dec: Check field_mode for sprites
authorMichael Niedermayer <michael@niedermayer.cc>
Sun, 8 Dec 2019 19:18:07 +0000 (20:18 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Sat, 11 Jan 2020 22:31:18 +0000 (23:31 +0100)
Fixes: Out of array read
Fixes: 19263/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5389219325542400
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/vc1dec.c

index c81939c5a7873f903b0a8c5c6dfcb97fb295180e..0a059896352e75fc19abee5fa623c044379e5446 100644 (file)
@@ -854,7 +854,12 @@ static int vc1_decode_frame(AVCodecContext *avctx, void *data,
         ret = AVERROR_INVALIDDATA;
         goto err;
     }
-
+    if ((avctx->codec_id == AV_CODEC_ID_WMV3IMAGE || avctx->codec_id == AV_CODEC_ID_VC1IMAGE)
+        && v->field_mode) {
+        av_log(v->s.avctx, AV_LOG_ERROR, "Sprite decoder: expected Frames not Fields\n");
+        ret = AVERROR_INVALIDDATA;
+        goto err;
+    }
     if ((s->mb_height >> v->field_mode) == 0) {
         av_log(v->s.avctx, AV_LOG_ERROR, "image too short\n");
         ret = AVERROR_INVALIDDATA;