macosx: fixed a few bugs found by clang's code analysis

diff --git a/modules/gui/macosx/controls.m b/modules/gui/macosx/controls.m
index 561e09dd6d494efd7b131b2ae825bb65b24f009e..084c7f1f4c7820854e97526600357dce3d0c0bdc 100644 (file)
--- a/modules/gui/macosx/controls.m
+++ b/modules/gui/macosx/controls.m
@@ -1094,7 +1094,7 @@
     }
 
     /* Special case for telx menu */
-    if( [[o_mi title] isEqualToString: _NS("Normal Size")] );
+    if( [[o_mi title] isEqualToString: _NS("Normal Size")] )
     {
         NSMenuItem *item = [[o_mi menu] itemWithTitle:_NS("Teletext")];
                bool b_telx = p_input && var_GetInteger( p_input, "teletext-es" ) >= 0;

diff --git a/modules/gui/macosx/intf.m b/modules/gui/macosx/intf.m
index 30eb9d5c2a7170ac5e7936f2c3dda412706a6d61..d411dc02222bf03f542d7f7e1a3d94ea7ba40fa8 100644 (file)
--- a/modules/gui/macosx/intf.m
+++ b/modules/gui/macosx/intf.m
@@ -760,7 +760,9 @@ static VLCMain *_o_sharedMainInstance = nil;
     /* remove global observer watching for vout device changes correctly */
     [[NSNotificationCenter defaultCenter] removeObserver: self];
 
+#ifdef UPDATE_CHECK
     [o_update end];
+#endif
 
     /* release some other objects here, because it isn't sure whether dealloc
      * will be called later on */