]> git.sesse.net Git - ffmpeg/commitdiff
avformat/movenc: Free old vos_data before overwriting it
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Mon, 28 Sep 2020 16:05:44 +0000 (18:05 +0200)
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Sun, 4 Oct 2020 22:49:11 +0000 (00:49 +0200)
Otherwise the old data leaks whenever extradata needs to be rewritten
(e.g. when encoding FLAC with our encoder that sends an updated
extradata packet at the end).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
libavformat/movenc.c

index 7256eb2a0fba31e431b82fe087bd1afb64303b24..6ed93d89eaed888ee5de579453059ce4bc6ad910 100644 (file)
@@ -6983,6 +6983,7 @@ static int mov_write_trailer(AVFormatContext *s)
             AVCodecParameters *par = track->par;
 
             track->vos_len  = par->extradata_size;
+            av_freep(&track->vos_data);
             track->vos_data = av_malloc(track->vos_len + AV_INPUT_BUFFER_PADDING_SIZE);
             if (!track->vos_data)
                 return AVERROR(ENOMEM);